51817 2004-05-23 05:50 0000 app-arch/par2cmdline v0.4: wildcard expansion fix 2006-04-07 00:28:41 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All All RESOLVED FIXED P2 normal --- 1 bugs-gentoo.org@scientician.net maintainer-needed@gentoo.org flash3001@yahoo.com bugs-gentoo.org@scientician.net 2004-05-23 05:50:26 0000 Hi, Version 0.4 of par2cmdline contains a bug whereby wildcard expansion on UNIX systems results in directories (and other non-regular files like sockets, character devices, etc.) being added to the file list. The par2 executable subsequently fails because it cannot handle such cases. The attached patch fixes this issue. The patch has been submitted to the SourceForge bug tracking system for inclusion into the next version, but it is unclear when/if this will happen (there does not seem to have been too much recent activity on the part of the developer, so it may take a while...), so I think it might be good to put the patch into portage. I've also attached a revised ebuild; the only change is the addition of the src_unpack() function. Cheers, bugs-gentoo.org@scientician.net 2004-05-23 05:51:07 0000 Created an attachment (id=31883) par2cmdline-0.4-wildcard-fix.patch bugs-gentoo.org@scientician.net 2004-05-23 05:51:56 0000 Created an attachment (id=31884) par2cmdline-0.4-r1.ebuild robbat2@gentoo.org 2004-05-23 18:34:13 0000 Bardur: could you please email the upstream author about your patch? I'm not certain what the correct behavior should be. My gut feeling is that it should throw an error or warning rather than siliently work around it. bugs-gentoo.org@scientician.net 2004-05-24 00:06:29 0000 Well, the was a similar bug in the Win32 version which is detailed here: http://sourceforge.net/tracker/index.php?func=detail&aid=892377&group_id=30568&atid=399698 See also this bug report (which is mine): https://sourceforge.net/tracker/index.php?func=detail&aid=958902&group_id=30568&atid=399698 In the last comment on the Win32-related bug (which was filed against 0.3), the developer suggests that he will change the behavior such that it will ignore directories specified on the command line. I haven't checked to see if he has actually changed this yet (and if so, whether it is _silently_ ignored or not). The trouble with the current behavior is that there is no workaround. This makes it impossible to add more files than can fit on a command-line. With 'find' and 'xargs' it is possible to add a number of files up to the command line length limit, but IIRC xargs cannot be told to die if it needs to use more than 1 command line; so in this case you get even more dangerous silent errors because some *files* will just be missing from the .par2 'archive'. Another annoying problem is that it is impossible to use wildcards like '*' in directories which contain subdirectories. Btw, I don't think silently ignoring specials/directories is as dangerous as you might think, since the par2 executable explicitly shows each file added to the 'archive'. There is also the fact that adding anything but regular files to archives doesn't make sense, and since the wildcards were never recursive to begin with I felt that silently ignoring directories/specials would be fine. But in any case, I've added code which emits warnings whenever a directory/special is omitted and uploaded the new patch. bugs-gentoo.org@scientician.net 2004-05-24 00:07:08 0000 Created an attachment (id=31931) par2cmdline-0.4-wildcard-fix-2.patch vapier@gentoo.org 2005-08-13 15:25:25 0000 fixed in cvs, thanks mjevans1983@gmail.com 2006-04-07 00:28:41 0000 Created an attachment (id=84110) shell expanded wildcard patch for par2cmdline This is Still a bug... I just figured out what's missing my self, and this is my shot at the patch... the par2cmdline-0.4-r1.ebuild is the one I'm currently using... This patch fixes the case of the wildcards being expanded by the shell, instead of par2. The previous patches seem to work inside of par2 if you manage to pass it * instead of \* or '*'. (Which is the best I could do when trying to pass par2 all it's arguments inside of a single argument to a shellscript.) 31883 2004-05-23 05:51 0000 par2cmdline-0.4-wildcard-fix.patch par2cmdline-0.4-wildcard-fix.patch text/plain ZGlmZiAtdXIgcGFyMmNtZGxpbmUtMC40L2Rpc2tmaWxlLmNwcCBwYXIyY21kbGluZS0wLjQucGF0 Y2hlZC9kaXNrZmlsZS5jcHAKLS0tIHBhcjJjbWRsaW5lLTAuNC9kaXNrZmlsZS5jcHAJMjAwNC0w NC0xMiAxMzoyNTozNy4wMDAwMDAwMDAgKzAyMDAKKysrIHBhcjJjbWRsaW5lLTAuNC5wYXRjaGVk L2Rpc2tmaWxlLmNwcAkyMDA0LTA1LTIzIDE0OjEzOjA3LjAxOTIwODg5OCArMDIwMApAQCAtNjE4 LDYgKzYxOCwxMiBAQAogICByZXR1cm4gcmVzdWx0OwogfQogCitib29sIGlzX3JlZ3VsYXJfZmls ZShjb25zdCBzdHJpbmcgJnApCit7CisgIHN0cnVjdCBzdGF0IHN0OworICByZXR1cm4gKHN0YXQo cC5jX3N0cigpLCAmc3QpID09IDAgJiYgU19JU1JFRyhzdC5zdF9tb2RlKSk7Cit9CisKIGxpc3Q8 c3RyaW5nPiogRGlza0ZpbGU6OkZpbmRGaWxlcyhzdHJpbmcgcGF0aCwgc3RyaW5nIHdpbGRjYXJk KQogewogICBsaXN0PHN0cmluZz4gKm1hdGNoZXMgPSBuZXcgbGlzdDxzdHJpbmc+OwpAQCAtNjQ2 LDcgKzY1Miw4IEBACiAgICAgICAgIHsKICAgICAgICAgICBpZiAobmFtZS5zaXplKCkgPj0gd2ls ZGNhcmQuc2l6ZSgpICYmCiAgICAgICAgICAgICAgIG5hbWUuc3Vic3RyKDAsIHdoZXJlKSA9PSBm cm9udCAmJgotICAgICAgICAgICAgICBuYW1lLnN1YnN0cihuYW1lLnNpemUoKS1iYWNrLnNpemUo KSkgPT0gYmFjaykKKyAgICAgICAgICAgICAgbmFtZS5zdWJzdHIobmFtZS5zaXplKCktYmFjay5z aXplKCkpID09IGJhY2sgJiYKKyAgICAgICAgICAgICAgaXNfcmVndWxhcl9maWxlKHBhdGggKyBu YW1lKSkKICAgICAgICAgICB7CiAgICAgICAgICAgICBtYXRjaGVzLT5wdXNoX2JhY2socGF0aCAr IG5hbWUpOwogICAgICAgICAgIH0KQEAgLTY2NSw3ICs2NzIsNyBAQAogICAgICAgICAgICAgICAr K3BuOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBpZiAocHcgPT0gd2lsZGNhcmQuZW5k KCkpCisgICAgICAgICAgICBpZiAocHcgPT0gd2lsZGNhcmQuZW5kKCkgJiYgaXNfcmVndWxhcl9m aWxlKHBhdGggKyBuYW1lKSkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgbWF0Y2hlcy0+ cHVzaF9iYWNrKHBhdGggKyBuYW1lKTsKICAgICAgICAgICAgIH0KQEAgLTY3NiwxNCArNjgzLDkg QEAKICAgICAgIGNsb3NlZGlyKGRpcnApOwogICAgIH0KICAgfQotICBlbHNlCisgIGVsc2UgaWYg KGlzX3JlZ3VsYXJfZmlsZShwYXRoICsgd2lsZGNhcmQpKQogICB7Ci0gICAgc3RydWN0IHN0YXQg c3Q7Ci0gICAgc3RyaW5nIGZuID0gcGF0aCArIHdpbGRjYXJkOwotICAgIGlmIChzdGF0KGZuLmNf c3RyKCksICZzdCkgPT0gMCkKLSAgICB7Ci0gICAgICBtYXRjaGVzLT5wdXNoX2JhY2socGF0aCAr IHdpbGRjYXJkKTsKLSAgICB9CisgICAgbWF0Y2hlcy0+cHVzaF9iYWNrKHBhdGggKyB3aWxkY2Fy ZCk7CiAgIH0KIAogICByZXR1cm4gbWF0Y2hlczsK 31884 2004-05-23 05:51 0000 par2cmdline-0.4-r1.ebuild par2cmdline-0.4-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA0IEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYy CiMgJEhlYWRlcjogL2hvbWUvY3Zzcm9vdC9nZW50b28teDg2L2FwcC1hcmNoL3BhcjJjbWRsaW5l L3BhcjJjbWRsaW5lLTAuNC5lYnVpbGQsdiAxLjEgMjAwNC8wNS8xNyAwNjozOTozMiByb2JiYXQy IEV4cCAkCgpERVNDUklQVElPTj0iQSBQQVItMi4wIGZpbGUgdmVyaWZpY2F0aW9uIGFuZCByZXBh aXIgdG9vbCIKSE9NRVBBR0U9Imh0dHA6Ly9wYXJjaGl2ZS5zb3VyY2Vmb3JnZS5uZXQvIgpTUkNf VVJJPSJtaXJyb3I6Ly9zb3VyY2Vmb3JnZS9wYXJjaGl2ZS8ke1B9LnRhci5neiIKTElDRU5TRT0i R1BMLTIiClNMT1Q9IjAiCktFWVdPUkRTPSJ+eDg2IH5hbWQ2NCIKREVQRU5EPSIiCgpzcmNfdW5w YWNrKCkgewoJdW5wYWNrICR7QX0KCWVwYXRjaCAke0ZJTEVTRElSfS8ke1B9LXdpbGRjYXJkLWZp eC5wYXRjaAp9CgpzcmNfY29tcGlsZSgpIHsKCWVjb25mIHx8IGRpZQoJZW1ha2UgfHwgZGllCn0K CnNyY19pbnN0YWxsKCkgewoJZWluc3RhbGwgfHwgZGllCglsb2NhbCBET0NMSVNUPSJBVVRIT1JT IElOU1RBTEwgQ09QWUlORyBDaGFuZ2VMb2cgTkVXUyBQT1JUSU5HIFJFQURNRSBST0FETUFQIgoJ Y2htb2QgLXggJHtET0NMSVNUfQoJZG9kb2MgJHtET0NMSVNUfQp9Cgpwa2dfcG9zdGluc3QoKSB7 CgllaW5mbyAiVXNlICg8cGFyMmNyZWF0ZXxwYXIyIGM+IGFyY2hpdmUpIHRvIGNyZWF0ZSBQQVIy IGFyY2hpdmUiCgllaW5mbyAiVXNlICg8cGFyMnZlcmlmeXxwYXIyIHY+IGFyY2hpdmUpIHRvIHZl cmlmeSBQQVIyIGFyY2hpdmUiCgllaW5mbyAiVXNlICg8cGFyMnJlcGFpcnxwYXIyIHI+IGFyY2hp dmUpIHRvIHJlcGFpciBQQVIyIGFyY2hpdmUiCn0K 31931 2004-05-24 00:07 0000 par2cmdline-0.4-wildcard-fix-2.patch par2cmdline-0.4-wildcard-fix.patch text/plain ZGlmZiAtdXIgcGFyMmNtZGxpbmUtMC40L2Rpc2tmaWxlLmNwcCBwYXIyY21kbGluZS0wLjQucGF0 Y2hlZC9kaXNrZmlsZS5jcHAKLS0tIHBhcjJjbWRsaW5lLTAuNC9kaXNrZmlsZS5jcHAJMjAwNC0w NC0xMiAxMzoyNTozNy4wMDAwMDAwMDAgKzAyMDAKKysrIHBhcjJjbWRsaW5lLTAuNC5wYXRjaGVk L2Rpc2tmaWxlLmNwcAkyMDA0LTA1LTI0IDA4OjU2OjQ1LjIxOTM2ODIwNyArMDIwMApAQCAtNjE4 LDYgKzYxOCwxMiBAQAogICByZXR1cm4gcmVzdWx0OwogfQogCitib29sIGlzX3JlZ3VsYXJfZmls ZShjb25zdCBzdHJpbmcgJnApCit7CisgIHN0cnVjdCBzdGF0IHN0OworICByZXR1cm4gKHN0YXQo cC5jX3N0cigpLCAmc3QpID09IDAgJiYgU19JU1JFRyhzdC5zdF9tb2RlKSk7Cit9CisKIGxpc3Q8 c3RyaW5nPiogRGlza0ZpbGU6OkZpbmRGaWxlcyhzdHJpbmcgcGF0aCwgc3RyaW5nIHdpbGRjYXJk KQogewogICBsaXN0PHN0cmluZz4gKm1hdGNoZXMgPSBuZXcgbGlzdDxzdHJpbmc+OwpAQCAtNjQ4 LDcgKzY1NCwxNSBAQAogICAgICAgICAgICAgICBuYW1lLnN1YnN0cigwLCB3aGVyZSkgPT0gZnJv bnQgJiYKICAgICAgICAgICAgICAgbmFtZS5zdWJzdHIobmFtZS5zaXplKCktYmFjay5zaXplKCkp ID09IGJhY2spCiAgICAgICAgICAgewotICAgICAgICAgICAgbWF0Y2hlcy0+cHVzaF9iYWNrKHBh dGggKyBuYW1lKTsKKyAgICAgICAgICAgIGlmIChpc19yZWd1bGFyX2ZpbGUocGF0aCArIG5hbWUp KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICBtYXRjaGVzLT5wdXNoX2JhY2socGF0aCAr IG5hbWUpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgewor ICAgICAgICAgICAgICBjZXJyIDw8ICJXYXJuaW5nOiAnIiA8PCAocGF0aCArIG5hbWUpIAorICAg ICAgICAgICAgICAgICAgIDw8ICInIGlnbm9yZWQ7IG5vdCBhIHJlZ3VsYXIgZmlsZSIgPDwgZW5k bDsKKyAgICAgICAgICAgIH0KICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgZWxzZQpA QCAtNjY3LDcgKzY4MSwxNSBAQAogCiAgICAgICAgICAgICBpZiAocHcgPT0gd2lsZGNhcmQuZW5k KCkpCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIG1hdGNoZXMtPnB1c2hfYmFjayhwYXRo ICsgbmFtZSk7CisgICAgICAgICAgICAgIGlmIChpc19yZWd1bGFyX2ZpbGUocGF0aCArIG5hbWUp KSAKKyAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIG1hdGNoZXMtPnB1c2hfYmFjayhw YXRoICsgbmFtZSk7CisgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgZWxzZQorICAgICAg ICAgICAgICB7CisgICAgICAgICAgICAgICAgY2VyciA8PCAiV2FybmluZzogJyIgPDwgKHBhdGgg KyBuYW1lKSAKKyAgICAgICAgICAgICAgICAgICAgIDw8ICInIGlnbm9yZWQ7IG5vdCBhIHJlZ3Vs YXIgZmlsZSIgPDwgZW5kbDsKKyAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAg ICAgIH0KICAgICAgICAgfQpAQCAtNjc4LDEyICs3MDAsMTUgQEAKICAgfQogICBlbHNlCiAgIHsK LSAgICBzdHJ1Y3Qgc3RhdCBzdDsKLSAgICBzdHJpbmcgZm4gPSBwYXRoICsgd2lsZGNhcmQ7Ci0g ICAgaWYgKHN0YXQoZm4uY19zdHIoKSwgJnN0KSA9PSAwKQorICAgIGlmIChpc19yZWd1bGFyX2Zp bGUocGF0aCArIHdpbGRjYXJkKSkKICAgICB7CiAgICAgICBtYXRjaGVzLT5wdXNoX2JhY2socGF0 aCArIHdpbGRjYXJkKTsKICAgICB9CisgICAgZWxzZQorICAgIHsKKyAgICAgIGNlcnIgPDwgIldh cm5pbmc6ICciIDw8IChwYXRoICsgd2lsZGNhcmQpIAorICAgICAgICAgICA8PCAiJyBpZ25vcmVk OyBub3QgYSByZWd1bGFyIGZpbGUiIDw8IGVuZGw7CisgICAgfQogICB9CiAKICAgcmV0dXJuIG1h dGNoZXM7Cg== 84110 2006-04-07 00:28 0000 shell expanded wildcard patch for par2cmdline par2cmdline.shellexpandedwildcard.patch text/plain LS0tIGNvbW1hbmRsaW5lLmNwcC5vcmlnCTIwMDYtMDQtMDYgMjE6NDE6MjcuMDAwMDAwMDAwIC0w NzAwCisrKyBjb21tYW5kbGluZS5jcHAJMjAwNi0wNC0wNyAwMDoxMjoyOS4wMDAwMDAwMDAgLTA3 MDAKQEAgLTU1MCw2ICs1NTAsMjAgQEAKICAgICAgICAgfQogICAgICAgICBlbHNlCiAgICAgICAg IHsKKyAgICAgICAgICAvL3N0YXJ0IG9mIHNoZWxsIGV4cGFuZGVkICogcGF0Y2guIC0tIE1pY2hh ZWwgRXZhbnMKKyAgICAgICAgICAvL1RoZSBzaGVsbCBtaWdodCBleHBhbmVkICogc28sIGlmIHdl IGhhdmUgb3VyIG5hbWUgYW5kIHdlJ3JlIGNyZWF0aW5nLCB0aGVuIGZpbHRlciBmb3IgZmlsZXMu Li4KKyAgICAgICAgICBpZiAoKHBhcmZpbGVuYW1lLmxlbmd0aCgpICE9IDApICYmIChvcGVyYXRp b24gPT0gb3BDcmVhdGUpKQorICAgICAgICAgIHsKKyAgICAgICAgICAgIHN0cnVjdCBzdGF0IHN0 OworICAgICAgICAgICAgaWYgKCEoc3RhdChhcmd2WzBdLCAmc3QpID09IDAgJiYgU19JU1JFRyhz dC5zdF9tb2RlKSkpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgIGNlcnIgPDwgIlNraXBw aW5nIG5vbi1yZWd1bGFyIGZpbGU6ICIgPDwgYXJndlswXSA8PCBlbmRsOworICAgICAgICAgICAg ICBhcmdjLS07CisgICAgICAgICAgICAgIGFyZ3YrKzsKKyAgICAgICAgICAgICAgb3B0aW9ucyA9 IGZhbHNlOworICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICB9Ly9lbmQgb2Ygc2hlbGwgZXhwYW5kZWQgKiBwYXRjaC4gLS0gTWljaGFlbCBFdmFucwogICAg ICAgICAgIGZpbGVuYW1lcyA9IG5ldyBsaXN0PHN0cmluZz47CiAgICAgICAgICAgZmlsZW5hbWVz LT5wdXNoX2JhY2soYXJndlswXSk7CiAgICAgICAgIH0K