49179 2004-04-27 10:00 0000 ALLOWED_FLAGS in extra_functions.sh overrides flag-o-matic.eclass 2004-10-22 08:47:30 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All All RESOLVED FIXED InCVS P2 normal --- 1 agriffis@gentoo.org agriffis@gentoo.org aliz@gentoo.org blkdeath@gentoo.org dev-portage@gentoo.org media-video@gentoo.org peddamat@gmail.com solar@gentoo.org spock@gentoo.org stkn@gentoo.org taviso@gentoo.org vapier@gentoo.org agriffis@gentoo.org 2004-04-27 10:00:16 0000 While working on the mozilla ebuild, I found that -fstack-protector is always filtered by strip-flags. This is because ALLOWED_FLAGS is set in extra-functions.sh. flag-o-matic.eclass has the following if [ -z "${ALLOWED_FLAGS}" ] ; then export ALLOWED_FLAGS="-O -O1 -O2 -mcpu -march -mtune -fstack-protector -pipe -g" ... fi So flag-o-matic never overrides the ALLOWED_FLAGS from ebuild.sh because it is trying to allow the ebuild to set a custom ALLOWED_FLAGS Clearly the flag-o-matic functions should never have been sucked into portage at all. extra-functions.sh simply doesn't make sense since those functions can be better maintained in eclasses, and there's no reason to make them dependent on the portage release cycle. I would like to do the following: 1. Fix all the ebuilds using flag functions to inherit flag-o-matic properly 2. Kill the flag-o-matic section from extra-functions.sh agriffis@gentoo.org 2004-04-27 10:02:18 0000 Btw, I am starting on #1 now, similar to the way I did econf || die yesterday agriffis@gentoo.org 2004-04-27 10:22:36 0000 Created an attachment (id=30164) missing-flag-o-matic.txt sed -n '/^[a-z]/s/(.*//p' eclass/flag-o-matic.eclass > flag-o-list.txt find . -name \*.ebuild | xargs grep -L '^inherit.*flag-o-matic' | xargs grep -wFf flag-o-list.txt | sort | tee missing-flag-o-matic.txt solar@gentoo.org 2004-04-27 11:16:13 0000 Adding a few extra commands to your output I get the following list of package maintainers. Which I'll add to the CC so they may be aware of this problem and hopefully use flag-o in the future with inherit statements. cat missing-flag-o-matic.txt | cut -d : -f 1 | while read ebuild ; do [ -f /portage/`dirname ${ebuild}`/metadata.xml ] && \ echo $(grep email /portage/`dirname ${ebuild}`/metadata.xml ) \ maintains $ebuild |sed s/'<email>'//g| sed s:'</email>'::g; done taviso@gentoo.org maintains ./app-shells/ksh/ksh-93.20030724.ebuild taviso@gentoo.org maintains ./app-shells/ksh/ksh-93.20040229.ebuild media-video@gentoo.org maintains ./dev-libs/libebml/libebml-0.6.4.ebuild media-video@gentoo.org maintains ./dev-libs/libebml/libebml-0.6.5.ebuild media-video@gentoo.org maintains ./media-libs/libmatroska/libmatroska-0.6.3.ebuild media-video@gentoo.org maintains ./media-plugins/live/live-2004.03.27.ebuild blkdeath@gentoo.org maintains ./net-dns/bind-tools/bind-tools-9.2.3.ebuild aliz@gentoo.org maintains ./net-firewall/fwbuilder/fwbuilder-1.0.11.ebuild aliz@gentoo.org maintains ./net-firewall/fwbuilder/fwbuilder-1.1.1.ebuild aliz@gentoo.org maintains ./net-firewall/fwbuilder/fwbuilder-1.1.1-r1.ebuild stkn@gentoo.org maintains ./net-libs/openh323/openh323-1.13.5.ebuild maintains ./sys-devel/gcc/gcc-3.0.4-r6.ebuild spock@gentoo.org maintains ./x11-misc/xfractint/xfractint-20.2.04.ebuild spock@gentoo.org maintains ./x11-misc/xfractint/xfractint-20.2.05.ebuild spock@gentoo.org maintains ./x11-misc/xfractint/xfractint-20.3.00.ebuild spock@gentoo.org maintains ./x11-misc/xfractint/xfractint-20.3.01.ebuild taviso@gentoo.org maintains ./x11-terms/xvt/xvt-2.1.ebuild agriffis@gentoo.org 2004-04-27 11:28:18 0000 Created an attachment (id=30168) Patch against extra_functions.sh to remove flag-o-matic cruft agriffis@gentoo.org 2004-04-27 11:35:06 0000 I guess my last comment was lost... I finished fixing the list of ebuilds, that's why the patch can now be applied to extra_functions.sh agriffis@gentoo.org 2004-04-27 11:40:54 0000 I'm putting further updates in 29683 blkdeath@gentoo.org 2004-04-28 23:54:09 0000 Sorry, I must be missing something here; one of my ebuilds inherits flag-o-matic, but I can't tell what I'm doing/not doing. agriffis@gentoo.org 2004-04-29 07:10:56 0000 Stewart, need more info... what ebuild, and what don't you understand? blkdeath@gentoo.org 2004-04-30 10:18:32 0000 blkdeath@gentoo.org maintains ./net-dns/bind-tools/bind-tools-9.2.3.ebuild I'm the BIND maintainer, the above ebuild does inherit flag-o-matic, but I don't understand why I'm being CC'ed on this bug - ie I don't understand what's being done incorrectly in said ebuild. agriffis@gentoo.org 2004-04-30 11:00:06 0000 Stewart, the reason you and everybody else is being cc'd on this bug is to make you aware that your ebuild was modified to use the flag functions from flag-o-matic. I modified your ebuild because it was using the flag functions from extra_functions.sh, and those functions are being removed in favor of the flag-o-matic eclass. So we want you to be aware of this so that future versions of your ebuild will continue to inherit flag-o-matic. Okay? :-) carpaski@gentoo.org 2004-05-16 04:29:25 0000 This is out of portage for the next revisions. vapier@gentoo.org 2004-05-29 14:14:20 0000 *** Bug 51352 has been marked as a duplicate of this bug. *** carpaski@gentoo.org 2004-10-22 08:47:30 0000 Bug has been fixed and released in stable portages on or before 2.0.51-r2 30164 2004-04-27 10:22 0000 missing-flag-o-matic.txt missing-flag-o-matic.txt text/plain Li9hcHAtc2hlbGxzL2tzaC9rc2gtOTMuMjAwMzA3MjQuZWJ1aWxkOgl1c2Ugc3RhdGljICYmIGFw cGVuZC1sZGZsYWdzIC1zdGF0aWMKLi9hcHAtc2hlbGxzL2tzaC9rc2gtOTMuMjAwNDAyMjkuZWJ1 aWxkOgl1c2Ugc3RhdGljICYmIGFwcGVuZC1sZGZsYWdzIC1zdGF0aWMKLi9kZXYtbGlicy9mZmNh bGwvZmZjYWxsLTEuOS5lYnVpbGQ6CWFwcGVuZC1mbGFncyAtZlBJQwouL2Rldi1saWJzL2xpYmVi bWwvbGliZWJtbC0wLjYuNC5lYnVpbGQ6CWFwcGVuZC1mbGFncyAtZlBJQwouL2Rldi1saWJzL2xp YmVibWwvbGliZWJtbC0wLjYuNS5lYnVpbGQ6CWFwcGVuZC1mbGFncyAtZlBJQwouL2Rldi1saWJz L3VjbC91Y2wtMS4wMS1yMS5lYnVpbGQ6CWFwcGVuZC1mbGFncyAtZlBJQwouL21lZGlhLWxpYnMv bGlibWF0cm9za2EvbGlibWF0cm9za2EtMC42LjMuZWJ1aWxkOgl1c2UgYW1kNjQgJiYgYXBwZW5k LWZsYWdzIC1mUElDCi4vbWVkaWEtcGx1Z2lucy9saXZlL2xpdmUtMjAwNC4wMy4yNy5lYnVpbGQ6 CXVzZSBhbWQ2NCAmJiBhcHBlbmQtZmxhZ3MgLWZQSUMKLi9tZWRpYS1zb3VuZC9tdXNlcGFjay10 b29scy9tdXNlcGFjay10b29scy0xLjE1ci5lYnVpbGQ6CWZpbHRlci1mbGFncyAiLWZwcmVmZXRj aC1sb29wLWFycmF5cyIKLi9uZXQtZG5zL2JpbmQtdG9vbHMvYmluZC10b29scy05LjIuMy5lYnVp bGQ6CQlhcHBlbmQtZmxhZ3MgLWZQSUMKLi9uZXQtZmlyZXdhbGwvZndidWlsZGVyL2Z3YnVpbGRl ci0xLjAuMTEuZWJ1aWxkOglyZXBsYWNlLWZsYWdzICItTzMiICItTzIiCi4vbmV0LWZpcmV3YWxs L2Z3YnVpbGRlci9md2J1aWxkZXItMS4xLjEuZWJ1aWxkOglyZXBsYWNlLWZsYWdzICItTzMiICIt TzIiCi4vbmV0LWZpcmV3YWxsL2Z3YnVpbGRlci9md2J1aWxkZXItMS4xLjEtcjEuZWJ1aWxkOgly ZXBsYWNlLWZsYWdzICItTzMiICItTzIiCi4vbmV0LWxpYnMvb3BlbmgzMjMvb3BlbmgzMjMtMS4x My41LmVidWlsZDoJdXNlIGFtZDY0ICYmIGFwcGVuZC1mbGFncyAtZlBJQwouL3N5cy1kZXZlbC9n Y2MvZ2NjLTMuMC40LXI2LmVidWlsZDoJZmlsdGVyLWZsYWdzIC1PPwouL3gxMS1taXNjL3hmcmFj dGludC94ZnJhY3RpbnQtMjAuMi4wNC5lYnVpbGQ6CXJlcGxhY2UtZmxhZ3MgIi1mdW5yb2xsLWFs bC1sb29wcyIgIi1mdW5yb2xsLWxvb3BzIgouL3gxMS1taXNjL3hmcmFjdGludC94ZnJhY3RpbnQt MjAuMi4wNS5lYnVpbGQ6CXJlcGxhY2UtZmxhZ3MgIi1mdW5yb2xsLWFsbC1sb29wcyIgIi1mdW5y b2xsLWxvb3BzIgouL3gxMS1taXNjL3hmcmFjdGludC94ZnJhY3RpbnQtMjAuMy4wMC5lYnVpbGQ6 CXJlcGxhY2UtZmxhZ3MgIi1mdW5yb2xsLWFsbC1sb29wcyIgIi1mdW5yb2xsLWxvb3BzIgouL3gx MS1taXNjL3hmcmFjdGludC94ZnJhY3RpbnQtMjAuMy4wMS5lYnVpbGQ6CXJlcGxhY2UtZmxhZ3Mg Ii1mdW5yb2xsLWFsbC1sb29wcyIgIi1mdW5yb2xsLWxvb3BzIgouL3gxMS10ZXJtcy94dnQveHZ0 LTIuMS5lYnVpbGQ6CWFwcGVuZC1sZGZsYWdzIC1ML3Vzci9YMTFSNi9saWIK 30168 2004-04-27 11:28 0000 Patch against extra_functions.sh to remove flag-o-matic cruft extra_functions.sh.patch text/plain LS0tIC91c3IvbGliL3BvcnRhZ2UvYmluL2V4dHJhX2Z1bmN0aW9ucy5zaAkyMDA0LTAyLTEyIDEz OjU1OjMxLjAwMDAwMDAwMCAtMDUwMAorKysgZXh0cmFfZnVuY3Rpb25zLnNoCTIwMDQtMDQtMjcg MTQ6Mjc6MDIuMDAwMDAwMDAwIC0wNDAwCkBAIC02LDEwNiArNiw2IEBACiAJZWNobyAiUlVOTklO RyBGUk9NIEVYVFJBX0ZVTkNUSU9OUy5TSCIKIH0KIAotIyA9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0j IEV4dHJhY3RlZCBmcm9tIGZsYWctby1tYXRpYyAtLSBNYXJjaCAxMCwgMjAwMwotIyA9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0KLSMjIyMgZmlsdGVyLWZsYWdzIDxmbGFnPiAjIyMjCi0jIFJlbW92ZSBw YXJ0aWN1bGFyIGZsYWdzIGZyb20gQ1tYWF1GTEFHUwotIwotIyMjIyBhcHBlbmQtZmxhZ3MgPGZs YWc+ICMjIyMKLSMgQWRkIGV4dHJhIGZsYWdzIHRvIHlvdXIgY3VycmVudCBDW1hYXUZMQUdTCi0j Ci0jIyMjIHJlcGxhY2UtZmxhZ3MgPG9yaWcuZmxhZz4gPG5ldy5mbGFnPiAjIyMKLSMgUmVwbGFj ZSBhIGZsYWcgYnkgYW5vdGhlciBvbmUKLSMKLSMjIyMgaXMtZmxhZyA8ZmxhZz4gIyMjIwotIyBS ZXR1cm5zICJ0cnVlIiBpZiBmbGFnIGlzIHNldCBpbiBDW1hYXUZMQUdTCi0jIE1hdGNoZXMgb25s eSBjb21wbGV0ZSBmbGFnCi0jCi0jIyMjIHN0cmlwLWZsYWdzICMjIyMKLSMgU3RyaXAgQ1tYWF1G TEFHUyBvZiBldmVyeXRoaW5nIGV4Y2VwdCBrbm93bgotIyBnb29kIG9wdGlvbnMuCi0jCi0jIyMj IGdldC1mbGFnIDxmbGFnPiAjIyMjCi0jIEZpbmQgYW5kIGVjaG8gdGhlIHZhbHVlIGZvciBhIHBh cnRpY3VsYXIgZmxhZwotIwotCi1BTExPV0VEX0ZMQUdTPSItTyAtbWNwdSAtbWFyY2ggLXBpcGUg LWciCi0KLWZpbHRlci1mbGFncygpIHsKLQlmb3IgeCBpbiAkMTsgZG8KLQkJZXhwb3J0IENGTEFH Uz0iJHtDRkxBR1MvJHt4fX0iCi0JCWV4cG9ydCBDWFhGTEFHUz0iJHtDWFhGTEFHUy8ke3h9fSIK LQlkb25lCi19Ci0KLWFwcGVuZC1mbGFncygpIHsKLQlDRkxBR1M9IiR7Q0ZMQUdTfSAkMSIKLQlD WFhGTEFHUz0iJHtDWFhGTEFHU30gJDEiCi19Ci0KLXJlcGxhY2UtZmxhZ3MoKSB7Ci0JQ0ZMQUdT PSIke0NGTEFHUy8kezF9LyR7Mn0gfSIKLQlDWFhGTEFHUz0iJHtDWFhGTEFHUy8kezF9LyR7Mn0g fSIKLX0KLQotaXMtZmxhZygpIHsKLQlmb3IgeCBpbiAke0NGTEFHU30gJHtDWFhGTEFHU307CWRv Ci0JCWlmIFsgIiR7eH0iID0gIiQxIiBdOyB0aGVuCi0JCQllY2hvIHRydWUKLQkJCXJldHVybiAw Ci0JCWZpCi0JZG9uZQotCXJldHVybiAxCi19Ci0KLXN0cmlwLWZsYWdzKCkgewotCWxvY2FsIE5F V19DRkxBR1M9IiIKLQlsb2NhbCBORVdfQ1hYRkxBR1M9IiIKLQotCXNldCAtZgotCWZvciB4IGlu ICR7Q0ZMQUdTfTsgZG8KLQkJZm9yIHkgaW4gJHtBTExPV0VEX0ZMQUdTfTsgZG8KLQkJCWlmIFsg IiR7eC8ke3l9fSIgIT0gIiR7eH0iIF07IHRoZW4KLQkJCQlpZiBbIC16ICIke05FV19DRkxBR1N9 IiBdOyB0aGVuCi0JCQkJCU5FV19DRkxBR1M9IiR7eH0iCi0JCQkJZWxzZQotCQkJCQlORVdfQ0ZM QUdTPSIke05FV19DRkxBR1N9ICR7eH0iCi0JCQkJZmkKLQkJCWZpCi0JCWRvbmUKLQlkb25lCi0K LQlmb3IgeCBpbiAke0NYWEZMQUdTfTsgZG8KLQkJZm9yIHkgaW4gJHtBTExPV0VEX0ZMQUdTfTsg ZG8KLQkJCWlmIFsgIiR7eC8ke3l9fSIgIT0gIiR7eH0iIF07IHRoZW4KLQkJCQlpZiBbIC16ICIk e05FV19DWFhGTEFHU30iIF07IHRoZW4KLQkJCQkJTkVXX0NYWEZMQUdTPSIke3h9IgotCQkJCWVs c2UKLQkJCQkJTkVXX0NYWEZMQUdTPSIke05FV19DWFhGTEFHU30gJHt4fSIKLQkJCQlmaQotCQkJ ZmkKLQkJZG9uZQotCWRvbmUKLQotCXNldCArZgotCi0JZXhwb3J0IENGTEFHUz0iJHtORVdfQ0ZM QUdTfSIKLQlleHBvcnQgQ1hYRkxBR1M9IiR7TkVXX0NYWEZMQUdTfSIKLX0KLQotZ2V0LWZsYWco KSB7Ci0JbG9jYWwgZmluZGZsYWc9IiQxIgotCi0JZm9yIGYgaW4gJHtDRkxBR1N9ICR7Q1hYRkxB R1N9OyBkbwotCQlpZiBbICIke2YvJHtmaW5kZmxhZ319IiAhPSAiJHtmfSIgXTsgdGhlbgotCQkJ ZWNobyAiJHtmLy0ke2ZpbmRmbGFnfT19IgotCQkJcmV0dXJuCi0JCWZpCi0JZG9uZQotfQotCiAj IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCg==