48947 2004-04-25 09:20 0000 Patch to make libsdl-1.2.7 compile and link with GCC 3.4 2004-05-15 23:16:59 0000 1 1 1 Unclassified Gentoo Linux Library unspecified x86 All RESOLVED FIXED P2 minor --- 48528 1 aknuds-1@broadpark.no gcc-porting@gentoo.org aknuds-1@broadpark.no 2004-04-25 09:20:41 0000 Unpatched libsdl-1.2.7 contains assembly code which isn't entirely compatible with GCC 3.4, ie. GCC will complain the PID register (ebx) is clobbered, and static variables are only referenced directly in inline asm; causing GCC to omit them from object code. The patched library is tested with neverball and UT2004, but no guarantees. aknuds-1@broadpark.no 2004-04-25 09:22:40 0000 Created an attachment (id=30017) Make libsdl-1.2.7 compile/link with GCC 3.4 Apply in directory containing SDL-1.2.7 lorien420@myrealbox.com 2004-04-28 03:59:03 0000 I've also successfully used this patch to play Savage lv@gentoo.org 2004-04-28 13:30:37 0000 can somebody on x86 take a look at this? i'm on amd64 and libsdl works perfectly, since we're not hitting this particular bit of assembly. jowilly@hotpop.com 2004-04-28 14:14:00 0000 The patch works perfectly here on x86. robmoss@gentoo.org 2004-04-30 18:16:16 0000 Just to note - this also works perfectly here on x86 too. schrepfler@hotmail.com 2004-05-03 09:03:20 0000 What's the procedure? Download patch in distfiles and apply the patch? How? Doesn't that change the md5 signature, how does portage let you continue the install? vapier@gentoo.org 2004-05-03 10:25:55 0000 SDL-1.2.7/src/audio/SDL_mixer_MMX.c and SDL-1.2.7/src/video/SDL_yuv_mmx.c looks good ... i'll send these upstream however, SDL-1.2.7/src/cpuinfo/SDL_cpuinfo.c doesnt look so good ... i notice you remove %ebx from the clobber list yet ebx is still used in the inline asm code ... aknuds-1@broadpark.no 2004-05-03 15:32:50 0000 The reason for removing ebx from the clobber list is that, unless I'm mistaken, it is restored at the end of the asm block (ie. movl %%ebx, %%edi at the beginning of the block and movl %%edi, %%ebx at the end), so it should equal the recommended pushl/popl combo? nicolas-laplante@videotron.ca 2004-05-04 14:47:47 0000 To Srepfler Srgjan: To make the patch apply, just put the patch in /usr/portage/media-libs/libsdl/files and edit the build to add: epatch ${FILESDIR}/the_file.patch in the src_unpack() function. vapier@gentoo.org 2004-05-05 17:50:01 0000 yeah, you're right, i missed that bit :) i'm talking with upstream devs to get it all integrated vapier@gentoo.org 2004-05-15 23:16:59 0000 ok, i added a patch that is partially yours and partially from upstream to cvs upstream should have this added for their next release :) 30017 2004-04-25 09:22 0000 Make libsdl-1.2.7 compile/link with GCC 3.4 gcc-3.4.patch text/plain ZGlmZiAtcnUgU0RMLTEuMi43L3NyYy9hdWRpby9TRExfbWl4ZXJfTU1YLmMgU0RMLTEuMi43Lm1v ZC9zcmMvYXVkaW8vU0RMX21peGVyX01NWC5jCi0tLSBTREwtMS4yLjcvc3JjL2F1ZGlvL1NETF9t aXhlcl9NTVguYwkyMDAyLTExLTA5IDA3OjEzOjI4LjAwMDAwMDAwMCArMDEwMAorKysgU0RMLTEu Mi43Lm1vZC9zcmMvYXVkaW8vU0RMX21peGVyX01NWC5jCTIwMDQtMDQtMjUgMTg6MTU6NDYuMzM1 MjI4NjI0ICswMjAwCkBAIC0xOSw5ICsxOSw5IEBACiAiCW1vdmwgJTEsJSVlc2lcbiIJLy8gZXNp ID0gc3JjCiAiCW1vdmwgJTMsJSVlYXhcbiIJLy8gZWF4ID0gdm9sdW1lCiAKLSIJbW92bCAlMiwl JWVieFxuIgkvLyBlYnggPSBzaXplCisiCW1vdmwgJTIsJSVlZHhcbiIJLy8gZWR4ID0gc2l6ZQog Ci0iCXNocmwgJDQsJSVlYnhcbiIJLy8gcHJvY2VzcyAxNiBieXRlcyBwZXIgaXRlcmF0aW9uID0g OCBzYW1wbGVzCisiCXNocmwgJDQsJSVlZHhcbiIJLy8gcHJvY2VzcyAxNiBieXRlcyBwZXIgaXRl cmF0aW9uID0gOCBzYW1wbGVzCiAKICIJanogLmVuZFMxNlxuIgogCkBAIC05NSw3ICs5NSw3IEBA CiAKICIJYWRkbCAkMTYsJSVlZGlcbiIKIAotIglkZWMgJSVlYnhcbiIKKyIJZGVjICUlZWR4XG4i CiAKICIJam56IC5taXhsb29wUzE2XG4iCiAKQEAgLTEwNSw3ICsxMDUsNyBAQAogCSA6CiAJIDog Im0iIChkc3QpLCAibSIoc3JjKSwibSIoc2l6ZSksCiAJICJtIih2b2x1bWUpCi0JIDogImVheCIs ImVieCIsICJlc2kiLCAiZWRpIiwibWVtb3J5IgorCSA6ICJlYXgiLCJlZHgiLCAiZXNpIiwgImVk aSIsIm1lbW9yeSIKIAkgKTsKIH0KIApAQCAtMTIzLDcgKzEyMyw3IEBACiAiCW1vdmwgJTEsJSVl c2lcbiIJLy8gZXNpID0gc3JjCiAiCW1vdmwgJTMsJSVlYXhcbiIJLy8gZWF4ID0gdm9sdW1lCiAK LSIJbW92ZCAlJWVieCwlJW1tMFxuIgorIgltb3ZkICUlZWR4LCUlbW0wXG4iCiAiCW1vdnEgJSVt bTAsJSVtbTFcbiIKICIJcHNsbHEgJDE2LCUlbW0wXG4iCiAiCXBvciAlJW1tMSwlJW1tMFxuIgpA QCAtMTMyLDEwICsxMzIsMTAgQEAKICIJcHNsbHEgJDE2LCUlbW0wXG4iCiAiCXBvciAlJW1tMSwl JW1tMFxuIgogCi0iCW1vdmwgJTIsJSVlYnhcbiIJLy8gZWJ4ID0gc2l6ZQotIglzaHIgJDMsJSVl YnhcbiIJLy8gcHJvY2VzcyA4IGJ5dGVzIHBlciBpdGVyYXRpb24gPSA4IHNhbXBsZXMKKyIJbW92 bCAlMiwlJWVkeFxuIgkvLyBlZHggPSBzaXplCisiCXNociAkMywlJWVkeFxuIgkvLyBwcm9jZXNz IDggYnl0ZXMgcGVyIGl0ZXJhdGlvbiA9IDggc2FtcGxlcwogCi0iCWNtcCAkMCwlJWVieFxuIgor IgljbXAgJDAsJSVlZHhcbiIKICIJamUgLmVuZFM4XG4iCiAKICIuYWxpZ24gMTZcbiIKQEAgLTE2 OSw3ICsxNjksNyBAQAogIgltb3ZxICUlbW0zLCglJWVkaSlcbiIJLy8gc3RvcmUgYmFjayB0byBy YW0KICIJYWRkbCAkOCwlJWVkaVxuIgogCi0iCWRlYyAlJWVieFxuIgorIglkZWMgJSVlZHhcbiIK IAogIglqbnogLm1peGxvb3BTOFxuIgogCkBAIC0xNzgsNyArMTc4LDcgQEAKIAkgOgogCSA6ICJt IiAoZHN0KSwgIm0iKHNyYyksIm0iKHNpemUpLAogCSAibSIodm9sdW1lKQotCSA6ICJlYXgiLCJl YngiLCAiZXNpIiwgImVkaSIsIm1lbW9yeSIKKwkgOiAiZWF4IiwiZWR4IiwgImVzaSIsICJlZGki LCJtZW1vcnkiCiAJICk7CiB9CiAjZW5kaWYKZGlmZiAtcnUgU0RMLTEuMi43L3NyYy9jcHVpbmZv L1NETF9jcHVpbmZvLmMgU0RMLTEuMi43Lm1vZC9zcmMvY3B1aW5mby9TRExfY3B1aW5mby5jCi0t LSBTREwtMS4yLjcvc3JjL2NwdWluZm8vU0RMX2NwdWluZm8uYwkyMDA0LTAyLTEwIDE2OjMxOjM1 LjAwMDAwMDAwMCArMDEwMAorKysgU0RMLTEuMi43Lm1vZC9zcmMvY3B1aW5mby9TRExfY3B1aW5m by5jCTIwMDQtMDQtMjUgMTg6MTU6NDYuMzM2MjI4NDcyICswMjAwCkBAIC0xMTgsNyArMTE4LDcg QEAKICIgICAgICAgIG1vdmwgICAgJSVlZGksJSVlYnhcbiIKIAk6ICI9bSIgKGZlYXR1cmVzKQog CToKLQk6ICIlZWF4IiwgIiVlYngiLCAiJWVjeCIsICIlZWR4IiwgIiVlZGkiCisJOiAiJWVheCIs ICIlZWN4IiwgIiVlZHgiLCAiJWVkaSIKIAkpOwogI2VsaWYgZGVmaW5lZChfTVNDX1ZFUikKIAlf X2FzbSB7CkBAIC0xNTMsNyArMTUzLDcgQEAKICIgICAgICAgIG1vdmwgICAgJSVlZGksJSVlYnhc biIKIAk6ICI9bSIgKGZlYXR1cmVzKQogCToKLQk6ICIlZWF4IiwgIiVlYngiLCAiJWVjeCIsICIl ZWR4IiwgIiVlZGkiCisJOiAiJWVheCIsICIlZWN4IiwgIiVlZHgiLCAiJWVkaSIKIAkpOwogI2Vs aWYgZGVmaW5lZChfTVNDX1ZFUikKIAlfX2FzbSB7CmRpZmYgLXJ1IFNETC0xLjIuNy9zcmMvdmlk ZW8vU0RMX3l1dl9tbXguYyBTREwtMS4yLjcubW9kL3NyYy92aWRlby9TRExfeXV2X21teC5jCi0t LSBTREwtMS4yLjcvc3JjL3ZpZGVvL1NETF95dXZfbW14LmMJMjAwNC0wMi0xOCAxODoyMjowNC4w MDAwMDAwMDAgKzAxMDAKKysrIFNETC0xLjIuNy5tb2Qvc3JjL3ZpZGVvL1NETF95dXZfbW14LmMJ MjAwNC0wNC0yNSAxODoxNTo0Ni4zMzcyMjgzMjAgKzAyMDAKQEAgLTEyMCwxMiArMTIwLDEyIEBA CiAJCSAibW92ZCAoJTIpLCAlJW1tMlxuIiAgICAgICAgICAgLy8gICAgMCAgMCAgMCAgMCBsMyBs MiBsMSBsMAogCQkgInB1bnBja2xidyAlJW1tNywlJW1tMVxuIiAvLyAgICAgICAgIDAgIHYzIDAg IHYyIDAwIHYxIDAwIHYwCiAJCSAicHVucGNrbGRxICUlbW0xLCUlbW0xXG4iIC8vICAgICAgICAg MDAgdjEgMDAgdjAgMDAgdjEgMDAgdjAKLQkJICJwc3VidyBfTU1YXzAwODB3LCUlbW0xXG4iICAv LyBtbTEtMTI4OnIxIHIxIHIwIHIwIHIxIHIxIHIwIHIwIAorCQkgInBzdWJ3ICVbX01NWF8wMDgw d10sJSVtbTFcbiIgIC8vIG1tMS0xMjg6cjEgcjEgcjAgcjAgcjEgcjEgcjAgcjAgCiAKIAkJIC8v IGNyZWF0ZSBDcl9nIChyZXN1bHQgaW4gbW0wKQogCQkgIm1vdnEgJSVtbTEsJSVtbTBcbiIgICAg ICAgICAgIC8vIHIxIHIxIHIwIHIwIHIxIHIxIHIwIHIwCi0JCSAicG11bGx3IF9NTVhfVmdyblJH QiwlJW1tMFxuIi8vIHJlZCotNDZkZWM9MC43MTM2KjY0Ci0JCSAicG11bGx3IF9NTVhfVnJlZFJH QiwlJW1tMVxuIi8vIHJlZCo4OWRlYz0xLjQwMTMqNjQKKwkJICJwbXVsbHcgJVtfTU1YX1Zncm5S R0JdLCUlbW0wXG4iLy8gcmVkKi00NmRlYz0wLjcxMzYqNjQKKwkJICJwbXVsbHcgJVtfTU1YX1Zy ZWRSR0JdLCUlbW0xXG4iLy8gcmVkKjg5ZGVjPTEuNDAxMyo2NAogCQkgInBzcmF3ICAkNiwgJSVt bTBcbiIgICAgICAgICAgIC8vIHJlZD1yZWQvNjQKIAkJICJwc3JhdyAgJDYsICUlbW0xXG4iICAg ICAgICAgICAvLyByZWQ9cmVkLzY0CiAJCSAKQEAgLTEzNCw4ICsxMzQsOCBAQAogCQkgIm1vdnEg KCUyLCU0KSwlJW1tM1xuIiAgICAgICAgIC8vICAgIDAgIDAgIDAgIDAgTDMgTDIgTDEgTDAKIAkJ ICJwdW5wY2tsZHEgJSVtbTMsJSVtbTJcbiIgICAgICAvLyAgIEwzIEwyIEwxIEwwIGwzIGwyIGwx IGwwCiAJCSAibW92cSAlJW1tMiwlJW1tNFxuIiAgICAgICAgICAgLy8gICBMMyBMMiBMMSBMMCBs MyBsMiBsMSBsMAotCQkgInBhbmQgX01NWF9GRjAwdywlJW1tMlxuIiAgICAgIC8vICAgTDMgMCAg TDEgIDAgbDMgIDAgbDEgIDAKLQkJICJwYW5kIF9NTVhfMDBGRncsJSVtbTRcbiIgICAgICAvLyAg IDAgIEwyICAwIEwwICAwIGwyICAwIGwwCisJCSAicGFuZCAlW19NTVhfRkYwMHddLCUlbW0yXG4i ICAgICAgLy8gICBMMyAwICBMMSAgMCBsMyAgMCBsMSAgMAorCQkgInBhbmQgJVtfTU1YXzAwRkZ3 XSwlJW1tNFxuIiAgICAgIC8vICAgMCAgTDIgIDAgTDAgIDAgbDIgIDAgbDAKIAkJICJwc3JsdyAk OCwlJW1tMlxuIiAgICAgICAgICAgICAvLyAgIDAgIEwzICAwIEwxICAwIGwzICAwIGwxCiAKIAkJ IC8vIGNyZWF0ZSBSIChyZXN1bHQgaW4gbW02KQpAQCAtMTUyLDExICsxNTIsMTEgQEAKIAkJICJt b3ZkICglMSksICUlbW0xXG4iICAgICAgLy8gICAgICAgICAwICAwICAwICAwICB1MyB1MiB1MSB1 MAogCQkgInB1bnBja2xidyAlJW1tNywlJW1tMVxuIiAvLyAgICAgICAgIDAgIHUzIDAgIHUyIDAw IHUxIDAwIHUwCiAJCSAicHVucGNrbGRxICUlbW0xLCUlbW0xXG4iIC8vICAgICAgICAgMDAgdTEg MDAgdTAgMDAgdTEgMDAgdTAKLQkJICJwc3VidyBfTU1YXzAwODB3LCUlbW0xXG4iICAvLyBtbTEt MTI4OnUxIHUxIHUwIHUwIHUxIHUxIHUwIHUwIAorCQkgInBzdWJ3ICVbX01NWF8wMDgwd10sJSVt bTFcbiIgIC8vIG1tMS0xMjg6dTEgdTEgdTAgdTAgdTEgdTEgdTAgdTAgCiAJCSAvLyBjcmVhdGUg Q2JfZyAocmVzdWx0IGluIG1tNSkKIAkJICJtb3ZxICUlbW0xLCUlbW01XG4iICAgICAgICAgICAg Ly8gdTEgdTEgdTAgdTAgdTEgdTEgdTAgdTAKLQkJICJwbXVsbHcgX01NWF9VZ3JuUkdCLCUlbW01 XG4iICAgIC8vIGJsdWUqLTEwOWRlYz0xLjcxMjkqNjQKLQkJICJwbXVsbHcgX01NWF9VYmx1UkdC LCUlbW0xXG4iICAgIC8vIGJsdWUqMTE0ZGVjPTEuNzgxMjUqNjQKKwkJICJwbXVsbHcgJVtfTU1Y X1Vncm5SR0JdLCUlbW01XG4iICAgIC8vIGJsdWUqLTEwOWRlYz0xLjcxMjkqNjQKKwkJICJwbXVs bHcgJVtfTU1YX1VibHVSR0JdLCUlbW0xXG4iICAgIC8vIGJsdWUqMTE0ZGVjPTEuNzgxMjUqNjQK IAkJICJwc3JhdyAgJDYsICUlbW01XG4iICAgICAgICAgICAgLy8gYmx1ZT1yZWQvNjQKIAkJICJw c3JhdyAgJDYsICUlbW0xXG4iICAgICAgICAgICAgLy8gYmx1ZT1ibHVlLzY0CiAKQEAgLTIzOCw4 ICsyMzgsMTQgQEAKIAkJICJwb3BsICUlZWJ4XG4iCiAJCSA6CiAJCSA6ICJtIiAoY3IpLCAiciIo Y2IpLCJyIihsdW0pLAotCQkgInIiKHJvdzEpLCJyIihjb2xzKSwiciIocm93MiksIm0iKHgpLCJt Iih5KSwibSIobW9kKQotCQkgOiAiJWVieCIKKwkJICJyIihyb3cxKSwiciIoY29scyksInIiKHJv dzIpLCJtIih4KSwibSIoeSksIm0iKG1vZCksCisgICAgICAgICBbX01NWF8wMDgwd10gIm0iICgq X01NWF8wMDgwdyksCisgICAgICAgICBbX01NWF8wMEZGd10gIm0iICgqX01NWF8wMEZGdyksCisg ICAgICAgICBbX01NWF9GRjAwd10gIm0iICgqX01NWF9GRjAwdyksCisgICAgICAgICBbX01NWF9W Z3JuUkdCXSAibSIgKCpfTU1YX1Zncm5SR0IpLAorICAgICAgICAgW19NTVhfVnJlZFJHQl0gIm0i ICgqX01NWF9WcmVkUkdCKSwKKyAgICAgICAgIFtfTU1YX1Vncm5SR0JdICJtIiAoKl9NTVhfVWdy blJHQiksCisgICAgICAgICBbX01NWF9VYmx1UkdCXSAibSIgKCpfTU1YX1VibHVSR0IpCiAJCSAp OwogfQogCkBAIC00MTMsOCArNDE5LDE2IEBACiAJICJwb3BsICUlZWJ4XG4iCiAgICAgICAgICA6 CiAgICAgICAgICA6Im0iIChjciksICJyIihjYiksInIiKGx1bSksCi0JICJyIihyb3cxKSwiciIo Y29scyksInIiKHJvdzIpLCJtIih4KSwibSIoeSksIm0iKG1vZCkKLQkgOiAiJWVieCIKKwkgInIi KHJvdzEpLCJyIihjb2xzKSwiciIocm93MiksIm0iKHgpLCJtIih5KSwibSIobW9kKSwKKyAgICAg W19NTVhfMDA4MHddICJtIiAoKl9NTVhfMDA4MHcpLAorIFtfTU1YX1Vncm41NjVdICJtIiAoKl9N TVhfVWdybjU2NSksCisgW19NTVhfVWJsdTV4NV0gIm0iICgqX01NWF9VYmx1NXg1KSwKKyBbX01N WF8wMEZGd10gIm0iICgqX01NWF8wMEZGdyksCisgW19NTVhfVmdybjU2NV0gIm0iICgqX01NWF9W Z3JuNTY1KSwKKyBbX01NWF9WcmVkNXg1XSAibSIgKCpfTU1YX1ZyZWQ1eDUpLAorIFtfTU1YX1lj b2VmZl0gIm0iICgqX01NWF9ZY29lZmYpLAorIFtfTU1YX3JlZDU2NV0gIm0iICgqX01NWF9yZWQ1 NjUpLAorIFtfTU1YX2dybjU2NV0gIm0iICgqX01NWF9ncm41NjUpCiAgICAgICAgICApOwogfQog Cg==