48210 2004-04-18 05:30 0000 media-sound/mpd ebuild: please get rid of the Gentoo config file 2004-04-20 11:12:48 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 shank@mercury.chem.pitt.edu eradicator@gentoo.org FunkieDaMouse@hotmail.com nathan.brown@tufts.edu Qball@qballcow.nl sbh@gawab.com sound@gentoo.org starz@antisocial.com shank@mercury.chem.pitt.edu 2004-04-18 05:30:01 0000 The current ebuilds for mpd install a "gentoo" config file in /etc/conf.d Please remove this config file! It causes me too many support headaches, as ppl need to work around problems or change config settings by creating a "real" mpd config file. So, commonly they add new config options to the gentoo config file, and obviously they do not affect in mpd at all! Please remove the gentoo config file! If a default config file is to be installed, use the default one from the mpd source package. and place it at /etc/mpd.conf (or whereever you see fit, and change the init.d scripts appropriatly). Reproducible: Always Steps to Reproduce: 1. 2. 3. nathan.brown@tufts.edu 2004-04-18 15:06:47 0000 Created an attachment (id=29579) new mpd ebuild This is a new version of the mpd-0.10.3 ebuild that installs the config file to /etc/mpd.conf and uses the author's example from the source. Only thing to think about is why did the previous version install to /etc/conf.d/mpd and should the defaults (for example the log file and error file location) be changed to match Gentoo ideas. Hope this helps nathan.brown@tufts.edu 2004-04-18 15:11:23 0000 Oh and here's the diff between the original version 0.10.3 ebuild and my new version if you'd rather see that: < insinto /etc/conf.d < newins ${FILESDIR}/mpd.conf mpd --- > insinto /etc > newins ${S}/doc/mpdconf.example mpd.conf 56c56 < einfo " LOG_FILE and ERROR_FILE in /etc/conf.d/mpd" --- > einfo " LOG_FILE and ERROR_FILE in /etc/mpd.conf" eradicator@gentoo.org 2004-04-19 13:38:17 0000 the gentoo way works... if users want to do it another way, they're free to change the init scripts to suit their needs. shank@mercury.chem.pitt.edu 2004-04-19 13:59:27 0000 Then in the next release, I will remove the ability to start mpd with command arguments. Then the "gentoo way" will not work. Thank you, -shank PS: I don't find it acceptable, that gentoo must have their own config file, that does not work with the config paramters specified in the mpd manpage! It is entirely too confusing to users to remember there is a "real" mpd config file, for which there is documentation for in the mpd man page, and there is a "gentto" config file that has nothing todo with the mpd config file. In fact, if a sure specifies a real config file, it will not use gentoo's at all! At the very least, until i break the gentoo config file in the next release, a note should be specified in the gentoo config file that this is not a real config file, and that the parameters in the mpd man page will not work with the gentoo config file! Or you can simply just remove the gentoo config file and install a default config file. normalperson@yhbt.net 2004-04-19 14:45:29 0000 There's absolutely no reason to have a redundant, and more importantly: incompatible_ configuration file anywhere in /etc when MPD has a perfectly good config file already. Check out the init script (mpd.init), mpd.postinst, and the libmpdconf shell function library I did for the Debian MPD package if you want some ideas: http://des.petta-tech.bogomips.org/~eric/viewarch.cgi/eric@petta-tech.com--2004a Although I maintain Debian packages, I wrote the functions of libmpdconf with ALL distributions in mind and plan on submitting it to be included with MPD itself soon. normalperson@yhbt.net 2004-04-19 15:02:32 0000 Ugh, URL got truncated, sorry about that: http://des.petta-tech.bogomips.org/~eric/viewarch.cgi/eric@petta-tech.com--2004a-ordinary/debian-mpd--devel--0.1--patch-11/ FunkieDaMouse@hotmail.com 2004-04-19 15:15:10 0000 I have used mpd under gentoo for some time and found it necessary to rewrite the init script so that it would work correctly with mpd's standard configuration file. I have uploaded the new /etc/init.d/mpd script to http://www.maltastart.com/~whitelynx/programming/downloads/mpd . The current state of the gentoo ebuild for mpd is not only confusing for new users (finding that they have to put the configuration options in a completely different file than the one they first had to edit), it also causes problems for the mpd devs having to explain the whole situation to other users. mpd already has its own configuration file (/etc/mpd.conf) and it should _not_ require any command-line arguments to run, as this was meant for debugging purposes or for running multiple mpd daemons at different ports. It was not meant to take the place of mpd's original configuration file. Please remove the /etc/conf.d/mpd file and instead copy the example configuration file from mpd's manpage to /etc/mpd.conf . nathan.brown@tufts.edu 2004-04-19 18:52:50 0000 Jeremy, the current init scripts will use the correct /etc/mpd.conf file and ignor the conf.d if the /etc/mpd.conf exists. There's no need for the init scripts to change, the only thing is that the /etc/conf.d file doesn't support all of the options available in the mpd man pages. Thus when I tried to add more options, they were ignored and my attempts to debug only led to me frustrating the developer. Now maybe I should have come here first, but once the developer and I figured it out, I rewrote the ebuild to use the config file suggested by the mpd dev. Is there any reason why the gentoo way is better? To me it only seems to add layers of confusion. Can someone explain why gentoo chose to go this way? starz@antisocial.com 2004-04-19 19:13:10 0000 Yes, the current init script _does_ break mpd. Please see why this bug came into existance: http://www.musicpd.org/forum/viewtopic.php?t=242 . This is not the first time this has happened. It's just confusing, and there is really no reason it should be like this. eradicator@gentoo.org 2004-04-19 21:14:25 0000 re: comment #4 All the configuration information for /etc/init.d/<init script> is contained in /etc/conf.d/<init script> when possible. It is too confusing for users to have a different configuration script in a different location for every package they install. the /etc/conf.d/<init script> file sets environment variables for the init script. Additionally, intentionally breaking a distribution's init script because you do not like the way the distribution handles things is not very professional. re comment #5, #6, #7: Thanks, I'll take a look at Eric's Debian script and David's modified gentoo script alternatives... eradicator@gentoo.org 2004-04-20 00:50:21 0000 ok, i've reworked the init script. shank@mercury.chem.pitt.edu 2004-04-20 04:24:40 0000 Thanks for your help Jeremy, and I'm sorry for being an ass. As far as the "location" of the config script, i personally do not care where it is, so long as the config script can take the same configuration parameters in the manpage of mpd, or it is clearly marked in the config file, where to put those paramters. I'm sorry for acting childish. Thanks, -shank eradicator@gentoo.org 2004-04-20 08:02:34 0000 thanks... no hard feelings ;) 29579 2004-04-18 15:06 0000 new mpd ebuild mpd-0.10.3.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA0IEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYy CiMgJEhlYWRlcjogL2hvbWUvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLXNvdW5kL21wZC9tcGQt MC4xMC4zLmVidWlsZCx2IDEuMiAyMDA0LzA0LzAzIDE0OjE1OjQyIG1ob2x6ZXIgRXhwICQKCklV U0U9Im9nZ3ZvcmJpcyBtYWQgYWFjIGF1ZGlvZmlsZSBpcHY2IgoKREVTQ1JJUFRJT049Ik11c2lj IFBsYXllciBEYWVtb24gKG1wZCkiClNSQ19VUkk9Im1pcnJvcjovL3NvdXJjZWZvcmdlL211c2lj cGQvJHtQfS50YXIuZ3oiClJFU1RSSUNUPSJub21pcnJvciIKSE9NRVBBR0U9Imh0dHA6Ly93d3cu bXVzaWNwZC5vcmciCgpLRVlXT1JEUz0ifng4NiB+YW1kNjQiClNMT1Q9IjAiCkxJQ0VOU0U9IkdQ TC0yIgoKREVQRU5EPSJvZ2d2b3JiaXM/ICggbWVkaWEtbGlicy9saWJ2b3JiaXMgKQoJbWFkPyAo IG1lZGlhLXNvdW5kL21hZCApCglhYWM/ICggPj1tZWRpYS1saWJzL2ZhYWQyLTIuMF9yYzIgKQoJ YXVkaW9maWxlPyAoIG1lZGlhLWxpYnMvYXVkaW9maWxlICkKCWZsYWM/ICggPj1tZWRpYS1saWJz L2ZsYWMtMS4xLjAgKQoJbWVkaWEtbGlicy9saWJpZDN0YWcKCT49bWVkaWEtbGlicy9saWJhby0w LjguNAoJc3lzLWxpYnMvemxpYiIKCnNyY19jb21waWxlKCkgewoJbG9jYWwgbXljb25mCglteWNv bmY9ImB1c2VfZW5hYmxlIGFhY2AgYHVzZV9lbmFibGUgYXVkaW9maWxlYCBgdXNlX2VuYWJsZSBp cHY2YCBgdXNlX2VuYWJsZSBmbGFjYCIKCgl1c2Ugb2dndm9yYmlzIFwKCQl8fCBteWNvbmY9IiR7 bXljb25mfSAtLWRpc2FibGUtb2dnICAtLWRpc2FibGUtb2dndGVzdCBcCgkJCS0tZGlzYWJsZS12 b3JiaXN0ZXN0IgoJdXNlIG1hZCB8fCBteWNvbmY9IiR7bXljb25mfSAtLWVuYWJsZS1tcGQtbWFk IC0tZW5hYmxlLW1wZC1pZDN0YWciCgoJZWNvbmYgJHtteWNvbmZ9IHx8IGRpZSAiY291bGQgbm90 IGNvbmZpZ3VyZSIKCgllbWFrZSB8fCBkaWUgImVtYWtlIGZhaWxlZCIKfQoKc3JjX2luc3RhbGwo KSB7CgllbWFrZSBpbnN0YWxsIERFU1RESVI9JHtEfSB8fCBkaWUKCXJtIC1yZiAke0R9L3Vzci9z aGFyZS9kb2MvbXBkLwoJZG9kb2MgQ09QWUlORyBDaGFuZ2VMb2cgSU5TVEFMTCBSRUFETUUgVE9E TyBVUEdSQURJTkcKCWRvZG9jIGRvYy9DT01NQU5EUyBkb2MvbXBkY29uZi5leGFtcGxlCgoJZXhl aW50byAvZXRjL2luaXQuZAoJbmV3ZXhlICR7RklMRVNESVJ9L21wZC5yYzYgbXBkCglpbnNpbnRv IC9ldGMKCW5ld2lucyAke1N9L2RvYy9tcGRjb25mLmV4YW1wbGUgbXBkLmNvbmYKfQoKcGtnX3Bv c3RpbnN0KCkgewoJZWluZm8gImxpYmFvIHByaW9yIHRvIDAuOC40IGhhcyBpc3N1ZXMgd2l0aCB0 aGUgQUxTQSBkcml2ZXJzLCBwbGVhc2UgcmVmZXIgdG8gdGhlIEZBUSIKCWVpbmZvICJodHRwOi8v bXVzaWNwZC5zb3VyY2Vmb3JnZS5uZXQvZmFxLnBocCBpZiB5b3UgYXJlIGhhdmluZyBwcm9ibGVt cy4iCgllaW5mbwoJZWluZm8gIiBZb3UgbmVlZCB0byBzZXQgUE9SVCwgTVVTSUNfRElSLCBQTEFZ TElTVF9ESVIsIgoJZWluZm8gIiBMT0dfRklMRSBhbmQgRVJST1JfRklMRSBpbiAvZXRjL21wZC5j b25mIgp9Cg==