43091 2004-02-27 05:36 0000 astyle command line error 2004-03-28 10:17:15 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 hrk@users.sourceforge.net karltk@gentoo.org hrk@users.sourceforge.net 2004-02-27 05:36:07 0000 Hi, astyle has a bug in its command line parameters parsing routine which affects the --force-indent=tab=# and --indent=tab=# options. I have fixed it and contacted the author to his SourceForge.net email address, but I still haven't received an answer. I am attaching a diff file (-Naur, as somebody asked me :-)) for the file astyle_main.cpp Reproducible: Always Steps to Reproduce: 1. astyle --force-indent=tab=4 2. 3. Actual Results: The program refuses the option (but it's documented in the --help output!) Expected Results: It should not refuse the option (and should use it!) hrk@users.sourceforge.net 2004-02-27 05:37:00 0000 Created an attachment (id=26467) Patch for command line parsing error. karltk@gentoo.org 2004-03-28 10:17:15 0000 Fixed. Available as dev-util/astyle-1.15.3-r1. 26467 2004-02-27 05:37 0000 Patch for command line parsing error. fix.diff text/plain LS0tIGFzdHlsZV9tYWluLmNwcAkyMDAyLTAzLTA3IDA4OjIyOjMwLjAwMDAwMDAwMCArMDEwMAor KysgL3Jvb3QvYXN0eWxlX21haW4uY3BwLmZpeGVkCTIwMDQtMDItMjUgMjI6MDU6MTMuODQxNzAw NjAwICswMTAwCkBAIC0yNjcsMjIgKzI2NywyMiBAQAogICAgIHsKICAgICAgICAgbWFudWFsbHlT ZXRKYXZhU3R5bGUoZm9ybWF0dGVyKTsKICAgICB9Ci0gICAgZWxzZSBpZiAoIElTX09QVElPTlMo YXJnLCAidCIsICJpbmRlbnQ9dGFiPSIpICkNCi0gICAgew0KLSAgICAgICAgaW50IHNwYWNlTnVt ID0gNDsNCi0gICAgICAgIHN0cmluZyBzcGFjZU51bVBhcmFtID0gR0VUX1BBUkFNUyhhcmcsICJ0 IiwgImluZGVudD10YWI9Iik7DQotICAgICAgICBpZiAoc3BhY2VOdW1QYXJhbS5sZW5ndGgoKSA+ IDApDQotICAgICAgICAgICAgc3BhY2VOdW0gPSBhdG9pKHNwYWNlTnVtUGFyYW0uY19zdHIoKSk7 DQotICAgICAgICBmb3JtYXR0ZXIuc2V0VGFiSW5kZW50YXRpb24oc3BhY2VOdW0sIGZhbHNlKTsN Ci0gICAgfQ0KLSAgICBlbHNlIGlmICggSVNfT1BUSU9OUyhhcmcsICJUIiwgImZvcmNlLWluZGVu dD10YWI9IikgKQ0KLSAgICB7DQotICAgICAgICBpbnQgc3BhY2VOdW0gPSA0Ow0KLSAgICAgICAg c3RyaW5nIHNwYWNlTnVtUGFyYW0gPSBHRVRfUEFSQU1TKGFyZywgIlQiLCAiZm9yY2UtaW5kZW50 PXRhYj0iKTsNCi0gICAgICAgIGlmIChzcGFjZU51bVBhcmFtLmxlbmd0aCgpID4gMCkNCi0gICAg ICAgICAgICBzcGFjZU51bSA9IGF0b2koc3BhY2VOdW1QYXJhbS5jX3N0cigpKTsNCi0gICAgICAg IGZvcm1hdHRlci5zZXRUYWJJbmRlbnRhdGlvbihzcGFjZU51bSwgdHJ1ZSk7DQotICAgIH0NCisg ICAgZWxzZSBpZiAoIElTX1BBUkFNX09QVElPTlMoYXJnLCAidCIsICJpbmRlbnQ9dGFiPSIpICkK KyAgICB7CisgICAgICAgIGludCBzcGFjZU51bSA9IDQ7CisgICAgICAgIHN0cmluZyBzcGFjZU51 bVBhcmFtID0gR0VUX1BBUkFNUyhhcmcsICJ0IiwgImluZGVudD10YWI9Iik7CisgICAgICAgIGlm IChzcGFjZU51bVBhcmFtLmxlbmd0aCgpID4gMCkKKyAgICAgICAgICAgIHNwYWNlTnVtID0gYXRv aShzcGFjZU51bVBhcmFtLmNfc3RyKCkpOworICAgICAgICBmb3JtYXR0ZXIuc2V0VGFiSW5kZW50 YXRpb24oc3BhY2VOdW0sIGZhbHNlKTsKKyAgICB9CisgICAgZWxzZSBpZiAoIElTX1BBUkFNX09Q VElPTlMoYXJnLCAiVCIsICJmb3JjZS1pbmRlbnQ9dGFiPSIpICkKKyAgICB7CisgICAgICAgIGlu dCBzcGFjZU51bSA9IDQ7CisgICAgICAgIHN0cmluZyBzcGFjZU51bVBhcmFtID0gR0VUX1BBUkFN UyhhcmcsICJUIiwgImZvcmNlLWluZGVudD10YWI9Iik7CisgICAgICAgIGlmIChzcGFjZU51bVBh cmFtLmxlbmd0aCgpID4gMCkKKyAgICAgICAgICAgIHNwYWNlTnVtID0gYXRvaShzcGFjZU51bVBh cmFtLmNfc3RyKCkpOworICAgICAgICBmb3JtYXR0ZXIuc2V0VGFiSW5kZW50YXRpb24oc3BhY2VO dW0sIHRydWUpOworICAgIH0KICAgICBlbHNlIGlmICggSVNfUEFSQU1fT1BUSU9OKGFyZywgImlu ZGVudD10YWIiKSApCiAgICAgewogICAgICAgICBmb3JtYXR0ZXIuc2V0VGFiSW5kZW50YXRpb24o NCk7CkBAIC0zNDMsMTAgKzM0MywxMCBAQAogICAgIHsKICAgICAgICAgZm9ybWF0dGVyLnNldExh YmVsSW5kZW50KHRydWUpOwogICAgIH0KLSAgICBlbHNlIGlmICggSVNfT1BUSU9OKGFyZywgImJy YWNrZXRzPWJyZWFrLWNsb3NpbmctaGVhZGVycyIpICkNCi0gICAgew0KLSAgICAgICAgZm9ybWF0 dGVyLnNldEJyZWFrQ2xvc2luZ0hlYWRlckJyYWNrZXRzTW9kZSh0cnVlKTsNCi0gICAgfQ0KKyAg ICBlbHNlIGlmICggSVNfT1BUSU9OKGFyZywgImJyYWNrZXRzPWJyZWFrLWNsb3NpbmctaGVhZGVy cyIpICkKKyAgICB7CisgICAgICAgIGZvcm1hdHRlci5zZXRCcmVha0Nsb3NpbmdIZWFkZXJCcmFj a2V0c01vZGUodHJ1ZSk7CisgICAgfQogICAgIGVsc2UgaWYgKCBJU19PUFRJT05TKGFyZywgImIi LCAiYnJhY2tldHM9YnJlYWsiKSApCiAgICAgewogICAgICAgICBmb3JtYXR0ZXIuc2V0QnJhY2tl dEZvcm1hdE1vZGUoQlJFQUtfTU9ERSk7CkBAIC00MDAsMTAgKzQwMCwxMCBAQAogICAgIGVsc2Ug aWYgKElTX09QVElPTihhcmcsICJicmVhay1ibG9ja3MiKSkKICAgICB7CiAgICAgICAgIGZvcm1h dHRlci5zZXRCcmVha0Jsb2Nrc01vZGUodHJ1ZSk7Ci0gICAgfQ0KLSAgICBlbHNlIGlmIChJU19P UFRJT04oYXJnLCAiYnJlYWstZWxzZWlmcyIpKQ0KLSAgICB7DQotICAgICAgICBmb3JtYXR0ZXIu c2V0QnJlYWtFbHNlSWZzTW9kZSh0cnVlKTsNCisgICAgfQorICAgIGVsc2UgaWYgKElTX09QVElP TihhcmcsICJicmVhay1lbHNlaWZzIikpCisgICAgeworICAgICAgICBmb3JtYXR0ZXIuc2V0QnJl YWtFbHNlSWZzTW9kZSh0cnVlKTsKICAgICB9CiAgICAgZWxzZSBpZiAoIElTX09QVElPTlMoYXJn LCAiWCIsICJlcnJvcnMtdG8tc3RhbmRhcmQtb3V0cHV0IikgKQogICAgIHsKQEAgLTUyOCwyMCAr NTI4LDIwIEBACiAgICAgKCpfZXJyKSA8PCAiICAgIC1qICAgT1IgICAtLW1vZGU9amF2YVxuIjsK ICAgICAoKl9lcnIpIDw8ICIgICAgSW5kZW50IGEgSmF2YShUTSkgc291cmNlIGZpbGVcbiI7CiAg ICAgKCpfZXJyKSA8PCBlbmRsOwotICAgICgqX2VycikgPDwgIiAgICAtcyAgIE9SICAgLXMjICAg T1IgICAtLWluZGVudD1zcGFjZXM9I1xuIjsNCi0gICAgKCpfZXJyKSA8PCAiICAgIEluZGVudCB1 c2luZyAjIHNwYWNlcyBwZXIgaW5kZW50LiBOb3Qgc3BlY2lmeWluZyAjXG4iIDsNCi0gICAgKCpf ZXJyKSA8PCAiICAgIHdpbGwgcmVzdWx0IGluIGEgZGVmYXVsdCBvZiA0IHNwYWNlYyBwZXIgaW5k ZW50LlxuIiA7DQotICAgICgqX2VycikgPDwgZW5kbDsNCisgICAgKCpfZXJyKSA8PCAiICAgIC1z ICAgT1IgICAtcyMgICBPUiAgIC0taW5kZW50PXNwYWNlcz0jXG4iOworICAgICgqX2VycikgPDwg IiAgICBJbmRlbnQgdXNpbmcgIyBzcGFjZXMgcGVyIGluZGVudC4gTm90IHNwZWNpZnlpbmcgI1xu IiA7CisgICAgKCpfZXJyKSA8PCAiICAgIHdpbGwgcmVzdWx0IGluIGEgZGVmYXVsdCBvZiA0IHNw YWNlYyBwZXIgaW5kZW50LlxuIiA7CisgICAgKCpfZXJyKSA8PCBlbmRsOwogICAgICgqX2Vycikg PDwgIiAgICAtdCAgIE9SICAgLXQjICAgT1IgICAtLWluZGVudD10YWI9I1xuIjsKICAgICAoKl9l cnIpIDw8ICIgICAgSW5kZW50IHVzaW5nIHRhYiBjaGFyYWN0ZXJzLCBhc3N1bWluZyB0aGF0IGVh Y2hcbiI7CiAgICAgKCpfZXJyKSA8PCAiICAgIHRhYiBpcyAjIHNwYWNlcyBsb25nLiBOb3Qgc3Bl Y2lmeWluZyAjIHdpbGwgcmVzdWx0XG4iOwogICAgICgqX2VycikgPDwgIiAgICBpbiBhIGRlZmF1 bHQgYXNzdW1wdGlvbiBvZiA0IHNwYWNlcyBwZXIgdGFiLlxuIiA7Ci0gICAgKCpfZXJyKSA8PCBl bmRsOw0KLSAgICAoKl9lcnIpIDw8ICIgICAgLVQjICAgT1IgICAtLWZvcmNlLWluZGVudD10YWI9 IyI7DQotICAgICgqX2VycikgPDwgIiAgICBJbmRlbnQgdXNpbmcgdGFiIGNoYXJhY3RlcnMsIGFz c3VtaW5nIHRoYXQgZWFjaFxuIjsNCi0gICAgKCpfZXJyKSA8PCAiICAgIHRhYiBpcyAjIHNwYWNl cyBsb25nLiBGb3JjZSB0YWJzIHRvIGJlIHVzZWQgaW4gYXJlYXNcbiI7DQotICAgICgqX2Vycikg PDwgIiAgICBBc3R5bGUgd291bGQgcHJlZmVyIHRvIHVzZSBzcGFjZXMuXG4iIDsNCi0gICAgKCpf ZXJyKSA8PCBlbmRsOw0KKyAgICAoKl9lcnIpIDw8IGVuZGw7CisgICAgKCpfZXJyKSA8PCAiICAg IC1UIyAgIE9SICAgLS1mb3JjZS1pbmRlbnQ9dGFiPSMiOworICAgICgqX2VycikgPDwgIiAgICBJ bmRlbnQgdXNpbmcgdGFiIGNoYXJhY3RlcnMsIGFzc3VtaW5nIHRoYXQgZWFjaFxuIjsKKyAgICAo Kl9lcnIpIDw8ICIgICAgdGFiIGlzICMgc3BhY2VzIGxvbmcuIEZvcmNlIHRhYnMgdG8gYmUgdXNl ZCBpbiBhcmVhc1xuIjsKKyAgICAoKl9lcnIpIDw8ICIgICAgQXN0eWxlIHdvdWxkIHByZWZlciB0 byB1c2Ugc3BhY2VzLlxuIiA7CisgICAgKCpfZXJyKSA8PCBlbmRsOwogICAgICgqX2VycikgPDwg IiAgICAtQyAgIE9SICAgLS1pbmRlbnQtY2xhc3Nlc1xuIjsKICAgICAoKl9lcnIpIDw8ICIgICAg SW5kZW50ICdjbGFzcycgYmxvY2tzLCBzbyB0aGF0IHRoZSBpbm5lciAncHVibGljOicsXG4iOwog ICAgICgqX2VycikgPDwgIiAgICAncHJvdGVjdGVkOicgYW5kICdwcml2YXRlOiBoZWFkZXJzIGFy ZSBpbmRlbnRlZCBpblxuIjsKQEAgLTU5NiwxMCArNTk2LDEwIEBACiAgICAgKCpfZXJyKSA8PCAi ICAgIEJyZWFrIGRlZmluaXRpb24tYmxvY2sgYnJhY2tldHMgYW5kIGF0dGFjaCBjb21tYW5kLWJs b2NrXG4iOwogICAgICgqX2VycikgPDwgIiAgICBicmFja2V0cy5cbiI7CiAgICAgKCpfZXJyKSA8 PCBlbmRsOwotICAgICgqX2VycikgPDwgIiAgICAtLWJyYWNrZXRzPWJyZWFrLWNsb3NpbmctaGVh ZGVyc1xuIjsNCi0gICAgKCpfZXJyKSA8PCAiICAgIEJyZWFrIGJyYWNrZXRzIGJlZm9yZSBjbG9z aW5nIGhlYWRlcnMgKGUuZy4gJ2Vsc2UnLCAnY2F0Y2gnLCAuLikuXG4iOw0KLSAgICAoKl9lcnIp IDw8ICIgICAgU2hvdWxkIGJlIGFwcGVuZGVkIHRvIC0tYnJhY2tldHM9YXR0YWNoIG9yIC0tYnJh Y2tldHM9bGludXguXG4iOw0KLSAgICAoKl9lcnIpIDw8IGVuZGw7DQorICAgICgqX2VycikgPDwg IiAgICAtLWJyYWNrZXRzPWJyZWFrLWNsb3NpbmctaGVhZGVyc1xuIjsKKyAgICAoKl9lcnIpIDw8 ICIgICAgQnJlYWsgYnJhY2tldHMgYmVmb3JlIGNsb3NpbmcgaGVhZGVycyAoZS5nLiAnZWxzZScs ICdjYXRjaCcsIC4uKS5cbiI7CisgICAgKCpfZXJyKSA8PCAiICAgIFNob3VsZCBiZSBhcHBlbmRl ZCB0byAtLWJyYWNrZXRzPWF0dGFjaCBvciAtLWJyYWNrZXRzPWxpbnV4LlxuIjsKKyAgICAoKl9l cnIpIDw8IGVuZGw7CiAgICAgKCpfZXJyKSA8PCAiICAgIC1vICAgT1IgIC0tb25lLWxpbmU9a2Vl cC1zdGF0ZW1lbnRzXG4iOwogICAgICgqX2VycikgPDwgIiAgICBEb24ndCBicmVhayBsaW5lcyBj b250YWluaW5nIG11bHRpcGxlIHN0YXRlbWVudHMgaW50b1xuIjsKICAgICAoKl9lcnIpIDw8ICIg ICAgbXVsdGlwbGUgc2luZ2xlLXN0YXRlbWVudCBsaW5lcy5cbiI7CkBAIC02MjYsOSArNjI2LDkg QEAKICAgICAoKl9lcnIpIDw8ICIgICAgTGlrZSAtLWJyZWFrLWJsb2NrcywgZXhjZXB0IGFsc28g aW5zZXJ0IGVtcHR5IGxpbmVzIFxuIjsKICAgICAoKl9lcnIpIDw8ICIgICAgYXJvdW5kIGNsb3Np bmcgaGVhZGVycyAoZS5nLiAnZWxzZScsICdjYXRjaCcsIC4uLikuXG4iOwogICAgICgqX2Vycikg PDwgZW5kbDsKLSAgICAoKl9lcnIpIDw8ICIgICAgLS1icmVhay1lbHNlaWZzXG4iOw0KLSAgICAo Kl9lcnIpIDw8ICIgICAgQnJlYWsgJ2Vsc2UgaWYoKScgc3RhdGVtZW50cyBpbnRvIHR3byBkaWZm ZXJlbnQgbGluZXMuXG4iOw0KLSAgICAoKl9lcnIpIDw8IGVuZGw7DQorICAgICgqX2VycikgPDwg IiAgICAtLWJyZWFrLWVsc2VpZnNcbiI7CisgICAgKCpfZXJyKSA8PCAiICAgIEJyZWFrICdlbHNl IGlmKCknIHN0YXRlbWVudHMgaW50byB0d28gZGlmZmVyZW50IGxpbmVzLlxuIjsKKyAgICAoKl9l cnIpIDw8IGVuZGw7CiAgICAgKCpfZXJyKSA8PCAiT3RoZXIgb3B0aW9uczpcbiI7CiAgICAgKCpf ZXJyKSA8PCAiLS0tLS0tLS0tLS0tLVxuIjsKICAgICAoKl9lcnIpIDw8ICIgICAgLS1zdWZmaXg9 IyMjI1xuIjsKQEAgLTc2Miw3ICs3NjIsNyBAQAogCiAgICAgaWYgKHNob3VsZFByaW50SGVscCkK ICAgICB7Ci0gICAgICAgIHByaW50SGVscCgpOw0KKyAgICAgICAgcHJpbnRIZWxwKCk7CiAJCWV4 aXQoMSk7CiAgICAgfQogCg==