37592 2004-01-08 04:55 0000 Allow usage of distccmon as user to watch over portage compiling 2004-01-09 09:32:31 0000 1 1 1 Unclassified Gentoo Linux Development unspecified All Linux RESOLVED LATER P2 minor --- 1 e.bachmann@xebec.de lisa@gentoo.org e.bachmann@xebec.de 2004-01-08 04:55:22 0000 My user account is in group portage, so it has access to the .distcc dir used by portage, yet I still can't use distccmon-* to watch over it. The problem is that it does a check for orphaned processes using the kill syscall, but doesn't check the return value correctly. I reported this bug to the distcc-mailing list, but they don't seem to be very interrested, so maybe you could add this one-line patch to the distcc ebuild. Reproducible: Always Steps to Reproduce: 1. emerge something (FEATURES=distcc...) 2. try to run DISTCC_TMPDIR=/var/tmp/portage/.distcc distccmon-text 1 3. run the same under strace to clearly see the bug. (kill-syscalls failing with EPERM) Actual Results: distccmon doesn't display any info as it regards every process as dead. Expected Results: It should display something :) e.bachmann@xebec.de 2004-01-08 04:57:23 0000 Created an attachment (id=23378) patch to add missing check for errno==EPERM One-line patch to src/mon.c that fixes the bug. lisa@gentoo.org 2004-01-08 17:34:25 0000 When Martin releases 2.12.1 I'll see if he put this patch into the code. If not I'll apply it and mark it ~arch. lisa@gentoo.org 2004-01-09 09:32:31 0000 2.12.1 addresses this. 23378 2004-01-08 04:57 0000 patch to add missing check for errno==EPERM patch text/plain KioqIG1vbi5jLm9yaWcgIDIwMDQtMDEtMDQgMTY6NDg6MTEuNDY2NDc5MDk2ICswMTAwCi0tLSBt b24uYyAgICAgICAyMDA0LTAxLTA0IDE2OjUzOjA3Ljg2MzIyMDIzNiArMDEwMAoqKioqKioqKioq KioqKioKKioqIDE2NSwxNzcgKioqKgogIC8qKgogICAqIENoZWNrIHRoYXQgdGhlIHByb2Nlc3Mg bmFtZWQgYnkgdGhlIGZpbGUgc3RpbGwgZXhpc3RzOyBpZiBub3QsCiAgICogcmV0dXJuIEVYSVRf R09ORS4KICAgKiovCiAgc3RhdGljIGludCBkY2NfbW9uX2NoZWNrX29ycGhhbnMoc3RydWN0IGRj Y19oaXN0b3J5ICptb25sKQogIHsKISAgICAgcmV0dXJuIGtpbGwobW9ubC0+Y3BpZCwgMCkgPyBF WElUX0dPTkUgOiAwOwogIH0KCi0tLSAxNjUsMTc3IC0tLS0KICAvKioKICAgKiBDaGVjayB0aGF0 IHRoZSBwcm9jZXNzIG5hbWVkIGJ5IHRoZSBmaWxlIHN0aWxsIGV4aXN0czsgaWYgbm90LAogICAq IHJldHVybiBFWElUX0dPTkUuCiAgICoqLwogIHN0YXRpYyBpbnQgZGNjX21vbl9jaGVja19vcnBo YW5zKHN0cnVjdCBkY2NfaGlzdG9yeSAqbW9ubCkKICB7CiEgICAgIHJldHVybiAoa2lsbChtb25s LT5jcGlkLCAwKSAmJiBlcnJubyAhPSBFUEVSTSkgPyBFWElUX0dPTkUgOiAwOwogIH0K