32471 2003-11-01 08:36 0000 apcupsd sends mail with an error in the headers 2009-04-02 13:06:09 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All Linux CLOSED FIXED P2 normal --- 1 demerss@gmail.com tantive@gentoo.org swtaylor@gentoo.org demerss@gmail.com 2003-11-01 08:36:39 0000 apcupsd 3.10.5 (up to and including -r3) and 3.10.6 When a power event occurs, scripts in the /etc/apcupsd directory are executed. Those scripts send mail, but they add an extra CRLF after the subject line of the headers, so we end up with something like this: Return-Path: <root@blackbox.linux> X-Original-To: black Delivered-To: black@blackbox.linux Received: by blackbox.linux (Postfix, from userid 0) id 81C7210CC0E; Sat, 1 Nov 2003 10:41:41 -0500 (EST) Subject: blackbox.linux Power has returned Message-Id: <20031101154141.81C7210CC0E@blackbox.linux> Date: Sat, 1 Nov 2003 10:41:41 -0500 (EST) From: root@blackbox.linux (root) To: undisclosed-recipients:; The extra line makes the following part of the message rather than part of the headers, so Date, From and To are, in effect, missing. The problem comes from the scripts in /etc/apcupsd. For example, mainsback contains this: HOSTNAME=`hostname` MSG="$HOSTNAME Power has returned" # ( echo "Subject: $MSG" echo " " echo "$MSG" echo " " /usr/sbin/apcaccess status ) | $APCUPSD_MAIL $SYSADMIN (Note: the last line is $APCUPSD_MAIL -s $MSG $SYSDAMIN in 3.10.6, see below as it causes problems with Postfix on my system) The problem here is that the headers should be separated from the message body with a blank line, but the above script sends a line with a single space after the "Subject" line. To correct, change to this: echo "Subject: $MSG" echo echo "$MSG" Echo alone will output the required blank line. Also, I suggest adding the following line just before or after the subject: echo "To: $SYSADMIN" This will prevent postfix/sendmail from adding "To: Undisclosed recipients" which in turn triggers a SpamAssassin rule. Finally, with 3.10.6, the sendmail command is called with the -s parameter to set the subject. Postfix doesn't seem to like this and thus fails to send the mail. Is this required for SendMail? If so, maybe we could add a parameter somewhere so that this switch isn't used when using Postfix. Or we could have the Postfix team just ignore that switch! :) Reproducible: Always Steps to Reproduce: demerss@gmail.com 2003-11-01 08:44:54 0000 Created an attachment (id=20062) Patch for my suggestions Note: this is the first time I create a patch, so I'd like somebody to check if it's done ok first. I made a directory called "old" with the original files and a "new" directory with my modified files, the called "diff -u old new > apcupsd.patch". I tried applying patches with "patch -p1 < apcupsd.patch" while in the /etc/apcupsd directory, and it seems to work. This patch removes the changes 'echo " "' to 'echo', adds a "To" line and removes the -s switch to the sendmail command because Postfix doesn't like it. swtaylor@gentoo.org 2003-11-01 11:02:01 0000 qmail will not even send any email when the -s "$MSG" is in the command line. Isn't that redundant anyway since the message itself contains the "Subject:" header? I'm all in favor of adding more complete headers too. Please! strip the -s "$MSG" from the scripts, and while you're at it, copy or symlink the /etc/apcupsd/onbattery to also run as /etc/apcupsd/powerout - apparently different models send different signals for a power failure. tantive@gentoo.org 2003-11-01 12:04:30 0000 I checked in an corrected ebuild (the 3.10.6.ebuild one) with -the patch and with -ln -s onbattery powerout. Please check if everything is fine. swtaylor@gentoo.org 2003-11-01 13:06:45 0000 Thanks! It peacefully coexists with qmail now. After several simulated power outages, I actually got one onbattery alert (the first one I've ever seen here) but it never missed the powerout alerts. This closes #30716 as well. Here's the scripts that actually got called. Getting an occasional extra email updating the status from powerout to onbattery is far better in my book than getting a mystery email that power has returned without having a power failure to match it up with... /etc/apcupsd/powerout BERTHOUD 1 0 /etc/apcupsd/mainsback BERTHOUD 1 0 /etc/apcupsd/powerout BERTHOUD 1 0 /etc/apcupsd/mainsback BERTHOUD 1 0 /etc/apcupsd/powerout BERTHOUD 1 0 /etc/apcupsd/onbattery BERTHOUD 1 0 /etc/apcupsd/mainsback BERTHOUD 1 0 demerss@gmail.com 2003-11-01 15:30:24 0000 I'm happy with that! Case closed as far as I'm concerned! Thanks! tantive@gentoo.org 2003-11-02 02:30:14 0000 Good news for me :) I closes #30716 and will close this one now. Thanks for your testing. Feel free to report any other bugs you find within apcupsd. 20062 2003-11-01 08:44 0000 Patch for my suggestions apcupsd.patch text/plain ZGlmZiAtdSBvbGQvY2hhbmdlbWUgbmV3L2NoYW5nZW1lCi0tLSBvbGQvY2hhbmdlbWUJMjAwMy0x MS0wMSAxMTozMToxMC4wMDAwMDAwMDAgLTA1MDAKKysrIG5ldy9jaGFuZ2VtZQkyMDAzLTExLTAx IDExOjI3OjA5LjAwMDAwMDAwMCAtMDUwMApAQCAtMTMsOSArMTMsMTAgQEAKICMKICgKICAgIGVj aG8gIlN1YmplY3Q6ICRNU0ciCi0gICBlY2hvICIgIgorICAgZWNobyAiVG86ICRTWVNBRE1JTiIK KyAgIGVjaG8KICAgIGVjaG8gIiRNU0ciCiAgICBlY2hvICIgIgogICAgL3Vzci9zYmluL2FwY2Fj Y2VzcyBzdGF0dXMKLSkgfCAkQVBDVVBTRF9NQUlMIC1zICIkTVNHIiAkU1lTQURNSU4KKykgfCAk QVBDVVBTRF9NQUlMICRTWVNBRE1JTgogZXhpdCAwCmRpZmYgLXUgb2xkL2NvbW1mYWlsdXJlIG5l dy9jb21tZmFpbHVyZQotLS0gb2xkL2NvbW1mYWlsdXJlCTIwMDMtMTEtMDEgMTE6MzE6MjYuMDAw MDAwMDAwIC0wNTAwCisrKyBuZXcvY29tbWZhaWx1cmUJMjAwMy0xMS0wMSAxMToyNzoxMy4wMDAw MDAwMDAgLTA1MDAKQEAgLTEzLDkgKzEzLDEwIEBACiAjCiAoCiAgICBlY2hvICJTdWJqZWN0OiAk TVNHIgotICAgZWNobyAiICIKKyAgIGVjaG8gIlRvOiAkU1lTQURNSU4iCisgICBlY2hvCiAgICBl Y2hvICIkTVNHIgogICAgZWNobyAiICIKICAgIC91c3Ivc2Jpbi9hcGNhY2Nlc3Mgc3RhdHVzCi0p IHwgJEFQQ1VQU0RfTUFJTCAtcyAiJE1TRyIgJFNZU0FETUlOCispIHwgJEFQQ1VQU0RfTUFJTCAk U1lTQURNSU4KIGV4aXQgMApkaWZmIC11IG9sZC9jb21tb2sgbmV3L2NvbW1vawotLS0gb2xkL2Nv bW1vawkyMDAzLTExLTAxIDExOjMxOjMzLjAwMDAwMDAwMCAtMDUwMAorKysgbmV3L2NvbW1vawky MDAzLTExLTAxIDExOjI3OjE2LjAwMDAwMDAwMCAtMDUwMApAQCAtMTMsOSArMTMsMTAgQEAKICMK ICgKICAgIGVjaG8gIlN1YmplY3Q6ICRNU0ciCi0gICBlY2hvICIgIgorICAgZWNobyAiVG86ICRT WVNBRE1JTiIKKyAgIGVjaG8KICAgIGVjaG8gIiRNU0ciCiAgICBlY2hvICIgIgogICAgL3Vzci9z YmluL2FwY2FjY2VzcyBzdGF0dXMKLSkgfCAkQVBDVVBTRF9NQUlMIC1zICIkTVNHIiAkU1lTQURN SU4KKykgfCAkQVBDVVBTRF9NQUlMICRTWVNBRE1JTgogZXhpdCAwCmRpZmYgLXUgb2xkL21haW5z YmFjayBuZXcvbWFpbnNiYWNrCi0tLSBvbGQvbWFpbnNiYWNrCTIwMDMtMTEtMDEgMTE6MzA6NTUu MDAwMDAwMDAwIC0wNTAwCisrKyBuZXcvbWFpbnNiYWNrCTIwMDMtMTEtMDEgMTE6Mjc6MjEuMDAw MDAwMDAwIC0wNTAwCkBAIC0xMyw5ICsxMywxMCBAQAogIwogKAogICAgZWNobyAiU3ViamVjdDog JE1TRyIKLSAgIGVjaG8gIiAiCisgICBlY2hvICJUbzogJFNZU0FETUlOIgorICAgZWNobwogICAg ZWNobyAiJE1TRyIKICAgIGVjaG8gIiAiCiAgICAvdXNyL3NiaW4vYXBjYWNjZXNzIHN0YXR1cwot KSB8ICRBUENVUFNEX01BSUwgLXMgIiRNU0ciICRTWVNBRE1JTgorKSB8ICRBUENVUFNEX01BSUwg JFNZU0FETUlOCiBleGl0IDAKZGlmZiAtdSBvbGQvbWFzdGVyY29ubmVjdCBuZXcvbWFzdGVyY29u bmVjdAotLS0gb2xkL21hc3RlcmNvbm5lY3QJMjAwMy0xMS0wMSAxMTozMTo0My4wMDAwMDAwMDAg LTA1MDAKKysrIG5ldy9tYXN0ZXJjb25uZWN0CTIwMDMtMTEtMDEgMTE6Mjc6MzAuMDAwMDAwMDAw IC0wNTAwCkBAIC0xMyw5ICsxMywxMCBAQAogIwogKAogICAgZWNobyAiU3ViamVjdDogJE1TRyIK LSAgIGVjaG8gIiAiCisgICBlY2hvICJUbzogJFNZU0FETUlOIgorICAgZWNobwogICAgZWNobyAi JE1TRyIKICAgIGVjaG8gIiAiCiAgICAvdXNyL3NiaW4vYXBjYWNjZXNzIHN0YXR1cwotKSB8ICRB UENVUFNEX01BSUwgLXMgIiRNU0ciICRTWVNBRE1JTgorKSB8ICRBUENVUFNEX01BSUwgJFNZU0FE TUlOCiBleGl0IDAKZGlmZiAtdSBvbGQvbWFzdGVydGltZW91dCBuZXcvbWFzdGVydGltZW91dAot LS0gb2xkL21hc3RlcnRpbWVvdXQJMjAwMy0xMS0wMSAxMTozMTo1Mi4wMDAwMDAwMDAgLTA1MDAK KysrIG5ldy9tYXN0ZXJ0aW1lb3V0CTIwMDMtMTEtMDEgMTE6Mjc6MzMuMDAwMDAwMDAwIC0wNTAw CkBAIC0xMyw5ICsxMywxMCBAQAogIwogKAogICAgZWNobyAiU3ViamVjdDogJE1TRyIKLSAgIGVj aG8gIiAiCisgICBlY2hvICJUbzogJFNZU0FETUlOIgorICAgZWNobwogICAgZWNobyAiJE1TRyIK ICAgIGVjaG8gIiAiCiAgICAvdXNyL3NiaW4vYXBjYWNjZXNzIHN0YXR1cwotKSB8ICRBUENVUFNE X01BSUwgLXMgIiRNU0ciICRTWVNBRE1JTgorKSB8ICRBUENVUFNEX01BSUwgJFNZU0FETUlOCiBl eGl0IDAKZGlmZiAtdSBvbGQvb25iYXR0ZXJ5IG5ldy9vbmJhdHRlcnkKLS0tIG9sZC9vbmJhdHRl cnkJMjAwMy0xMS0wMSAxMTozMjowMy4wMDAwMDAwMDAgLTA1MDAKKysrIG5ldy9vbmJhdHRlcnkJ MjAwMy0xMS0wMSAxMToyNzozNS4wMDAwMDAwMDAgLTA1MDAKQEAgLTEzLDkgKzEzLDEwIEBACiAj CiAoCiAgICBlY2hvICJTdWJqZWN0OiAkTVNHIgotICAgZWNobyAiICIKKyAgIGVjaG8gIlRvOiAk U1lTQURNSU4iCisgICBlY2hvCiAgICBlY2hvICIkTVNHIgogICAgZWNobyAiICIKICAgIC91c3Iv c2Jpbi9hcGNhY2Nlc3Mgc3RhdHVzCi0pIHwgJEFQQ1VQU0RfTUFJTCAtcyAiJE1TRyIgJFNZU0FE TUlOCispIHwgJEFQQ1VQU0RfTUFJTCAkU1lTQURNSU4KIGV4aXQgMAo=