31660 2003-10-21 03:19 0000 Sawfish 1.3 lacks support for shading certain window types. 2003-11-24 19:20:44 0000 1 1 1 Unclassified Gentoo Linux GNOME unspecified All All RESOLVED FIXED P2 minor --- 1 dreid@dreid.ath.cx agriffis@gentoo.org gnome@gentoo.org henrik@brixandersen.dk dreid@dreid.ath.cx 2003-10-21 03:19:39 0000 Because of sawfish 1.3's shading implementation it lacks the ability to shade windows of type _NET_WM_WINDOW_TYPE_UTILITY, _NET_WM_WINDOW_TYPE_MENU, and _NET_WM_WINDOW_TYPE_TOOLBAR. This occurs even if the theme implements the standard mappings of shaded-<type>, because the sawfish internals actually lack the ability to recognize those mappings. The attached patch fixes this issue. Reproducible: Always Steps to Reproduce: 1. Start gimp 1.3 (or other app that implements utility, menu, or toolbar types) 2. Open a gimpdock (or tear off a menu) and attempt to shade it. Actual Results: The window appears without contents but with full default window border. Expected Results: Fallen back to a default shaded border. dreid@dreid.ath.cx 2003-10-21 03:20:33 0000 Created an attachment (id=19574) Adds support for shading windows of types utility, menu, and toolbar. henrik@brixandersen.dk 2003-10-21 04:40:44 0000 I can confirm this bug report. foser@gentoo.org 2003-10-21 15:49:42 0000 reassigning to someone who's eager to fix it ;) agriffis@gentoo.org 2003-10-27 06:12:01 0000 Thanks, I've applied this in sawfish-1.3-r2 agriffis@gentoo.org 2003-11-24 19:20:44 0000 I've filed http://bugzilla.gnome.org/show_bug.cgi?id=127865 to push this upstream 19574 2003-10-21 03:20 0000 Adds support for shading windows of types utility, menu, and toolbar. shaded-utility-2.patch text/plain ZGlmZiAtciAtdSAteCAnKi5qbGMnIC14IC5jdnNpZ25vcmUgc2F3ZmlzaC0xLjNfb3JpZy9saXNw L3Nhd2Zpc2gvd20vZnJhbWVzLmpsIHNhd2Zpc2gtMS4zL2xpc3Avc2F3ZmlzaC93bS9mcmFtZXMu amwKLS0tIHNhd2Zpc2gtMS4zX29yaWcvbGlzcC9zYXdmaXNoL3dtL2ZyYW1lcy5qbAkyMDAyLTEw LTIwIDAxOjA3OjUwLjAwMDAwMDAwMCAtMDcwMAorKysgc2F3ZmlzaC0xLjMvbGlzcC9zYXdmaXNo L3dtL2ZyYW1lcy5qbAkyMDAzLTEwLTIwIDEyOjQ2OjQxLjAwMDAwMDAwMCAtMDcwMApAQCAtMTU1 LDggKzE1NSwxMSBAQAogICAgICAgKGljb24gLiBzaGFwZWQtdHJhbnNpZW50KQogICAgICAgKGRv Y2sgLiBpY29uKQogICAgICAgKHV0aWxpdHkgLiB0cmFuc2llbnQpCisgICAgICAoc2hhZGVkLXV0 aWxpdHkgLiBzaGFkZWQtdHJhbnNpZW50KQogICAgICAgKHRvb2xiYXIgLiB1dGlsaXR5KQorICAg ICAgKHNoYWRlZC10b29sYmFyIC4gc2hhZGVkLXV0aWxpdHkpCiAgICAgICAobWVudSAuIHV0aWxp dHkpCisgICAgICAoc2hhZGVkLW1lbnUgLiBzaGFkZWQtdXRpbGl0eSkKICAgICAgIChzcGxhc2gg LiB1bmZyYW1lZCkpCiAgICAgIkZyYW1lIHR5cGUgZmFsbGJhY2tzLiIpCiAKZGlmZiAtciAtdSAt eCAnKi5qbGMnIC14IC5jdnNpZ25vcmUgc2F3ZmlzaC0xLjNfb3JpZy9saXNwL3Nhd2Zpc2gvd20v c3RhdGUvc2hhZGluZy5qbCBzYXdmaXNoLTEuMy9saXNwL3Nhd2Zpc2gvd20vc3RhdGUvc2hhZGlu Zy5qbAotLS0gc2F3ZmlzaC0xLjNfb3JpZy9saXNwL3Nhd2Zpc2gvd20vc3RhdGUvc2hhZGluZy5q bAkyMDAzLTEwLTIwIDA0OjI3OjA2LjAwMDAwMDAwMCAtMDcwMAorKysgc2F3ZmlzaC0xLjMvbGlz cC9zYXdmaXNoL3dtL3N0YXRlL3NoYWRpbmcuamwJMjAwMy0xMC0yMCAwNDoyNjoyOC4wMDAwMDAw MDAgLTA3MDAKQEAgLTgzLDYgKzgzLDkgQEAKIAkoY2FzZSB0eXBlCiAJICAoKGRlZmF1bHQgc2hh cGVkKSAnc2hhZGVkKQogCSAgKCh0cmFuc2llbnQgc2hhcGVkLXRyYW5zaWVudCkgJ3NoYWRlZC10 cmFuc2llbnQpCisJICAoKHV0aWxpdHkgc2hhcGVkLXV0aWxpdHkpICdzaGFkZWQtdXRpbGl0eSkK KwkgICgobWVudSBzaGFwZWQtbWVudSkgJ3NoYWRlZC1tZW51KQorCSAgKCh0b29sYmFyIHNoYXBl ZC10b29sYmFyKSAnc2hhZGVkLXRvb2xiYXIpCiAJICAodCB0eXBlKSkKICAgICAgIHR5cGUpKQog Cg==