27995 2003-09-05 06:17 0000 Request xxdiff ebuild allow optional KDE support 2003-10-17 02:33:10 0000 1 1 1 Unclassified Gentoo Linux Development unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 carl@hudkins.org kde@gentoo.org int.teo@gmail.com carl@hudkins.org 2003-09-05 06:17:03 0000 With version 2.6, xxdiff now may be compiled against kdelibs, allowing some sort of KDE support in the application. As "kde" is a USE flag, I think xxdiff should be built with KDE support if that flag is enabled. Reproducible: Always Steps to Reproduce: 1. 2. 3. Expected Results: Adding KDE support is done by changing 3 lines in src/xxdiff.pro before building the Makefile. I have been attempting to get this to work, but the build currently bombs because ld cannot find -lkdeui. If I get this working, I will post my ebuild. int.teo@gmail.com 2003-09-06 15:48:34 0000 Created an attachment (id=17193) xxdiff-2.9.2.ebuild.patch Apply this patch to the ebuild int.teo@gmail.com 2003-09-06 15:50:04 0000 Created an attachment (id=17194) kdesupport.patch Add this in /usr/portage/dev-util/xxdiff/files/ dir int.teo@gmail.com 2003-09-06 15:51:30 0000 Now these patches allow the program to be compiled with kde support. The binary that is created seems to work just fine. Just don't ask me what kind of extra things it adds :-) I leave that to you ;-) carl@hudkins.org 2003-09-06 18:28:12 0000 Rats, you beat me to the ebuild submission! :) That's essentially what I did here, except I was trying to make the ebuild change xxdiff.pro using "dosed" instead of an external patch file. (Oh, and I had removed some redundant things from the ebuild, like IUSE="" and S=${WORKDIR}/$P.) However, since I don't seem to understand "dosed" (it doesn't actually *do* anything here), it's back to the old-fashioned way! Thanks for your work; now everyone else can enjoy the lovely KDE support of xxdiff -- which is basically use of kfiledialog and making the widgets follow the user's theme. I really miss the extra up-arrow at the bottom of scrollbars, so of course I had to have it. :) carl@hudkins.org 2003-09-06 19:47:00 0000 Created an attachment (id=17205) Optional KDE support & ebuild cleanup Also removes superfluous items from ebuild, such as IUSE="". Such things are implied if not defined, so defining them to their default values is pointless. caleb@gentoo.org 2003-09-15 19:53:25 0000 put your patch stuff in - -r1. Let me know if there's any problems. Thanks! blais@iro.umontreal.ca 2003-10-16 22:54:32 0000 whoah... sexy. i had never even seen it myself with kde widgets. i had merely patched up someone else's contribution. how cool! now that i run gentoo myself, all i had to do was emerge! :-) (the author of xxdiff) 17193 2003-09-06 15:48 0000 xxdiff-2.9.2.ebuild.patch xxdiff-2.9.2.ebuild.patch text/plain LS0tIHh4ZGlmZi0yLjkuMi5lYnVpbGQub3JpZwkyMDAzLTA5LTA3IDAxOjI0OjU5LjAwMDAwMDAw MCArMDMwMAorKysgeHhkaWZmLTIuOS4yLmVidWlsZAkyMDAzLTA5LTA3IDAxOjM1OjQ4LjAwMDAw MDAwMCArMDMwMApAQCAtOCwxNSArOCwyNSBAQAogSE9NRVBBR0U9Imh0dHA6Ly94eGRpZmYuc291 cmNlZm9yZ2UubmV0LyIKIAogREVQRU5EPSI9eDExLWxpYnMvcXQtMyoKLQk+PWRldi11dGlsL3Rt YWtlLTEuOC1yMSIKKwk+PWRldi11dGlsL3RtYWtlLTEuOC1yMQorCWtkZT8gKCA9a2RlLWJhc2Uv a2RlbGlicy0zLjEqICkiCiAKIFJERVBFTkQ9Ij14MTEtbGlicy9xdC0zKgotCXN5cy1hcHBzL2Rp ZmZ1dGlscyIKKwlzeXMtYXBwcy9kaWZmdXRpbHMKKwlrZGU/ICggPWtkZS1iYXNlL2tkZWxpYnMt My4xKiApIgogCiBTTE9UPSIwIgogTElDRU5TRT0iR1BMLTIiCiBLRVlXT1JEUz0ieDg2IH5zcGFy YyIKLUlVU0U9IiIKK0lVU0U9ImtkZSIKKworc3JjX3VucGFjaygpIHsKKwl1bnBhY2sgJHtBfQor CWlmIFsgYHVzZSBrZGVgIF0gOyB0aGVuCisJCWNkICR7U30vc3JjCisJCWVwYXRjaCAke0ZJTEVT RElSfS9rZGVzdXBwb3J0LnBhdGNoCisJZmkKK30KIAogc3JjX2NvbXBpbGUoKSB7CiAJY2Qgc3Jj Cg== 17194 2003-09-06 15:50 0000 kdesupport.patch kdesupport.patch text/plain LS0tIHh4ZGlmZi5wcm8ub3JpZwkyMDAzLTA5LTA3IDAwOjQyOjU1LjAwMDAwMDAwMCArMDMwMAor KysgeHhkaWZmLnBybwkyMDAzLTA5LTA3IDAxOjA4OjI1LjAwMDAwMDAwMCArMDMwMApAQCAtMjcs OSArMjcsOSBAQAogQ09ORklHID0gcmVsZWFzZSBxdCB3YXJuX29uIHRocmVhZAogCiAjIEZvciBL REUgc3VwcG9ydCwgdW5jb21tZW50IHRoZSBmb2xsb3dpbmcgbGluZXM6Ci0jVE1BS0VfQ0ZMQUdT ICs9IC1EWFhfS0RFIC1JL3Vzci9pbmNsdWRlL2tkZQotI1RNQUtFX0NYWEZMQUdTICs9IC1EWFhf S0RFIC1JL3Vzci9pbmNsdWRlL2tkZQotI1RNQUtFX0xJQlMgKz0gLWxrZGV1aSAtbGtpbyAtbHF0 LW10CitUTUFLRV9DRkxBR1MgKz0gLURYWF9LREUgLUkvdXNyL2tkZS8zLjEvaW5jbHVkZQorVE1B S0VfQ1hYRkxBR1MgKz0gLURYWF9LREUgLUkvdXNyL2tkZS8zLjEvaW5jbHVkZQorVE1BS0VfTElC UyArPSAtTC91c3Iva2RlLzMuMS9saWIgLUwvdXNyL3F0LzMvbGliIC1sa2RldWkgLWxraW8gLWxx dC1tdAogCiBkZWJ1ZzpUTUFLRV9DRkxBR1MgKz0gLURYWF9ERUJVRwogZGVidWc6VE1BS0VfQ1hY RkxBR1MgKz0gLURYWF9ERUJVRwo= 17205 2003-09-06 19:47 0000 Optional KDE support & ebuild cleanup kxxdiff-2.9.2.patch text/plain LS0tIC91c3IvcG9ydGFnZS9kZXYtdXRpbC94eGRpZmYveHhkaWZmLTIuOS4yLmVidWlsZAkyMDAz LTA3LTEyIDEwOjI4OjEzLjAwMDAwMDAwMCAtMDQwMAorKysgLi94eGRpZmYtMi45LjIuZWJ1aWxk CTIwMDMtMDktMDYgMjI6NDE6MDQuMDAwMDAwMDAwIC0wNDAwCkBAIC0yLDIxICsyLDMwIEBACiAj IERpc3RyaWJ1dGVkIHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgdjIKICMgJEhlYWRlcjogL2hvbWUvY3Zzcm9vdC9nZW50b28teDg2L2Rldi11dGlsL3h4 ZGlmZi94eGRpZmYtMi45LjIuZWJ1aWxkLHYgMS4yIDIwMDMvMDcvMTIgMTQ6Mjg6MTMgYWxpeiBF eHAgJAogCi1TPSR7V09SS0RJUn0vJHtQfQogREVTQ1JJUFRJT049IkEgZ3JhcGhpY2FsIGZpbGUg YW5kIGRpcmVjdG9yaWVzIGNvbXBhcmF0b3IgYW5kIG1lcmdlIHRvb2wuIgogU1JDX1VSST0ibWly cm9yOi8vc291cmNlZm9yZ2UvJHtQTn0vJHtQfS50YXIuZ3oiCiBIT01FUEFHRT0iaHR0cDovL3h4 ZGlmZi5zb3VyY2Vmb3JnZS5uZXQvIgogCi1ERVBFTkQ9Ij14MTEtbGlicy9xdC0zKgorREVQRU5E PSI+PXgxMS1saWJzL3F0LTMuMQorCWtkZT8gKCA+PWtkZS1iYXNlL2tkZWxpYnMtMy4xICkKIAk+ PWRldi11dGlsL3RtYWtlLTEuOC1yMSIKIAotUkRFUEVORD0iPXgxMS1saWJzL3F0LTMqCitSREVQ RU5EPSI+PXgxMS1saWJzL3F0LTMuMQorCWtkZT8gKCA+PWtkZS1iYXNlL2tkZWxpYnMtMy4xICkK IAlzeXMtYXBwcy9kaWZmdXRpbHMiCiAKIFNMT1Q9IjAiCiBMSUNFTlNFPSJHUEwtMiIKIEtFWVdP UkRTPSJ4ODYgfnNwYXJjIgotSVVTRT0iIgorCitzcmNfdW5wYWNrKCkgeworCXVucGFjayAke0F9 CisKKwlpZiBbIGB1c2Uga2RlYCBdCisJdGhlbgorCQllcGF0Y2ggJHtGSUxFU0RJUn0va2Rlc3Vw cG9ydC5wYXRjaAorCWZpCit9CiAKIHNyY19jb21waWxlKCkgewogCWNkIHNyYwo=