245973 2008-11-07 15:33 0000 x11-libs/wxGTK-2.8.9.1-r1: wx/db.h undefines BOOL when USE=odbc 2008-11-07 23:34:54 0000 1 1 1 Unclassified Gentoo Linux Library 2008.0 All Linux RESOLVED FIXED http://trac.wxwidgets.org/ticket/10167 P2 minor --- 1 Martin.vGagern@gmx.net wxwidgets@gentoo.org Martin.vGagern@gmx.net 2008-11-07 15:33:16 0000 I encountered this while trying to compile truecrypt-6.1 from bug 245322. The build process there calls g++ with -DBOOL=int, but still I get errors like this "error: ‘BOOL’ does not name a type". I traced this to wx/db.h which defines BOOL, includes some other headers, and then unconditionally undefines it again. The inclusion path is the following: <wx/wx.h> -> "wx/window.h" -> "wx/colour.h" -> "wx/variant.h" -> "wx/db.h" Bug 210024 worked around this for previous truecrypt releases, and including that workaround again would be easy. On the other hand, I consider it bad behaviour for a header file to undefine any macros, especially such common ones. Therefore I'd prefer wxGTK to address this issue. I'll attach a patch. Martin.vGagern@gmx.net 2008-11-07 15:34:59 0000 Created an attachment (id=171002) Use and keep already defined BOOL This patch only defines and undefines BOOL if it hasn't already been defined. If it already is defined, it is assumed to be compatible with int, or that the application won't use that part of the wxGTK interface. No further checks made. dirtyepic@gentoo.org 2008-11-07 22:41:13 0000 makes sense to me. http://trac.wxwidgets.org/ticket/10167 vz-gentoo@zeitlins.org 2008-11-07 22:46:58 0000 Patch applied to wx sources, will be in 2.8.10, thanks. dirtyepic@gentoo.org 2008-11-07 23:34:54 0000 Thanks for the quick response. Fixed in wxGTK-2.8.9.1-r2 and -r3. 171002 2008-11-07 15:34 0000 Use and keep already defined BOOL wxGTK-2.8.9-BOOL.patch text/plain LS0tIC92YXIvdG1wL3BvcnRhZ2UveDExLWxpYnMvd3hHVEstMi44LjkuMS1yMS93b3JrL3d4UHl0 aG9uLXNyYy0yLjguOS4xL2luY2x1ZGUvd3gvZGIuaAkyMDA3LTA3LTA0IDIxOjI0OjU3LjAwMDAw MDAwMCArMDIwMAorKysgL3Vzci9pbmNsdWRlL3d4LTIuOC93eC9kYi5oCTIwMDgtMTEtMDcgMTY6 MDA6MDYuMDAwMDAwMDAwICswMTAwCkBAIC03NywxMiArNzcsMTcgQEAKICAgICAgICAgLy8gU1FM IGhlYWRlcnMgZGVmaW5lIEJPT0wgaWYgaXQncyBub3QgZGVmaW5lZCB5ZXQgYnV0IEJPT0wgaXMg YWxzbwogICAgICAgICAvLyBkZWZpbmVkIGluIG1hbnkgb3RoZXIgcGxhY2VzIG9uIG90aGVyIHN5 c3RlbXMgKE1vdGlmLCBhdCBsZWFzdCBvbgogICAgICAgICAvLyBPcGVuVk1TOyBDb2NvYSBhbmQg WDExKSBzbyBwcmV2ZW50IHRoZSBwcm9ibGVtIGJ5IGRlZmluaW5nIGl0IGJlZm9yZQogICAgICAg ICAvLyBpbmNsdWRpbmcgdGhlc2UgaGVhZGVycworICAgICAgICAjaWYgZGVmaW5lZChCT09MKQor ICAgICAgICAjaW5jbHVkZSA8c3FsLmg+CisgICAgICAgICNpbmNsdWRlIDxzcWxleHQuaD4KKyAg ICAgICAgI2Vsc2UKICAgICAgICAgI2RlZmluZSBCT09MIGludAogICAgICAgICAjaW5jbHVkZSA8 c3FsLmg+CiAgICAgICAgICNpbmNsdWRlIDxzcWxleHQuaD4KICAgICAgICAgI3VuZGVmIEJPT0wK KyAgICAgICAgI2VuZGlmCiAgICAgI2VuZGlmIC8vIHd4VVNFX0JVSUxUSU5fSU9EQkMvIXd4VVNF X0JVSUxUSU5fSU9EQkMKICAgICB9CiAjZW5kaWYKIAo=