245231 2008-11-02 06:33 0000 sys-apps/portage-2.2_rc13 waits for lockfile with -fOp 2008-11-11 22:21:06 0000 1 1 1 Unclassified Portage Development Core - External Interaction unspecified All Linux RESOLVED FIXED P2 normal --- 210077 1 vaeth@mathematik.uni-wuerzburg.de dev-portage@gentoo.org vaeth@mathematik.uni-wuerzburg.de 2008-11-02 06:33:44 0000 With sys-apps/portage-2.2_rc13, getdelta.sh waits forever, because it calls GENTOO_MIRRORS="" emerge -fOp =category/package-version to get the non-mirrored address which then (because it is called from emerge via FETCHOMMAND) sees a lockfile and waits for the mother process to finish... This did not happen with =sys-apps/portage-2.2_rc12 or earlier versions, and indeed it seems that there should not be a reason to wait for a lockfile. If this is technically too hard, perhaps another command could be provided which app-portage/getdelta could use, or - even better - the non-mirrored address could be passed in an environment variable to FETCHOMMAND (which would speed up gedelta quite a bit and perhaps also has other uses). zmedico@gentoo.org 2008-11-02 07:14:30 0000 (In reply to comment #0) > This did not happen with =sys-apps/portage-2.2_rc12 or earlier versions, > and indeed it seems that there should not be a reason to wait for a lockfile. It's only needed for cases when the pkg_nofetch() phase has to be executed (bug #241118). In this case, the locked directory is used to collect elog messages and to provide a safe working directory for bug #239560. In order to avoid the need to lock the directory, we can use mkdtemp() to allocate a temporary directory. > If this is technically too hard, perhaps another command could be provided > which app-portage/getdelta could use, or - even better - the non-mirrored > address could be passed in an environment variable to FETCHOMMAND > (which would speed up gedelta quite a bit and perhaps also has other uses). I'm not sure exactly what's required here. In some cases there are multiple non-mirrored URIs available, and in other cases only mirrored URIs are available. vaeth@mathematik.uni-wuerzburg.de 2008-11-02 08:16:42 0000 (In reply to comment #1) > I'm not sure exactly what's required here. In some cases there are multiple > non-mirrored URIs available, and in other cases only mirrored URIs are > available. I am not an author of getdelta and can only guess what happens on the server side. However, the script simply considers the words (space or newline separated) output by GENTOO_MIRRORS="" emerge -fOp =category/package-version and uses the last of those word which is an address and contains the filename to be fetched. So I guess just putting the output which you would get with GENTOO_MIRRORS="" into some variable (optionally eliminating those entries which do not end with the name for the current file to be fetched) would be sufficient for getdelta. zmedico@gentoo.org 2008-11-02 09:07:51 0000 Created an attachment (id=170521) use a private temp directory instead of the main one If this patch is saved as /tmp/fetch_tmp.patch, then it can be applied as follows: patch /usr/lib/portage/pym/_emerge/__init__.py /tmp/fetch_tmp.patch vaeth@mathematik.uni-wuerzburg.de 2008-11-02 18:49:05 0000 Thanks. The patch works smoothly. zmedico@gentoo.org 2008-11-11 22:21:06 0000 This is fixed in 2.2_rc14. 170521 2008-11-02 09:07 0000 use a private temp directory instead of the main one fetch_tmp.patch text/plain SW5kZXg6IHB5bS9fZW1lcmdlL19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHB5bS9fZW1lcmdl L19faW5pdF9fLnB5CShyZXZpc2lvbiAxMTc5NSkKKysrIHB5bS9fZW1lcmdlL19faW5pdF9fLnB5 CShyZXZpc2lvbiAxMTc5NikKQEAgLTE1OTAsNyArMTU5MCwyMyBAQAogCWRlZiBleGVjdXRlKHNl bGYpOgogCQkjIFRvIHNwYXduIHBrZ19ub2ZldGNoIHJlcXVpcmVzIFBPUlRBR0VfQlVJTERESVIg Zm9yCiAJCSMgZW5zdXJpbmcgc2FuZSAkUFdEIChidWcgIzIzOTU2MCkgYW5kIHN0b3JpbmcgZWxv ZwotCQkjIG1lc3NhZ2VzLgorCQkjIG1lc3NhZ2VzLiBVc2UgYSBwcml2YXRlIHRlbXAgZGlyZWN0 b3J5LCBpbiBvcmRlcgorCQkjIHRvIGF2b2lkIGxvY2tpbmcgdGhlIG1haW4gb25lLgorCQlzZXR0 aW5ncyA9IHNlbGYuc2V0dGluZ3MKKwkJZ2xvYmFsX3RtcGRpciA9IHNldHRpbmdzWyJQT1JUQUdF X1RNUERJUiJdCisJCWZyb20gdGVtcGZpbGUgaW1wb3J0IG1rZHRlbXAKKwkJcHJpdmF0ZV90bXBk aXIgPSBta2R0ZW1wKCIiLCAiLl9wb3J0YWdlX2ZldGNoXy4iLCBnbG9iYWxfdG1wZGlyKQorCQlz ZXR0aW5nc1siUE9SVEFHRV9UTVBESVIiXSA9IHByaXZhdGVfdG1wZGlyCisJCXNldHRpbmdzLmJh Y2t1cF9jaGFuZ2VzKCJQT1JUQUdFX1RNUERJUiIpCisJCXRyeToKKwkJCXJldHZhbCA9IHNlbGYu X2V4ZWN1dGUoKQorCQlmaW5hbGx5OgorCQkJc2V0dGluZ3NbIlBPUlRBR0VfVE1QRElSIl0gPSBn bG9iYWxfdG1wZGlyCisJCQlzZXR0aW5ncy5iYWNrdXBfY2hhbmdlcygiUE9SVEFHRV9UTVBESVIi KQorCQkJc2h1dGlsLnJtdHJlZShwcml2YXRlX3RtcGRpcikKKwkJcmV0dXJuIHJldHZhbAorCisJ ZGVmIF9leGVjdXRlKHNlbGYpOgogCQlidWlsZF9kaXIgPSBFYnVpbGRCdWlsZERpcihwa2c9c2Vs Zi5wa2csIHNldHRpbmdzPXNlbGYuc2V0dGluZ3MpCiAJCWJ1aWxkX2Rpci5sb2NrKCkKIAkJYnVp bGRfZGlyLmNsZWFuKCkKQEAgLTIzNjcsNyArMjM4Myw3IEBACiAJCXNlbGYuX2NhdGRpciA9IGNh dGRpcgogCiAJCXBvcnRhZ2UudXRpbC5lbnN1cmVfZGlycyhvcy5wYXRoLmRpcm5hbWUoY2F0ZGly KSwKLQkJCXVpZD1wb3J0YWdlLnBvcnRhZ2VfdWlkLCBnaWQ9cG9ydGFnZS5wb3J0YWdlX2dpZCwK KwkJCWdpZD1wb3J0YWdlLnBvcnRhZ2VfZ2lkLAogCQkJbW9kZT0wNzAsIG1hc2s9MCkKIAkJY2F0 ZGlyX2xvY2sgPSBOb25lCiAJCXRyeToK