24178 2003-07-09 07:55 0000 gdbm files installed as bin:bin instead of root:root 2005-09-21 16:15:06 0000 1 1 1 Unclassified Gentoo Linux Library unspecified All Linux RESOLVED FIXED P2 normal --- 1 splite-gentoo@sigint.cs.purdue.edu base-system@gentoo.org dc1847@gmail.com ppc-macos@gentoo.org splite-gentoo@sigint.cs.purdue.edu 2003-07-09 07:55:15 0000 gdbm installs its files with bin:bin ownership instead of root:root. Here's an ebuild patch: diff -u gdbm-1.8.0-r5.ebuild.orig gdbm-1.8.0-r5.ebuild --- gdbm-1.8.0-r5.ebuild.orig 2003-06-22 01:21:43.000000000 -0500 +++ gdbm-1.8.0-r5.ebuild 2003-07-09 09:49:27.000000000 -0500 @@ -41,12 +41,12 @@ } src_install() { - make prefix=${D}/usr \ + make BINOWN=root BINGRP=root prefix=${D}/usr \ man3dir=${D}/usr/share/man/man3 \ infodir=${D}/usr/share/info \ install || die - make includedir=${D}/usr/include/gdbm \ + make BINOWN=root BINGRP=root includedir=${D}/usr/include/gdbm \ install-compat || die dosed "s:/usr/local/lib':/usr/lib':g" /usr/lib/libgdbm.la Reproducible: Always Steps to Reproduce: 1. 2. 3. gmsoft@gentoo.org 2003-11-13 15:07:13 0000 Wonder why this was assigned to me. mholzer@gentoo.org 2004-04-22 11:24:18 0000 what's the problem when ownership is wrong ? mholzer@gentoo.org 2004-04-22 11:24:59 0000 finally fixed, since econf and emake are used now splite-gentoo@sigint.cs.purdue.edu 2005-09-20 20:06:51 0000 The problem when the ownership is wrong is that it's bad form to install files that aren't owned by root in system directories. There's no reason gdbm's files need to be owned by bin:bin. In fact, this later caused bug #96743 because Mac OS X doesn't have user/group bin. And no, using econf and emake doesn't fix the problem. BINOWN and BINGRP are hardcoded to "bin" in Makefile.in and aren't affected by configure. vapier@gentoo.org 2005-09-21 05:43:11 0000 *** Bug 96743 has been marked as a duplicate of this bug. *** grobian@gentoo.org 2005-09-21 10:27:44 0000 Created an attachment (id=68944) gdbm-1.8.3-r1.ebuild patch which uses suggested fix on OSX the group of root is wheel, so we cannot hardcode root:root here. I attached a patch where I revert the OSX specific bin user/group creation and use the suggested BINOWN and BINGRP variables to set the root user and it's primary group via a call to `id -gn root`. I'm not sure on whether this is the right way to do it, but it appears to work on OSX and linux. grobian@gentoo.org 2005-09-21 10:40:20 0000 thinking this over, we could just use uid=0 and gid=0 instead of trying with names and avoid the `id -gn root` call. However, if portage ever will allow non-root installs, then it would require here to use `id -u` and `id -g` for user and group respectively. splite-gentoo@sigint.cs.purdue.edu 2005-09-21 13:24:46 0000 Hoist on my own petard. :) Should have used 0 instead of root, sorry about that. (In my defense, it _is_ an old patch and predates the "which group is gid 0?" saga.) As for non-root installs, I'd be tempted to just rip out the Makefile bits that set the ownership and send the patch upstream. There's just no need for gdbm to set the file ownership at all, IMO. vapier@gentoo.org 2005-09-21 16:15:06 0000 fixed in cvs 68944 2005-09-21 10:27 0000 gdbm-1.8.3-r1.ebuild patch which uses suggested fix ebuild.diff text/plain SW5kZXg6IGdkYm0tMS44LjMtcjEuZWJ1aWxkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC92YXIvY3Zz cm9vdC9nZW50b28teDg2L3N5cy1saWJzL2dkYm0vZ2RibS0xLjguMy1yMS5lYnVpbGQsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTUKZGlmZiAtdSAtcjEuMTUgZ2RibS0xLjguMy1yMS5lYnVpbGQK LS0tIGdkYm0tMS44LjMtcjEuZWJ1aWxkCTEwIFNlcCAyMDA1IDE0OjU1OjUzIC0wMDAwCTEuMTUK KysrIGdkYm0tMS44LjMtcjEuZWJ1aWxkCTIxIFNlcCAyMDA1IDE3OjI0OjIyIC0wMDAwCkBAIC0x NSwxNSArMTUsNiBAQAogCiBERVBFTkQ9ImJlcmtkYj8gKCBzeXMtbGlicy9kYiApIgogCi1wa2df c2V0dXAoKSB7Ci0JIyBPbiBPU1ggdGhlcmUgaXMgbm8gdXNlci9ncm91cCBiaW4sIHNlZSBidWcg Izk2NzQzCi0JaWYgdXNlIHBwYy1tYWNvczsKLQl0aGVuCi0JCWVuZXdncm91cCBiaW4KLQkJZW5l d3VzZXIgYmluIC0xIC0xIC0xIGJpbgotCWZpCi19Ci0KIHNyY191bnBhY2soKSB7CiAJdW5wYWNr ICR7QX0KIAljZCAiJHtTfSIKQEAgLTM4LDExICsyOSwxOSBAQAogfQogCiBzcmNfaW5zdGFsbCgp IHsKLQltYWtlIElOU1RBTExfUk9PVD0iJHtEfSIgaW5zdGFsbCB8fCBkaWUKKwkjIE9uIE9TWCBm b3IgZXhhbXBsZSwgdGhlIGdyb3VwIG9mIHJvb3QgaXMgd2hlZWwsIG5vdCByb290LCBzbyB3ZQor CSMgaGF2ZSB0byBmaW5kIHRoaXMgb3V0IGR5bmFtaWNhbGx5LiAgT24gU29sYXJpcyB3ZSBzaG91 bGQgdXNlCisJIyAvdXNyL3hwZzQvYmluL2lkIGluIG9yZGVyIHRvIG1ha2UgdGhpcyB3b3JrLgor CWxvY2FsIHJvb3RfZ3JvdXA9YGlkIC1nbiByb290YAorCQorCW1ha2UgSU5TVEFMTF9ST09UPSIk e0R9IiBcCisJCUJJTk9XTj0icm9vdCIgQklOR1JQPSIke3Jvb3RfZ3JvdXB9IiBcCisJCWluc3Rh bGwgfHwgZGllCiAKIAltYWtlIFwKIAkJaW5jbHVkZWRpcj0vdXNyL2luY2x1ZGUvZ2RibSBcCiAJ CUlOU1RBTExfUk9PVD0iJHtEfSIgXAorCQlCSU5PV049InJvb3QiIEJJTkdSUD0iJHtyb290X2dy b3VwfSIgXAogCQlpbnN0YWxsLWNvbXBhdCB8fCBkaWUKIAogCWRvZG9jIENoYW5nZUxvZyBORVdT IFJFQURNRQo=