238520 2008-09-23 22:20 0000 kde-base/kdelibs-4.1.1-r4, kde-base/kdebase-3.5.9-r3: KDE doesn't provide "locale" flag when mounting with HAL and ntfs-3g 2008-10-01 00:49:51 0000 1 1 1 Unclassified Gentoo Linux KDE unspecified All Linux RESOLVED FIXED P2 critical --- 1 ambro@b4ever.net kde@gentoo.org ambro@b4ever.net 2008-09-23 22:20:58 0000 If the latest unstable sys-fs/ntfs3g is installed with the 'hal' use flag, KDE can mount NTFS filesystems with the ntfs-3g driver through HAL. However, ntfs-3g has to be provided a locale so it can translate file names with non-ascii characters. ntfs-3g will check its environment variables (LC_ALL, ...) and also has a "locale" mount option. It never has those environment variables, even if a system locale is configured. So the best would be for KDE to provide the locale though HAL (which allows it) as in the user's enviroment; but it doesn't right now. I have a patch for KDE 4.1 which solves the problem by providing the "locale" option to HAL. I will post the KDE 3.5 patch shortly, and will also commit both upstream. I've set the severity to critical, because it presents a potential data loss (e.g. you backup a folder from your NTFS drive, and have no idea some files with non-ascii names were not copied). Reproducible: Always Steps to Reproduce: ambro@b4ever.net 2008-09-23 22:21:44 0000 Created an attachment (id=166221) KDE 4.1 fix (kdelibs patch) ambro@b4ever.net 2008-09-23 22:31:22 0000 I've forgot to mention why there could be a data loss: if ntfs-3g is not provided a locale, it will fail to show any files with non-ascii names. It will also refuse the creation of such files. ambro@b4ever.net 2008-09-24 12:51:35 0000 Created an attachment (id=166269) KDE 3.5.9 fix (kdebase / kdebase-kioslaves) ambro@b4ever.net 2008-09-24 12:51:52 0000 Created an attachment (id=166271) KDE 3.5.10 fix (kdebase/kdebase-kioslaves) ambro@b4ever.net 2008-09-24 14:03:18 0000 Created an attachment (id=166272) KDE 3.5.10 fix (kdebase / kdebase-kioslaves) Mounting plain ntfs (kernel driver, no ntfs-3g) was broken (with and without my patch) in KDE 3.5.10. HAL somehow always lists the "locale" option as available for the "ntfs" fstype, which is not really supported by the default kernel driver, providing it will trigger a mount error. Maybe it was meant for the the ntfsmount driver from linux-ntfs, which is really unmaintained and broken. So, I added a check to pass the locale only if the fstype is "ntfs-3g", as in the other two patches. jmbsvicetto@gentoo.org 2008-09-26 04:30:08 0000 Please add the link to the upstream bugs/commits and reopen again. ambro@b4ever.net 2008-09-26 09:03:48 0000 Upstream commits: 3.5 branch: http://websvn.kde.org/?view=rev&revision=864963 4.1 branch: http://websvn.kde.org/?view=rev&revision=864120 trunk: http://websvn.kde.org/?view=rev&revision=864123 The 3.5.9 patch posted here is different from the committed 3.5 patch because since 3.5.10 there is already some (broken) locale support, but the resulting code is the same. jmbsvicetto@gentoo.org 2008-10-01 00:49:51 0000 I've just added a revbumped 3.5.9 and 3.5.10 to the tree with the provided patches. I haven't fixed 4.1.1 as 4.1.2 should be released tomorrow and provides the fix. 166221 2008-09-23 22:21 0000 KDE 4.1 fix (kdelibs patch) kdelibs-4.1.1-ntfs3g-locale.patch text/plain SW5kZXg6IHNvbGlkL3NvbGlkL2JhY2tlbmRzL2hhbC9oYWxzdG9yYWdlYWNjZXNzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBzb2xpZC9zb2xpZC9iYWNrZW5kcy9oYWwvaGFsc3RvcmFnZWFjY2Vzcy5jcHAJ KHJldmlzaW9uIDg2MDYyNykKKysrIHNvbGlkL3NvbGlkL2JhY2tlbmRzL2hhbC9oYWxzdG9yYWdl YWNjZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgPFF0 R3VpL1FXaWRnZXQ+CiAKICNpbmNsdWRlIDx1bmlzdGQuaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4K IAogI2luY2x1ZGUgImhhbGZzdGFiaGFuZGxpbmcuaCIKIApAQCAtMjcyLDYgKzI3MywxNiBAQAog ICAgICAgICB9CiAgICAgfQogCisgICAgLy8gcGFzcyBvdXIgbG9jYWxlIHRvIHRoZSBudGZzLTNn IGRyaXZlciBzbyBpdCBjYW4gdHJhbnNsYXRlIGxvY2FsIGNoYXJhY3RlcnMKKyAgICBpZiAoIG1f ZGV2aWNlLT5wcm9wZXJ0eSgidm9sdW1lLmZzdHlwZSIpLnRvU3RyaW5nKCk9PSJudGZzLTNnIiAm JiBoYWxPcHRpb25zLmNvbnRhaW5zKCJsb2NhbGU9IikgKSB7CisgICAgICAgIC8vIGhhdmUgdG8g b2J0YWluIExDX0NUWVBFIGFzIHJldHVybmVkIGJ5IHRoZSBgbG9jYWxlYCBjb21tYW5kCisgICAg ICAgIC8vIGNoZWNrIGluIHRoZSBzYW1lIG9yZGVyIGFzIGBsb2NhbGVgIGRvZXMKKyAgICAgICAg Y2hhciAqY1R5cGU7CisgICAgICAgIGlmICggKGNUeXBlID0gZ2V0ZW52KCJMQ19BTEwiKSkgfHwg KGNUeXBlID0gZ2V0ZW52KCJMQ19DVFlQRSIpKSB8fCAoY1R5cGUgPSBnZXRlbnYoIkxBTkciKSkg KSB7CisgICAgICAgICAgICBvcHRpb25zIDw8ICJsb2NhbGU9IitRU3RyaW5nKGNUeXBlKTsKKyAg ICAgICAgfQorICAgIH0KKwogICAgIG1zZyA8PCAiIiA8PCAiIiA8PCBvcHRpb25zOwogCiAgICAg cmV0dXJuIGMuY2FsbFdpdGhDYWxsYmFjayhtc2csIHRoaXMsCg== 166269 2008-09-24 12:51 0000 KDE 3.5.9 fix (kdebase / kdebase-kioslaves) kdebase-3.5.9-ntfs3g-locale.patch text/plain SW5kZXg6IGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBraW9zbGF2ZS9tZWRpYS9tZWRpYW1hbmFnZXIvaGFsYmFja2VuZC5jcHAJKHJldmlz aW9uIDg2NDA5OSkKKysrIGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODQ5LDYgKzg0OSwxNCBAQAogICAgICAgICByZXN1bHQgPDwg dG1wOwogICAgIH0KIAorICAgIGlmICh2YWxpZHMuY29udGFpbnMoImxvY2FsZSIpICYmIGZzdHlw ZSA9PSAibnRmcy0zZyIpCisgICAgeworICAgICAgICBjaGFyICpjVHlwZTsKKyAgICAgICAgaWYg KCAoY1R5cGUgPSBnZXRlbnYoIkxDX0FMTCIpKSB8fCAoY1R5cGUgPSBnZXRlbnYoIkxDX0NUWVBF IikpIHx8IChjVHlwZSA9IGdldGVudigiTEFORyIpKSApIHsKKyAgICAgICAgICAgIHJlc3VsdCA8 PCBRU3RyaW5nKCJsb2NhbGU9JTEiKS5hcmcoY1R5cGUpOworICAgICAgICB9CisgICAgfQorCiAg ICAgaWYgKHZhbGlkcy5jb250YWlucygidXRmOCIpKQogICAgIHsKICAgICAgICAgdmFsdWUgPSBj b25maWcucmVhZEJvb2xFbnRyeSgidXRmOCIsIHRydWUpOwpAQCAtMTE0OSw2ICsxMTU3LDExIEBA CiAgICAgaWYgKHZhbGlkc1sicXVpZXQiXSA9PSAidHJ1ZSIpCiAgICAgICAgIHNvcHRpb25zIDw8 ICJxdWlldCI7CiAKKyAgICBpZiAodmFsaWRzLmNvbnRhaW5zKCJsb2NhbGUiKSkKKyAgICB7Cisg ICAgICAgIHNvcHRpb25zIDw8IFFTdHJpbmcoImxvY2FsZT0lMSIpLmFyZyh2YWxpZHNbImxvY2Fs ZSJdKTsKKyAgICB9CisKICAgICBpZiAodmFsaWRzWyJ1dGY4Il0gPT0gInRydWUiKQogICAgICAg ICBzb3B0aW9ucyA8PCAidXRmOCI7CiAK 166271 2008-09-24 12:51 0000 KDE 3.5.10 fix (kdebase/kdebase-kioslaves) kdebase-3.5.10-ntfs3g-locale.patch text/plain SW5kZXg6IGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBraW9zbGF2ZS9tZWRpYS9tZWRpYW1hbmFnZXIvaGFsYmFja2VuZC5jcHAJKHJldmlz aW9uIDg2NDA5OCkKKysrIGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODUxLDEzICs4NTEsNiBAQAogICAgICAgICByZXN1bHQgPDwg dG1wOwogICAgIH0KIAotCWlmICggdmFsaWRzLmNvbnRhaW5zKCJsb2NhbGUiKSApCi0JewotCQl2 YWx1ZSA9IGNvbmZpZy5yZWFkQm9vbEVudHJ5KCAibG9jYWxlIiwgdHJ1ZSApOwotCQl0bXAgPSBR U3RyaW5nKCAibG9jYWxlPSUxIiApLmFyZyggdmFsdWUgPyAidHJ1ZSIgOiAiZmFsc2UiICk7Ci0J CXJlc3VsdCA8PCB0bXA7Ci0JfQotCiAgICAgaWYgKHZhbGlkcy5jb250YWlucygidXRmOCIpKQog ICAgIHsKICAgICAgICAgdmFsdWUgPSBjb25maWcucmVhZEJvb2xFbnRyeSgidXRmOCIsIHRydWUp OwpAQCAtODc4LDYgKzg3MSwxNSBAQAogICAgICAgICAgICAgcmVzdWx0IDw8ICJzaG9ydG5hbWU9 bG93ZXIiOwogICAgIH0KIAorCisgICAgaWYgKHZhbGlkcy5jb250YWlucygibG9jYWxlIikpCisg ICAgeworICAgICAgICBjaGFyICpjVHlwZTsKKyAgICAgICAgaWYgKCAoY1R5cGUgPSBnZXRlbnYo IkxDX0FMTCIpKSB8fCAoY1R5cGUgPSBnZXRlbnYoIkxDX0NUWVBFIikpIHx8IChjVHlwZSA9IGdl dGVudigiTEFORyIpKSApIHsKKyAgICAgICAgICAgIHJlc3VsdCA8PCBRU3RyaW5nKCJsb2NhbGU9 JTEiKS5hcmcoY1R5cGUpOworICAgICAgICB9CisgICAgfQorCiAgICAgaWYgKHZhbGlkcy5jb250 YWlucygic3luYyIpKQogICAgIHsKICAgICAgICAgdmFsdWUgPSBjb25maWcucmVhZEJvb2xFbnRy eSgic3luYyIsICggdmFsaWRzLmNvbnRhaW5zKCJmbHVzaCIpICYmICFmc3R5cGUuZW5kc1dpdGgo ImZhdCIpICkgJiYgcmVtb3ZhYmxlKTsKQEAgLTkzMSw3ICs5MzMsNyBAQAogCiAgICAgUU1hcDxR U3RyaW5nLFFTdHJpbmc+IHZhbGlkcyA9IE1lZGlhTWFuYWdlclV0aWxzOjpzcGxpdE9wdGlvbnMo b3B0aW9ucyk7CiAKLSAgICBjb25zdCBjaGFyICpuYW1lc1tdID0geyAicm8iLCAicXVpZXQiLCAi YXRpbWUiLCAidWlkIiwgInV0ZjgiLCAiZmx1c2giLCAic3luYyIsICJsb2NhbGUiLCAwIH07Cisg ICAgY29uc3QgY2hhciAqbmFtZXNbXSA9IHsgInJvIiwgInF1aWV0IiwgImF0aW1lIiwgInVpZCIs ICJ1dGY4IiwgImZsdXNoIiwgInN5bmMiLCAwIH07CiAgICAgZm9yIChpbnQgaW5kZXggPSAwOyBu YW1lc1tpbmRleF07ICsraW5kZXgpCiAgICAgICAgIGlmICh2YWxpZHMuY29udGFpbnMobmFtZXNb aW5kZXhdKSkKICAgICAgICAgICAgIGNvbmZpZy53cml0ZUVudHJ5KG5hbWVzW2luZGV4XSwgdmFs aWRzW25hbWVzW2luZGV4XV0gPT0gInRydWUiKTsKQEAgLTk1MSwxMCArOTUzLDYgQEAKICAgICAg ICAgY29uZmlnLndyaXRlRW50cnkoImF1dG9tb3VudCIsIHZhbGlkc1siYXV0b21vdW50Il0pOwog ICAgIH0KIAotCWlmICh2YWxpZHMuY29udGFpbnMoImxvY2FsZSIpICkgewotCQljb25maWcud3Jp dGVFbnRyeSgibG9jYWxlIiwgdmFsaWRzWyJsb2NhbGUiXSk7Ci0JfQotCiAgICAgcmV0dXJuIHRy dWU7CiB9CiAKQEAgLTExNTMsMTEgKzExNTEsNiBAQAogICAgICAgICBzb3B0aW9ucyA8PCBRU3Ry aW5nKCJ1aWQ9JTEiKS5hcmcoZ2V0dWlkKCkpOwogICAgIH0KIAotICAgIGlmICh2YWxpZHNbImxv Y2FsZSJdID09ICJ0cnVlIikKLQl7Ci0JCXNvcHRpb25zIDw8IFFTdHJpbmcoImxvY2FsZT0lMSIp LmFyZyggS0dsb2JhbDo6bG9jYWxlKCktPmxhbmd1YWdlKCkgKTsgCi0JfQotCiAgICAgaWYgKHZh bGlkc1sicm8iXSA9PSAidHJ1ZSIpCiAgICAgICAgIHNvcHRpb25zIDw8ICJybyI7CiAKQEAgLTEx ODIsNiArMTE3NSwxMSBAQAogICAgICAgICBzb3B0aW9ucyA8PCBRU3RyaW5nKCJzaG9ydG5hbWU9 JTEiKS5hcmcodmFsaWRzWyJzaG9ydG5hbWUiXSk7CiAgICAgfQogCisgICAgaWYgKHZhbGlkcy5j b250YWlucygibG9jYWxlIikpCisgICAgeworICAgICAgICBzb3B0aW9ucyA8PCBRU3RyaW5nKCJs b2NhbGU9JTEiKS5hcmcodmFsaWRzWyJsb2NhbGUiXSk7CisgICAgfQorCiAgICAgaWYgKHZhbGlk cy5jb250YWlucygiam91cm5hbGluZyIpKQogICAgIHsKICAgICAgICAgUVN0cmluZyBvcHRpb24g PSB2YWxpZHNbImpvdXJuYWxpbmciXTsK 166272 2008-09-24 14:03 0000 KDE 3.5.10 fix (kdebase / kdebase-kioslaves) kdebase-3.5.10-ntfs3g-locale.patch text/plain SW5kZXg6IGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBraW9zbGF2ZS9tZWRpYS9tZWRpYW1hbmFnZXIvaGFsYmFja2VuZC5jcHAJKHJldmlz aW9uIDg2NDA5OCkKKysrIGtpb3NsYXZlL21lZGlhL21lZGlhbWFuYWdlci9oYWxiYWNrZW5kLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODUxLDEzICs4NTEsNiBAQAogICAgICAgICByZXN1bHQgPDwg dG1wOwogICAgIH0KIAotCWlmICggdmFsaWRzLmNvbnRhaW5zKCJsb2NhbGUiKSApCi0JewotCQl2 YWx1ZSA9IGNvbmZpZy5yZWFkQm9vbEVudHJ5KCAibG9jYWxlIiwgdHJ1ZSApOwotCQl0bXAgPSBR U3RyaW5nKCAibG9jYWxlPSUxIiApLmFyZyggdmFsdWUgPyAidHJ1ZSIgOiAiZmFsc2UiICk7Ci0J CXJlc3VsdCA8PCB0bXA7Ci0JfQotCiAgICAgaWYgKHZhbGlkcy5jb250YWlucygidXRmOCIpKQog ICAgIHsKICAgICAgICAgdmFsdWUgPSBjb25maWcucmVhZEJvb2xFbnRyeSgidXRmOCIsIHRydWUp OwpAQCAtODc4LDYgKzg3MSwxNSBAQAogICAgICAgICAgICAgcmVzdWx0IDw8ICJzaG9ydG5hbWU9 bG93ZXIiOwogICAgIH0KIAorCisgICAgaWYgKHZhbGlkcy5jb250YWlucygibG9jYWxlIikgJiYg ZnN0eXBlID09ICJudGZzLTNnIikKKyAgICB7CisgICAgICAgIGNoYXIgKmNUeXBlOworICAgICAg ICBpZiAoIChjVHlwZSA9IGdldGVudigiTENfQUxMIikpIHx8IChjVHlwZSA9IGdldGVudigiTENf Q1RZUEUiKSkgfHwgKGNUeXBlID0gZ2V0ZW52KCJMQU5HIikpICkgeworICAgICAgICAgICAgcmVz dWx0IDw8IFFTdHJpbmcoImxvY2FsZT0lMSIpLmFyZyhjVHlwZSk7CisgICAgICAgIH0KKyAgICB9 CisKICAgICBpZiAodmFsaWRzLmNvbnRhaW5zKCJzeW5jIikpCiAgICAgewogICAgICAgICB2YWx1 ZSA9IGNvbmZpZy5yZWFkQm9vbEVudHJ5KCJzeW5jIiwgKCB2YWxpZHMuY29udGFpbnMoImZsdXNo IikgJiYgIWZzdHlwZS5lbmRzV2l0aCgiZmF0IikgKSAmJiByZW1vdmFibGUpOwpAQCAtOTMxLDcg KzkzMyw3IEBACiAKICAgICBRTWFwPFFTdHJpbmcsUVN0cmluZz4gdmFsaWRzID0gTWVkaWFNYW5h Z2VyVXRpbHM6OnNwbGl0T3B0aW9ucyhvcHRpb25zKTsKIAotICAgIGNvbnN0IGNoYXIgKm5hbWVz W10gPSB7ICJybyIsICJxdWlldCIsICJhdGltZSIsICJ1aWQiLCAidXRmOCIsICJmbHVzaCIsICJz eW5jIiwgImxvY2FsZSIsIDAgfTsKKyAgICBjb25zdCBjaGFyICpuYW1lc1tdID0geyAicm8iLCAi cXVpZXQiLCAiYXRpbWUiLCAidWlkIiwgInV0ZjgiLCAiZmx1c2giLCAic3luYyIsIDAgfTsKICAg ICBmb3IgKGludCBpbmRleCA9IDA7IG5hbWVzW2luZGV4XTsgKytpbmRleCkKICAgICAgICAgaWYg KHZhbGlkcy5jb250YWlucyhuYW1lc1tpbmRleF0pKQogICAgICAgICAgICAgY29uZmlnLndyaXRl RW50cnkobmFtZXNbaW5kZXhdLCB2YWxpZHNbbmFtZXNbaW5kZXhdXSA9PSAidHJ1ZSIpOwpAQCAt OTUxLDEwICs5NTMsNiBAQAogICAgICAgICBjb25maWcud3JpdGVFbnRyeSgiYXV0b21vdW50Iiwg dmFsaWRzWyJhdXRvbW91bnQiXSk7CiAgICAgfQogCi0JaWYgKHZhbGlkcy5jb250YWlucygibG9j YWxlIikgKSB7Ci0JCWNvbmZpZy53cml0ZUVudHJ5KCJsb2NhbGUiLCB2YWxpZHNbImxvY2FsZSJd KTsKLQl9Ci0KICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMTE1MywxMSArMTE1MSw2IEBACiAg ICAgICAgIHNvcHRpb25zIDw8IFFTdHJpbmcoInVpZD0lMSIpLmFyZyhnZXR1aWQoKSk7CiAgICAg fQogCi0gICAgaWYgKHZhbGlkc1sibG9jYWxlIl0gPT0gInRydWUiKQotCXsKLQkJc29wdGlvbnMg PDwgUVN0cmluZygibG9jYWxlPSUxIikuYXJnKCBLR2xvYmFsOjpsb2NhbGUoKS0+bGFuZ3VhZ2Uo KSApOyAKLQl9Ci0KICAgICBpZiAodmFsaWRzWyJybyJdID09ICJ0cnVlIikKICAgICAgICAgc29w dGlvbnMgPDwgInJvIjsKIApAQCAtMTE4Miw2ICsxMTc1LDExIEBACiAgICAgICAgIHNvcHRpb25z IDw8IFFTdHJpbmcoInNob3J0bmFtZT0lMSIpLmFyZyh2YWxpZHNbInNob3J0bmFtZSJdKTsKICAg ICB9CiAKKyAgICBpZiAodmFsaWRzLmNvbnRhaW5zKCJsb2NhbGUiKSkKKyAgICB7CisgICAgICAg IHNvcHRpb25zIDw8IFFTdHJpbmcoImxvY2FsZT0lMSIpLmFyZyh2YWxpZHNbImxvY2FsZSJdKTsK KyAgICB9CisKICAgICBpZiAodmFsaWRzLmNvbnRhaW5zKCJqb3VybmFsaW5nIikpCiAgICAgewog ICAgICAgICBRU3RyaW5nIG9wdGlvbiA9IHZhbGlkc1siam91cm5hbGluZyJdOwo=