236858 2008-09-06 12:57 0000 sys-apps/util-linux-2.14 installs non-POSIX /etc/init.d/crypto-loop 2008-10-26 03:16:36 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 vaeth@mathematik.uni-wuerzburg.de base-system@gentoo.org vaeth@mathematik.uni-wuerzburg.de 2008-09-06 12:57:23 0000 As the summary says, file/crypto-loop.initd uses several bashisms which make the file fail if e.g. /bin/sh is a symlink to dash. As usual, only small syntax changes are necessary to make it POSIX compliant. I attach a patch. vaeth@mathematik.uni-wuerzburg.de 2008-09-06 13:05:23 0000 Created an attachment (id=164719) Patch to make crypto-loop.initd POSIX compliant The patch in addition removes the redundant call of "ls" which might have produced a confusing error message if no /dev/loop[0-9] exists (and a new line was inserted to deal with that case). wormo@gentoo.org 2008-09-06 17:59:50 0000 Thanks for the cleanup patch, assigning to maintainers vapier@gentoo.org 2008-10-26 03:16:36 0000 changing [[ -n ${var} ]] to [ -n ${var} ] is broken ive fixed things up and committed it, thanks http://sources.gentoo.org/sys-apps/util-linux/files/crypto-loop.initd?r1=1.3&r2=1.4 164719 2008-09-06 13:05 0000 Patch to make crypto-loop.initd POSIX compliant crypto-loop.initd.patch text/plain LS0tIGNyeXB0by1sb29wLmluaXRkCisrKyBjcnlwdG8tbG9vcC5pbml0ZApAQCAtMTgsNyArMTgs NyBAQAogCiAJZWJlZ2luICJTdGFydGluZyBjcnlwdG8gbG9vcCBkZXZpY2VzIgogCi0JaWYgW1sg LWUgL2V0Yy9jb25mLmQvY3J5cHRvLWxvb3AgXV0gOyB0aGVuCisJaWYgWyAtZSAvZXRjL2NvbmYu ZC9jcnlwdG8tbG9vcCBdIDsgdGhlbgogCQllZ3JlcCAiXmxvb3AiIC9ldGMvY29uZi5kL2NyeXB0 by1sb29wIHwgXAogCQl3aGlsZSByZWFkIGxvb3BsaW5lIDsgZG8KIAkJCWV2YWwgJHtsb29wbGlu ZX0KQEAgLTI2LDE3ICsyNiwxNyBAQAogCQkJbG9jYWwgY29uZmlndXJlZD0kKGF3ayAtdiBNT1VO VD0iJHtkZXZpY2V9IiBcCiAJCQkJJygkMiA9PSBNT1VOVCkgeyBwcmludCAieWVzIiB9JyAvcHJv Yy9tb3VudHMpCiAKLQkJCWlmIFtbICR7Y29uZmlndXJlZH0gIT0gInllcyIgXV0gOyB0aGVuCisJ CQlpZiBbICIke2NvbmZpZ3VyZWR9IiAhPSAieWVzIiBdIDsgdGhlbgogCQkJCWVpbmZvICIgIExv b3AgJHtsb29wfSBvbiBkZXZpY2UgJHtkZXZpY2V9IChjaXBoZXIgJHtjaXBoZXJ9LCBrZXkgc2l6 ZSAke2tleXNpemV9KTogIgogCi0JCQkJaWYgW1sgLW4gJHtoYXNofSBdXSA7IHRoZW4KKwkJCQlp ZiBbIC1uICR7aGFzaH0gXSA7IHRoZW4KIAkJCQkJL3Vzci9zYmluL2hhc2hhbG90IC1uICR7a2V5 c2l6ZX0gJHtoYXNofSA8L2Rldi90dHl8XAogCQkJCQkvc2Jpbi9sb3NldHVwIC1wIDAgLWUgJHtj aXBoZXJ9LSR7a2V5c2l6ZX0gJHtsb29wfSAke2RldmljZX0gJHtvdGhlcn0KIAkJCQllbHNlCiAJ CQkJCS9zYmluL2xvc2V0dXAgLWUgJHtjaXBoZXJ9LSR7a2V5c2l6ZX0gJHtsb29wfSAke2Rldmlj ZX0gJHtvdGhlcn0KIAkJCQlmaQogCi0JCQkJaWYgW1sgJD8gLW5lIDAgXV0gOyB0aGVuCisJCQkJ aWYgWyAkPyAtbmUgMCBdIDsgdGhlbgogCQkJCQlld2FybiAiRmFpbHVyZSBjb25maWd1cmluZyAk e2xvb3B9LiAgU2tpcHBpbmcuIgogCQkJCQlzdGF0dXM9MQogCQkJCWZpCkBAIC01MywxMSArNTMs MTIgQEAKIAogc3RvcCgpIHsKIAlsb2NhbCBzdGF0dXM9IjAiCi0JZm9yIGxvb3AgaW4gJChscyAv ZGV2L2xvb3BbMC05XSkgOyBkbwotCQlsb3NldHVwICR7bG9vcH0gJj4gL2Rldi9udWxsCi0JCWlm IFtbICQ/ID09IDAgXV0gOyB0aGVuCi0JCQl1bW91bnQgJHtsb29wfSAmPi9kZXYvbnVsbCB8fCBz d2Fwb2ZmICIke2xvb3B9IiAmPi9kZXYvbnVsbAotCQkJaWYgISAvc2Jpbi9sb3NldHVwIC1kICR7 bG9vcH0gJj4gL2Rldi9udWxsIDsgdGhlbgorCWZvciBsb29wIGluIC9kZXYvbG9vcFswLTldIDsg ZG8KKwkJWyAtZSAiJHtsb29wfSIgXSB8fCBjb250aW51ZQorCQlsb3NldHVwICR7bG9vcH0gPiAv ZGV2L251bGwgMj4mMQorCQlpZiBbICQ/IC1lcSAwIF0gOyB0aGVuCisJCQl1bW91bnQgJHtsb29w fSA+L2Rldi9udWxsIDI+JjEgfHwgc3dhcG9mZiAiJHtsb29wfSIgPi9kZXYvbnVsbCAyPiYxCisJ CQlpZiAhIC9zYmluL2xvc2V0dXAgLWQgJHtsb29wfSA+IC9kZXYvbnVsbCAyPiYxOyB0aGVuCiAJ CQkJZXdhcm4gIkZhaWx1cmUgZGVjb25maWd1cmluZyAke2xvb3B9LiIKIAkJCQlzdGF0dXM9MQog CQkJZmkK