235393 2008-08-21 18:55 0000 dev-util/git: 72git-gentoo.el does nothing for >=emacs-22.2 2008-11-24 00:46:42 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 simons@cryp.to emacs@gentoo.org robbat2@gentoo.org simons@cryp.to 2008-08-21 18:55:03 0000 I'm wondering about the file /usr/share/emacs/site-lisp/site-gentoo.d/72git-gentoo.el that's installed by dev-util/git: Why is the initialization code contained in a (unless (fboundp 'vc-git-registered) ...) bracket? I don't see how git can be registered as a VC backend at the time that file is parsed. No matter what I do, I cannot make the default installation support M-x git-status. Removing that unless-conditional remedies the problem. Am I missing something? How is that thing supposed to work? Reproducible: Always Steps to Reproduce: 1. USE=emacs emerge git 2. emacs 3. M-x git-status Doesn't work. ulm@gentoo.org 2008-08-21 20:13:47 0000 This is on purpose, since VC in >=emacs-22.2 comes with its own Git backend already. So in this case we disable the code that comes with dev-util/git, see bug 194690. ulm@gentoo.org 2008-08-25 08:03:15 0000 Resolving as invalid. Please reopen if you think that this is still an issue. For clarification, I've put a comment in 72git-gentoo.el: ;; GNU Emacs >=22.2 already includes vc-git.el. ;; Enable the following only if Emacs has no GIT support. simons@cryp.to 2008-10-30 05:25:52 0000 The git support shipped with Emacs does not provide 'git-status'; the mode installed by git, however, does. So the elisp files from git should be preferred. Am I missing something? ulm@gentoo.org 2008-10-30 07:24:40 0000 Created an attachment (id=170294) Proposed patch for git-1.6.0.3.ebuild (In reply to comment #3) > The git support shipped with Emacs does not provide 'git-status'; the mode > installed by git, however, does. So the elisp files from git should be > preferred. As I wrote before, we cannot use vc-git.el with Emacs >= 22.2. But you have a point, we could autoload git.el (i.e., git-status) unconditionally and apply the version test only for vc-git.el. Patch for the ebuild is attached, new site-init file will follow. ulm@gentoo.org 2008-10-30 07:29:27 0000 Created an attachment (id=170296) files/50git-gentoo.el New site-init file. (I've changed its number from 72 to the canonical 50. There is no other package required before git in the load sequence, and whenever I see a number like 72 I ask myself what would be the reason for this.) ulm@gentoo.org 2008-11-15 13:22:57 0000 robbat2, any objections if I commit this myself? robbat2@gentoo.org 2008-11-24 00:46:42 0000 In 1.6.0.4-r1 170294 2008-10-30 07:24 0000 Proposed patch for git-1.6.0.3.ebuild git-1.6.0.3.ebuild.patch text/plain LS0tIGdpdC0xLjYuMC4zLmVidWlsZAkyOSBPY3QgMjAwOCAwMTozMzoxMyAtMDAwMAkxLjEKKysr IGdpdC0xLjYuMC4zLmVidWlsZAkzMCBPY3QgMjAwOCAwNzoxNTo0MSAtMDAwMApAQCAtNDMsNyAr NDMsNyBAQAogCQkJKQogCWd0az8gICggPj1kZXYtcHl0aG9uL3B5Z3RrLTIuOCApIgogCi1TSVRF RklMRT03MiR7UE59LWdlbnRvby5lbAorU0lURUZJTEU9NTAke1BOfS1nZW50b28uZWwKIFM9IiR7 V09SS0RJUn0vJHtNWV9QfSIKIAogcGtnX3NldHVwKCkgewpAQCAtMTM0LDEyICsxMzQsMTIgQEAK IAlkb2Jhc2hjb21wbGV0aW9uIGNvbnRyaWIvY29tcGxldGlvbi9naXQtY29tcGxldGlvbi5iYXNo ICR7UE59CiAKIAlpZiB1c2UgZW1hY3MgOyB0aGVuCi0JCWVsaXNwLWluc3RhbGwgJHtQTn0gY29u dHJpYi9lbWFjcy97LHZjLX1naXQuZWwqIHx8IFwKLQkJCWRpZSAiZWxpc3AtaW5zdGFsbCBmYWls ZWQiCi0JCWVsaXNwLXNpdGUtZmlsZS1pbnN0YWxsICIke0ZJTEVTRElSfSIvJHtTSVRFRklMRX0K KwkJZWxpc3AtaW5zdGFsbCAke1BOfSBjb250cmliL2VtYWNzL2dpdC57ZWwsZWxjfSB8fCBkaWUK KwkJZWxpc3AtaW5zdGFsbCAke1BOfS9jb21wYXQgY29udHJpYi9lbWFjcy92Yy1naXQue2VsLGVs Y30gfHwgZGllCiAJCSMgZG9uJ3QgYWRkIGF1dG9tYXRpY2FsbHkgdG8gdGhlIGxvYWQtcGF0aCwg c28gdGhlIHNpdGVmaWxlCiAJCSMgY2FuIGRvIGEgY29uZGl0aW9uYWwgbG9hZGluZwotCQl0b3Vj aCAiJHtEfSIvIiR7U0lURUxJU1B9Ii8ke1BOfS8ubm9zZWFyY2gKKwkJdG91Y2ggIiR7RH0ke1NJ VEVMSVNQfS8ke1BOfS9jb21wYXQvLm5vc2VhcmNoIgorCQllbGlzcC1zaXRlLWZpbGUtaW5zdGFs bCAiJHtGSUxFU0RJUn0vJHtTSVRFRklMRX0iIHx8IGRpZQogCWZpCiAKIAlpZiB1c2UgZ3RrIDsg dGhlbgpAQCAtMjcwLDEyICsyNzAsNyBAQAogfQogCiBwa2dfcG9zdGluc3QoKSB7Ci0JaWYgdXNl IGVtYWNzIDsgdGhlbgotCQllbGlzcC1zaXRlLXJlZ2VuCi0JCWVsb2cgIkdOVSBFbWFjcyBoYXMg YnVpbHQtaW4gR2l0IHN1cHBvcnQgaW4gdmVyc2lvbnMgZ3JlYXRlciAyMi4xLiIKLQkJZWxvZyAi WW91IGNhbiBkaXNhYmxlIHRoZSBlbWFjcyBVU0UgZmxhZyBmb3IgZGV2LXV0aWwvZ2l0IgotCQll bG9nICJpZiB5b3UgYXJlIHVzaW5nIHN1Y2ggYSB2ZXJzaW9uLiIKLQlmaQorCXVzZSBlbWFjcyAm JiBlbGlzcC1zaXRlLXJlZ2VuCiAJaWYgdXNlIHN1YnZlcnNpb24gJiYgISBidWlsdF93aXRoX3Vz ZSBkZXYtdXRpbC9zdWJ2ZXJzaW9uIHBlcmwgOyB0aGVuCiAJCWV3YXJuICJZb3UgbXVzdCBidWls ZCBkZXYtdXRpbC9zdWJ2ZXJzaW9uIHdpdGggVVNFPXBlcmwiCiAJCWV3YXJuICJ0byBnZXQgdGhl IGZ1bGwgZnVuY3Rpb25hbGl0eSBvZiBnaXQtc3ZuISIK 170296 2008-10-30 07:29 0000 files/50git-gentoo.el 50git-gentoo.el text/plain Cjs7OyBkZXYtdXRpbC9naXQgc2l0ZS1saXNwIGNvbmZpZ3VyYXRpb24KCihhZGQtdG8tbGlzdCAn bG9hZC1wYXRoICJAU0lURUxJU1BAIikKKGF1dG9sb2FkICdnaXQtc3RhdHVzICJnaXQiICJFbnRy eSBwb2ludCBpbnRvIGdpdC1zdGF0dXMgbW9kZS4iIHQpCjs7KGF1dG9sb2FkICdnaXQtYmxhbWUt bW9kZSAiZ2l0LWJsYW1lIgo7OyAgIk1pbm9yIG1vZGUgZm9yIGluY3JlbWVudGFsIGJsYW1lIGZv ciBHaXQuIiB0KQoKOzsgR05VIEVtYWNzID49MjIuMiBhbHJlYWR5IGluY2x1ZGVzIHZjLWdpdC5l bC4KOzsgRW5hYmxlIHRoZSBmb2xsb3dpbmcgb25seSBpZiBFbWFjcyBoYXMgbm8gR0lUIHN1cHBv cnQuCih1bmxlc3MgKGZib3VuZHAgJ3ZjLWdpdC1yZWdpc3RlcmVkKQogIChhZGQtdG8tbGlzdCAn bG9hZC1wYXRoICJAU0lURUxJU1BAL2NvbXBhdCIpCiAgKGFkZC10by1saXN0ICd2Yy1oYW5kbGVk LWJhY2tlbmRzICdHSVQpKQo=