232418 2008-07-20 09:48 0000 media-plugins/audacious-plugins-1.5.1 fails to build on 64bits arches. 2008-07-22 14:25:19 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 aballier@gentoo.org chainsaw@gentoo.org sound@gentoo.org aballier@gentoo.org 2008-07-20 09:48:58 0000 Similar to bug #216848 * QA Notice: Package has poor programming practices which may compile * but will almost certainly crash on 64bit architectures. * Function `audacious_get_localdir' implicitly converted to pointer at i_configure.c:419 * * ERROR: media-plugins/audacious-plugins-1.5.1 failed. * Call stack: * misc-functions.sh, line 653: Called install_qa_check * misc-functions.sh, line 349: Called die * The specific snippet of code: * alpha*|ia64*|powerpc64*|mips64*|sparc64*|x86_64*) die "this code is not 64bit clean";; * The die message: * this code is not 64bit clean Probably missing #include <audacious/plugin.h> that means the default return value of the function will be int, while it's casted to gchar* ivanhoe@vfemail.net 2008-07-22 13:02:46 0000 (In reply to comment #0) Same here. ivanhoe@vfemail.net 2008-07-22 13:15:34 0000 Created an attachment (id=161095) Patch that fixes the bug chainsaw@gentoo.org 2008-07-22 13:29:04 0000 Thank you Ivan, patch committed upstream: <CIA-1> audacious-plugins: Tony Vroon <chainsaw@gentoo.org> default * 2843:29a14d80fcd8 /src/amidi-plug/i_configure.c: Patch by ivanhoe@vfemail.net to include missing header, resolves QA warning and Gentoo bug #232418. chainsaw@gentoo.org 2008-07-22 14:15:42 0000 Ivan, your contribution to the Audacious project & Gentoo linux is highly appreciated. This is in the tree as 1.5.1-r1. ivanhoe@vfemail.net 2008-07-22 14:25:19 0000 (In reply to comment #4) It was a pleasure to contribute. Thanks to you all for your efforts. 161095 2008-07-22 13:15 0000 Patch that fixes the bug patch.txt text/plain LS0tIGF1ZGFjaW91cy1wbHVnaW5zLTEuNS4xL3NyYy9hbWlkaS1wbHVnL2lfY29uZmlndXJlLmN+ IDIwMDgtMDUtMjMgMTY6NDQ6MTkuMDAwMDAwMDAwIC0wNjAwIAorKysgYXVkYWNpb3VzLXBsdWdp bnMtMS41LjEvc3JjL2FtaWRpLXBsdWcvaV9jb25maWd1cmUuYyAyMDA4LTA2LTE3IDE2OjI5OjIy LjAwMDAwMDAwMCAtMDYwMCAKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJpX2NvbmZpZ3Vy ZS1kdW1teS5oIgogI2luY2x1ZGUgImlfdXRpbHMuaCIKICNpbmNsdWRlIDxhdWRhY2lvdXMvYXVk ZHJjdC5oPgorI2luY2x1ZGUgPGF1ZGFjaW91cy9wbHVnaW4uaD4KCgogYW1pZGlwbHVnX2NmZ19i YWNrZW5kX3QgKiBhbWlkaXBsdWdfY2ZnX2JhY2tlbmQ7Cg==