226931 2008-06-14 18:26 0000 x11-wm/windowmaker: append-ldflags is used to pass libraries 2008-06-18 18:12:52 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 226863 1 flameeyes@gentoo.org gnustep@gentoo.org flameeyes@gentoo.org 2008-06-14 18:26:49 0000 I've made append-ldflags throw a warning when libraries are passed through it to link them in. The reason is that LDFLAGS should _not_ be used for libraries, as it has to be positioned before the list of objects to link together, while libraries should go after. This mistake in commandline is what causes as-needed to either fail or not apply at all (if LDFLAGS are put at the end). Please fix your package not to pass libraries through LDFLAGS. grobian@gentoo.org 2008-06-14 21:17:50 0000 since there are a whole lot more packages that do this, can you please explain how one is supposed to fix this? grobian@gentoo.org 2008-06-18 15:58:59 0000 if you don't care to explain your problem, then I take it as an unsolvable problem. sorry. flameeyes@gentoo.org 2008-06-18 16:13:38 0000 I have over 400 bugs open at the same bloody time, I'm doing my bloody job and you can WAIT A BLOODY WEEK AT LEAST! grobian@gentoo.org 2008-06-18 16:24:38 0000 If the tone of the bug was less commanding and less vague, I probably could have waited a month without a problem. truedfx@gentoo.org 2008-06-18 16:44:01 0000 Created an attachment (id=157463) windowmaker-ldflags-libs.patch Calm down, please, both of you. grobian, the problem is that `gcc -Wl,--as-needed -lresolv *.o` won't link with -lresolv. It needs to be at the end of the command line, after the .o files, so that ld can tell whether it's actually used. This is what LIBS is for as opposed to LDFLAGS, and windowmaker appears to have no problems with LIBS, meaning it could be fixed as simple as this (though it'd be nice if flag-o-matic had an append-libs). Since I don't have access to a Solaris box, could you please test to make sure that there is no change in configure test results, and either commit this yourself or let me know afterwards? grobian@gentoo.org 2008-06-18 16:48:38 0000 Aha. Thanks for the explanation. Looking at the thing itself, I guess I could also just patch configure to add the right macro to figure out if resolv() can be used without libs, or -lresolv as suggestion on Solaris. There is such macro, but I forget which one each time. Wouldn't that just solve the issue in the most elegant way? truedfx@gentoo.org 2008-06-18 16:59:04 0000 Yes, that would be even better. It looks like windowmaker already tries to look in libresolv: AC_CHECK_FUNC(inet_aton, AC_DEFINE(HAVE_INET_ATON, 1, [define if you have then inet_aton function (set by configure)]), for lib in resolv socket inet bsd; do AC_CHECK_LIB($lib, inet_aton, [AC_DEFINE(HAVE_INET_ATON) NETLIBS="$NETLIBS -l$lib"; break],, $NETLIBS) done) so then the question is not what the right macro is -- AC_CHECK_LIB is the right one -- but why it didn't work. grobian@gentoo.org 2008-06-18 17:29:07 0000 checking for inet_aton in -lresolv... yes so the whole -lresolv thing is obsolete (in -r7 at least) the -lintl is left but nastier IMO. truedfx@gentoo.org 2008-06-18 18:07:42 0000 > checking for inet_aton in -lresolv... yes > > so the whole -lresolv thing is obsolete (in -r7 at least) Good to know. I've removed it. > the -lintl is left but nastier IMO. There's no -lintl in the ebuilds in gentoo-x86, so I'm assuming you're checking an overlay? Let me know and I'll take a look, in the weekend at the latest, if you want. I'll go ahead and close this bug since it's fixed in the main tree. grobian@gentoo.org 2008-06-18 18:12:52 0000 > > the -lintl is left but nastier IMO. > > There's no -lintl in the ebuilds in gentoo-x86, so I'm assuming you're checking > an overlay? Let me know and I'll take a look, in the weekend at the latest, if > you want. I'll go ahead and close this bug since it's fixed in the main tree. Thanks, but I already found where the problem must be. The configure script does not properly check if it needs libintl (only if gettext function is not found). Anyway, it seems indeed I only fixed this for Solaris in the prefix tree, not in gentoo-x86. 157463 2008-06-18 16:44 0000 windowmaker-ldflags-libs.patch windowmaker-ldflags-libs.patch text/plain LS0tIHdpbmRvd21ha2VyLTAuOTIuMC1yNy5lYnVpbGQKKysrIHdpbmRvd21ha2VyLTAuOTIuMC1y Ny5lYnVpbGQKQEAgLTEzMCw3ICsxMzAsNyBAQAogCWFwcGVuZC1mbGFncyAtREJPVU5DRV9BUFAg LURORVdBUFBJQ09OIC1EVklSVFVBTF9ERVNLVE9QCiAKIAkjIFNvbGFyaXMgaGFzIGluZXRfYXRv biwgYnV0IGl0J3MgaGlkZGVuIGluIC1scmVzb2x2Ci0JW1sgJHtDSE9TVH0gPT0gKi1zb2xhcmlz KiBdXSAmJiBhcHBlbmQtbGRmbGFncyAtbHJlc29sdgorCVtbICR7Q0hPU1R9ID09ICotc29sYXJp cyogXV0gJiYgTElCUz0iJHtMSUJTfSAtbHJlc29sdiIKIAogCSMgZGVmYXVsdCBzZXR0aW5ncyB3 aXRoICRteWNvbmYgYXBwZW5kZWQKIAllY29uZiBcCg==