223875 2008-05-27 18:27 0000 sci-chemistry/gperiodic-2.0.10 (update) 2008-05-29 18:57:20 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux CLOSED FIXED P2 enhancement --- 1 rgkmg25@gmail.com cryos@gentoo.org mlm@ngc17.pl sci-chemistry@gentoo.org rgkmg25@gmail.com 2008-05-27 18:27:05 0000 Please find attached gperiodic-2.0.10.ebuild which is an update to gperiodic-2.0.7.ebuild in portage. GPeriodic is a program for looking up data of elements from the periodic table. It is an easy reference to the periodic table if you ever need it. Go to http://www.frantz.fi/software/gperiodic.php for more information. rgk rgkmg25@gmail.com 2008-05-27 18:29:25 0000 Created an attachment (id=154509) http://www.frantz.fi/software/gperiodic.php mlm@ngc17.pl 2008-05-28 10:20:26 0000 My sed complains about '|' delimiter: USE="-nls' emerge -v1 =gperiodic-2.0.10 ----- >>> Source unpacked. >>> Compiling source in /tmp/portage/tmpdir/portage/sci-chemistry/gperiodic-2.0.10/work/gperiodic-2.0.10 ... sed: -e expression #1, char 1: unknown command: `|' sed: -e expression #1, char 1: unknown command: `|' make gperiodic ----- This is about lines: 26: sed -i -e "|make clean|d" Makefile and 29: sed -i -e "|make -C po|d" Makefile Changing '|' to '/' fixes the case. Another problem is that the ebuild doesn't check if cairo was compiled with USE="X". I had cairo without X support and got following error: ----- gcc `pkg-config --cflags gtk+-2.0` -I. -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -O2 -march=pentium-m -pipe -fomit-frame-pointer -g -ggdb -o gperiodic gperiodic.o `pkg-config --libs gtk+-2.0` /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../libgdk-x11-2.0.so: undefined reference to `cairo_xlib_surface_create_for_bitmap' /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../libgdk-x11-2.0.so: undefined reference to `cairo_xlib_surface_set_size' /usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../libgdk-x11-2.0.so: undefined reference to `cairo_xlib_surface_create' collect2: ld returned 1 exit status make[1]: *** [gperiodic] Error 1 make[1]: Leaving directory `/tmp/portage/tmpdir/portage/sci-chemistry/gperiodic-2.0.10/work/gperiodic-2.0.10' make: *** [all] Error 2 ----- Again, recompiling cairo with X fixex the case. Tested on x86. Hope it will help. mlm@ngc17.pl 2008-05-28 16:21:46 0000 One more thing: exactly the same is with the stable gperiodic-2.0.7. markusle@gentoo.org 2008-05-29 12:43:41 0000 (In reply to comment #3) > One more thing: exactly the same is with the stable gperiodic-2.0.7. > Thanks guys, I'll have a look at this. Best, Markus cryos@gentoo.org 2008-05-29 12:54:14 0000 Did something change with sed? The | character has certainly always worked in the past and was one of the preferred delimiters for a while. The current stable ebuild still works here and I am at a loss as to why that would not work. What does your emerge --info look like - I am sure there are many more ebuilds in the tree using this delimiter. markusle@gentoo.org 2008-05-29 13:31:53 0000 I've added gperiodic-2.0.10 to portage. The sed errors should be fixed and I've added a check for cairo's X use flag. Thanks, Markus markusle@gentoo.org 2008-05-29 13:34:40 0000 (In reply to comment #5) > Did something change with sed? The | character has certainly always worked in > the past and was one of the preferred delimiters for a while. The current > stable ebuild still works here and I am at a loss as to why that would not > work. What does your emerge --info look like - I am sure there are many more > ebuilds in the tree using this delimiter. > I think "|" is allowed for regular expression type things (s|foo|bar|) but invalid for delete expressions (/foobar/d). I am not sure if '|' used to be valid in the latter case, but newer sed's clearly reject it. Best, Markus cryos@gentoo.org 2008-05-29 15:13:39 0000 Which versions of sed? I have sys-apps/sed-4.1.5-r1 and it didn't reject it. I am using ~amd64 and so would have thought I would have been able to reproduce the error... markusle@gentoo.org 2008-05-29 15:22:08 0000 (In reply to comment #8) > Which versions of sed? I have sys-apps/sed-4.1.5-r1 and it didn't reject it. I > am using ~amd64 and so would have thought I would have been able to reproduce > the error... > Hmm, interesting. I am using sys-apps/sed-4.1.5-r1 as well on ~amd64 and here is what happens # cat bla.txt foobar # sed -e "|foobar|d" -i bla.txt sed: -e expression #1, char 1: unknown command: `|' # sed -e "/foobar/d" -i bla.txt # cat bla.txt Best, Markus markusle@gentoo.org 2008-05-29 15:28:54 0000 (In reply to comment #9) > (In reply to comment #8) > > Which versions of sed? I have sys-apps/sed-4.1.5-r1 and it didn't reject it. I > > am using ~amd64 and so would have thought I would have been able to reproduce > > the error... > > > > Hmm, interesting. I am using sys-apps/sed-4.1.5-r1 as well on ~amd64 and > here is what happens > > # cat bla.txt > foobar > # sed -e "|foobar|d" -i bla.txt > sed: -e expression #1, char 1: unknown command: `|' > # sed -e "/foobar/d" -i bla.txt > # cat bla.txt > > > Best, > Markus > Could it be locale related? I am using en_US.UTF-8, but plain "C" fails as well. Markus cryos@gentoo.org 2008-05-29 15:51:20 0000 Sorry - looking closer it does fail now. May be those sed statements should be | die "sed failed". May be the author should bring back a build system too but hey... Sorry for the noise. In related news I don't seem to be able to fetch the 2.0.10 package. mlm@ngc17.pl 2008-05-29 16:11:01 0000 If it will help, my emerge --info is an in bug 218084, comment 3. mlm@ngc17.pl 2008-05-29 18:56:23 0000 Answer to comment 5 > I am sure there are many more > ebuilds in the tree using this delimiter. I scaned the whole portage tree, sunrise and science overlays and there is only _one_ ebuild that uses '|' in delete expressions. Guess which one. markusle@gentoo.org 2008-05-29 18:57:20 0000 (In reply to comment #11) >In related news I don't seem to be able to fetch > the 2.0.10 package. It should be on our mirrors, I just tried it. In any case, both SRC_URI and HOMEPAGE were broken so I updated them. It looks like the 2.0.7 tarball is gone from upstream's download page and I've therefore changed SRC_URI to point to our mirrors instead. Best, Markus 154509 2008-05-27 18:29 0000 http://www.frantz.fi/software/gperiodic.php gperiodic-2.0.10.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA4IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgoKaW5oZXJp dCB0b29sY2hhaW4tZnVuY3MKCkRFU0NSSVBUSU9OPSJQZXJpb2RpYyB0YWJsZSBhcHBsaWNhdGlv biBmb3IgTGludXgiClNSQ19VUkk9Imh0dHA6Ly93d3cuZnJhbnR6LmZpL3NvZnR3YXJlLyR7UH0u dGFyLmd6IgpIT01FUEFHRT0iaHR0cDovL3d3dy5mcmFudHouZmkvc29mdHdhcmUvZ3BlcmlvZGlj LnBocCIKCktFWVdPUkRTPSJ4ODYgYW1kNjQiClNMT1Q9IjAiCkxJQ0VOU0U9IkdQTC0yIgpJVVNF PSJubHMiCgpSREVQRU5EPSI+PXN5cy1saWJzL25jdXJzZXMtNS4yCgk9eDExLWxpYnMvZ3RrKy0y KgoJbmxzPyAoIHN5cy1kZXZlbC9nZXR0ZXh0ICkiCgpERVBFTkQ9IiR7UkRFUEVORH0KCQlkZXYt dXRpbC9wa2djb25maWciCgpzcmNfY29tcGlsZSgpIHsKCSMgVGhlIGF1dGhvciBoYXMgcmVtb3Zl ZCAidW5uZWNlc3NhcnkgYXV0b21ha2UvYXV0b2NvbmYgc2V0dXAiCgoJc2VkIC1pIC1lICJzfC1E R1RLX0RJU0FCTEVfREVQUkVDQVRFRHwke0NGTEFHU318IiBNYWtlZmlsZQoJc2VkIC1pIC1lICJ8 bWFrZSBjbGVhbnxkIiBNYWtlZmlsZQoJc2VkIC1pIC1lICJzfENDPWdjY3xDQz0kKHRjLWdldEND KXwiIE1ha2VmaWxlCglpZiAhIHVzZSBubHM7IHRoZW4KCQlzZWQgLWkgLWUgInxtYWtlIC1DIHBv fGQiIE1ha2VmaWxlCglmaQoJZW1ha2UgfHwgZGllICJlbWFrZSBmYWlsZWQhIgp9CgpzcmNfaW5z dGFsbCgpIHsKCXNlZCAtaSAtZSAic3wvdXNyL2Jpbnwke0R9L3Vzci9iaW58IiBNYWtlZmlsZQoJ c2VkIC1pIC1lICJzfC91c3Ivc2hhcmV8JHtEfS91c3Ivc2hhcmV8IiBNYWtlZmlsZQoJc2VkIC1p IC1lICJzfC91c3Ivc2hhcmV8JHtEfS91c3Ivc2hhcmV8IiBwby9NYWtlZmlsZQoKCSMgQ3JlYXRl IGRpcmVjdG9yaWVzIC0gTWFrZWZpbGUgaXMgcXVpdGUgYnJva2VuLgoJZG9kaXIgL3Vzci9iaW4K CWRvZGlyIC91c3Ivc2hhcmUvcGl4bWFwcwoJZG9kaXIgL3Vzci9zaGFyZS9hcHBsaWNhdGlvbnMK CgltYWtlIGluc3RhbGwgfHwgZGllICJtYWtlIGluc3RhbGwgZmFpbGVkLiIKCgkjIEZpeCBwZXJt aXNzaW9ucwoJY2htb2QgNjQ0ICIke0R9L3Vzci9zaGFyZS9waXhtYXBzLyoiCgljaG1vZCA2NDQg IiR7RH0vdXNyL3NoYXJlL2FwcGxpY2F0aW9ucy8qIgoKCSMgRml4IHRoZSBjaGVtaXN0cnkgY2F0 ZWdvcnkgaW4gdGhlIC5kZXNrdG9wIGZpbGUsIGJ1ZyA5NzIwMi4KCXNlZCAtaSAtZSAic3xDaGVt ZXN0cnl8Q2hlbWlzdHJ5fCIgIiR7RH0vdXNyL3NoYXJlL2FwcGxpY2F0aW9ucy9ncGVyaW9kaWMu ZGVza3RvcCIKCgkjIFRoZSBtYW4gcGFnZSBzZWVtcyB0byBoYXZlIGJlZW4gcmVtb3ZlZCB0b28u CiMJZG9tYW4gbWFuL2dwZXJpb2RpYy4xCglkb2RvYyBBVVRIT1JTIENoYW5nZUxvZyBSRUFETUUg TkVXUwoJbmV3ZG9jIHBvL1JFQURNRSBSRUFETUUudHJhbnNsYXRpb24KfQo=