220383 2008-05-05 15:20 0000 sys-block/gparted-0.3.7 : gksu dependancy not really needed 2008-06-15 18:56:27 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 mattepiu@gentoo.org gnome@gentoo.org nulleight@gmail.com mattepiu@gentoo.org 2008-05-05 15:20:06 0000 gksu is not really needed,and pulls in some gnome (not gtk!) deps: gnome-base/gconf, gnome-base/gnome-keyring, gnome-base/orbit, gnome-base/libgtop . Could it be made optional (under gnome use flag or whatever else you like) please? mattepiu@gentoo.org 2008-05-05 15:30:21 0000 Created an attachment (id=151939) gparted-0.3.7-ebuild.patch proposed patch to ebuild eva@gentoo.org 2008-05-05 16:18:09 0000 > "GParted is the Gnome Partition Editor" gksu has been added so that it's seemlessly integrated into the desktop like gdmsetup and some other gnome admin apps. Now why don't you want gksu ? It's lightweight compared to gtkmm. Please also add a emerge --tree gparted so I can better see your problem. mattepiu@gentoo.org 2008-05-05 19:23:03 0000 I don't have any problem and I just don't want any gnome dep, I'm using kdesu, I'm using -gnome as useflag, and gparted doesn't needs any of these deps (already tested the proposed ebuild, works flawlessy): emerge -pv --tree gparted [ebuild N ] sys-block/gparted-0.3.7 USE="fat ntfs reiserfs xfs -debug -hfs -jfs -reiser4" 0 kB [ebuild N ] x11-libs/gksu-2.0.0 USE="-debug -doc -gnome" 431 kB [ebuild N ] x11-libs/libgksu-2.0.5 USE="nls -debug -doc" 486 kB [ebuild N ] gnome-base/gnome-keyring-2.22.1 USE="hal pam -debug -doc -test" 938 kB [ebuild N ] gnome-base/gconf-2.22.0 USE="-debug -doc -ldap" 1,384 kB [ebuild N ] gnome-base/orbit-2.14.12 USE="-debug -doc" 729 kB [ebuild N ] gnome-base/libgtop-2.22.1 USE="-debug" 764 kB [ebuild N ] x11-libs/startup-notification-0.9 221 kB eva@gentoo.org 2008-05-05 20:19:56 0000 well I don't see anything shoking in these deps besides gnome-keyring which should probably be optional (but that's another story) the rest is non gui only. I'll probably go for USE="+gnome" but one last question just ouf of interest, why aren't you using qtparted if you don't want anything gnome ? mattepiu@gentoo.org 2008-05-06 14:41:50 0000 Sadly, qtparted is nearly unmaintained, just 2 releases since 2004, see: http://qtparted.sourceforge.net/changes.en.html also, I'm using gtk apps, what I have blocked is just gconf and such (too much ebuilds, too much little deps to keep track of, for me...) i92guboj@gentoo.org 2008-05-12 00:02:58 0000 Qtparted is nowhere near gparted. Qtparted is unmaintained, and it never worked well. To start with, why should we have dependencies installed if they are not really required? It might seem trivial for you, but this is the way I see it: ======================== # emerge -uva gparted These are the packages that would be merged, in order: Calculating dependencies... done! [ebuild U ] sys-kernel/linux-headers-2.6.25-r2 [2.6.25-r1] 9 kB [ebuild N ] gnome-base/gnome-common-2.20.0 USE="-debug" 63 kB [ebuild N ] app-admin/eselect-esd-20060719 2 kB [ebuild U ] app-editors/nano-2.1.1-r1 [2.1.1] USE="ncurses nls spell unicode -debug -justify -minimal -slang" 0 kB [ebuild N ] app-text/rarian-0.8.0-r1 USE="-debug" 331 kB [ebuild N ] app-text/scrollkeeper-9999 0 kB [ebuild U ] app-admin/sudo-1.6.9_p16 [1.6.9_p15] USE="pam -ldap -offensive (-selinux) -skey" 580 kB [ebuild U ] sys-apps/openrc-0.2.4 [0.2.3] USE="ncurses pam unicode -debug" 140 kB [ebuild U ] dev-lang/perl-5.8.8-r5 [5.8.8-r4] USE="-berkdb -build -debug -doc -gdbm -ithreads -perlsuid" 0 kB [ebuild N ] dev-perl/XML-NamespaceSupport-1.09 8 kB [ebuild N ] perl-core/Storable-2.16 170 kB [ebuild N ] perl-core/Test-Simple-0.80 80 kB [ebuild U ] perl-core/Test-Harness-3.10 [2.64] 0 kB [ebuild N ] dev-perl/XML-LibXML-Common-0.13 13 kB [ebuild N ] dev-perl/XML-SAX-0.16 59 kB [ebuild N ] virtual/perl-Test-Simple-0.80 0 kB [ebuild N ] virtual/perl-Storable-2.16 0 kB [ebuild N ] dev-perl/XML-LibXML-1.66 271 kB [ebuild N ] dev-perl/XML-Simple-2.18 70 kB [ebuild N ] x11-misc/icon-naming-utils-0.8.6 68 kB [ebuild N ] gnome-base/gnome-mime-data-2.18.0 USE="-debug" 593 kB [ebuild N ] x11-themes/gnome-icon-theme-2.22.0 USE="-debug" 3,581 kB [ebuild U ] x11-misc/util-macros-1.1.6-r1 [1.1.6] 0 kB [ebuild U ] dev-libs/libusb-0.1.12-r2 [0.1.12-r1] USE="-debug -doc" 0 kB [ebuild N ] sys-apps/acl-2.2.47 USE="nls (-nfs)" 152 kB [ebuild N ] app-text/sgml-common-0.6.3-r5 75 kB [ebuild N ] media-sound/esound-0.2.38-r1 USE="ipv6 -alsa -debug -doc -tcpd" 385 kB [ebuild U ] net-libs/gnutls-2.2.3 [2.2.2] USE="nls zlib -bindist -doc -guile -lzo" 4,805 kB [ebuild U ] x11-libs/xtrans-1.2 [1.0.4] USE="-debug" 0 kB [ebuild N ] app-text/docbook-xml-dtd-4.4-r1 94 kB [ebuild N ] app-text/gnome-doc-utils-0.12.2 USE="-debug" 582 kB [ebuild U ] x11-apps/xkbcomp-1.0.5 [1.0.4] USE="-debug" 197 kB [ebuild N ] gnome-base/libgtop-2.22.1 USE="-debug" 764 kB [ebuild N ] net-libs/libsoup-2.4.1 USE="ssl -debug -doc" 614 kB [ebuild N ] gnome-base/libbonobo-2.22.0 USE="-debug -doc" 1,412 kB [ebuild N ] gnome-base/gail-1.22.1 USE="-debug -doc" 659 kB [ebuild U ] x11-apps/xinit-1.0.8-r3 [1.0.8-r2] USE="hal minimal pam -debug" 0 kB [ebuild N ] gnome-base/gnome-vfs-2.22.0 USE="acl fam ipv6 kerberos -avahi -debug -doc -gnutls -hal -samba -ssl" 1,895 kB [ebuild N ] gnome-base/libgnome-2.22.0 USE="esd -debug -doc" 1,375 kB [ebuild N ] gnome-base/gvfs-0.2.3 USE="gnome hal -avahi -bluetooth -cdda -debug -doc -fuse -gnome-keyring -gphoto2 -samba" 811 kB [ebuild N ] x11-libs/libgksu-2.0.5 USE="nls -debug -doc" 486 kB [ebuild N ] gnome-base/libgnomecanvas-2.20.1.1 USE="X -debug -doc" 570 kB [ebuild U ] x11-drivers/xf86-video-nv-2.1.9 [2.1.8] USE="-debug" 377 kB [ebuild N ] gnome-base/libbonoboui-2.22.0 USE="X -debug -doc" 983 kB [ebuild N ] gnome-base/libgnomeui-2.22.1 USE="jpeg -debug -doc" 1,417 kB [ebuild N ] gnome-base/gnome-desktop-2.22.1 USE="-debug -doc" 1,410 kB [ebuild N ] gnome-base/eel-2.22.1 USE="X -debug" 599 kB [ebuild N ] gnome-base/nautilus-2.22.2 USE="X -beagle -debug -gnome -tracker" 4,915 kB [ebuild N ] x11-libs/gksu-2.0.0 USE="gnome -debug -doc" 431 kB [ebuild U ] sys-block/gparted-0.3.7 [0.3.6] USE="debug -fat -hfs -jfs -ntfs -reiser4 -reiserfs -xfs" 554 kB [ebuild UD] x11-drivers/nvidia-drivers-169.12 [173.08] USE="acpi custom-cflags gtk (-multilib)" 15,263 kB [1=>0] Total: 51 packages (14 upgrades, 1 downgrade, 36 new), Size of downloads: 46,845 kB ======================== Besides some updates, most stuff in that list is marked as 'N', which basically menas that it's being pulled into my system by gparted. There's absolutely no reason that justifies installing nautilus to get gparted. It's just nonsensical. I am not allergic to gnome nor gtk apps, but I don't feel like compiling a big monolith like nautilus every time that there's an update for it. For now, I will overlay this and add a -gnome use flag there. But this should be fixed in portage. Remember: that a given application's name start with a 'g' doesn't mean that the name of your desktop or window manager has also to start with a 'g'. And you should not force anyone to install gnome just because you think that the integration with gksu is a must. I kindly ask for a new use flag :) i92guboj@gentoo.org 2008-05-12 00:18:38 0000 Created an attachment (id=152885) gparted-0.3.7.ebuild Improved ebuild which also supports kdesu. Both can be turned on for those of use that don't need such things. It's a pure gtk program and it should not need gnome nor kde to run. Regards. ford_prefect@gentoo.org 2008-05-26 11:22:22 0000 (In reply to comment #7) > Created an attachment (id=152885) [edit] > gparted-0.3.7.ebuild > > Improved ebuild which also supports kdesu. Both can be turned on for those of > use that don't need such things. It's a pure gtk program and it should not need > gnome nor kde to run. Could you provide a patch against the current ebuild in-tree instead? It makes review a lot simpler. Thanks. nulleight@gmail.com 2008-06-14 11:25:32 0000 Here is the patch i did with `diff -Naur gparted-0.3.7.ebuild gparted-0.3.7-nogksudep.ebuild > patchfile` here is the `cat patchfile`: --- gparted-0.3.7.ebuild 2008-05-04 13:43:14.000000000 +0200 +++ gparted-0.3.7-nogksudep.ebuild 2008-06-14 15:15:39.000000000 +0200 @@ -12,13 +12,14 @@ LICENSE="GPL-2" SLOT="0" KEYWORDS="~amd64 ~ppc ~sparc ~x86" -IUSE="fat hfs jfs ntfs reiserfs reiser4 xfs" +IUSE="fat gnome hfs kde jfs ntfs reiserfs reiser4 xfs" common_depends=">=sys-apps/parted-1.7.1 >=dev-cpp/gtkmm-2.8.0" RDEPEND="${common_depends} - x11-libs/gksu + gnome? ( x11-libs/gksu ) + kde? ( kde-base/kdesu ) fat? ( sys-fs/dosfstools ) ntfs? ( sys-fs/ntfsprogs ) hfs? ( sys-fs/hfsutils ) @@ -34,5 +35,17 @@ src_unpack() { gnome2_src_unpack - sed -i "s:Exec=:Exec=gksu :" gparted.desktop.in.in + if use gnome + then + if use kde + then + die "Only one desktop might be enabled. Disable either gnome or kde." + fi + sed -i "s:Exec=:Exec=gksu :" gparted.desktop.in.in + fi + + if use kde + then + sed -i "s:Exec=:Exec=kdesu :" gparted.desktop.in.in + fi } ford_prefect@gentoo.org 2008-06-14 12:09:19 0000 This is just my opinion, but I think it is a bad thing that the ebuild dies if the user has both 'gnome' and 'kde' in USE. Perhaps the default should be to pick one (I'm partial towards 'gksu') if both are selected and throow an ewarn or einfo stating that it is doing so. Thoughts? nulleight@gmail.com 2008-06-14 13:52:37 0000 I also got this: [blocks B ] =kde-base/kdebase-3.5* (is blocking kde-base/kdesu-3.5.9) [blocks B ] kde-base/kdesu:3.5 (is blocking kde-base/kdebase-3.5.9-r4) I think the best way is just to remove kdesu dependency and have a system wide "su-something" script which will execute su/gksu/kdesu depending on environment or user preferences. remi@gentoo.org 2008-06-14 15:31:04 0000 What about 2 identical .desktop launchers but each with a line specifying which DE should be allowed to present it. I don't remember the exact syntax for it, but I'm pretty sure it can be done. nulleight@gmail.com 2008-06-14 15:33:41 0000 The fix for my problem would be - kde? ( kde-base/kdesu ) + kde? ( || ( kde-base/kdesu kde-base/kdebase ) ) Also if you think a su script would be a good idea i could try to write one. If there is no kdesu/gksu, one can launch xterm with su prompt like that: xterm -e /bin/su -c "program name" ford_prefect@gentoo.org 2008-06-14 16:25:44 0000 > Also if you think a su script would be a good idea i could try to write one. > If there is no kdesu/gksu, one can launch xterm with su prompt like that: > xterm -e /bin/su -c "program name" There's no guarantee that xterm will be present, really. nulleight@gmail.com 2008-06-15 12:45:53 0000 How about this: If there is no xterm in worst case it would leave the gparted shortcut alone. If both gnome and kde are enabled it will use gksu. I still think the global su script would be better because it would choose correct gksu/kdesu/xterm -c or something else at runtime and even after the user changed his dektop environment or preference without the need to edit gparted shortcut. --- gparted-0.3.7.ebuild 2008-05-04 13:43:14.000000000 +0200 +++ gparted-0.3.7-nogksudep.ebuild 2008-06-15 16:28:36.000000000 +0200 @@ -12,13 +12,14 @@ LICENSE="GPL-2" SLOT="0" KEYWORDS="~amd64 ~ppc ~sparc ~x86" -IUSE="fat hfs jfs ntfs reiserfs reiser4 xfs" +IUSE="fat gnome hfs kde jfs ntfs reiserfs reiser4 xfs" common_depends=">=sys-apps/parted-1.7.1 >=dev-cpp/gtkmm-2.8.0" RDEPEND="${common_depends} - x11-libs/gksu + gnome? ( x11-libs/gksu ) + kde? ( || ( kde-base/kdesu kde-base/kdebase ) ) fat? ( sys-fs/dosfstools ) ntfs? ( sys-fs/ntfsprogs ) hfs? ( sys-fs/hfsutils ) @@ -34,5 +35,16 @@ src_unpack() { gnome2_src_unpack - sed -i "s:Exec=:Exec=gksu :" gparted.desktop.in.in + if use gnome + then + sed -i "s:Exec=:Exec=gksu :" gparted.desktop.in.in + + elif use kde + then + sed -i "s:Exec=:Exec=kdesu :" gparted.desktop.in.in + + elif [[ -e "/usr/bin/xterm" ]] + then + sed -i "s:Exec=:Exec=xterm -e /bin/su -c :" parted.desktop.in.in + fi } eva@gentoo.org 2008-06-15 18:56:27 0000 since we don't have a magic unique helper for every DE, I've only took care of kde/gnome/xfce. If you don't have any of these you won't even see the entry anymore (because it makes no sense to show something that just throw an error like message at you). I've followed remi's suggestion which should work nicely, I hope it'll satisfy everyone. Closing for now. 151939 2008-05-05 15:30 0000 gparted-0.3.7-ebuild.patch gparted_ebuild.patch text/plain LS0tIGdwYXJ0ZWQtMC4zLjcuZWJ1aWxkLm9yaWcJMjAwOC0wNS0wNCAxMzo0MzoxNC4wMDAwMDAw MDAgKzAyMDAKKysrIGdwYXJ0ZWQtMC4zLjcuZWJ1aWxkCTIwMDgtMDUtMDUgMTg6MjY6MDYuMDAw MDAwMDAwICswMjAwCkBAIC0xMiwxMyArMTIsMTMgQEAKIExJQ0VOU0U9IkdQTC0yIgogU0xPVD0i MCIKIEtFWVdPUkRTPSJ+YW1kNjQgfnBwYyB+c3BhcmMgfng4NiIKLUlVU0U9ImZhdCBoZnMgamZz IG50ZnMgcmVpc2VyZnMgcmVpc2VyNCB4ZnMiCitJVVNFPSJmYXQgaGZzIGpmcyBudGZzIHJlaXNl cmZzIHJlaXNlcjQgeGZzIGdub21lIgogCiBjb21tb25fZGVwZW5kcz0iPj1zeXMtYXBwcy9wYXJ0 ZWQtMS43LjEKIAkJPj1kZXYtY3BwL2d0a21tLTIuOC4wIgogCiBSREVQRU5EPSIke2NvbW1vbl9k ZXBlbmRzfQotCQl4MTEtbGlicy9na3N1CisJCWdub21lPyAoIHgxMS1saWJzL2drc3UgKQogCQlm YXQ/ICggc3lzLWZzL2Rvc2ZzdG9vbHMgKQogCQludGZzPyAoIHN5cy1mcy9udGZzcHJvZ3MgKQog CQloZnM/ICggc3lzLWZzL2hmc3V0aWxzICkKQEAgLTM0LDUgKzM0LDcgQEAKIHNyY191bnBhY2so KSB7CiAJZ25vbWUyX3NyY191bnBhY2sKIAotCXNlZCAtaSAiczpFeGVjPTpFeGVjPWdrc3UgOiIg Z3BhcnRlZC5kZXNrdG9wLmluLmluCisJaWYgdXNlIGdub21lIDsgdGhlbgorCQlzZWQgLWkgInM6 RXhlYz06RXhlYz1na3N1IDoiIGdwYXJ0ZWQuZGVza3RvcC5pbi5pbgorCWZpCiB9Cg== 152885 2008-05-12 00:18 0000 gparted-0.3.7.ebuild gparted-0.3.7.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA4IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L3N5cy1ibG9jay9ncGFydGVkL2dwYXJ0ZWQtMC4z LjcuZWJ1aWxkLHYgMS4xIDIwMDgvMDUvMDQgMTE6NDM6MTQgZXZhIEV4cCAkCgppbmhlcml0IGV1 dGlscyBnbm9tZTIKCkRFU0NSSVBUSU9OPSJHbm9tZSBQYXJ0aXRpb24gRWRpdG9yIgpIT01FUEFH RT0iaHR0cDovL2dwYXJ0ZWQuc291cmNlZm9yZ2UubmV0LyIKClNSQ19VUkk9Im1pcnJvcjovL3Nv dXJjZWZvcmdlL2dwYXJ0ZWQvJHtQfS50YXIuYnoyIgoKTElDRU5TRT0iR1BMLTIiClNMT1Q9IjAi CktFWVdPUkRTPSJ+YW1kNjQgfnBwYyB+c3BhcmMgfng4NiIKSVVTRT0iZmF0IGdub21lIGhmcyBr ZGUgamZzIG50ZnMgcmVpc2VyZnMgcmVpc2VyNCB4ZnMiCgpjb21tb25fZGVwZW5kcz0iPj1zeXMt YXBwcy9wYXJ0ZWQtMS43LjEKCQk+PWRldi1jcHAvZ3RrbW0tMi44LjAiCgpSREVQRU5EPSIke2Nv bW1vbl9kZXBlbmRzfQoJCWdub21lPyAoIHgxMS1saWJzL2drc3UgKQoJCWtkZT8gKCBrZGUtYmFz ZS9rZGVzdSApCgkJZmF0PyAoIHN5cy1mcy9kb3Nmc3Rvb2xzICkKCQludGZzPyAoIHN5cy1mcy9u dGZzcHJvZ3MgKQoJCWhmcz8gKCBzeXMtZnMvaGZzdXRpbHMgKQoJCWpmcz8gKCBzeXMtZnMvamZz dXRpbHMgKQoJCXJlaXNlcmZzPyAoIHN5cy1mcy9yZWlzZXJmc3Byb2dzICkKCQlyZWlzZXI0PyAo IHN5cy1mcy9yZWlzZXI0cHJvZ3MgKQoJCXhmcz8gKCBzeXMtZnMveGZzcHJvZ3Mgc3lzLWZzL3hm c2R1bXAgKSIKCkRFUEVORD0iJHtjb21tb25fZGVwZW5kc30KCQk+PWRldi11dGlsL3BrZ2NvbmZp Zy0wLjEyCgkJPj1kZXYtdXRpbC9pbnRsdG9vbC0wLjM1LjUiCgpzcmNfdW5wYWNrKCkgewoJZ25v bWUyX3NyY191bnBhY2sKCglpZiB1c2UgZ25vbWUKCXRoZW4KCQlpZiB1c2Uga2RlCgkJdGhlbgoJ CQlkaWUgIk9ubHkgb25lIGRlc2t0b3AgbWlnaHQgYmUgZW5hYmxlZC4gRGlzYWJsZSBlaXRoZXIg Z25vbWUgb3Iga2RlLiIKCQlmaQoJCXNlZCAtaSAiczpFeGVjPTpFeGVjPWdrc3UgOiIgZ3BhcnRl ZC5kZXNrdG9wLmluLmluCglmaQoKCWlmIHVzZSBrZGUKCXRoZW4KCQlzZWQgLWkgInM6RXhlYz06 RXhlYz1rZGVzdSA6IiBncGFydGVkLmRlc2t0b3AuaW4uaW4KCWZpCn0K