217895 2008-04-16 03:23 0000 app-dicts/stardict-3.0.1 ebuild improvements and cleanup 2008-04-29 20:18:54 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 minor --- 73657 1 denilsonsa@gmail.com pva@gentoo.org cjk@gentoo.org dirk@liji-und-dirk.de denilsonsa@gmail.com 2008-04-16 03:23:17 0000 The current stardict-3.0.1 ebuild will build stardict with qqwry support, but won't download and install the required QQWry.Dat file. So, I've added a qqwry useflag that installs it. qqwry is some type of IP database. However, it appears to be in chinese language, or something like that. Considering that some people might find it useful, I think the useflag is the way to go. I've also added a "dodoc" command to add some documentation that is not installed by "make install". These are just 4 plaintext files. I'm attaching a diff to the current ebuild. Please take a look and update the ebuild in portage. It could also be possible to add a useflag to download and install WyabdcRealPeopleTTS, or maybe it would be better to add a new ebuild for it. It's a huge pack (81MB) of wav files. See http://stardict.sourceforge.net/download.php Well, in addition to these improvements, I think we can also do some cleanup. The "files/stardict-gentoo.patch" file can be safely deleted, because it is for stardict-1.3. There is also "files/stardict-gtk24.patch" which is for stardict-2.4.2, but does not follow the same naming convention of other patches. So I suggest to either rename this file or remove it and the 2.4.2 ebuild. denilsonsa@gmail.com 2008-04-16 03:24:16 0000 Created an attachment (id=149891) stardict-3.0.1.ebuild.diff My proposed changes. They work for me. denilsonsa@gmail.com 2008-04-16 04:06:35 0000 Oh, I just found that "play" command gives corrupted sound here, while "aplay" works well. Maybe we should write a patch to change the default "play" to "aplay"? pva@gentoo.org 2008-04-28 10:58:31 0000 Thank you for report Denilson. Take a look at just committed stardict-3.0.1-r1 it should contain most of fixes you suggest. The only change I've decided to ignore was to change play to aplay as I failed to reproduce/experience any problems with play and that is play bug in any case. If there is anything else we could improve, fill in new bugs! Thank you again. denilsonsa@gmail.com 2008-04-28 14:10:07 0000 (In reply to comment #3) > If there is anything else we could improve, fill in new bugs! I hope you don't mind if I post more comments/improvements in this bug (and reopen it). And these are really just small improvements (one about festival use flag, and another about qqwry use flag). Right now I wonder about the usefulness of festival useflag. It only adds a dependency, nothing else. So, maybe someone tries to enable this useflag, and only then finds that the plugin has not been built. Maybe that conditional message should be made unconditional. Maybe the useflag could be removed. I think that there should be an explanation why the festival plugin is disabled. Does it fail to compile? Does it segfault? I remember I read somewhere the reason why it is disabled (maybe inside stardict sources/docs?), but unfortunately I've already forgot why. $ euse -i festival [- ] festival (app-dicts/stardict): Enable festival text to speach plugin Hum... The festival description is a lie! The plugin is *not* being enabled. ;) $ euse -i qqwry [- ] qqwry (app-dicts/stardict): Enable QQWry plugin, which provides information about geographical position, owner, etc. for IP address I think you should say that qqwry displays information in chinese language. Otherwise, people will just enable it, look at that strange language, say WTF?, and then disable it. That's all. Thank you for improving stardict on portage. pva@gentoo.org 2008-04-28 15:54:29 0000 (In reply to comment #4) > Right now I wonder about the usefulness of festival useflag. Yes it just enables dependency... I see no problem with this. > I think that there should be an explanation why the festival plugin is > disabled. Does it fail to compile? Does it segfault? This's is described, read comments inside ebuild :) > $ euse -i festival > [- ] festival (app-dicts/stardict): > Enable festival text to speach plugin > > Hum... The festival description is a lie! The plugin is *not* being enabled. Ok, I've changed wording so now it does not states that we install plugin. > $ euse -i qqwry > [- ] qqwry (app-dicts/stardict): > Enable QQWry plugin, which provides information about geographical position, > owner, etc. for IP address > I think you should say that qqwry displays information in chinese language. Ok, I've added this too. Fixed again. Enjoy. :) dirk@liji-und-dirk.de 2008-04-29 11:30:42 0000 hmm, cleaning up the ebuild is good but unconditionally checking the use flag of a library not necessarily installed (no hard dependency on libgnome, only with gnome use flag) is really really bad as it breaks the ebuild for people not having installed gnome (or libgnome) pva@gentoo.org 2008-04-29 20:18:54 0000 (In reply to comment #6) > but unconditionally checking the use flag of a library not necessarily > installed (no hard dependency on libgnome, only with gnome use flag) is really > really bad as it breaks the ebuild for people not having installed gnome (or > libgnome) This was reported this morning in bug #219631 and was already fixed. 149891 2008-04-16 03:24 0000 stardict-3.0.1.ebuild.diff stardict-3.0.1.ebuild.diff text/plain LS0tIC9nZW50b28vcG9ydGFnZS9hcHAtZGljdHMvc3RhcmRpY3Qvc3RhcmRpY3QtMy4wLjEuZWJ1 aWxkCTIwMDgtMDQtMTQgMTM6MDc6MDMuMDAwMDAwMDAwIC0wMzAwCisrKyAvZ2VudG9vL292ZXJs YXkvYXBwLWRpY3RzL3N0YXJkaWN0L3N0YXJkaWN0LTMuMC4xLmVidWlsZAkyMDA4LTA0LTE2IDAw OjAwOjM0LjAwMDAwMDAwMCAtMDMwMApAQCAtOCwxMCArOCwxMSBAQAogIyAgICAgICB0aGVpciBp bmRleGVzIHNlZW0gdG8gYmUgaW4gYSBkaWZmZXJlbnQgZm9ybWF0LiBTbyB3ZSdsbCBrZWVwIHRo ZW0KICMgICAgICAgc2VwZXJhdGUgZm9yIG5vdy4KIAotSVVTRT0iZmVzdGl2YWwgZXNwZWFrIGdu b21lIGd1Y2hhcm1hcCBzcGVsbCIKK0lVU0U9ImZlc3RpdmFsIGVzcGVhayBnbm9tZSBndWNoYXJt YXAgcXF3cnkgc3BlbGwiCiBERVNDUklQVElPTj0iQSBHTk9NRTIgaW50ZXJuYXRpb25hbCBkaWN0 aW9uYXJ5IHN1cHBvcnRpbmcgZnV6enkgYW5kIGdsb2Igc3R5bGUgbWF0Y2hpbmciCiBIT01FUEFH RT0iaHR0cDovL3N0YXJkaWN0LnNvdXJjZWZvcmdlLm5ldC8iCi1TUkNfVVJJPSJtaXJyb3I6Ly9z b3VyY2Vmb3JnZS9zdGFyZGljdC8ke1B9LnRhci5iejIiCitTUkNfVVJJPSJtaXJyb3I6Ly9zb3Vy Y2Vmb3JnZS9zdGFyZGljdC8ke1B9LnRhci5iejIKKwlxcXdyeT8gKCBtaXJyb3I6Ly9zb3VyY2Vm b3JnZS9zdGFyZGljdC9RUVdyeS5EYXQuYnoyICkiCiAKIFJFU1RSSUNUPSJ0ZXN0IgogTElDRU5T RT0iR1BMLTIiCkBAIC01MywxMyArNTQsMjYgQEAKIAlHMkNPTkY9IiQodXNlX2VuYWJsZSBnbm9t ZSBnbm9tZS1zdXBwb3J0KQogCQkkKHVzZV9lbmFibGUgc3BlbGwpCiAJCSQodXNlX2VuYWJsZSBn dWNoYXJtYXApCi0JCSQodXNlX2VuYWJsZSBlc3BlYWsgZXNwZWFrKQorCQkkKHVzZV9lbmFibGUg ZXNwZWFrKQorCQkkKHVzZV9lbmFibGUgcXF3cnkpCiAJCS0tZGlzYWJsZS1mZXN0aXZhbAogCQkt LWRpc2FibGUtYWR2ZXJ0aXNlbWVudAogCQktLWRpc2FibGUtdXBkYXRlaW5mbyIKIAlnbm9tZTJf c3JjX2NvbXBpbGUKIH0KIAorc3JjX2luc3RhbGwoKSB7CisJZ25vbWUyX3NyY19pbnN0YWxsCisJ aWYgdXNlIHFxd3J5IDsgdGhlbgorCQlpbnNpbnRvIC91c3Ivc2hhcmUvc3RhcmRpY3QvZGF0YQor CQlkb2lucyAuLi9RUVdyeS5EYXQKKwlmaQorCWNkIGRvYworCWRvZG9jIEZBUSBIb3dUb0NyZWF0 ZURpY3Rpb25hcnkgU3RhckRpY3RGaWxlRm9ybWF0IFRyYW5zbGF0aW9uCisJIyBUaGlzIGlzIG9u bHkgdXNlZnVsIGZvciBkZXZlbG9wZXJzCisJI2RvZG9jIEhBQ0tJTkcKK30KKwogcGtnX3Bvc3Rp bnN0KCkgewogCWVsb2cgIk5vdGU6IGZlc3RpdmFsIHRleHQgdG8gc3BlYWNoIChUVFMpIHBsdWdp biBpcyBub3QgYnVpbHQuIFRvIHVzZSBmZXN0aXZhbCIKIAllbG9nICdUVFMgcGx1Z2luLCBwbGVh c2UsIGVuYWJsZSAiVXNlIFRUUyBwcm9ncmFtLiIgYXQ6Jwo=