215085 2008-03-27 17:43 0000 dev-games/ogre - Fix --as-needed with cg 2008-04-09 17:16:58 0000 1 1 1 Unclassified Gentoo Linux Games unspecified All Linux RESOLVED FIXED http://www.ogre3d.org P2 normal --- 129413 1 chewi@aura-online.co.uk games@gentoo.org Sander.Sweers@gmail.com chewi@aura-online.co.uk 2008-03-27 17:43:07 0000 Because of the way NVIDIA linked their Cg toolkit, building Ogre with the cg USE flag enabled and -Wl,--as-needed in your LDFLAGS doesn't work. Here's a new ebuild that filters the flags. chewi@aura-online.co.uk 2008-03-27 17:44:29 0000 Created an attachment (id=147461) ogre-1.4.7.ebuild Probably no point in incrementing the revision number. mr_bones_@gentoo.org 2008-04-08 16:47:40 0000 in portage. thanks for the bug report and patch. Sander.Sweers@gmail.com 2008-04-08 17:00:42 0000 Filtering --as-needed is just hiding a bug. It should either be left open or fixed. mr_bones_@gentoo.org 2008-04-08 17:04:37 0000 talk is cheap - patches welcome. chewi@aura-online.co.uk 2008-04-08 17:24:18 0000 The command that causes the error is... gcc -o conftest <CFLAGS> -Wl,--as-needed conftest.c -lCg -lILU -lIL -lpthread -lz -lm -ldl If you add (or move) -lpthread and -lm before the -Wl,--as-needed option then it works. Maybe you could do some trick with -Wl,--no-as-needed but you'd have to make sure that -Wl,--as-needed is added again afterwards and ONLY when it is wanted. It could be done but it wouldn't be too pretty. There are two lines in the configure script that add the -lCg option and they read LIBS="-lCg $LIBS". Maybe something could be done with this. Sander.Sweers@gmail.com 2008-04-08 18:43:22 0000 (In reply to comment #4) > talk is cheap - patches welcome. Sigh... (In reply to comment #5) > The command that causes the error is... > > gcc -o conftest <CFLAGS> -Wl,--as-needed conftest.c -lCg -lILU -lIL -lpthread > -lz -lm -ldl > > If you add (or move) -lpthread and -lm before the -Wl,--as-needed option then > it works. > > There are two lines in the configure script that add the -lCg option and they > read LIBS="-lCg $LIBS". Maybe something could be done with this. Probably changing the linking order from LIBS="-lCg $LIBS" to LIBS="$LIBS -lCg" will fix it. But I am not able to test that for another week. Could you have a go at it? chewi@aura-online.co.uk 2008-04-08 19:12:36 0000 I tried putting -lCg in various places before but that didn't work. It makes sense that you have to move -lm and -lpthread because Cg doesn't reference them when it should and so they must be linked regardless of whether they appear to be needed. chewi@aura-online.co.uk 2008-04-09 17:16:58 0000 Created an attachment (id=149213) ogre-1.4.7-as-needed.patch Okay I've come up with a very simple patch. We can get away with only modifying the configure test because libm and libpthread are actually "needed" by OGRE itself any other time that libCg is linked. Thanks to the way AC_CHECK_LIB works, it is easy to add extra arguments to the test. Apply this patch before the ce-gui patch. "-Xlinker --no-as-needed" was used rather than "-Wl,--no-as-needed" because the comma confuses autoconf. Sorry for the extra work, Mr Bones! 147461 2008-03-27 17:44 0000 ogre-1.4.7.ebuild ogre-1.4.7.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA4IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCmluaGVyaXQgZXV0aWxzIGF1dG90b29scyBmbGFnLW8tbWF0aWMKCkRFU0NSSVBUSU9O PSJPYmplY3Qtb3JpZW50ZWQgR3JhcGhpY3MgUmVuZGVyaW5nIEVuZ2luZSIKSE9NRVBBR0U9Imh0 dHA6Ly93d3cub2dyZTNkLm9yZy8iClNSQ19VUkk9Im1pcnJvcjovL3NvdXJjZWZvcmdlL29ncmUv b2dyZS1saW51eF9vc3gtdiR7UFYvLy4vLX0udGFyLmJ6MiIKCkxJQ0VOU0U9IkxHUEwtMi4xIgpT TE9UPSIwIgpLRVlXT1JEUz0ifmFtZDY0IH54ODYiCklVU0U9ImRvYyBjZWd1aSBjZyBkZXZpbCBk b3VibGUtcHJlY2lzaW9uIGV4YW1wbGVzIGd0ayBvcGVuZXhyIHRocmVhZHMiClJFU1RSSUNUPSJ0 ZXN0IiAjMTM5OTA1CgpSREVQRU5EPSJkZXYtbGlicy96emlwbGliCgk+PW1lZGlhLWxpYnMvZnJl ZXR5cGUtMgoJdmlydHVhbC9vcGVuZ2wKCXZpcnR1YWwvZ2x1Cgl4MTEtbGlicy9saWJYdAoJeDEx LWxpYnMvbGliWGF3Cgl4MTEtbGlicy9saWJYcmFuZHIKCXgxMS1saWJzL2xpYlgxMQoJY2VndWk/ ICggPj1kZXYtZ2FtZXMvY2VndWktMC41ICkKCWNnPyAoIG1lZGlhLWdmeC9udmlkaWEtY2ctdG9v bGtpdCApCglkZXZpbD8gKCBtZWRpYS1saWJzL2RldmlsICkKCWd0az8gKCA+PXgxMS1saWJzL2d0 aystMiApCglvcGVuZXhyPyAoIG1lZGlhLWxpYnMvb3BlbmV4ciApCgl0aHJlYWRzPyAoIGRldi1s aWJzL2Jvb3N0ICkiCkRFUEVORD0iJHtSREVQRU5EfQoJeDExLXByb3RvL3hmODZ2aWRtb2RlcHJv dG8KCWRldi11dGlsL3BrZ2NvbmZpZyIKClM9JHtXT1JLRElSfS9vZ3JlbmV3Cgpwa2dfc2V0dXAo KSB7CglpZiB1c2UgdGhyZWFkcyAmJiBoYXNfdmVyc2lvbiAiPGRldi1saWJzL2Jvb3N0LTEuMzQi ICYmIFwKCQkhIGJ1aWx0X3dpdGhfdXNlIGRldi1saWJzL2Jvb3N0IHRocmVhZHMKCXRoZW4KCQlk aWUgIlBsZWFzZSBlbWVyZ2UgZGV2LWxpYnMvYm9vc3Qgd2l0aCBVU0U9dGhyZWFkcyIKCWZpCn0K CnNyY191bnBhY2soKSB7Cgl1bnBhY2sgJHtBfQoJY2QgIiR7U30iCgllY3ZzX2NsZWFuCglpZiB1 c2UgZXhhbXBsZXMgOyB0aGVuCgkJY3AgLXIgU2FtcGxlcyBpbnN0YWxsLWV4YW1wbGVzIHx8IGRp ZQoJCWZpbmQgaW5zdGFsbC1leGFtcGxlcyBcCgkJCScoJyAtbmFtZSAnTWFrZWZpbGUqJyAtbyAt bmFtZSBvYmogLW8gXAoJCQkgICAgLW5hbWUgYmluIC1vIC1uYW1lICcqLmNicCcgLW8gLW5hbWUg JyoudmNwcm9qKicgJyknIFwKCQkJLXByaW50MCB8IHhhcmdzIC0wIHJtIC1yZgoJZmkKCXNlZCAt aSAnL0NQUFVOSVQvZCcgY29uZmlndXJlLmluIHx8IGRpZSAic2VkIGZhaWxlZCIKCWVwYXRjaCAi JHtGSUxFU0RJUn0iLyR7UH0tY2VndWkucGF0Y2gKCWVhdXRvcmVjb25mCn0KCnNyY19jb21waWxl KCkgewoJdXNlIGNnICYmIGZpbHRlci1sZGZsYWdzIC1XbCwtLWFzLW5lZWRlZAoKCWVjb25mIFwK CQktLWRpc2FibGUtZGVwZW5kZW5jeS10cmFja2luZyBcCgkJLS1kaXNhYmxlLWZyZWVpbWFnZSBc CgkJLS1kaXNhYmxlLW9ncmUtZGVtb3MgXAoJCS0tZW5hYmxlLXN0YXRpYyBcCgkJLS13aXRoLXBs YXRmb3JtPUdMWCBcCgkJLS13aXRoLWd1aT0kKHVzZXYgZ3RrIHx8IGVjaG8gWHQpIFwKCQkkKHVz ZV9lbmFibGUgY2VndWkpIFwKCQkkKHVzZV9lbmFibGUgY2cpIFwKCQkkKHVzZV9lbmFibGUgZGV2 aWwpIFwKCQkkKHVzZV9lbmFibGUgZG91YmxlLXByZWNpc2lvbiBkb3VibGUpIFwKCQkkKHVzZV9l bmFibGUgb3BlbmV4cikgXAoJCSQodXNlX2VuYWJsZSB0aHJlYWRzIHRocmVhZGluZykgXAoJCXx8 IGRpZQoJZW1ha2UgfHwgZGllICJlbWFrZSBmYWlsZWQiCn0KCnNyY19pbnN0YWxsKCkgewoJZW1h a2UgREVTVERJUj0iJHtEfSIgaW5zdGFsbCB8fCBkaWUgImVtYWtlIGluc3RhbGwgZmFpbGVkIgoJ aWYgdXNlIGRvYyA7IHRoZW4KCQlpbnNpbnRvIC91c3Ivc2hhcmUvZG9jLyR7UEZ9L2h0bWwKCQlk b2lucyAtciBEb2NzLyogfHwgZGllICJkb2lucyBEb2NzIGZhaWxlZCIKCWZpCglpZiB1c2UgZXhh bXBsZXMgOyB0aGVuCgkJaW5zaW50byAvdXNyL3NoYXJlL2RvYy8ke1BGfS9TYW1wbGVzCgkJZG9p bnMgLXIgaW5zdGFsbC1leGFtcGxlcy8qIHx8IGRpZSAiZG9pbnMgU2FtcGxlcyBmYWlsZWQiCglm aQoJZG9kb2MgQVVUSE9SUyBCVUdTIExJTlVYLkRFViBSRUFETUUKfQo= 149213 2008-04-09 17:16 0000 ogre-1.4.7-as-needed.patch ogre-1.4.7-as-needed.patch text/plain LS0tIGFjaW5jbHVkZS5tNC5vcmlnCTIwMDgtMDQtMDkgMTc6NDk6MzAuODQ4OTg3MDAwICswMTAw CisrKyBhY2luY2x1ZGUubTQJMjAwOC0wNC0wOSAxNzo1MzoyNS42NTIwNjgzNTkgKzAxMDAKQEAg LTM0MCw3ICszNDAsNyBAQAogCSogLS1kaXNhYmxlLWNnIHRvIHRoaXMgY29uZmlndXJlIHNjcmlw dCBidXQgdGhpcyBpcyBoaWdobHkgICAgICoKIAkqIGRpc2NvdXJhZ2VkIGFzIHRoaXMgYnJlYWtz IG1hbnkgb2YgdGhlIGV4YW1wbGVzLiAgICAgICAgICAgICAqCiAJKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKl0pCi0JKQorCSwt WGxpbmtlciAtLW5vLWFzLW5lZWRlZCkKIGZpCiAKIEFNX0NPTkRJVElPTkFMKEJVSUxEX0NHUExV R0lOLCB0ZXN0IHgkYnVpbGRfY2cgPSB4eWVzKQo=