215031 2008-03-27 11:44 0000 mail-filter/postgrey-1.31 init script doesn't work with openrc and it usually appears died 2008-05-21 18:46:16 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 mrfree@infinito.it net-mail@gentoo.org casta@xwing.info gentoo@obeliks.de gentoo@obfusc8.org neil@digimed.co.uk reuben-gentoo-bugzilla@reub.net mrfree@infinito.it 2008-03-27 11:44:34 0000 For the problem with OpenRC replacing the --exec args with the following is enough: start-stop-daemon --start --quiet --background \ --exec /usr/bin/perl -- -T -w /usr/sbin/postgrey \ --${POSTGREY_ADDR} \ --daemonize \ --pidfile=${POSTGREY_PID} \ ${POSTGREY_DELAY_ARG} \ ${POSTGREY_OPTS} \ "${POSTGREY_TEXT_ARG}" (I inverted the last two args as suggested in #213709 too) When the service starts (it happens with the in-tree init script too): * Starting Postgrey ... [ok] * start-stop-daemon: caught an interrupt [ok] but the daemon works well jakub@gentoo.org 2008-03-27 11:58:09 0000 Please, attach a unified diff next time; a whole lot easier to review any changes. dertobi123@gentoo.org 2008-04-06 15:43:41 0000 Fixed in CVS. gentoo@obfusc8.org 2008-04-08 12:51:44 0000 And this breaks without openrc, suggest you find some other way of fixing the problem than by breaking sysvinit. If there's another perl script running start-stop-daemon dies with '/usr/bin/perl already running'. Suggest reversion until someone comes up with a new fix for openrc. dertobi123@gentoo.org 2008-04-08 16:42:06 0000 uhrm, I did test this with both latest (stable) baselayout and openrc ... please give me a few more details on your setup please. gentoo@obfusc8.org 2008-04-08 19:19:48 0000 (In reply to comment #4) > uhrm, I did test this with both latest (stable) baselayout and openrc ... > please give me a few more details on your setup please. > # qlist -IvC baselayout sysvinit postgrey mail-filter/postgrey-1.31-r1 sys-apps/baselayout-1.12.11.1 sys-apps/sysvinit-2.86-r10 All latest stable as of yesterday except for postgrey. Error only occurs if there is another perl daemon running (I'm guessing spamd in my case, though I haven't bothered to trace it since calling /usr/sbin/postgrey directly instead of /usr/bin/perl resolved it for me. Anything further I can provide that will help you verify it? I guess I could strace it and post the log if you want, so you can see where the conflict occurs... dertobi123@gentoo.org 2008-04-10 17:09:50 0000 I reverted the change for now. If someone has a proper fix for this ... please post a diff ;) casta@xwing.info 2008-04-16 17:36:52 0000 Created an attachment (id=149963) postgrey-openrc-fix.patch I suggest adding a "--name" option to start-stop-daemon Seems to fix the problem with openrc. I have no baselayout 1.12 box to do a non-regression test, but I do not think it hurts... dertobi123@gentoo.org 2008-04-16 18:04:09 0000 (In reply to comment #7) > Created an attachment (id=149963) [edit] > postgrey-openrc-fix.patch > > I suggest adding a "--name" option to start-stop-daemon > Seems to fix the problem with openrc. I have no baselayout 1.12 box to do a > non-regression test, but I do not think it hurts... > tested on systems with both OpenRC plus baselayout 1.12 - working and committed to CVS. Thanks for your patch! gentoo@obeliks.de 2008-05-18 15:21:01 0000 (In reply to comment #7) > Created an attachment (id=149963) [edit] > postgrey-openrc-fix.patch > > I suggest adding a "--name" option to start-stop-daemon > Seems to fix the problem with openrc. I have no baselayout 1.12 box to do a > non-regression test, but I do not think it hurts... > I know this bug is closed, but I think the more elegant solution would be to use --pidfile with both start-stop-daemon and postgrey. After all, that's what the PID file is for ;) Patch coming right up. gentoo@obeliks.de 2008-05-18 15:21:56 0000 Created an attachment (id=153563) add --pidfile to start-stop-daemon in start() dertobi123@gentoo.org 2008-05-21 18:16:38 0000 (In reply to comment #10) > Created an attachment (id=153563) [edit] > add --pidfile to start-stop-daemon in start() > --pidfile is already set ... <-- snip --> start-stop-daemon --start --quiet --background \ --name postgrey \ --exec /usr/sbin/postgrey -- \ --${POSTGREY_ADDR} \ --daemonize \ --pidfile=${POSTGREY_PID} \ ${POSTGREY_DELAY_ARG} \ ${POSTGREY_OPTS} \ "${POSTGREY_TEXT_ARG}" eend ${?} <-- snip --> gentoo@obeliks.de 2008-05-21 18:31:12 0000 (In reply to comment #11) > (In reply to comment #10) > > Created an attachment (id=153563) [edit] > > add --pidfile to start-stop-daemon in start() > > > > --pidfile is already set ... --pidfile is set as a param to postgrey, which results in the pidfile being created in the first place. But if you also pass it to start-stop-daemon, it checks for the pidfile/pid instead of the name passed to --exec, which solves the mentioned problem (in a more elegant way than using --name, imho). Hence the patch. dertobi123@gentoo.org 2008-05-21 18:46:16 0000 (In reply to comment #12) > --pidfile is set as a param to postgrey, which results in the pidfile being > created in the first place. But if you also pass it to start-stop-daemon, it > checks for the pidfile/pid instead of the name passed to --exec, which solves > the mentioned problem (in a more elegant way than using --name, imho). Hence > the patch. > Missed that ... added the patch and added =postgrey-1.31-r2 to CVS. Thanks Bernhard! 149963 2008-04-16 17:36 0000 postgrey-openrc-fix.patch postgrey-openrc-fix.patch text/plain LS0tIGZpbGVzL3Bvc3RncmV5LnJjLm5ldy5vbGQJMjAwOC0wNC0xNiAxOTozMjo0Ny4wMDAwMDAw MDAgKzAyMDAKKysrIGZpbGVzL3Bvc3RncmV5LnJjLm5ldwkyMDA4LTA0LTE2IDE5OjM0OjA4LjAw MDAwMDAwMCArMDIwMApAQCAtNzYsNiArNzYsNyBAQAogCWZpCiAKIAlzdGFydC1zdG9wLWRhZW1v biAtLXN0YXJ0IC0tcXVpZXQgLS1iYWNrZ3JvdW5kIFwKKwkJLS1uYW1lIHBvc3RncmV5IFwKIAkJ LS1leGVjIC91c3Ivc2Jpbi9wb3N0Z3JleSAtLSBcCiAJCS0tJHtQT1NUR1JFWV9BRERSfSBcCiAJ CS0tZGFlbW9uaXplIFwK 153563 2008-05-18 15:21 0000 add --pidfile to start-stop-daemon in start() postgrey-initrc-pidfile.patch text/plain LS0tIHBvc3RncmV5ICAgICAgICAgICAyMDA4LTA1LTE4IDE3OjE4OjA5LjAwMDAwMDAwMCArMDIw MAorKysgcG9zdGdyZXkucGF0Y2hlZCAgIDIwMDgtMDUtMTggMTc6MTc6NTcuMDAwMDAwMDAwICsw MjAwCkBAIC03Niw2ICs3Niw3IEBACiAgICAgICAgZmkKCiAgICAgICAgc3RhcnQtc3RvcC1kYWVt b24gLS1zdGFydCAtLXF1aWV0IC0tYmFja2dyb3VuZCBcCisgICAgICAgICAgICAgICAtLXBpZGZp bGU9JHtQT1NUR1JFWV9QSUR9IFwKICAgICAgICAgICAgICAgIC0tZXhlYyAvdXNyL2Jpbi9wZXJs IC0tIC1UIC13IC91c3Ivc2Jpbi9wb3N0Z3JleSBcCiAgICAgICAgICAgICAgICAtLSR7UE9TVEdS RVlfQUREUn0gXAogICAgICAgICAgICAgICAgLS1kYWVtb25pemUgXAo=