210904 2008-02-20 17:19 0000 >=dev-lang/lua-5.1.3-r1 : sieve.lua test fails, patch provided 2008-05-16 16:14:30 0000 1 1 1 Unclassified Gentoo Linux Ebuilds 2007.0 AMD64 Linux RESOLVED FIXED P2 enhancement --- 1 oli.huber@gmail.com mabi@gentoo.org jer@gentoo.org oli.huber@gmail.com 2008-02-20 17:19:14 0000 the sieve test fail because math.mod seems to be depreciate : in src/luaconf.h : /* @@ LUA_COMPAT_MOD controls compatibility with old math.mod function. ** CHANGE it to undefined as soon as your programs use 'math.fmod' or ** the new '%' operator instead of 'math.mod'. */ #undef LUA_COMPAT_MOD So I replace math.mod with math.fmod in the test. oli.huber@gmail.com 2008-02-20 17:21:00 0000 Created an attachment (id=144135) replace math.mod with math.fmod in test/sieve.lua oli.huber@gmail.com 2008-02-20 17:21:53 0000 Created an attachment (id=144136) ebuild's diff oli.huber@gmail.com 2008-02-21 19:41:27 0000 Created an attachment (id=144257) lua.ebuild.patch In fact we need to patch only if use=deprecated is not enable. jer@gentoo.org 2008-05-15 18:29:42 0000 It would also be nice if we got rid of the ridiculous &> /dev/null in src_test(). If anything you'd want to _keep_ the output of a test, especially if it fails. Frankly, why anyone would ever put &> /dev/null in an ebuild is beyond me. Changing the summary as this hasn't been fixed in -r2. mabi@gentoo.org 2008-05-16 16:14:30 0000 Probably the &> /dev/null was introduced so the output looked nicer or whatever. I agree with you that it's silly, i removed it and included the patch for the test. Thanks Oliver! 144135 2008-02-20 17:21 0000 replace math.mod with math.fmod in test/sieve.lua lua-5.1.3-test.patch text/plain LS0tIHRlc3Qvc2lldmUubHVhfgkyMDAyLTEwLTMxIDAzOjUyOjU4LjAwMDAwMDAwMCArMDEwMAor KysgdGVzdC9zaWV2ZS5sdWEJMjAwOC0wMi0yMCAxNzo0NDoyMi40NjgyODExMjEgKzAxMDAKQEAg LTE0LDcgKzE0LDcgQEAKICAgICB3aGlsZSAxIGRvCiAgICAgICBsb2NhbCBuID0gZygpCiAgICAg ICBpZiBuID09IG5pbCB0aGVuIHJldHVybiBlbmQKLSAgICAgIGlmIG1hdGgubW9kKG4sIHApIH49 IDAgdGhlbiBjb3JvdXRpbmUueWllbGQobikgZW5kCisgICAgICBpZiBtYXRoLmZtb2QobiwgcCkg fj0gMCB0aGVuIGNvcm91dGluZS55aWVsZChuKSBlbmQKICAgICBlbmQKICAgZW5kKQogZW5kCg== 144136 2008-02-20 17:21 0000 ebuild's diff lua.ebuild.patch text/plain LS0tIC9wb3J0YWdlL3BvcnRhZ2UvZGV2LWxhbmcvbHVhL2x1YS01LjEuMy1yMS5lYnVpbGQJMjAw OC0wMi0xOCAyMTozNTo0MS4wMDAwMDAwMDAgKzAxMDAKKysrIGx1YS01LjEuMy1yMS5lYnVpbGQJ MjAwOC0wMi0yMCAxNzo1NzowMC4wMDAwMDAwMDAgKzAxMDAKQEAgLTIyLDYgKzIyLDcgQEAKIAog CWVwYXRjaCAiJHtGSUxFU0RJUn0iLyR7UE59LSR7UEFUQ0hfUFZ9LW1ha2UucGF0Y2gKIAllcGF0 Y2ggIiR7RklMRVNESVJ9Ii8ke1BOfS0ke1BBVENIX1BWfS1tb2R1bGVfcGF0aHMucGF0Y2gKKwll cGF0Y2ggIiR7RklMRVNESVJ9Ii8ke1B9LXRlc3QucGF0Y2gKIAogCUVQQVRDSF9TT1VSQ0U9IiR7 RklMRVNESVJ9LyR7UFZ9IiBFUEFUQ0hfU1VGRklYPSJ1cHN0cmVhbS5wYXRjaCIgZXBhdGNoCiAK 144257 2008-02-21 19:41 0000 lua.ebuild.patch lua.ebuild.patch text/plain LS0tIC91c3IvcG9ydGFnZS9kZXYtbGFuZy9sdWEvbHVhLTUuMS4zLXIxLmVidWlsZAkyMDA4LTAy LTE4IDIxOjM1OjQxLjAwMDAwMDAwMCArMDEwMAorKysgbHVhLTUuMS4zLXIxLmVidWlsZAkyMDA4 LTAyLTIxIDIwOjM3OjAwLjAwMDAwMDAwMCArMDEwMApAQCAtMzIsNiArMzIsNyBAQAogCiAJaWYg ISB1c2UgZGVwcmVjYXRlZCA7IHRoZW4KIAkJZXBhdGNoICIke0ZJTEVTRElSfSIvJHtQfS1kZXBy ZWNhdGVkLnBhdGNoCisJCWVwYXRjaCAiJHtGSUxFU0RJUn0iLyR7UH0tdGVzdC5wYXRjaAogCWZp CiAKIAlpZiAhIHVzZSByZWFkbGluZSA7IHRoZW4K