209055 2008-02-05 23:12 0000 net-misc/openvpn-2.1_rc6 fails to remove assigned address and exits 2008-04-16 17:52:17 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 217989 1 roy@marples.name alonbl@gentoo.org roy@marples.name 2008-02-05 23:12:13 0000 Feb 5 20:16:24 [openvpn] TUN/TAP device vpn opened Feb 5 20:16:24 [openvpn] TUN/TAP link layer address set to f0:01:aa:00:00:02 Feb 5 20:16:24 [openvpn] /sbin/ip link set dev vpn up mtu 1500 Feb 5 20:16:24 [openvpn] /sbin/ip addr add dev vpn 10.73.1.30/24 broadcast 10.73.1.255 Feb 5 20:16:24 [openvpn] /etc/openvpn/up.sh vpn 1500 1574 10.73.1.30 255.255.255.0 init Feb 5 20:16:24 [openvpn] Initialization Sequence Completed Feb 5 22:53:34 [openvpn] [marples.name] Inactivity timeout (--ping-restart), restarting Feb 5 22:53:34 [openvpn] /etc/openvpn/down.sh vpn 1500 1574 10.73.1.30 255.255.255.0 init Feb 5 22:53:34 [openvpn] /sbin/ip addr del dev vpn local 10.73.1.30 peer 255.255.255.0 Feb 5 22:53:34 [openvpn] Linux ip addr del failed: shell command exited with error status: 2 Feb 5 22:53:34 [openvpn] Exiting Basically, the ip command is wrong. The correct command is of course /sbin/ip addr del dev vpn local 10.73.1.30/24 as iproute2 does not understand 255.255.255.0 style netmasks. I also fail to see the point of the command, as the next command in the code removes the interface which does the same thing anyway! roy@marples.name 2008-02-05 23:15:28 0000 Created an attachment (id=142755) Don't bother removing ip addr from the interface roy@marples.name 2008-02-05 23:19:27 0000 Created an attachment (id=142756) Same as above, but doesn't require existing iproute2 patch alonbl@gentoo.org 2008-02-06 06:58:57 0000 Created an attachment (id=142774) tap-cleanup.patch Hi Roy, This is required in order to delete address from persistent interface and work completely unprivileged. Look for "Unprivileged mode" at the howto: http://openvpn.net/howto.html You are right! the tap interface is not handled correctly. Can you please test this out? Thanks! roy@marples.name 2008-02-06 10:24:48 0000 (In reply to comment #3) > This is required in order to delete address from persistent interface and work > completely unprivileged. And you've made that work only on Linux using iproute2? Last I checked, iproute2 was optional and ifconfig was the default. What other OS's like FreeBSD? alonbl@gentoo.org 2008-02-06 11:21:01 0000 > And you've made that work only on Linux using iproute2? Yes. It was the simplest to do this for iproute2. Does the patch works? > Last I checked, iproute2 was optional and ifconfig was the default. Still... No change. > What other OS's like FreeBSD? I don't know freebsd at all... But I got the impression that openvpn support only ifconfig configuration, am I wrong? BTW: Do you know how to set the privilege of tun interface in freebsd? roy@marples.name 2008-02-06 11:36:47 0000 Fails Feb 6 11:33:39 [openvpn] /etc/openvpn/down.sh vpn 1500 1574 10.73.1.30 255.255.255.0 init Feb 6 11:33:39 [openvpn] /sbin/ip addr add dev vpn 10.73.1.30/24 broadcast 10.73.1.255 Feb 6 11:33:39 [openvpn] Linux ip addr del failed: shell command exited with error status: 2 Why did you specify the broadcast? I told you the command to use above and broadcast isn't there. As to your other question - are you implying that you only need to remove the address with iproute2 and not ifconfig? If so, I'd love to know why you think so :) alonbl@gentoo.org 2008-02-06 12:07:52 0000 Created an attachment (id=142812) tap-cleanup.patch Roy, I am not an expert as you in the ifconfig/iproute stuff... Have I got this right this time? The ifconfig commands seems working... But I am not sure it is correct. Also... Why this has an ip6 address? config_tap1="null" # /etc/init.d/net.tap1 start * Bringing up interface tap1 * Running preup ... * Creating Tun/Tap interface tap1 ... [ok] * null ... [ok] * Waiting for IPv6 addresses ... [ok] # ifconfig tap1 tap1 Link encap:Ethernet HWaddr 00:FF:75:74:F6:A3 inet6 addr: fe80::2ff:75ff:fe74:f6a3/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:6 overruns:0 carrier:0 collisions:0 txqueuelen:100 RX bytes:0 (0.0 b) TX bytes:0 (0.0 b) roy@marples.name 2008-02-06 22:15:02 0000 I don't even need to run the patch to see it's wrong addr add Shouldn't that be del? And yes, ifconfig seems to do the right thing. Well, as best it can on Linux anyway. For the BSD's you can do this ifconfig tap1 inet 10.2.3.4/24 -alias The IPv6 address is a local link address and is automagically calculated by the kernel based on the hardware address. It's supposed to be there. alonbl@gentoo.org 2008-02-07 10:30:22 0000 Created an attachment (id=142862) tap-cleanup.patch True, sorry. I could not test this at that time. Can you please create a patch for BSD? Is it possible to change permission of tap in BSD? roy@marples.name 2008-02-07 11:31:23 0000 (In reply to comment #9) > Created an attachment (id=142862) [edit] > tap-cleanup.patch Better, but you also break non iproute2 systems by assuming the linux ifconfig style. I'm now testing it anyway with iproute2. > Can you please create a patch for BSD? > Is it possible to change permission of tap in BSD? Will take some time as I'm busy with my new daughter, but will try to. It *is* possible to change the permissions (ie, owner mode) of the tap interface in FreeBSD, but that's using a special config entry for devfs which OpenVPN shouldn't be touching. Plus it's FreeBSD specific. I'll see if I can find something for the other BSDs as I have a NetBSD box as well now. alonbl@gentoo.org 2008-02-07 12:00:37 0000 (In reply to comment #10) > Better, but you also break non iproute2 systems by assuming the linux ifconfig > style. I'm now testing it anyway with iproute2. This code is #ifdef for Linux... So it is OK... > Will take some time as I'm busy with my new daughter, but will try to. > It *is* possible to change the permissions (ie, owner mode) of the tap > interface in FreeBSD, but that's using a special config entry for devfs which > OpenVPN shouldn't be touching. Plus it's FreeBSD specific. I'll see if I can > find something for the other BSDs as I have a NetBSD box as well now. Great! alonbl@gentoo.org 2008-02-09 16:17:57 0000 Fixed, thanks! 142755 2008-02-05 23:15 0000 Don't bother removing ip addr from the interface openvpn.patch text/plain ZGlmZiAtdXIgb3BlbnZwbi0yLjFfcmM2Lm9yaWcvdHVuLmMgb3BlbnZwbi0yLjFfcmM2L3R1bi5j Ci0tLSBvcGVudnBuLTIuMV9yYzYub3JpZy90dW4uYwkyMDA4LTAyLTA1IDIzOjA5OjM2LjAwMDAw MDAwMCArMDAwMAorKysgb3BlbnZwbi0yLjFfcmM2L3R1bi5jCTIwMDgtMDItMDUgMjM6MTI6MzQu MDAwMDAwMDAwICswMDAwCkBAIC0xMjIwLDI2ICsxMjIwLDYgQEAKIHsKICAgaWYgKHR0KQogICAg IHsKLSNpZmRlZiBDT05GSUdfRkVBVFVSRV9JUFJPVVRFCi0JaWYgKHR0LT50eXBlICE9IERFVl9U WVBFX05VTEwgJiYgdHQtPmRpZF9pZmNvbmZpZykKLQkgIHsKLQkgICAgY2hhciBjb21tYW5kX2xp bmVbMjU2XTsKLQkgICAgc3RydWN0IGdjX2FyZW5hIGdjID0gZ2NfbmV3ICgpOwotCi0JICAgIG9w ZW52cG5fc25wcmludGYgKGNvbW1hbmRfbGluZSwgc2l6ZW9mIChjb21tYW5kX2xpbmUpLAotCQkJ ICAiJXMgYWRkciBkZWwgZGV2ICVzIGxvY2FsICVzIHBlZXIgJXMiLAotCQkJICBpcHJvdXRlX3Bh dGgsCi0JCQkgIHR0LT5hY3R1YWxfbmFtZSwKLQkJCSAgcHJpbnRfaW5fYWRkcl90ICh0dC0+bG9j YWwsIDAsICZnYyksCi0JCQkgIHByaW50X2luX2FkZHJfdCAodHQtPnJlbW90ZV9uZXRtYXNrLCAw LCAmZ2MpCi0JCQkgICk7Ci0KLQkgICAgbXNnIChNX0lORk8sICIlcyIsIGNvbW1hbmRfbGluZSk7 Ci0JICAgIHN5c3RlbV9jaGVjayAoY29tbWFuZF9saW5lLCBOVUxMLCBTX0ZBVEFMLCAiTGludXgg aXAgYWRkciBkZWwgZmFpbGVkIik7Ci0KLQkgICAgZ2NfZnJlZSAoJmdjKTsKLQkgIH0KLSNlbmRp ZgogICAgICAgY2xvc2VfdHVuX2dlbmVyaWMgKHR0KTsKICAgICAgIGZyZWUgKHR0KTsKICAgICB9 Cg== 142756 2008-02-05 23:19 0000 Same as above, but doesn't require existing iproute2 patch openvpn.patch text/plain ZGlmZiAtdXIgb3BlbnZwbi0yLjFfcmM2Lm9yaWcvdHVuLmMgb3BlbnZwbi0yLjFfcmM2L3R1bi5j Ci0tLSBvcGVudnBuLTIuMV9yYzYub3JpZy90dW4uYwkyMDA4LTAxLTIzIDIxOjA4OjQxLjAwMDAw MDAwMCArMDAwMAorKysgb3BlbnZwbi0yLjFfcmM2L3R1bi5jCTIwMDgtMDItMDUgMjM6MTc6NDYu MDAwMDAwMDAwICswMDAwCkBAIC0xMjIwLDE5ICsxMjIwLDYgQEAKIHsKICAgaWYgKHR0KQogICAg IHsKLSNpZmRlZiBDT05GSUdfRkVBVFVSRV9JUFJPVVRFCi0JY2hhciBjb21tYW5kX2xpbmVbMjU2 XTsKLQkvKgotCSAqIEZsdXNoIElQIGNvbmZpZ3VyYXRpb24gZm9yIHRoZSBkZXZpY2UKLQkgKi8K LQlvcGVudnBuX3NucHJpbnRmIChjb21tYW5kX2xpbmUsIHNpemVvZiAoY29tbWFuZF9saW5lKSwK LQkJCSAgIiVzIGFkZHIgZmx1c2ggZGV2ICVzIiwKLQkJCSAgaXByb3V0ZV9wYXRoLAotCQkJICB0 dC0+YWN0dWFsX25hbWUKLQkJCSAgKTsKLQltc2cgKE1fSU5GTywgIiVzIiwgY29tbWFuZF9saW5l KTsKLQlzeXN0ZW1fY2hlY2sgKGNvbW1hbmRfbGluZSwgTlVMTCwgU19GQVRBTCwgIkxpbnV4IGlw IGZsdXNoIGZhaWxlZCIpOwotI2VuZGlmCiAgICAgICBjbG9zZV90dW5fZ2VuZXJpYyAodHQpOwog ICAgICAgZnJlZSAodHQpOwogICAgIH0K 142774 2008-02-06 06:58 0000 tap-cleanup.patch tap-cleanup.patch text/plain SW5kZXg6IHR1bi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHR1bi5jCShyZXZpc2lvbiAyNzEzKQorKysgdHVu LmMJKHdvcmtpbmcgY29weSkKQEAgLTEyMjYsMTMgKzEyMjYsMjcgQEAKIAkgICAgY2hhciBjb21t YW5kX2xpbmVbMjU2XTsKIAkgICAgc3RydWN0IGdjX2FyZW5hIGdjID0gZ2NfbmV3ICgpOwogCi0J ICAgIG9wZW52cG5fc25wcmludGYgKGNvbW1hbmRfbGluZSwgc2l6ZW9mIChjb21tYW5kX2xpbmUp LAotCQkJICAiJXMgYWRkciBkZWwgZGV2ICVzIGxvY2FsICVzIHBlZXIgJXMiLAotCQkJICBpcHJv dXRlX3BhdGgsCi0JCQkgIHR0LT5hY3R1YWxfbmFtZSwKLQkJCSAgcHJpbnRfaW5fYWRkcl90ICh0 dC0+bG9jYWwsIDAsICZnYyksCi0JCQkgIHByaW50X2luX2FkZHJfdCAodHQtPnJlbW90ZV9uZXRt YXNrLCAwLCAmZ2MpCi0JCQkgICk7CisJICAgIGlmIChpc190dW5fcDJwICh0dCkpCisJICAgICAg eworCQlvcGVudnBuX3NucHJpbnRmIChjb21tYW5kX2xpbmUsIHNpemVvZiAoY29tbWFuZF9saW5l KSwKKwkJCSIlcyBhZGRyIGRlbCBkZXYgJXMgbG9jYWwgJXMgcGVlciAlcyIsCisJCQlpcHJvdXRl X3BhdGgsCisJCQl0dC0+YWN0dWFsX25hbWUsCisJCQlwcmludF9pbl9hZGRyX3QgKHR0LT5sb2Nh bCwgMCwgJmdjKSwKKwkJCXByaW50X2luX2FkZHJfdCAodHQtPnJlbW90ZV9uZXRtYXNrLCAwLCAm Z2MpCisJCQkpOworCSAgICAgIH0KKwkgICAgZWxzZQorCSAgICAgIHsKKwkJb3BlbnZwbl9zbnBy aW50ZiAoY29tbWFuZF9saW5lLCBzaXplb2YgKGNvbW1hbmRfbGluZSksCisJCQkiJXMgYWRkciBh ZGQgZGV2ICVzICVzLyVkIGJyb2FkY2FzdCAlcyIsCisJCQlpcHJvdXRlX3BhdGgsCisJCQl0dC0+ YWN0dWFsX25hbWUsCisJCQlwcmludF9pbl9hZGRyX3QgKHR0LT5sb2NhbCwgMCwgJmdjKSwKKwkJ CWNvdW50X25ldG1hc2tfYml0cyhwcmludF9pbl9hZGRyX3QgKHR0LT5yZW1vdGVfbmV0bWFzaywg MCwgJmdjKSksCisJCQlwcmludF9pbl9hZGRyX3QgKHR0LT5icm9hZGNhc3QsIDAsICZnYykKKwkJ CSk7CisJICAgICAgfQogCiAJICAgIG1zZyAoTV9JTkZPLCAiJXMiLCBjb21tYW5kX2xpbmUpOwog CSAgICBzeXN0ZW1fY2hlY2sgKGNvbW1hbmRfbGluZSwgTlVMTCwgU19GQVRBTCwgIkxpbnV4IGlw IGFkZHIgZGVsIGZhaWxlZCIpOwo= 142812 2008-02-06 12:07 0000 tap-cleanup.patch tap-cleanup.patch text/plain SW5kZXg6IHR1bi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHR1bi5jCShyZXZpc2lvbiAyNzEzKQorKysgdHVu LmMJKHdvcmtpbmcgY29weSkKQEAgLTEyMjAsMjYgKzEyMjAsNDQgQEAKIHsKICAgaWYgKHR0KQog ICAgIHsKLSNpZmRlZiBDT05GSUdfRkVBVFVSRV9JUFJPVVRFCiAJaWYgKHR0LT50eXBlICE9IERF Vl9UWVBFX05VTEwgJiYgdHQtPmRpZF9pZmNvbmZpZykKIAkgIHsKIAkgICAgY2hhciBjb21tYW5k X2xpbmVbMjU2XTsKIAkgICAgc3RydWN0IGdjX2FyZW5hIGdjID0gZ2NfbmV3ICgpOwogCisjaWZk ZWYgQ09ORklHX0ZFQVRVUkVfSVBST1VURQorCSAgICBpZiAoaXNfdHVuX3AycCAodHQpKQorCSAg ICAgIHsKKwkJb3BlbnZwbl9zbnByaW50ZiAoY29tbWFuZF9saW5lLCBzaXplb2YgKGNvbW1hbmRf bGluZSksCisJCQkiJXMgYWRkciBkZWwgZGV2ICVzIGxvY2FsICVzIHBlZXIgJXMiLAorCQkJaXBy b3V0ZV9wYXRoLAorCQkJdHQtPmFjdHVhbF9uYW1lLAorCQkJcHJpbnRfaW5fYWRkcl90ICh0dC0+ bG9jYWwsIDAsICZnYyksCisJCQlwcmludF9pbl9hZGRyX3QgKHR0LT5yZW1vdGVfbmV0bWFzaywg MCwgJmdjKQorCQkJKTsKKwkgICAgICB9CisJICAgIGVsc2UKKwkgICAgICB7CisJCW9wZW52cG5f c25wcmludGYgKGNvbW1hbmRfbGluZSwgc2l6ZW9mIChjb21tYW5kX2xpbmUpLAorCQkJIiVzIGFk ZHIgYWRkIGRldiAlcyAlcy8lZCIsCisJCQlpcHJvdXRlX3BhdGgsCisJCQl0dC0+YWN0dWFsX25h bWUsCisJCQlwcmludF9pbl9hZGRyX3QgKHR0LT5sb2NhbCwgMCwgJmdjKSwKKwkJCWNvdW50X25l dG1hc2tfYml0cyhwcmludF9pbl9hZGRyX3QgKHR0LT5yZW1vdGVfbmV0bWFzaywgMCwgJmdjKSkK KwkJCSk7CisJICAgICAgfQorI2Vsc2UKIAkgICAgb3BlbnZwbl9zbnByaW50ZiAoY29tbWFuZF9s aW5lLCBzaXplb2YgKGNvbW1hbmRfbGluZSksCi0JCQkgICIlcyBhZGRyIGRlbCBkZXYgJXMgbG9j YWwgJXMgcGVlciAlcyIsCi0JCQkgIGlwcm91dGVfcGF0aCwKLQkJCSAgdHQtPmFjdHVhbF9uYW1l LAotCQkJICBwcmludF9pbl9hZGRyX3QgKHR0LT5sb2NhbCwgMCwgJmdjKSwKLQkJCSAgcHJpbnRf aW5fYWRkcl90ICh0dC0+cmVtb3RlX25ldG1hc2ssIDAsICZnYykKLQkJCSAgKTsKKwkJCUlGQ09O RklHX1BBVEggIiVzIGFkZHIgMC4wLjAuMCIsCisJCQl0dC0+YWN0dWFsX25hbWUKKwkJCSk7Cisj ZW5kaWYKIAogCSAgICBtc2cgKE1fSU5GTywgIiVzIiwgY29tbWFuZF9saW5lKTsKIAkgICAgc3lz dGVtX2NoZWNrIChjb21tYW5kX2xpbmUsIE5VTEwsIFNfRkFUQUwsICJMaW51eCBpcCBhZGRyIGRl bCBmYWlsZWQiKTsKIAogCSAgICBnY19mcmVlICgmZ2MpOwogCSAgfQotI2VuZGlmCiAgICAgICBj bG9zZV90dW5fZ2VuZXJpYyAodHQpOwogICAgICAgZnJlZSAodHQpOwogICAgIH0K 142862 2008-02-07 10:30 0000 tap-cleanup.patch tap-cleanup.patch text/plain SW5kZXg6IHR1bi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHR1bi5jCShyZXZpc2lvbiAyNzEzKQorKysgdHVu LmMJKHJldmlzaW9uIDI3MTQpCkBAIC0xMjIwLDI2ICsxMjIwLDQ0IEBACiB7CiAgIGlmICh0dCkK ICAgICB7Ci0jaWZkZWYgQ09ORklHX0ZFQVRVUkVfSVBST1VURQogCWlmICh0dC0+dHlwZSAhPSBE RVZfVFlQRV9OVUxMICYmIHR0LT5kaWRfaWZjb25maWcpCiAJICB7CiAJICAgIGNoYXIgY29tbWFu ZF9saW5lWzI1Nl07CiAJICAgIHN0cnVjdCBnY19hcmVuYSBnYyA9IGdjX25ldyAoKTsKIAorI2lm ZGVmIENPTkZJR19GRUFUVVJFX0lQUk9VVEUKKwkgICAgaWYgKGlzX3R1bl9wMnAgKHR0KSkKKwkg ICAgICB7CisJCW9wZW52cG5fc25wcmludGYgKGNvbW1hbmRfbGluZSwgc2l6ZW9mIChjb21tYW5k X2xpbmUpLAorCQkJIiVzIGFkZHIgZGVsIGRldiAlcyBsb2NhbCAlcyBwZWVyICVzIiwKKwkJCWlw cm91dGVfcGF0aCwKKwkJCXR0LT5hY3R1YWxfbmFtZSwKKwkJCXByaW50X2luX2FkZHJfdCAodHQt PmxvY2FsLCAwLCAmZ2MpLAorCQkJcHJpbnRfaW5fYWRkcl90ICh0dC0+cmVtb3RlX25ldG1hc2ss IDAsICZnYykKKwkJCSk7CisJICAgICAgfQorCSAgICBlbHNlCisJICAgICAgeworCQlvcGVudnBu X3NucHJpbnRmIChjb21tYW5kX2xpbmUsIHNpemVvZiAoY29tbWFuZF9saW5lKSwKKwkJCSIlcyBh ZGRyIGRlbCBkZXYgJXMgJXMvJWQiLAorCQkJaXByb3V0ZV9wYXRoLAorCQkJdHQtPmFjdHVhbF9u YW1lLAorCQkJcHJpbnRfaW5fYWRkcl90ICh0dC0+bG9jYWwsIDAsICZnYyksCisJCQljb3VudF9u ZXRtYXNrX2JpdHMocHJpbnRfaW5fYWRkcl90ICh0dC0+cmVtb3RlX25ldG1hc2ssIDAsICZnYykp CisJCQkpOworCSAgICAgIH0KKyNlbHNlCiAJICAgIG9wZW52cG5fc25wcmludGYgKGNvbW1hbmRf bGluZSwgc2l6ZW9mIChjb21tYW5kX2xpbmUpLAotCQkJICAiJXMgYWRkciBkZWwgZGV2ICVzIGxv Y2FsICVzIHBlZXIgJXMiLAotCQkJICBpcHJvdXRlX3BhdGgsCi0JCQkgIHR0LT5hY3R1YWxfbmFt ZSwKLQkJCSAgcHJpbnRfaW5fYWRkcl90ICh0dC0+bG9jYWwsIDAsICZnYyksCi0JCQkgIHByaW50 X2luX2FkZHJfdCAodHQtPnJlbW90ZV9uZXRtYXNrLCAwLCAmZ2MpCi0JCQkgICk7CisJCQlJRkNP TkZJR19QQVRIICIlcyBhZGRyIDAuMC4wLjAiLAorCQkJdHQtPmFjdHVhbF9uYW1lCisJCQkpOwor I2VuZGlmCiAKIAkgICAgbXNnIChNX0lORk8sICIlcyIsIGNvbW1hbmRfbGluZSk7CiAJICAgIHN5 c3RlbV9jaGVjayAoY29tbWFuZF9saW5lLCBOVUxMLCBTX0ZBVEFMLCAiTGludXggaXAgYWRkciBk ZWwgZmFpbGVkIik7CiAKIAkgICAgZ2NfZnJlZSAoJmdjKTsKIAkgIH0KLSNlbmRpZgogICAgICAg Y2xvc2VfdHVuX2dlbmVyaWMgKHR0KTsKICAgICAgIGZyZWUgKHR0KTsKICAgICB9Cg==