20846 2003-05-12 09:10 0000 Hotplug 20030501 script errors 2003-06-07 09:30:35 0000 1 1 1 Unclassified Gentoo Linux Applications 1.4_rc1 x86 Linux RESOLVED FIXED P2 normal --- 1 deviantgeek@gmail.com zwelch@gentoo.org azarah@gentoo.org chadh@gentoo.org tigger@gentoo.org zwelch@gentoo.org deviantgeek@gmail.com 2003-05-12 09:10:53 0000 When hotplug starts up it errors out towards the end of it's run. although it completes with a successful status and it seems to work fine, there appears to be somthing missing from the script (maybe quotes?). Reproducible: Always Steps to Reproduce: 1. Emerge hotplug-20030501 2. Start hotplug 3. Actual Results: The following errors are echoed to the console (edited for space): /etc/hotplug/pci.agent: line 167: [: =: unary operator expected /etc/hotplug/usb.agent: line 167: [: =: unary operator expected Expected Results: No errors. Not sure where the error lies. Line 167 on usb.agent is a comment and in pci.agent, the script does not appear to be wrong. tigger@gentoo.org 2003-05-12 19:31:09 0000 Created an attachment (id=11861) Fixes the unary operator error The problem was caused by a text being run on an unquoted variable in /etc/hotplug/hotplug.functions The patch fixes that specific error, there may be more of those. I haven't checked. tigger@gentoo.org 2003-05-12 19:32:23 0000 That should have read "test being run" ;) And the line number the error gave was the line number in /etc/hotplug/hotplug.functions btw deviantgeek@gmail.com 2003-05-14 09:14:42 0000 Fixed. I thought there must have been some quotes missing somewhere but my brain was not functional at the time. Thanks. dpn@isomerica.net 2003-05-15 11:12:22 0000 I had the same problem; The patch fixes it for me as well. dnellans@cs.utah.edu 2003-05-27 11:23:18 0000 I'll thirdly confirm the bug and that this patch fixes it sucessfully. Can someone commit this to cvs for the next revision of hotplug? dave zwelch@gentoo.org 2003-05-27 18:38:27 0000 Fixed in hotplug-20030501-r1.ebuild. Enjoy. ian@abbott.org 2003-06-07 09:30:35 0000 Created an attachment (id=12913) A better patch to fix the underlying bug The previous patch merely hides the real bug, which is that the LOADED variable ought to be set to a value each time around the loop. I mentioned this yesterday on linux-hotplug-devel@lists.sourceforge.net along with the attached patch to fix the problem, and that has now been merged. 11861 2003-05-12 19:31 0000 Fixes the unary operator error hotplug.functions.patch text/plain LS0tIGhvdHBsdWcuZnVuY3Rpb25zLm9yaWcJMjAwMy0wNS0xMiAyMzoyMzo1MS4wMDAwMDAwMDAg KzAwMDAKKysrIGhvdHBsdWcuZnVuY3Rpb25zCTIwMDMtMDUtMTIgMjM6MjI6NTYuMDAwMDAwMDAw ICswMDAwCkBAIC0xNjQsNyArMTY0LDcgQEAKIAkgICAgTE9BREVEPXRydWUKIAlmaQogCi0JaWYg WyAkTE9BREVEID0gZmFsc2UgXTsgdGhlbgorCWlmIFsgIiRMT0FERUQiID0gZmFsc2UgXTsgdGhl bgogCSAgICBtZXNnICJtaXNzaW5nIGtlcm5lbCBvciB1c2VyIG1vZGUgZHJpdmVyICRNT0RVTEUg IgogCWZpCiAgICAgZG9uZQo= 12913 2003-06-07 09:30 0000 A better patch to fix the underlying bug hotplug.functions.diff text/plain LS0tIGV0Yy9ob3RwbHVnL2hvdHBsdWcuZnVuY3Rpb25zLm9yaWcgIDIwMDMtMDQtMTUKMTc6Mzg6 NDIuMDAwMDAwMDAwICswMTAwCisrKyBldGMvaG90cGx1Zy9ob3RwbHVnLmZ1bmN0aW9ucyAgICAg ICAyMDAzLTA2LTA2IAoxNDoxNjo0Ny4wMDAwMDAwMDAgKzAxMDAKQEAgLTEzMSwxMyArMTMxLDEz IEBACiAgICAgZm9yIE1PRFVMRSBpbiAkRFJJVkVSUwogICAgIGRvCiAgICAgICAgIyBtYXliZSBk cml2ZXIgbW9kdWxlcyBuZWVkIGxvYWRpbmcKKyAgICAgICBMT0FERUQ9ZmFsc2UKICAgICAgICBp ZiAhIGxzbW9kIHwgZ3JlcCAtcSAiXiRNT0RVTEUgIiA+IC9kZXYvbnVsbCAyPiYxOyB0aGVuCiAg ICAgICAgICAgIGlmIGdyZXAgLXEgIl4kTU9EVUxFXCQiICRIT1RQTFVHX0RJUi9ibGFja2xpc3Qg XAogICAgICAgICAgICAgICAgICAgID4vZGV2L251bGwgMj4mMTsgdGhlbgogICAgICAgICAgICAg ICAgZGVidWdfbWVzZyAiLi4uIGJsYWNrbGlzdGVkIG1vZHVsZTogICRNT0RVTEUiCiAgICAgICAg ICAgICAgICBjb250aW51ZQogICAgICAgICAgICBmaQotICAgICAgICAgICBMT0FERUQ9ZmFsc2UK CiAgICAgICAgICAgICMgc3RhdGljYWxseSBsaW5rZWQgbW9kdWxlcyBhcmVuJ3Qgc2hvd24gYnkg J2xzbW9kJywKICAgICAgICAgICAgIyBhbmQgdXNlciBtb2RlIGRyaXZlcnMgd2lsbCBPTkxZIGhh dmUgYSBzZXR1cCBzY3JpcHQ7Cg==