<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>20776</bug_id>
          
          <creation_ts>2003-05-10 23:49 0000</creation_ts>
          <short_desc>mhwaveeditor-1.2.1 (New Package)</short_desc>
          <delta_ts>2003-05-12 15:35:15 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>karl420@comcast.net</reporter>
          <assigned_to>avenj@gentoo.org</assigned_to>
          <cc>greg_g@gentoo.org</cc>
    
    <cc>karl420@comcast.net</cc>

      

      
          <long_desc isprivate="0">
            <who>karl420@comcast.net</who>
            <bug_when>2003-05-10 23:49:21 0000</bug_when>
            <thetext>mhWaveEditor is a wav (and a few other formats) editor. It can use GT2 or GTK1,
oss, sdl, libsndfile, and portsound.

http://www.mtek.chalmers.se/~hjormagn/mhwaveedit.html</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>karl420@comcast.net</who>
            <bug_when>2003-05-10 23:51:04 0000</bug_when>
            <thetext>Created an attachment (id=11781)
mhwaveeditor-1.2.1.ebuild
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>avenj@gentoo.org</who>
            <bug_when>2003-05-11 00:11:54 0000</bug_when>
            <thetext>I should be able to get to this soon.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>greg_g@gentoo.org</who>
            <bug_when>2003-05-11 06:58:14 0000</bug_when>
            <thetext>Created an attachment (id=11784)
How would I change the ebuild

Since you asked for feedback on gentoo-dev, here is how I would have written
the ebuild:

-# http://www.mtek.chalmers.se/~hjormagn/mhwaveedit-1.2.1.tar.gz
+# $Header: $

I think this line is needed to automatize insertion of headers (devs, correct
me if I&apos;m wrong)

-P=${PN}-${PV/_/}
-S=${WORKDIR}/${P}

Unneeded

-DEPEND=&quot;virtual/x11
-	gtk2? ( &gt;=x11-libs/gtk+-2.0.0 )
+DEPEND=&quot;gtk2? ( &gt;=x11-libs/gtk+-2.0.0 )

virtual/x11 is already a dependancy of gtk+

-	( &gt;=media-libs/libsdl-1.2.3 )
+	sdl? ( &gt;=media-libs/libsdl-1.2.3 )

Important!!

+	use sdl || myconf=&quot;${myconf} --without-sdl&quot;

Important!!

-	econf ${myconf} || die
+	econf ${myconf}

See `man 5 ebuild&apos;

And a little note: if someone uses alsa (has -oss) and has -sdl in USE, will
not be able to play wavs, and I don&apos;t know how to avoid that...

Bye! 
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>avenj@gentoo.org</who>
            <bug_when>2003-05-12 15:35:15 0000</bug_when>
            <thetext>Commited, thanks!</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>11781</attachid>
            <date>2003-05-10 23:51 0000</date>
            <desc>mhwaveeditor-1.2.1.ebuild</desc>
            <filename>mhwaveedit-1.2.1.ebuild</filename>
            <type>text/plain</type>
            <data encoding="base64">IyBDb3B5cmlnaHQgMTk5OS0yMDAzIEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli
dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHYy
CiMgaHR0cDovL3d3dy5tdGVrLmNoYWxtZXJzLnNlL35oam9ybWFnbi9taHdhdmVlZGl0LTEuMi4x
LnRhci5negoKSVVTRT0iZ3RrMiBvc3Mgc2RsIgpQPSR7UE59LSR7UFYvXy99ClM9JHtXT1JLRElS
fS8ke1B9CkRFU0NSSVBUSU9OPSJHVEsyIFNvdW5kIGZpbGUgZWRpdG9yICh3YXYsIGFuZCBhIGZl
dyBvdGhlcnMuKSIKU1JDX1VSST0iaHR0cDovL3d3dy5tdGVrLmNoYWxtZXJzLnNlL35oam9ybWFn
bi8ke1B9LnRhci5neiIKSE9NRVBBR0U9Imh0dHA6Ly93d3cubXRlay5jaGFsbWVycy5zZS9+aGpv
cm1hZ24vbWh3YXZlZWRpdC5odG1sIgoKU0xPVD0iMCIKTElTQ0VOU0U9IkdQTC0yIgpLRVlXT1JE
Uz0ieDg2IH5wcGMgfnNwYXJjICIKCkRFUEVORD0idmlydHVhbC94MTEKCWd0azI/ICggPj14MTEt
bGlicy9ndGsrLTIuMC4wICkKCSFndGsyPyAoID14MTEtbGlicy9ndGsrLTEuMiogKQoJKCA+PW1l
ZGlhLWxpYnMvbGlic2RsLTEuMi4zICkKCSggPj1tZWRpYS1saWJzL2xpYnNuZGZpbGUtMS4wLjEg
KQoJKCA+PW1lZGlhLWxpYnMvcG9ydGF1ZGlvLTE4ICkiCgpzcmNfY29tcGlsZSgpIHsKCWxvY2Fs
IG15Y29uZgoJCgl1c2UgZ3RrMiBcCgkJJiYgbXljb25mPSIke215Y29uZn0iIFwKCQl8fCBteWNv
bmY9IiR7bXljb25mfSAtLWRpc2FibGUtZ3RrMiIKCXVzZSBvc3MgXAoJCSYmIG15Y29uZj0iJHtt
eWNvbmZ9IiBcCgkJfHwgbXljb25mPSIke215Y29uZn0gLS13aXRob3V0LW9zcyIKCQoJZWNvbmYg
JHtteWNvbmZ9IHx8IGRpZQoJZW1ha2UgfHwgZGllCn0KCnNyY19pbnN0YWxsKCkgewoKCWVpbnN0
YWxsIHx8IGRpZQoKCWRvZG9jIENPUFlJTkcgQ2hhbmdlTG9nIEFVVEhPUlMgUkVBRE1FKiBORVdT
IEJVR1MKfQo=
</data>        

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>11784</attachid>
            <date>2003-05-11 06:58 0000</date>
            <desc>How would I change the ebuild</desc>
            <filename>my-proposal.diff</filename>
            <type>text/plain</type>
            <data encoding="base64">LS0tIG1od2F2ZWVkaXQtMS4yLjEuZWJ1aWxkLm9sZAkyMDAzLTA1LTExIDEyOjQ5OjA5LjAwMDAw
MDAwMCArMDIwMAorKysgbWh3YXZlZWRpdC0xLjIuMS5lYnVpbGQJMjAwMy0wNS0xMSAxMjo0Mjo1
NS4wMDAwMDAwMDAgKzAyMDAKQEAgLTEsMzYgKzEsMzEgQEAKICMgQ29weXJpZ2h0IDE5OTktMjAw
MyBHZW50b28gVGVjaG5vbG9naWVzLCBJbmMuCiAjIERpc3RyaWJ1dGVkIHVuZGVyIHRoZSB0ZXJt
cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgdjIKLSMgaHR0cDovL3d3dy5tdGVr
LmNoYWxtZXJzLnNlL35oam9ybWFnbi9taHdhdmVlZGl0LTEuMi4xLnRhci5negorIyAkSGVhZGVy
OiAkCiAKIElVU0U9Imd0azIgb3NzIHNkbCIKLVA9JHtQTn0tJHtQVi9fL30KLVM9JHtXT1JLRElS
fS8ke1B9CisKIERFU0NSSVBUSU9OPSJHVEsyIFNvdW5kIGZpbGUgZWRpdG9yICh3YXYsIGFuZCBh
IGZldyBvdGhlcnMuKSIKIFNSQ19VUkk9Imh0dHA6Ly93d3cubXRlay5jaGFsbWVycy5zZS9+aGpv
cm1hZ24vJHtQfS50YXIuZ3oiCiBIT01FUEFHRT0iaHR0cDovL3d3dy5tdGVrLmNoYWxtZXJzLnNl
L35oam9ybWFnbi9taHdhdmVlZGl0Lmh0bWwiCiAKIFNMT1Q9IjAiCiBMSVNDRU5TRT0iR1BMLTIi
Ci1LRVlXT1JEUz0ieDg2IH5wcGMgfnNwYXJjICIKK0tFWVdPUkRTPSJ4ODYgfnBwYyB+c3BhcmMi
CiAKLURFUEVORD0idmlydHVhbC94MTEKLQlndGsyPyAoID49eDExLWxpYnMvZ3RrKy0yLjAuMCAp
CitERVBFTkQ9Imd0azI/ICggPj14MTEtbGlicy9ndGsrLTIuMC4wICkKIAkhZ3RrMj8gKCA9eDEx
LWxpYnMvZ3RrKy0xLjIqICkKLQkoID49bWVkaWEtbGlicy9saWJzZGwtMS4yLjMgKQorCXNkbD8g
KCA+PW1lZGlhLWxpYnMvbGlic2RsLTEuMi4zICkKIAkoID49bWVkaWEtbGlicy9saWJzbmRmaWxl
LTEuMC4xICkKIAkoID49bWVkaWEtbGlicy9wb3J0YXVkaW8tMTggKSIKIAogc3JjX2NvbXBpbGUo
KSB7CiAJbG9jYWwgbXljb25mCiAJCi0JdXNlIGd0azIgXAotCQkmJiBteWNvbmY9IiR7bXljb25m
fSIgXAotCQl8fCBteWNvbmY9IiR7bXljb25mfSAtLWRpc2FibGUtZ3RrMiIKLQl1c2Ugb3NzIFwK
LQkJJiYgbXljb25mPSIke215Y29uZn0iIFwKLQkJfHwgbXljb25mPSIke215Y29uZn0gLS13aXRo
b3V0LW9zcyIKLQkKLQllY29uZiAke215Y29uZn0gfHwgZGllCisJdXNlIGd0azIgfHwgbXljb25m
PSIke215Y29uZn0gLS1kaXNhYmxlLWd0azIiCisJdXNlIG9zcyB8fCBteWNvbmY9IiR7bXljb25m
fSAtLXdpdGhvdXQtb3NzIgorCXVzZSBzZGwgfHwgbXljb25mPSIke215Y29uZn0gLS13aXRob3V0
LXNkbCIJCisKKwllY29uZiAke215Y29uZn0KIAllbWFrZSB8fCBkaWUKIH0KIAo=
</data>        

          </attachment>
    </bug>

</bugzilla>