206302 2008-01-17 08:43 0000 [PATCH] dev-libs/newt-0.52.7 fails to compile with uclibc due to missing libintl.h 2008-03-19 16:18:30 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 206088 1 natanael.copa@gmail.com embedded@gentoo.org xmerlin@gentoo.org natanael.copa@gmail.com 2008-01-17 08:43:35 0000 i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_GNU_SOURCE -I/usr/include/slang -c -o test.o test.c i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_GNU_SOURCE -I/usr/include/slang -c -o newt.o newt.c i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_GNU_SOURCE -I/usr/include/slang -c -o button.o button.c In file included from whiptail.c:12: nls.h:9:22: libintl.h: No such file or directory In file included from dialogboxes.c:12: nls.h:9:22: libintl.h: No such file or directory i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_GNU_SOURCE -I/usr/include/slang -c -o form.o form.c i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_GNU_SOURCE -I/usr/include/slang -c -o checkbox.o checkbox.c make: *** [depend] Error 1 make: *** Waiting for unfinished jobs.... NOTE: patches from #206088 needs to be applied first to be able to reproduce. natanael.copa@gmail.com 2008-01-17 08:45:39 0000 Created an attachment (id=141111) newt-0.52.7-nonls.patch Attatched patch fixes the problem. ... IUSE="gpm nls tcl" ... use nls || epatch "${FILESDIR}"/${P}-nonls.patch vapier@gentoo.org 2008-01-17 09:22:39 0000 there's no need to hack it out like that ... if it doesnt already have a standard --disable-nls option to key off of, add one and wrap the header logic in that natanael.copa@gmail.com 2008-01-17 09:45:28 0000 (In reply to comment #2) > there's no need to hack it out like that ... if it doesnt already have a > standard --disable-nls option to key off of, add one and wrap the header logic > in that > It does not have a standard --disable-nls option. Adding it would require gettext.m4 which is provided in gettext which is masked on uclibc. If upstream would do that for next release problem would be solved. There was no easy way to find out how to report things upstream (HOMEPAGE points to a major Linux distribution/vendor rather than a project page for newt) I went for the quick and dirty solution and moved on. natanael.copa@gmail.com 2008-01-17 10:15:00 0000 Got contact with upstream developer, mlichvar at redhat. Package uses autoconf but not automake so AM_GNU_GETTEXT will not work. vapier@gentoo.org 2008-01-17 10:21:13 0000 sorry, when i said "standard" i was merely referring to the user interface for building the package so you'd do AC_ARG_ENABLE(....nls..........) and handle the enable/disable stuff yourself rather than relying on adding gettext cruft does that make sense ? natanael.copa@gmail.com 2008-01-17 10:32:00 0000 (In reply to comment #5) > sorry, when i said "standard" i was merely referring to the user interface for > building the package > > so you'd do AC_ARG_ENABLE(....nls..........) and handle the enable/disable > stuff yourself rather than relying on adding gettext cruft > > does that make sense ? > yes. thanks! natanael.copa@gmail.com 2008-01-17 11:02:12 0000 Created an attachment (id=141126) newt-0.52.7-nonls.patch adds a standard --disable-nls option to the configure script. tested on uclibc x86 (without nls) and glibc amd64 (with nls). patch is submitted to upstream maintainer. vapier@gentoo.org 2008-01-17 15:45:02 0000 usually people macro away all functions when !NLS: # define setlocale(category,locale # define bindtextdomain(domainname, dirname) .... that way people dont need to sprinkle #ifdef checks throughout their code you should use AC_HELP_STRING([--disable-nls],[compile without NLS support]) otherwise i think this looks good and can be submitted upstream to see how they feel about it natanael.copa@gmail.com 2008-01-18 07:14:12 0000 (In reply to comment #8) > usually people macro away all functions when !NLS: > # define setlocale(category,locale > # define bindtextdomain(domainname, dirname) > .... > > that way people dont need to sprinkle #ifdef checks throughout their code Thanks for the tip! Will do this next time. > > you should use AC_HELP_STRING([--disable-nls],[compile without NLS support]) Don't think this is needed. It is already listed under "Optional Features" help text. > > otherwise i think this looks good and can be submitted upstream to see how they > feel about it > I already submitted upstream and he said he would apply it to his CVS. Thanks! vapier@gentoo.org 2008-01-18 10:57:38 0000 i'm not saying AC_HELP_STRING() will make any practical difference at all ... i'm saying that is the correct way for generating help strings in autotools rather than padding it with whitespace yourself natanael.copa@gmail.com 2008-01-24 10:36:34 0000 The patch is included in newt-0.52.8. http://koji.fedoraproject.org/koji/buildinfo?buildID=32661 natanael.copa@gmail.com 2008-03-17 12:51:56 0000 Could we either bump to 0.52.8 or commit this patch? Would be nice to close this bug. Thanks! xmerlin@gentoo.org 2008-03-19 16:18:30 0000 0.52.8 in cvs 141111 2008-01-17 08:45 0000 newt-0.52.7-nonls.patch newt-0.52.7-nonls.patch text/plain ZGlmZiAtcnUgbmV3dC0wLjUyLjcub3JpZy9ubHMuaCBuZXd0LTAuNTIuNy9ubHMuaAotLS0gbmV3 dC0wLjUyLjcub3JpZy9ubHMuaAkyMDA4LTAxLTE3IDA3OjMwOjIwICswMDAwCisrKyBuZXd0LTAu NTIuNy9ubHMuaAkyMDA4LTAxLTE3IDA3OjM1OjIwICswMDAwCkBAIC02LDggKzYsMTAgQEAKIAog IyBpbmNsdWRlIDxsb2NhbGUuaD4KIAotIyBpbmNsdWRlIDxsaWJpbnRsLmg+Ci0jIGRlZmluZSBf KFRleHQpIGdldHRleHQgKFRleHQpCisvLyMgaW5jbHVkZSA8bGliaW50bC5oPgorIyBkZWZpbmUg XyhUZXh0KSAoVGV4dCkKKyMgZGVmaW5lIGRnZXR0ZXh0KFBhY2thZ2UsIFN0cmluZykgKFN0cmlu ZykKKwogIyBpZmRlZiBnZXR0ZXh0X25vb3AKICMgIGRlZmluZSBOXyhTdHJpbmcpIGdldHRleHRf bm9vcCAoU3RyaW5nKQogIyBlbHNlCk9ubHkgaW4gbmV3dC0wLjUyLjc6IHB5dGhvbjIuNApPbmx5 IGluIG5ld3QtMC41Mi43OiBzaGFyZWQKZGlmZiAtcnUgbmV3dC0wLjUyLjcub3JpZy93aGlwdGFp bC5jIG5ld3QtMC41Mi43L3doaXB0YWlsLmMKLS0tIG5ld3QtMC41Mi43Lm9yaWcvd2hpcHRhaWwu YwkyMDA4LTAxLTE3IDA3OjMwOjIwICswMDAwCisrKyBuZXd0LTAuNTIuNy93aGlwdGFpbC5jCTIw MDgtMDEtMTcgMDc6MzE6NTAgKzAwMDAKQEAgLTM4OSwxMSArMzg5LDExIEBACiAJICAgIHsgInZl cnNpb24iLCAndicsIDAsICZ2ZXJzaW9uLCAwLCBOVUxMLCBOVUxMIH0sCiAJICAgIHsgMCwgMCwg MCwgMCwgMCB9IAogICAgIH07Ci0gICAKKy8qCiAgICAgc2V0bG9jYWxlIChMQ19BTEwsICIiKTsK ICAgICBiaW5kdGV4dGRvbWFpbiAoUEFDS0FHRSwgTE9DQUxFRElSKTsKICAgICB0ZXh0ZG9tYWlu IChQQUNLQUdFKTsKLQorKi8KICAgICBvcHRDb24gPSBwb3B0R2V0Q29udGV4dCgid2hpcHRhaWwi LCBhcmdjLCBhcmd2LCBvcHRpb25zVGFibGUsIDApOwogCiAgICAgd2hpbGUgKChhcmcgPSBwb3B0 R2V0TmV4dE9wdChvcHRDb24pKSA+IDApIHsK 141126 2008-01-17 11:02 0000 newt-0.52.7-nonls.patch newt-0.52.7-nonls.patch text/plain ZGlmZiAtcnUgbmV3dC0wLjUyLjcub3JpZy9jb25maWd1cmUuYWMgbmV3dC0wLjUyLjcvY29uZmln dXJlLmFjCi0tLSBuZXd0LTAuNTIuNy5vcmlnL2NvbmZpZ3VyZS5hYwkyMDA4LTAxLTE3IDEwOjQz OjM3ICswMDAwCisrKyBuZXd0LTAuNTIuNy9jb25maWd1cmUuYWMJMjAwOC0wMS0xNyAxMDo0NDoy MCArMDAwMApAQCAtMzUsNiArMzUsMTIgQEAKICAgQUNfREVGSU5FKFtVU0VfR1BNXSwgMSwgW0Rl ZmluZSB0byAxIGlmIEdQTSBzdXBwb3J0IGlzIGVuYWJsZWRdKQogZmkKIAorQUNfQVJHX0VOQUJM RShbbmxzXSwgWyAgLS1kaXNhYmxlLW5scyAgICAgICAgICAgY29tcGlsZSB3aXRob3V0IE5MUyBz dXBwb3J0XSkKKworaWYgdGVzdCAieCRlbmFibGVfbmxzIiAhPSAieG5vIjsgdGhlbgorICBBQ19E RUZJTkUoW0VOQUJMRV9OTFNdLCAxLCBbRGVmaW5lIHRvIDEgaWYgTkxTIHN1cHBvcnQgaXMgZW5h YmxlZF0pCitmaQorCiBBQ19DT05GSUdfRklMRVMoW01ha2VmaWxlXSkKIEFDX09VVFBVVAogCmRp ZmYgLXJ1IG5ld3QtMC41Mi43Lm9yaWcvbmxzLmggbmV3dC0wLjUyLjcvbmxzLmgKLS0tIG5ld3Qt MC41Mi43Lm9yaWcvbmxzLmgJMjAwOC0wMS0xNyAxMDo0MzozNyArMDAwMAorKysgbmV3dC0wLjUy LjcvbmxzLmgJMjAwOC0wMS0xNyAxMDo0Nzo0OSArMDAwMApAQCAtNiw4ICs2LDE0IEBACiAKICMg aW5jbHVkZSA8bG9jYWxlLmg+CiAKKyNpZmRlZiBFTkFCTEVfTkxTCiAjIGluY2x1ZGUgPGxpYmlu dGwuaD4KICMgZGVmaW5lIF8oVGV4dCkgZ2V0dGV4dCAoVGV4dCkKKyNlbHNlCisjIGRlZmluZSBf KFRleHQpIChUZXh0KQorIyBkZWZpbmUgZGdldHRleHQoUGFja2FnZSwgU3RyaW5nKSAoU3RyaW5n KQorI2VuZGlmCisKICMgaWZkZWYgZ2V0dGV4dF9ub29wCiAjICBkZWZpbmUgTl8oU3RyaW5nKSBn ZXR0ZXh0X25vb3AgKFN0cmluZykKICMgZWxzZQpkaWZmIC1ydSBuZXd0LTAuNTIuNy5vcmlnL3do aXB0YWlsLmMgbmV3dC0wLjUyLjcvd2hpcHRhaWwuYwotLS0gbmV3dC0wLjUyLjcub3JpZy93aGlw dGFpbC5jCTIwMDgtMDEtMTcgMTA6NDM6MzcgKzAwMDAKKysrIG5ld3QtMC41Mi43L3doaXB0YWls LmMJMjAwOC0wMS0xNyAxMDo0OTozNCArMDAwMApAQCAtMzg5LDEwICszODksMTIgQEAKIAkgICAg eyAidmVyc2lvbiIsICd2JywgMCwgJnZlcnNpb24sIDAsIE5VTEwsIE5VTEwgfSwKIAkgICAgeyAw LCAwLCAwLCAwLCAwIH0gCiAgICAgfTsKLSAgIAorCisjaWZkZWYgRU5BQkxFX05MUwogICAgIHNl dGxvY2FsZSAoTENfQUxMLCAiIik7CiAgICAgYmluZHRleHRkb21haW4gKFBBQ0tBR0UsIExPQ0FM RURJUik7CiAgICAgdGV4dGRvbWFpbiAoUEFDS0FHRSk7CisjZW5kaWYKIAogICAgIG9wdENvbiA9 IHBvcHRHZXRDb250ZXh0KCJ3aGlwdGFpbCIsIGFyZ2MsIGFyZ3YsIG9wdGlvbnNUYWJsZSwgMCk7 CiAK