204227 2008-01-04 01:17 0000 media-libs/faad2 will not exit if output pipe breaks 2008-05-08 12:08:23 0000 1 1 1 Unclassified Gentoo Linux Library unspecified All Linux RESOLVED FIXED P2 normal --- 1 lavajoe@gentoo.org sound@gentoo.org lavajoe@gentoo.org 2008-01-04 01:17:04 0000 If using the "-w" option in faad and piping to another program, faad will not exit if the other program quits before faad is done. This affects music servers that convert on-the-fly, since if a song is stopped, especially several times, faad processes will continue to eat CPU cycles until done. I will attach the patch. lavajoe@gentoo.org 2008-01-04 01:29:19 0000 Created an attachment (id=140008) files/faad2-2.6.1-broken-pipe.patch Here is a patch for 2.6.1. aballier@gentoo.org 2008-01-05 19:13:48 0000 Please send the patch upstream and ping me once its applied so that I just have to backport it. They're the ones the most able to review the patches. lavajoe@gentoo.org 2008-01-05 19:31:40 0000 OK, emailed - will file a bug there if requested or no response... Thanks! lavajoe@gentoo.org 2008-05-06 18:50:51 0000 (Oops, forgot to send this on when I got it...) Patch accepted by upstream and in their CVS; should be all set to incorporate. Here's email from upstream: ------------- Received by lavajoe on 03/24/2008 ---------- Hi Joe, Thanks a lot for the patch! I checked it and committed it to CVS. I applied some more patches this weekend, so I'll wait for some feedback and if everything is ok now, I will release some new packages. Best regards, Menno ------------- lavajoe@gentoo.org 2008-05-08 12:08:23 0000 Patch applied in faad2-2.6.1-r1 140008 2008-01-04 01:29 0000 files/faad2-2.6.1-broken-pipe.patch faad2-2.6.1-broken-pipe.patch text/plain LS0tIGZhYWQyL2Zyb250ZW5kL21haW4uY34JMjAwNy0xMS0wMSAwNjozMzoyOS4wMDAwMDAwMDAg LTA2MDAKKysrIGZhYWQyL2Zyb250ZW5kL21haW4uYwkyMDA4LTAxLTAzIDE4OjA1OjEwLjAwMDAw MDAwMCAtMDcwMApAQCAtNjQwLDcgKzY0MCw4IEBACiAKICAgICAgICAgaWYgKChmcmFtZUluZm8u ZXJyb3IgPT0gMCkgJiYgKGZyYW1lSW5mby5zYW1wbGVzID4gMCkgJiYgKCFhZHRzX291dCkpCiAg ICAgICAgIHsKLSAgICAgICAgICAgIHdyaXRlX2F1ZGlvX2ZpbGUoYXVmaWxlLCBzYW1wbGVfYnVm ZmVyLCBmcmFtZUluZm8uc2FtcGxlcywgMCk7CisgICAgICAgICAgICBpZiAod3JpdGVfYXVkaW9f ZmlsZShhdWZpbGUsIHNhbXBsZV9idWZmZXIsIGZyYW1lSW5mby5zYW1wbGVzLCAwKSA9PSAwKQor ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKICAgICAgICAgLyogZmlsbCBidWZm ZXIgKi8KQEAgLTk3Niw3ICs5NzcsOCBAQAogCiAgICAgICAgIGlmICgoZnJhbWVJbmZvLmVycm9y ID09IDApICYmIChzYW1wbGVfY291bnQgPiAwKSAmJiAoIWFkdHNfb3V0KSkKICAgICAgICAgewot ICAgICAgICAgICAgd3JpdGVfYXVkaW9fZmlsZShhdWZpbGUsIHNhbXBsZV9idWZmZXIsIHNhbXBs ZV9jb3VudCwgZGVsYXkpOworICAgICAgICAgICAgaWYgKHdyaXRlX2F1ZGlvX2ZpbGUoYXVmaWxl LCBzYW1wbGVfYnVmZmVyLCBzYW1wbGVfY291bnQsIGRlbGF5KSA9PSAwKQorICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGZyYW1lSW5mby5lcnJvciA+IDAp Cg==