203594 2007-12-28 17:40 0000 media-video/mplayer should only depend on x264-svn if both encode and x264 USE flags are enabled 2008-01-03 02:04:05 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 minor --- 1 hopeless@hamiltonshells.ca media-video@gentoo.org hopeless@hamiltonshells.ca 2007-12-28 17:40:12 0000 `emerge mplayer` pulls in media-libs/x264-svn if the "x264" USE flag is enabled, however it's not actually used if the "encode" USE flag is also enabled. From the ebuild (mplayer-1.0_rc2_p24929); if use encode; then use aac || myconf="${myconf} --disable-faac" use dv || myconf="${myconf} --disable-libdv" use x264 || myconf="${myconf} --disable-x264" else myconf="${myconf} --disable-mencoder --disable-libdv --disable-x264 \ --disable-faac" fi Interestingly, I have mplayer installed on two boxes, both with x264 in USE but only one with encode. x264-svn is pulled in in both cases, but as you can see it's disabled if mencoder isn't built, however `ldd /usr/bin/mplayer` on the box with encode in USE shows that the mplayer binary is actually linked to libx264.so as well as mencoder, suggesting the possiblity that mplayer itself makes use of it even without mencoder. I suggest either changing the ebuild to depend on x264-svn if the x264 USE flag is enabled irrespective of whether or not encode is also enabled, OR changing the depends so x264-svn is only pulled in if the encode flag is enabled as well as x264. Reproducible: Always hopeless@hamiltonshells.ca 2007-12-28 17:41:20 0000 That should read "however it's not actually used UNLESS the "encode" USE flag is also enabled. jakub@gentoo.org 2007-12-28 18:21:28 0000 Reopen with a patch or something instead of this messy description. hopeless@hamiltonshells.ca 2007-12-28 22:34:03 0000 Fair enough, I'll attach a patch to mplayer-1.0_rc2_p24929.ebuild so it only pulls in x264-svn if the encode USE flag is also active. Anyway, even if mplayer is compiled with libx264 support it still uses ffmpeg's ffh264 for playback by default. hopeless@hamiltonshells.ca 2007-12-28 22:35:09 0000 Created an attachment (id=139540) patch to fix the x264svn RDEPEND jakub@gentoo.org 2007-12-28 22:40:00 0000 Thanks, much more clear now... :) beandog@gentoo.org 2008-01-03 02:04:05 0000 Fixed in CVS, thanks 139540 2007-12-28 22:35 0000 patch to fix the x264svn RDEPEND mplayer_x264depends.patch text/plain LS0tIG1wbGF5ZXItMS4wX3JjMl9wMjQ5MjkuZWJ1aWxkLm9yaWcJMjAwNy0xMi0yOCAyMjoyNDo0 Ni4wMDAwMDAwMDAgKzAwMDAKKysrIG1wbGF5ZXItMS4wX3JjMl9wMjQ5MjkuZWJ1aWxkCTIwMDct MTItMjggMjI6MjU6MzYuMDAwMDAwMDAwICswMDAwCkBAIC02MSw2ICs2MSw3IEBACiAJCWFhYz8g KCBtZWRpYS1saWJzL2ZhYWMgKQogCQltcDI/ICggbWVkaWEtc291bmQvdHdvbGFtZSApCiAJCW1w Mz8gKCBtZWRpYS1zb3VuZC9sYW1lICkKKwkJeDI2ND8gKCBtZWRpYS1saWJzL3gyNjQtc3ZuICkK IAkJKQogCWVzZD8gKCBtZWRpYS1zb3VuZC9lc291bmQgKQogCWVuY2E/ICggYXBwLWkxOG4vZW5j YSApCkBAIC05NSw3ICs5Niw2IEBACiAJCW1lZGlhLWxpYnMvZm9udGNvbmZpZyApCiAJdmlkaXg/ ICggeDExLWxpYnMvbGliWHhmODZ2bQogCQkJIHgxMS1saWJzL2xpYlhleHQgKQotCXgyNjQ/ICgg bWVkaWEtbGlicy94MjY0LXN2biApCiAJeGFuaW0/ICggbWVkaWEtdmlkZW8veGFuaW0gKQogCXhp bmVyYW1hPyAoIHgxMS1saWJzL2xpYlhpbmVyYW1hCiAJCXgxMS1saWJzL2xpYlh4Zjg2dm0K