<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>201951</bug_id>
          
          <creation_ts>2007-12-11 14:37 0000</creation_ts>
          <short_desc>patch pinentry-0.7.2-grab.patch breaks app-crypt/pinentry 0.7.3 when using compiz</short_desc>
          <delta_ts>2007-12-22 05:21:16 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Applications</component>
          <version>2007.0</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>ghepeu@virgilio.it</reporter>
          <assigned_to>swegener@gentoo.org</assigned_to>
          <cc>crypto@gentoo.org</cc>
    
    <cc>gentoo@profvince.com</cc>
    
    <cc>griffon26@gentoo.org</cc>
    
    <cc>hanno@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>ghepeu@virgilio.it</who>
            <bug_when>2007-12-11 14:37:11 0000</bug_when>
            <thetext>The patch pinentry-0.7.2-grab.patch works reliably with pinentry 0.7.3 and metacity but breaks pinentry when using compiz 0.6.2. 
The passphrase is accepted when I use the [Enter] key but if I click on the OK button pinentry crashes.
Commenting out the relevant epatch line from the ebuild and rebulding pinentry fixes this problem.

Reproducible: Always</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>ghepeu@virgilio.it</who>
            <bug_when>2007-12-20 23:19:13 0000</bug_when>
            <thetext>The same&apos;s true for pinentry 0.7.4.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alonbl@gentoo.org</who>
            <bug_when>2007-12-21 06:47:38 0000</bug_when>
            <thetext>Any clue what the difference is?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alonbl@gentoo.org</who>
            <bug_when>2007-12-21 23:29:30 0000</bug_when>
            <thetext>This is following bug#165493.

I am no gtk+ developer... I tried to play with these events...

map-event is issued too early for some users... So grab does not work.
expose-event is issued too many times during session, so it may cause the behavior we see here.

I tried to add gdk_event_get_graphics_expose() at the map-expose event handler, but then it stacked.

I tried to see if there is another event happening after map-event, and found focus-in-event that already used if nograb is used.

I don&apos;t really understand the function of the map-event here...
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alonbl@gentoo.org</who>
            <bug_when>2007-12-21 23:32:29 0000</bug_when>
            <thetext>Created an attachment (id=139069)
pinentry-0.7.4-grab.patch

I think this patch is &quot;good enough&quot;, it handles focus-in/focus-out-event and grab the keyboard if requested.

The extra protection of early grab set is dropped... But if it works, I think it will do.

Can you all check if it works?
</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>griffon26@gentoo.org</who>
            <bug_when>2007-12-22 01:07:03 0000</bug_when>
            <thetext>This patch works perfectly for me.

It turns out that with the previous patch pinentry crashed for me as well when clicking OK. I only tested with the enter key before. 

I&apos;m not running compiz though and disabling the composite extension did not make a difference.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>alonbl@gentoo.org</who>
            <bug_when>2007-12-22 05:21:16 0000</bug_when>
            <thetext>OK.
Closing this.
If someone has a better solution please reopen.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>139069</attachid>
            <date>2007-12-21 23:32 0000</date>
            <desc>pinentry-0.7.4-grab.patch</desc>
            <filename>pinentry-0.7.4-grab.patch</filename>
            <type>text/plain</type>
            <data encoding="base64">ZGlmZiAtdXJOcCBwaW5lbnRyeS0wLjcuNC9ndGsrLTIvcGluZW50cnktZ3RrLTIuYyBwaW5lbnRy
eS0wLjcuNC5uZXcvZ3RrKy0yL3BpbmVudHJ5LWd0ay0yLmMKLS0tIHBpbmVudHJ5LTAuNy40L2d0
aystMi9waW5lbnRyeS1ndGstMi5jCTIwMDctMTEtMjkgMDA6NTc6NTUuMDAwMDAwMDAwICswMjAw
CisrKyBwaW5lbnRyeS0wLjcuNC5uZXcvZ3RrKy0yL3BpbmVudHJ5LWd0ay0yLmMJMjAwNy0xMi0y
MCAyMjozODowNS4wMDAwMDAwMDAgKzAyMDAKQEAgLTI2MSwxMCArMjYxLDEwIEBAIGNyZWF0ZV93
aW5kb3cgKGludCBjb25maXJtX21vZGUpCiAgIGlmICghY29uZmlybV9tb2RlKQogICAgIHsKICAg
ICAgIGdfc2lnbmFsX2Nvbm5lY3QgKEdfT0JKRUNUICh3aW4pLAotCQkJcGluZW50cnktPmdyYWIg
PyAibWFwLWV2ZW50IiA6ICJmb2N1cy1pbi1ldmVudCIsCisJCQkiZm9jdXMtaW4tZXZlbnQiLAog
CQkJR19DQUxMQkFDSyAoZ3JhYl9rZXlib2FyZCksIE5VTEwpOwogICAgICAgZ19zaWduYWxfY29u
bmVjdCAoR19PQkpFQ1QgKHdpbiksCi0JCQlwaW5lbnRyeS0+Z3JhYiA/ICJ1bm1hcC1ldmVudCIg
OiAiZm9jdXMtb3V0LWV2ZW50IiwKKwkJCSJmb2N1cy1vdXQtZXZlbnQiLAogCQkJR19DQUxMQkFD
SyAodW5ncmFiX2tleWJvYXJkKSwgTlVMTCk7CiAgICAgfQogICBndGtfd2luZG93X2FkZF9hY2Nl
bF9ncm91cCAoR1RLX1dJTkRPVyAod2luKSwgYWNjKTsK
</data>        

          </attachment>
    </bug>

</bugzilla>