199730 2007-11-20 06:45 0000 app-office/gnucash-2.2.1-r1 does not install icon 2007-12-18 14:34:05 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 trivial --- 1 tetromino@gmail.com tove@gentoo.org jsled-gentoo@asynchronous.org tetromino@gmail.com 2007-11-20 06:45:39 0000 gnucash-2.2.1 (unlike 2.0.x series) does not install a png or svg icon for its desktop menu entry; gnucash.desktop says Icon=gnucash-icon, but there is no gnucash-icon.png installed. Instead, gnucash ebuild sticks gnucash-icon.ico in /usr/share/pixmaps, but that doesn't help since .ico files cannot be read by current Gnome application menu. Solution is to add src_install() { gnome2_src_install newicon "src/pixmaps/gnucash-icon-48x48.png" "gnucash-icon.png" } to the ebuild. jsled-gentoo@asynchronous.org 2007-11-20 16:55:33 0000 It'd be nicer to use the svg version, if possible. tove@gentoo.org 2007-11-20 17:57:19 0000 Please help me: 1) Josh, this seems to be an upstream problem. You deliver a .desktop file with an Icon that doesn't match. Can you fix it? 2) The svg version is this one -> http://svn.gnucash.org/trac/browser/gnucash/trunk/art/tango/scalable/gnucash.svg It's not in the tarball but we can fetch it (and mirror it). Does the svg version work in every desktop environment? As i can only find 2 other .svg files in my /usr/share/pixmaps. tetromino@gmail.com 2007-11-20 22:22:55 0000 Created an attachment (id=136553) gnucash-2.2.1-icons.patch" After looking at this a bit more, this is basically a bug in the gnucash build system. The gnucash program uses gnucash-icon-*x*.png files (which it installs in /usr/share/gnucash/pixmaps). Mistakenly, it then additionally installs them into /usr/share/pixmaps, thinking that the menu system will pick them up to display the desktop icon. However, the menu system expects a file called "gnucash-icon.png". To use multiple sizes, "gnucash-icon.png" has to be present in multiple directories under /usr/share/icons. So the correct solution is to change the makefile to copy the differently-sized icons under the right name to the right subdirectories of /usr/share/icons. Patch attached. tetromino@gmail.com 2007-11-20 22:30:13 0000 So with the above patch, you should not install anything into /usr/share/pixmaps any more (so you ignore my first comment about src_install). And if you do want to install the svg version, it should go into /usr/share/icons/hicolor/scalable/apps/gnucash-icon.svg, and then the the svg-compatible menu systems will pick it up. jsled-gentoo@asynchronous.org 2007-12-16 17:38:37 0000 Upstream: http://bugzilla.gnome.org/show_bug.cgi?id=503889 tove@gentoo.org 2007-12-18 12:28:18 0000 gnucash-2.2.2 is in the tree with the icons patch. I have also added the svg icon. Thanks to Alex, for reporting and patching, and Josh, for filing the upstream bugreport. jsled-gentoo@asynchronous.org 2007-12-18 14:34:05 0000 (In reply to comment #6) > gnucash-2.2.2 is in the tree with the icons patch. I have also added the svg > icon. Oh, wow. I'd worked up an upstream commit for the icon issue over the weekend, but wasn't quite able to get it into 2.2.2 (needs to be tested against Windows for upstream submission). I was going to hand it to you here, but you beat me to the punch! :) Nice job, and thanks for the bump. 136553 2007-11-20 22:22 0000 gnucash-2.2.1-icons.patch" gnucash-2.2.1-icons.patch text/plain ZGlmZiAtcnUgZ251Y2FzaC0yLjIuMS5vcmlnL3NyYy9waXhtYXBzL01ha2VmaWxlLmFtIGdudWNh c2gtMi4yLjEvc3JjL3BpeG1hcHMvTWFrZWZpbGUuYW0KLS0tIGdudWNhc2gtMi4yLjEub3JpZy9z cmMvcGl4bWFwcy9NYWtlZmlsZS5hbQkyMDA3LTA4LTE5IDA5OjQ1OjI3LjAwMDAwMDAwMCAtMDQw MAorKysgZ251Y2FzaC0yLjIuMS9zcmMvcGl4bWFwcy9NYWtlZmlsZS5hbQkyMDA3LTExLTIwIDE2 OjU5OjA3LjAxOTI3ODgzOCAtMDUwMApAQCAtMzYsMTAgKzM2LDI3IEBACiAgIHN0b2NrX3NwbGl0 X3RpdGxlLnBuZyBcCiAgIHN0b2NrX3NwbGl0X3dhdGVybWFyay5wbmcKIAotZ25jaWNvbmRpciA9 ICR7ZGF0YWRpcn0vcGl4bWFwcwotZ25jaWNvbl9EQVRBID0gZ251Y2FzaC1pY29uLTE2eDE2LnBu ZyBcCi0gIGdudWNhc2gtaWNvbi0zMngzMi5wbmcgXAotICBnbnVjYXNoLWljb24tNDh4NDgucG5n CitnbmNub3JtYWxpY29uZGlyID0gJHtkYXRhZGlyfS9pY29ucy9oaWNvbG9yLzQ4eDQ4L2FwcHMK K2duY25vcm1hbGljb25fREFUQSA9IDQ4eDQ4L2dudWNhc2gtaWNvbi5wbmcKKzQ4eDQ4L2dudWNh c2gtaWNvbi5wbmc6IGdudWNhc2gtaWNvbi00OHg0OC5wbmcKKwktbWtkaXIgNDh4NDgKKwljcCBn bnVjYXNoLWljb24tNDh4NDgucG5nIDQ4eDQ4L2dudWNhc2gtaWNvbi5wbmcKKworZ25jbWVkaXVt aWNvbmRpciA9ICR7ZGF0YWRpcn0vaWNvbnMvaGljb2xvci8zMngzMi9hcHBzCitnbmNtZWRpdW1p Y29uX0RBVEEgPSAzMngzMi9nbnVjYXNoLWljb24ucG5nCiszMngzMi9nbnVjYXNoLWljb24ucG5n OiBnbnVjYXNoLWljb24tMzJ4MzIucG5nCisJLW1rZGlyIDMyeDMyCisJY3AgZ251Y2FzaC1pY29u LTMyeDMyLnBuZyAzMngzMi9nbnVjYXNoLWljb24ucG5nCisKK2duY3NtYWxsaWNvbmRpciA9ICR7 ZGF0YWRpcn0vaWNvbnMvaGljb2xvci8xNngxNi9hcHBzCitnbmNzbWFsbGljb25fREFUQSA9IDE2 eDE2L2dudWNhc2gtaWNvbi5wbmcKKzE2eDE2L2dudWNhc2gtaWNvbi5wbmc6IGdudWNhc2gtaWNv bi0xNngxNi5wbmcKKwktbWtkaXIgMTZ4MTYKKwljcCBnbnVjYXNoLWljb24tMTZ4MTYucG5nIDE2 eDE2L2dudWNhc2gtaWNvbi5wbmcKIAogRVhUUkFfRElTVCA9IFwKLSAgJHtnbmNwaXhtYXBfREFU QX0gJHtnbmNpY29uX0RBVEF9CisgICR7Z25jcGl4bWFwX0RBVEF9IFwKKyAgJHtnbmNub3JtYWxp Y29uX0RBVEF9ICR7Z25jbWVkaXVtaWNvbl9EQVRBfSAke2duY3NtYWxsaWNvbl9EQVRBfQorCitj bGVhbi1sb2NhbDoKKwktcm0gLXJmIDQ4eDQ4IDMyeDMyIDE2eDE2Cg==