199579 2007-11-18 19:09 0000 [gcc-4.3] fix missing include in media-sound/flac-1.2.1-r1 2008-11-05 18:31:54 0000 1 1 1 Unclassified Gentoo Linux GCC Porting unspecified All Linux RESOLVED FIXED P2 normal --- 198121 1 dirtyepic@gentoo.org sound@gentoo.org christoph.gysin@fr33z3.org fauli@gentoo.org dirtyepic@gentoo.org 2007-11-18 19:09:35 0000 GCC 4.3 cleans up the include dependencies of the C++ stdlib headers. The result is some packages have missing includes. This patch fixes one such error in flac-1.2.1-r1. make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r1/work/flac-1.2.1/examples/cpp/encode/file' x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../.. -DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include -I../../../../include -O2 -g -march=native -fomit-frame-pointer -pipe -c -o main.o main.cpp main.cpp: In function 'int main(int, char**)': main.cpp:75: error: 'memcmp' was not declared in this scope make[5]: *** [main.o] Error 1 dirtyepic@gentoo.org 2007-11-18 19:11:54 0000 Created an attachment (id=136308) flac-1.2.1-gcc-4.3-includes.patch dirtyepic@gentoo.org 2007-11-18 19:14:24 0000 http://sourceforge.net/tracker/index.php?func=detail&aid=1834168&group_id=13478&atid=313478 aballier@gentoo.org 2007-11-18 19:32:03 0000 applid for 1.2.1-r2, thanks it's currently masked but only for the time I add the checks for flac++ christoph.gysin@fr33z3.org 2008-09-14 18:59:12 0000 As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.". There is another missing include in examples/cpp/decode/file/main.cpp, patch follows. Please reopen. christoph.gysin@fr33z3.org 2008-09-14 19:00:29 0000 Created an attachment (id=165420) the updated patch fauli@gentoo.org 2008-11-05 18:07:18 0000 (In reply to comment #4) > As the reporter mentiones "This patch fixes ONE such error in flac-1.2.1-r1.". > > There is another missing include in examples/cpp/decode/file/main.cpp, patch > follows. > > Please reopen. Sound team, please check. loki_val@gentoo.org 2008-11-05 18:31:54 0000 make[4]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode' Making all in file make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file' x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../.. -DFLaC__INLINE=__inline__ -DNDEBUG -I../../../.. -I./include -I../../../../include -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -c -o main.o main.cpp main.cpp: In member function ‘virtual void OurDecoder::metadata_callback(const FLAC__StreamMetadata*)’: main.cpp:181: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 3 has type ‘FLAC__uint64’ /bin/sh ../../../../libtool --tag=CXX --mode=link x86_64-pc-linux-gnu-g++ -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -Wl,--as-needed -o example_cpp_decode_file main.o ../../../../src/libFLAC++/libFLAC++.la ../../../../src/libFLAC/libFLAC.la -L/usr/lib -logg -lm libtool: link: x86_64-pc-linux-gnu-g++ -O2 -march=core2 -mcx16 -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 -mtune=core2 -pipe -Wall -ggdb -Wl,--as-needed -o .libs/example_cpp_decode_file main.o ../../../../src/libFLAC++/.libs/libFLAC++.so -L/usr/lib /var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/src/libFLAC/.libs/libFLAC.so ../../../../src/libFLAC/.libs/libFLAC.so /usr/lib64/libogg.so -lm make[5]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode/file' make[5]: Entering directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode' make[5]: Nothing to be done for `all-am'. make[5]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode' make[4]: Leaving directory `/var/tmp/portage/media-libs/flac-1.2.1-r3/work/flac-1.2.1/examples/cpp/decode' IOW, fixed. 136308 2007-11-18 19:11 0000 flac-1.2.1-gcc-4.3-includes.patch flac-1.2.1-gcc-4.3-includes.patch text/plain ZGlmZiAtTmF1ciBmbGFjLTEuMi4xLW9yaWcvZXhhbXBsZXMvY3BwL2VuY29kZS9maWxlL21haW4u Y3BwIGZsYWMtMS4yLjEvZXhhbXBsZXMvY3BwL2VuY29kZS9maWxlL21haW4uY3BwCi0tLSBmbGFj LTEuMi4xLW9yaWcvZXhhbXBsZXMvY3BwL2VuY29kZS9maWxlL21haW4uY3BwCTIwMDctMDktMTMg MDk6NTg6MDMuMDAwMDAwMDAwIC0wNjAwCisrKyBmbGFjLTEuMi4xL2V4YW1wbGVzL2NwcC9lbmNv ZGUvZmlsZS9tYWluLmNwcAkyMDA3LTExLTE4IDEyOjU5OjQ1LjAwMDAwMDAwMCAtMDYwMApAQCAt MzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4K KyNpbmNsdWRlIDxjc3RyaW5nPgogI2luY2x1ZGUgIkZMQUMrKy9tZXRhZGF0YS5oIgogI2luY2x1 ZGUgIkZMQUMrKy9lbmNvZGVyLmgiCiAK 165420 2008-09-14 19:00 0000 the updated patch flac-1.2.1-gcc-4.3-includes.patch text/plain LS0tIGV4YW1wbGVzL2NwcC9lbmNvZGUvZmlsZS9tYWluLmNwcC5vcmlnCTIwMDctMDktMTMgMDk6 NTg6MDMuMDAwMDAwMDAwIC0wNjAwCisrKyBleGFtcGxlcy9jcHAvZW5jb2RlL2ZpbGUvbWFpbi5j cHAJMjAwNy0xMS0xOCAxMjo1OTo0NS4wMDAwMDAwMDAgLTA2MDAKQEAgLTMwLDYgKzMwLDcgQEAK IAogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CisjaW5jbHVkZSA8Y3N0 cmluZz4KICNpbmNsdWRlICJGTEFDKysvbWV0YWRhdGEuaCIKICNpbmNsdWRlICJGTEFDKysvZW5j b2Rlci5oIgogCi0tLSBleGFtcGxlcy9jcHAvZGVjb2RlL2ZpbGUvbWFpbi5jcHAub3JpZwkyMDA4 LTA5LTE0IDIwOjM3OjA1LjAwMDAwMDAwMCArMDIwMAorKysgZXhhbXBsZXMvY3BwL2RlY29kZS9m aWxlL21haW4uY3BwCTIwMDgtMDktMTQgMjA6Mzc6MTkuMDAwMDAwMDAwICswMjAwCkBAIC0zMCw2 ICszMCw3IEBACiAKICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgorI2lu Y2x1ZGUgPGNzdHJpbmc+CiAjaW5jbHVkZSAiRkxBQysrL2RlY29kZXIuaCIKIAogc3RhdGljIEZM QUNfX3VpbnQ2NCB0b3RhbF9zYW1wbGVzID0gMDsK