1988 2002-04-21 18:17 0000 mgetty-1.1.26-r3.ebuild (Updated Ebuild - Fix) 2003-02-04 19:42:18 0000 1 1 1 Unclassified Gentoo Linux Ebuilds 1.1a x86 All RESOLVED FIXED P2 normal --- 1 geekasylum@gmail.com rphillips@gentoo.org geekasylum@gmail.com 2002-04-21 18:17:20 0000 There were 2 main problems with the mgetty-1.1.26-r2.ebuild which I have fixed in this updated ebuild. #1) The src_unpack function used sed to edit policy.h to correct the logfile define for the mgetty.% log, however there is also a sendfax log which should also be changed. I updated the sed code to edit both logfile locations. I also added another sed command to uncomment the CNDFILE define in policy.h. This activates Calling Number Display (CND) options. With this undefined (as shipped), mgetty will never read the "dialin.config" config file and CND processing is disabled. Activating CND is benign since there are no definitions in the example dialin.config, it will have no effect. I have had CND working in mgetty (non- gentoo) for over a year with no problems. #2 The make (emake) statements in src_compile did not pass some needed variables to make. At compile time, mgetty uses ${prefix} and $CONFDIR (among others) in #defines inside several source files. Leaving these to the default values would cause mgetty to have incorect paths hardcoded internally and could lead to problems at run time. The Makefile also has CFLAGS set internally which override the users chosen flags (in make.conf) I corrected both of these problems by passing the appropriate environment variables to both the main mgetty make and the make for the voice utils. mgetty now compiles with correct internal paths, and the users chosen CFLAGS. Feel free to leave out the CND stuff if you want (though I can see no reason to) simply delete the entire 3rd line in the sed command (ie the 3rd -e line containing "CNDFILE") I thought of making it optional but couldnt think how to without another USE variable which I thought was overkill. geekasylum@gmail.com 2002-04-21 18:26:02 0000 Created an attachment (id=632) mgetty-1.1.26-r3.ebuild (Updated ebuild) geekasylum@gmail.com 2002-04-21 18:49:51 0000 Noticed another bug in this ebuild - in src_install, INFODIR=${D}/usr/share should read INFODIR=${D}/usr/share/info Tried to upload a revised ebuild but it didnt work. Can you fix this one by hand, thanks. rphillips@gentoo.org 2002-04-23 12:35:23 0000 committed. 632 2002-04-21 18:26 0000 mgetty-1.1.26-r3.ebuild (Updated ebuild) mgetty-1.1.26-r3.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDAyIEdlbnRvbyBUZWNobm9sb2dpZXMsIEluYy4KIyBEaXN0cmli dXRlZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlLCB2 MiBvciBsYXRlcgojIEF1dGhvciBHcmFudCBHb29keWVhciA8ZzJib29qdW1AZ2VudG9vLm9yZz4K IyBVcGRhdGVkIGJ5IFRvZGQgV3JpZ2h0IDx3eWxpZUBnZWVrYXN5bHVtLm9yZz4gLXIzCiMgL2hv bWUvY3Zzcm9vdC9nZW50b28teDg2L3NrZWwuYnVpbGQsdiAxLjcgMjAwMS8wOC8yNSAyMToxNTow OCBjaGFkaCBFeHAKClM9JHtXT1JLRElSfS8ke1B9CkRFU0NSSVBUSU9OPSJGYXggYW5kIFZvaWNl IG1vZGVtIHByb2dyYW1zLiIKClNSQ19VUkk9ImZ0cDovL2FscGhhLmdyZWVuaWUubmV0L3B1Yi9t Z2V0dHkvc291cmNlLzEuMS8ke1BOfSR7UFZ9LUFwcjE2LnRhci5neiIKSE9NRVBBR0U9Imh0dHA6 Ly9hbHBoYS5ncmVlbmllLm5ldC9tZ2V0dHkiCgpERVBFTkQ9InN5cy1saWJzL2dsaWJjCglhcHAt dGV4dC90ZXRleAoJc3lzLWFwcHMvZ2F3awoJc3lzLWRldmVsL3BlcmwiCgpzcmNfdW5wYWNrKCkg ewoJdW5wYWNrICR7QX0KCgljZCAke1N9L2RvYwoJcGF0Y2ggLXAwIDwgJHtGSUxFU0RJUn0vbWdl dHR5LSR7UFZ9LWdlbnRvby5kaWZmIHx8IGRpZQoJCgljcCBNYWtlZmlsZSBNYWtlZmlsZS5vcmln CglzZWQgLWUgInM6ZHZpcHMgLW8gbWdldHR5LnBzOmR2aXBzIC1NIC1vIG1nZXR0eS5wczoiIFwK CQlNYWtlZmlsZS5vcmlnID5NYWtlZmlsZQoKCWNkICR7U30KCXNlZCAtZSAnczp2YXIvbG9nL21n ZXR0eTp2YXIvbG9nL21nZXR0eS9tZ2V0dHk6JyBcCgkgICAgLWUgJ3M6dmFyL2xvZy9zZW5kZmF4 OnZhci9sb2cvbWdldHR5L3NlbmRmYXg6JyBcCgkgICAgLWUgJ3M6XC9cKiBcI2RlZmluZSBDTkRG SUxFICJkaWFsaW4uY29uZmlnIiBcKlwvOlwjZGVmaW5lIENOREZJTEUgImRpYWxpbi5jb25maWci OicgXAoJICAgIHBvbGljeS5oLWRpc3QgPiBwb2xpY3kuaAp9CgpzcmNfY29tcGlsZSgpIHsKCW15 Y2ZsYWdzPSIke0NGTEFHU30iCgl1bnNldCBDRkxBR1MKCWVtYWtlIHByZWZpeD0vdXNyIFwKCSAg ICAgIENPTkZESVI9L2V0Yy9tZ2V0dHkrc2VuZGZheCBcCgkgICAgICBDRkxBR1M9IiR7bXljZmxh Z3N9IiBcCgkgICAgICB8fCBkaWUKCWNkIHZvaWNlCgllbWFrZSBDT05GRElSPS9ldGMvbWdldHR5 K3NlbmRmYXggXAoJICAgICAgQ0ZMQUdTPSIke215Y2ZsYWdzfSIgXAoJICAgICAgfHwgZGllCglj ZCAke1N9Cn0KCnNyY19pbnN0YWxsICgpIHsKCWRvZGlyIC92YXIvc3Bvb2wKCWRvZGlyIC91c3Iv c2hhcmUvaW5mbwoJbWFrZSBwcmVmaXg9JHtEfS91c3IgXAoJICAgICBJTkZPRElSPSR7RH0vdXNy L3NoYXJlIFwKCSAgICAgQ09ORkRJUj0ke0R9L2V0Yy9tZ2V0dHkrc2VuZGZheCBcCgkgICAgIHNw b29sPSR7RH0vdmFyL3Nwb29sIFwKCSAgICAgaW5zdGFsbCB8fCBkaWUKCgljZCB2b2ljZQoJbWFr ZSBwcmVmaXg9JHtEfS91c3IgXAoJICAgICBDT05GRElSPSR7RH0vZXRjL21nZXR0eStzZW5kZmF4 IFwKCSAgICAgaW5zdGFsbCB8fCBkaWUKCgljZCAke1N9Cglkb2RvYyBCVUdTIENoYW5nZUxvZyBG VFAgUkVBRE1FLjFzdCBSZWNvbW1lbmQgVEhBTktTIFRPRE8KCWNkIGRvYwoJZG9kb2MgKi50eHQg bW9kZW1zLmRiIG1nZXR0eS5wcwoKCSNnZW5lcmF0ZSBtaXNzaW5nIGZvbnRzIGlmIGFueS4KCWlm IFsgLWYgJHtTfS9kb2MvbWlzc2ZvbnQubG9nIF0KCXRoZW4KCQllY2hvICcjIS9iaW4vYmFzaCcg PmdlbmZvbnRzLnNoCgkJY2F0IG1pc3Nmb250LmxvZyA+PmdlbmZvbnRzLnNoCgkJY2htb2QgK3gg Z2VuZm9udHMuc2gKCQlkb2RvYyBnZW5mb250cy5zaAoJZmkKfQoKcGtnX3Bvc3RpbnN0KCkgewoJ I2dlbmVyYXRlIG1pc3NpbmcgZm9udHMgaWYgYW55LgoJaWYgWyAteCB7JFJPT1R9L3Vzci9zaGFy ZS9kb2MvJHtQRn0vZ2VuZm9udHMuc2ggXQoJdGhlbgoJCXskUk9PVH0vdXNyL3NoYXJlL2RvYy8k e1BGfS9nZW5mb250cy5zaAoJZmkKCglpZiBbICEgLWQgJHtST09UfS92YXIvc3Bvb2wvZmF4L2lu Y29taW5nIF0KCXRoZW4KCQlta2RpciAtcCAke1JPT1R9L3Zhci9zcG9vbC9mYXgvaW5jb21pbmcK CWZpCglpZiBbICEgLWQgJHtST09UfS92YXIvc3Bvb2wvZmF4L291dGdvaW5nL2xvY2tzIF0KCXRo ZW4KCQlta2RpciAtcCAke1JPT1R9L3Zhci9zcG9vbC9mYXgvb3V0Z29pbmcvbG9ja3MKCWZpCn0K Cg==