194862 2007-10-05 23:42 0000 net-mail/mailman/mailman-2.1.9-r2 - make mailman user configurable 2007-11-29 09:47:26 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified x86 Linux RESOLVED FIXED P5 enhancement --- 1 sebastian@nanofortnight.org hanno@gentoo.org hansmi@gentoo.org sebastian@nanofortnight.org sebastian@nanofortnight.org 2007-10-05 23:42:18 0000 Is it possible to change the user "mailman" to a variable like we did it for VAR_PREFIX, CGIGID and MAILGID, too? Because we would like to change VAR_PREFIX to a home directory of another user and then it would be great that portage doesn't create another mailman user. I have got a test installation and it works great. If you accept my suggestion, it would be necessary to change files/mailman.rc You can easily change to the new mailman user, but then please use the full path in the ebuild. Another point is the line 67 in /usr/lib/mailman/bin/qmail-to-mailman.py: "local = re.sub("^mailman-","",local)" You strip there only the mailman user, but if we've change to another user than mailman it would be better to use: "local = re.sub("^" + os.environ['USER'] + "-","",local)" Hanno, thanks a lot for your help. :-) If you've got any questions feel free to ask me. With the changes above it works for me very well. Reproducible: Always hansmi@gentoo.org 2007-10-06 08:56:50 0000 (In reply to comment #0) > Another point is the line 67 in /usr/lib/mailman/bin/qmail-to-mailman.py: > "local = re.sub("^mailman-","",local)" > You strip there only the mailman user, but if we've change to another user than > mailman it would be better to use: > "local = re.sub("^" + os.environ['USER'] + "-","",local)" This creates a potential security problem. Please use re.escape(os.environ["USER"]) at least. sebastian@nanofortnight.org 2007-10-22 14:05:37 0000 --- mailman-2.1.9-r2.ebuild 2007-10-22 10:10:22.000000000 +0000 +++ mailman-2.1.9-r100.ebuild 2007-10-22 14:03:58.000000000 +0000 @@ -22,15 +22,17 @@ INSTALLDIR=${MAILMAN_PREFIX:-"/usr/lib/mailman"} VAR_PREFIX=${MAILMAN_VAR_PREFIX:-"/var/lib/mailman"} CGIGID=${MAILMAN_CGIGID:-81} - MAILGID=${MAILMAN_MAILGID:-280} MAILUSR=${MAILMAN_MAILUSR:-mailman} MAILUID=${MAILMAN_MAILUID:-280} + MAILGRP=${MAILMAN_MAILGRP:mailman} + MAILGID=${MAILMAN_MAILGID:-280} + # Bug #58526: switch to enew{group,user}. # need to add mailman here for compile process. # Duplicated at pkg_postinst() for binary install. - enewgroup mailman 280 - enewuser ${MAILUSR} ${MAILUID} /bin/bash ${INSTALLDIR} mailman -G cron -c ${MAILUSR} + enewgroup ${MAILGRP} ${MAILGID} + enewuser ${MAILUSR} ${MAILUID} /bin/bash ${INSTALLDIR} mailman -G cron -c "mailman" } src_unpack() { @@ -45,6 +47,8 @@ --with-mail-gid=${MAILGID} \ --with-cgi-gid=${CGIGID} \ --with-var-prefix=${VAR_PREFIX} \ + --with-username=${MAILUSR} \ + --with-groupname=${MAILGRP} \ || die "configure failed" emake || die "make failed" @@ -88,7 +92,7 @@ keepdir ${VAR_PREFIX}/lists keepdir ${VAR_PREFIX}/qfiles - chown -R mailman:mailman ${D}/${VAR_PREFIX} ${D}/${INSTALLDIR} ${D}/etc/mailman/* + chown -R ${MAILUSR}:${MAILGRP} ${D}/${VAR_PREFIX} ${D}/${INSTALLDIR} ${D}/etc/mailman/* chmod 2775 ${D}/${INSTALLDIR} ${D}/${INSTALLDIR}/templates/* \ ${D}/${INSTALLDIR}/messages/* ${D}/${VAR_PREFIX} ${D}/${VAR_PREFIX}/{logs,lists,spam,locks,archives/public} chmod 2750 ${D}/${VAR_PREFIX}/archives/private @@ -100,8 +104,8 @@ pkg_postinst() { python_mod_optimize ${INSTALLDIR}/bin/ ${INSTALLDIR}/Mailman - enewgroup mailman 280 - enewuser mailman 280 -1 ${INSTALLDIR} mailman -G cron -c "mailman" + enewgroup ${MAILGRP} ${MAILGID} + enewuser ${MAILUSR} ${MAILUID} -1 ${INSTALLDIR} mailman -G cron -c "mailman" elog elog "Please read /usr/share/doc/${PF}/README.gentoo.gz for additional" elog "Setup information, mailman will NOT run unless you follow" @@ -120,6 +124,9 @@ ewarn "MAILMAN_INSTALLDIR (default: /usr/lib/mailman)" ewarn "MAILMAN_VAR_PREFIX (default: /var/lib/mailman)" ewarn "MAILMAN_CGIGID (default: 81)" + ewarn "MAILMAN_MAILUSR (default: mailman)" + ewarn "MAILMAN_MAILUID (default: 280)" + ewarn "MAILMAN_MAILGRP (default: mailman)" ewarn "MAILMAN_MAILGID (default: 280)" ewarn ewarn "Config file is now symlinked in /etc/mailman, so etc-update works." This could be help to change the mailman-user and mailman-group easily with some meta variables. It is tested and seems to work at least for me. Sebastian 'kickino' Wieseler sebastian@nanofortnight.org 2007-10-22 14:08:49 0000 --- /usr/portage/net-mail/mailman/mailman-2.1.9-r2.ebuild 2007-09-28 07:36:11.000000000 +0000 +++ mailman-2.1.9-r100.ebuild 2007-10-22 14:08:21.000000000 +0000 @@ -22,13 +22,17 @@ INSTALLDIR=${MAILMAN_PREFIX:-"/usr/lib/mailman"} VAR_PREFIX=${MAILMAN_VAR_PREFIX:-"/var/lib/mailman"} CGIGID=${MAILMAN_CGIGID:-81} + MAILUSR=${MAILMAN_MAILUSR:-mailman} + MAILUID=${MAILMAN_MAILUID:-280} + MAILGRP=${MAILMAN_MAILGRP:-mailman} MAILGID=${MAILMAN_MAILGID:-280} + # Bug #58526: switch to enew{group,user}. # need to add mailman here for compile process. # Duplicated at pkg_postinst() for binary install. - enewgroup mailman 280 - enewuser mailman 280 /bin/bash ${INSTALLDIR} mailman -G cron -c mailman + enewgroup ${MAILGRP} ${MAILGID} + enewuser ${MAILUSR} ${MAILUID} /bin/bash ${INSTALLDIR} mailman -G cron -c "mailman" } src_unpack() { @@ -43,6 +47,8 @@ --with-mail-gid=${MAILGID} \ --with-cgi-gid=${CGIGID} \ --with-var-prefix=${VAR_PREFIX} \ + --with-username=${MAILUSR} \ + --with-groupname=${MAILGRP} \ || die "configure failed" emake || die "make failed" @@ -86,7 +92,7 @@ keepdir ${VAR_PREFIX}/lists keepdir ${VAR_PREFIX}/qfiles - chown -R mailman:mailman ${D}/${VAR_PREFIX} ${D}/${INSTALLDIR} ${D}/etc/mailman/* + chown -R ${MAILUSR}:${MAILGRP} ${D}/${VAR_PREFIX} ${D}/${INSTALLDIR} ${D}/etc/mailman/* chmod 2775 ${D}/${INSTALLDIR} ${D}/${INSTALLDIR}/templates/* \ ${D}/${INSTALLDIR}/messages/* ${D}/${VAR_PREFIX} ${D}/${VAR_PREFIX}/{logs,lists,spam,locks,archives/public} chmod 2750 ${D}/${VAR_PREFIX}/archives/private @@ -98,8 +104,8 @@ pkg_postinst() { python_mod_optimize ${INSTALLDIR}/bin/ ${INSTALLDIR}/Mailman - enewgroup mailman 280 - enewuser mailman 280 -1 ${INSTALLDIR} mailman -G cron -c "mailman" + enewgroup ${MAILGRP} ${MAILGID} + enewuser ${MAILUSR} ${MAILUID} -1 ${INSTALLDIR} mailman -G cron -c "mailman" elog elog "Please read /usr/share/doc/${PF}/README.gentoo.gz for additional" elog "Setup information, mailman will NOT run unless you follow" @@ -118,6 +124,9 @@ ewarn "MAILMAN_INSTALLDIR (default: /usr/lib/mailman)" ewarn "MAILMAN_VAR_PREFIX (default: /var/lib/mailman)" ewarn "MAILMAN_CGIGID (default: 81)" + ewarn "MAILMAN_MAILUSR (default: mailman)" + ewarn "MAILMAN_MAILUID (default: 280)" + ewarn "MAILMAN_MAILGRP (default: mailman)" ewarn "MAILMAN_MAILGID (default: 280)" ewarn ewarn "Config file is now symlinked in /etc/mailman, so etc-update works." Fixed some things. sebastian@nanofortnight.org 2007-10-22 17:06:00 0000 Created an attachment (id=134121) diff as attachment (maybe prefered?) - mailman user and group configurable hanno@gentoo.org 2007-11-26 02:25:11 0000 ebuild changes committed, thanks. About the qmail-to-mailman-script, can you make the patch secure and send it upstream? sebastian@nanofortnight.org 2007-11-29 09:47:26 0000 (In reply to comment #5) > About the qmail-to-mailman-script, can you make the patch secure and send it > upstream? I did. But qmail-to-mailman isn't maintained by the mailman team but from a third party. I mailed my patch to the programmer but no respone since some weeks. :-/ 134121 2007-10-22 17:06 0000 diff as attachment (maybe prefered?) - mailman user and group configurable mailman-usr-grp.diff text/plain LS0tIC91c3IvcG9ydGFnZS9uZXQtbWFpbC9tYWlsbWFuL21haWxtYW4tMi4xLjktcjIuZWJ1aWxk CTIwMDctMDktMjggMDc6MzY6MTEuMDAwMDAwMDAwICswMDAwCisrKyBtYWlsbWFuLTIuMS45LXIz LmVidWlsZAkyMDA3LTEwLTIyIDE0OjA4OjIxLjAwMDAwMDAwMCArMDAwMApAQCAtMjIsMTMgKzIy LDE3IEBACiAJSU5TVEFMTERJUj0ke01BSUxNQU5fUFJFRklYOi0iL3Vzci9saWIvbWFpbG1hbiJ9 CiAJVkFSX1BSRUZJWD0ke01BSUxNQU5fVkFSX1BSRUZJWDotIi92YXIvbGliL21haWxtYW4ifQog CUNHSUdJRD0ke01BSUxNQU5fQ0dJR0lEOi04MX0KKwlNQUlMVVNSPSR7TUFJTE1BTl9NQUlMVVNS Oi1tYWlsbWFufQorCU1BSUxVSUQ9JHtNQUlMTUFOX01BSUxVSUQ6LTI4MH0KKwlNQUlMR1JQPSR7 TUFJTE1BTl9NQUlMR1JQOi1tYWlsbWFufQogCU1BSUxHSUQ9JHtNQUlMTUFOX01BSUxHSUQ6LTI4 MH0KIAorCiAJIyBCdWcgIzU4NTI2OiBzd2l0Y2ggdG8gZW5ld3tncm91cCx1c2VyfS4KIAkjIG5l ZWQgdG8gYWRkIG1haWxtYW4gaGVyZSBmb3IgY29tcGlsZSBwcm9jZXNzLgogCSMgRHVwbGljYXRl ZCBhdCBwa2dfcG9zdGluc3QoKSBmb3IgYmluYXJ5IGluc3RhbGwuCi0JZW5ld2dyb3VwIG1haWxt YW4gMjgwCi0JZW5ld3VzZXIgbWFpbG1hbiAyODAgL2Jpbi9iYXNoICR7SU5TVEFMTERJUn0gbWFp bG1hbiAtRyBjcm9uIC1jIG1haWxtYW4KKwllbmV3Z3JvdXAgJHtNQUlMR1JQfSAke01BSUxHSUR9 CisJZW5ld3VzZXIgICR7TUFJTFVTUn0gJHtNQUlMVUlEfSAvYmluL2Jhc2ggJHtJTlNUQUxMRElS fSBtYWlsbWFuIC1HIGNyb24gLWMgIm1haWxtYW4iCiB9CiAKIHNyY191bnBhY2soKSB7CkBAIC00 Myw2ICs0Nyw4IEBACiAJCS0td2l0aC1tYWlsLWdpZD0ke01BSUxHSUR9IFwKIAkJLS13aXRoLWNn aS1naWQ9JHtDR0lHSUR9IFwKIAkJLS13aXRoLXZhci1wcmVmaXg9JHtWQVJfUFJFRklYfSBcCisJ CS0td2l0aC11c2VybmFtZT0ke01BSUxVU1J9IFwKKwkJLS13aXRoLWdyb3VwbmFtZT0ke01BSUxH UlB9IFwKIAl8fCBkaWUgImNvbmZpZ3VyZSBmYWlsZWQiCiAKIAllbWFrZSB8fCBkaWUgIm1ha2Ug ZmFpbGVkIgpAQCAtODYsNyArOTIsNyBAQAogCWtlZXBkaXIgJHtWQVJfUFJFRklYfS9saXN0cwog CWtlZXBkaXIgJHtWQVJfUFJFRklYfS9xZmlsZXMKIAotCWNob3duIC1SIG1haWxtYW46bWFpbG1h biAke0R9LyR7VkFSX1BSRUZJWH0gJHtEfS8ke0lOU1RBTExESVJ9ICR7RH0vZXRjL21haWxtYW4v KgorCWNob3duIC1SICR7TUFJTFVTUn06JHtNQUlMR1JQfSAke0R9LyR7VkFSX1BSRUZJWH0gJHtE fS8ke0lOU1RBTExESVJ9ICR7RH0vZXRjL21haWxtYW4vKgogCWNobW9kIDI3NzUgJHtEfS8ke0lO U1RBTExESVJ9ICR7RH0vJHtJTlNUQUxMRElSfS90ZW1wbGF0ZXMvKiBcCiAJCSR7RH0vJHtJTlNU QUxMRElSfS9tZXNzYWdlcy8qICR7RH0vJHtWQVJfUFJFRklYfSAke0R9LyR7VkFSX1BSRUZJWH0v e2xvZ3MsbGlzdHMsc3BhbSxsb2NrcyxhcmNoaXZlcy9wdWJsaWN9CiAJY2htb2QgMjc1MCAke0R9 LyR7VkFSX1BSRUZJWH0vYXJjaGl2ZXMvcHJpdmF0ZQpAQCAtOTgsOCArMTA0LDggQEAKIHBrZ19w b3N0aW5zdCgpIHsKIAlweXRob25fbW9kX29wdGltaXplICR7SU5TVEFMTERJUn0vYmluLyAke0lO U1RBTExESVJ9L01haWxtYW4KIAotCWVuZXdncm91cCBtYWlsbWFuIDI4MAotCWVuZXd1c2VyIG1h aWxtYW4gMjgwIC0xICR7SU5TVEFMTERJUn0gbWFpbG1hbiAtRyBjcm9uIC1jICJtYWlsbWFuIgor CWVuZXdncm91cCAke01BSUxHUlB9ICR7TUFJTEdJRH0KKwllbmV3dXNlciAgJHtNQUlMVVNSfSAk e01BSUxVSUR9IC0xICR7SU5TVEFMTERJUn0gbWFpbG1hbiAtRyBjcm9uIC1jICJtYWlsbWFuIgog CWVsb2cKIAllbG9nICJQbGVhc2UgcmVhZCAvdXNyL3NoYXJlL2RvYy8ke1BGfS9SRUFETUUuZ2Vu dG9vLmd6IGZvciBhZGRpdGlvbmFsIgogCWVsb2cgIlNldHVwIGluZm9ybWF0aW9uLCBtYWlsbWFu IHdpbGwgTk9UIHJ1biB1bmxlc3MgeW91IGZvbGxvdyIKQEAgLTExOCw2ICsxMjQsOSBAQAogCWV3 YXJuICJNQUlMTUFOX0lOU1RBTExESVIgKGRlZmF1bHQ6IC91c3IvbGliL21haWxtYW4pIgogCWV3 YXJuICJNQUlMTUFOX1ZBUl9QUkVGSVggKGRlZmF1bHQ6IC92YXIvbGliL21haWxtYW4pIgogCWV3 YXJuICJNQUlMTUFOX0NHSUdJRCAoZGVmYXVsdDogODEpIgorCWV3YXJuICJNQUlMTUFOX01BSUxV U1IgKGRlZmF1bHQ6IG1haWxtYW4pIgorCWV3YXJuICJNQUlMTUFOX01BSUxVSUQgKGRlZmF1bHQ6 IDI4MCkiCisJZXdhcm4gIk1BSUxNQU5fTUFJTEdSUCAoZGVmYXVsdDogbWFpbG1hbikiCiAJZXdh cm4gIk1BSUxNQU5fTUFJTEdJRCAoZGVmYXVsdDogMjgwKSIKIAlld2FybgogCWV3YXJuICJDb25m aWcgZmlsZSBpcyBub3cgc3ltbGlua2VkIGluIC9ldGMvbWFpbG1hbiwgc28gZXRjLXVwZGF0ZSB3 b3Jrcy4iCg==