194234 2007-09-30 00:10 0000 app-portage/gentoolkit-0.2.4_pre7: revdep-rebuild-rewrite's "portable find" function is slightly bogus 2008-02-21 01:52:11 0000 1 1 1 Unclassified Portage Development Tools unspecified All Linux RESOLVED FIXED InSVN P2 minor --- 170220 1 levertond@googlemail.com tools-portage@gentoo.org michael@smith-li.com levertond@googlemail.com 2007-09-30 00:10:53 0000 The "find" function in revdep-rebuild-rewrite assumes that the script itself will have the executable bit. While this is true when it is installed from an ebuild, it may not be when, for example, downloading the latest version of the script from viewvc with a web browser. This leads to the second issue: if the script isn't executable, all the tests of find's syntax fail, and it falls through to the "Last resort" branch, which replaces -executable etc with "-exec test ...". This fails because all it does is cause the test command to be executed for each file - find doesn't do anything with the return value. If the actual call to find specifies an explicit action it well be executed regardless of whether the file is actually executable, otherwise the default -print action will /not/ be executed at all. levertond@googlemail.com 2007-09-30 00:12:56 0000 Created an attachment (id=132207) patch This fixes both issues: for the first, use $(type -P find) as the assumed-executable to test, since if it isn't executable then things are /really/ hopeless. For the second, since no-one's complained before we can assume that no implementation of find requires the "last resort", so we can just replace it with a die. michael@smith-li.com 2008-01-21 19:54:43 0000 In reply to comment #0: Hi, David, I agree that testing the executability of $(type -P find) is more appropriate than testing $0. As for the Last Resort branch, find(1p) claims that for the syntax "-exec utility_name [argument...] ;", "...the utility utility_name shall be invoked once for each pathname and the primary shall evaluate as true if the utility returns a zero value as exit status." It's certainly possible my implementation was faulty, but the man page backs up the theory behind the "Last Resort" method. Is it possible that the failure you experienced had a different cause? levertond@googlemail.com 2008-01-21 21:03:36 0000 (In reply to comment #2) > As for the Last Resort branch, find(1p) claims that for the syntax "-exec > utility_name [argument...] ;", "...the utility utility_name shall be invoked > once for each pathname and the primary shall evaluate as true if the utility > returns a zero value as exit status." Yeah, sorry, I must have missed that part of the doc. > It's certainly possible my implementation was faulty, but the man page backs > up the theory behind the "Last Resort" method. Is it possible that the > failure you experienced had a different cause? In > while read LIST; do > break # Set LIST > done < <(find $HOME/ /var/tmp/ /tmp/ -writable) when the last resort method is used, the use of -exec suppresses the default -print, causing find not to output anything. It seems to work fine if the -print is specified explicitly, so that would be better than what I suggested before. michael@smith-li.com 2008-01-22 22:15:03 0000 Created an attachment (id=141612) revdep-rebuild_r453_find_find.patch How does this patch look? I believe it should fix this bug. levertond@googlemail.com 2008-01-22 22:51:23 0000 (In reply to comment #4) > How does this patch look? I believe it should fix this bug. > Looks good to me. Tested and it works fine here. fuzzyray@gentoo.org 2008-02-16 20:36:14 0000 $ svn commit -m "Apply patch for revdep-rebuild portable find function. (Bug 194234)" Sending revdep-rebuild/revdep-rebuild Transmitting file data . Committed revision 460. fuzzyray@gentoo.org 2008-02-21 01:52:11 0000 Released in gentoolkit-0.2.4_rc2 132207 2007-09-30 00:12 0000 patch revdep-rebuild.patch text/plain LS0tIHJldmRlcC1yZWJ1aWxkLXJld3JpdGVfcHJlN34JMjAwNy0wOS0zMCAwMDo0Mjo1MC4wMDAw MDAwMDAgKzAxMDAKKysrIHJldmRlcC1yZWJ1aWxkLXJld3JpdGVfcHJlNwkyMDA3LTA5LTMwIDAx OjA0OjEzLjAwMDAwMDAwMCArMDEwMApAQCAtMTAwLDMwICsxMDAsMjUgQEAKICMgb2YgdmFyaW91 cyB2ZXJzaW9ucyBvZiAtcGVybSAvKyBibGFoIGJsYWggYW5kIGhhY2tzCiBmaW5kKCkgewogCWhh c2ggZmluZCB8fCB7IGRpZSAxICdmaW5kIG5vdCBmb3VuZCEnOyB9Ci0JIyBXZSBjYW4gYmUgcHJl dHR5IHN1cmUgIiQwIiBzaG91bGQgYmUgZXhlY3V0YWJsZS4KLQlpZiBbWyAkKGNvbW1hbmQgZmlu ZCAiJDAiIC1leGVjdXRhYmxlIDI+IC9kZXYvbnVsbCkgXV07IHRoZW4KKwkjIFdlIGNhbiBiZSBw cmV0dHkgc3VyZSBmaW5kIHNob3VsZCBiZSBleGVjdXRhYmxlLgorCWlmIFtbICQoY29tbWFuZCBm aW5kICIkKHR5cGUgLVAgZmluZCkiIC1leGVjdXRhYmxlIDI+IC9kZXYvbnVsbCkgXV07IHRoZW4K IAkJdW5zZXQgLWYgZmluZCAjIFdlIGNhbiBqdXN0IHVzZSB0aGUgY29tbWFuZCBmaW5kCi0JZWxp ZiBbWyAkKGNvbW1hbmQgZmluZCAiJDAiIC1wZXJtIC91K3ggMj4gL2Rldi9udWxsKSBdXTsgdGhl bgorCWVsaWYgW1sgJChjb21tYW5kIGZpbmQgIiQodHlwZSAtUCBmaW5kKSIgLXBlcm0gL3UreCAy PiAvZGV2L251bGwpIF1dOyB0aGVuCiAJCWZpbmQoKSB7CiAJCQlhPSgke0AvLy1leGVjdXRhYmxl Ly1wZXJtIFwvdSt4fSkKIAkJCWE9KCR7YVtAXS8vLXdyaXRhYmxlLy1wZXJtIFwvdSt3fSkKIAkJ CWE9KCR7YVtAXS8vLXJlYWRhYmxlLy1wZXJtIFwvcit3fSkKIAkJCWNvbW1hbmQgZmluZCAiJHth W0BdfSIKIAkJfQotCWVsaWYgW1sgJChjb21tYW5kIGZpbmQgIiQwIiAtcGVybSArdSt4IDI+IC9k ZXYvbnVsbCkgXV07IHRoZW4KKwllbGlmIFtbICQoY29tbWFuZCBmaW5kICIkKHR5cGUgLVAgZmlu ZCkiIC1wZXJtICt1K3ggMj4gL2Rldi9udWxsKSBdXTsgdGhlbgogCQlmaW5kKCkgewogCQkJYT0o JHtALy8tZXhlY3V0YWJsZS8tcGVybSArdSt4fSkKIAkJCWE9KCR7YVtAXS8vLXdyaXRhYmxlLy1w ZXJtICt1K3d9KQogCQkJYT0oJHthW0BdLy8tcmVhZGFibGUvLXBlcm0gK3Ird30pCiAJCQljb21t YW5kIGZpbmQgIiR7YVtAXX0iCiAJCX0KLQllbHNlICMgTGFzdCByZXNvcnQKLQkJZmluZCgpIHsK LQkJCWE9KCR7QC8vLWV4ZWN1dGFibGUvLWV4ZWMgdGVzdCAteCAne30nIFw7fSkKLQkJCWE9KCR7 YVtAXS8vLXdyaXRhYmxlLy1leGVjIHRlc3QgLXcgJ3t9JyBcO30pCi0JCQlhPSgke2FbQF0vLy1y ZWFkYWJsZS8tZXhlYyB0ZXN0IC1yICd7fScgXDt9KQotCQkJY29tbWFuZCBmaW5kICIke2FbQF19 IgotCQl9CisJZWxzZQorCQlkaWUgMSAiZG9uJ3Qga25vdyBob3cgdG8gc2VhcmNoIGZvciBwZXJt aXNzaW9ucyB3aXRoIGZpbmQiCiAJZmkKIAlmaW5kICIkQCIKIH0K 141612 2008-01-22 22:15 0000 revdep-rebuild_r453_find_find.patch revdep-rebuild_r453_find_find.patch text/plain LS0tIHJldmRlcC1yZWJ1aWxkX3I0NTMJMjAwOC0wMS0yMSAxNDozMDoxOS4wMDAwMDAwMDAgLTA1 MDAKKysrIHJldmRlcC1yZWJ1aWxkCTIwMDgtMDEtMjIgMTc6MDg6NTQuMDAwMDAwMDAwIC0wNTAw CkBAIC03NiwxNyArNzYsMTggQEAKICMgb2YgdmFyaW91cyB2ZXJzaW9ucyBvZiAtcGVybSAvKyBi bGFoIGJsYWggYW5kIGhhY2tzCiBmaW5kKCkgewogCWhhc2ggZmluZCB8fCB7IGRpZSAxICdmaW5k IG5vdCBmb3VuZCEnOyB9Ci0JIyBXZSBjYW4gYmUgcHJldHR5IHN1cmUgIiQwIiBzaG91bGQgYmUg ZXhlY3V0YWJsZS4KLQlpZiBbWyAkKGNvbW1hbmQgZmluZCAiJDAiIC1leGVjdXRhYmxlIDI+IC9k ZXYvbnVsbCkgXV07IHRoZW4KKwkjIFdlIGNhbiBiZSBwcmV0dHkgc3VyZSBmaW5kIGl0c2VsZiBz aG91bGQgYmUgZXhlY3V0YWJsZS4KKwlsb2NhbCB0ZXN0c3ViamVjdD0iJCh0eXBlIC1QIGZpbmQp IgorCWlmIFtbICQoY29tbWFuZCBmaW5kICIkdGVzdHN1YmplY3QiIC1leGVjdXRhYmxlIDI+IC9k ZXYvbnVsbCkgXV07IHRoZW4KIAkJdW5zZXQgLWYgZmluZCAjIFdlIGNhbiBqdXN0IHVzZSB0aGUg Y29tbWFuZCBmaW5kCi0JZWxpZiBbWyAkKGNvbW1hbmQgZmluZCAiJDAiIC1wZXJtIC91K3ggMj4g L2Rldi9udWxsKSBdXTsgdGhlbgorCWVsaWYgW1sgJChjb21tYW5kIGZpbmQgIiR0ZXN0c3ViamVj dCIgLXBlcm0gL3UreCAyPiAvZGV2L251bGwpIF1dOyB0aGVuCiAJCWZpbmQoKSB7CiAJCQlhPSgk e0AvLy1leGVjdXRhYmxlLy1wZXJtIFwvdSt4fSkKIAkJCWE9KCR7YVtAXS8vLXdyaXRhYmxlLy1w ZXJtIFwvdSt3fSkKIAkJCWE9KCR7YVtAXS8vLXJlYWRhYmxlLy1wZXJtIFwvcit3fSkKIAkJCWNv bW1hbmQgZmluZCAiJHthW0BdfSIKIAkJfQotCWVsaWYgW1sgJChjb21tYW5kIGZpbmQgIiQwIiAt cGVybSArdSt4IDI+IC9kZXYvbnVsbCkgXV07IHRoZW4KKwllbGlmIFtbICQoY29tbWFuZCBmaW5k ICIkdGVzdHN1YmplY3QiIC1wZXJtICt1K3ggMj4gL2Rldi9udWxsKSBdXTsgdGhlbgogCQlmaW5k KCkgewogCQkJYT0oJHtALy8tZXhlY3V0YWJsZS8tcGVybSArdSt4fSkKIAkJCWE9KCR7YVtAXS8v LXdyaXRhYmxlLy1wZXJtICt1K3d9KQpAQCAtMzY4LDcgKzM2OSw3IEBACiAJIyBIQUNLOiBUaGlz IGlzIGEgcmF0aGVyIG5vaXN5LCBidXQgcG9ydGFibGUgd2F5IHRvIGltcGxlbWVudCAtcXVpdAog CXdoaWxlIHJlYWQgTElTVDsgZG8KIAkJYnJlYWsgIyBTZXQgTElTVAotCWRvbmUgPCA8KGZpbmQg JEhPTUUvIC92YXIvdG1wLyAvdG1wLyAtd3JpdGFibGUpCisJZG9uZSA8IDwoZmluZCAkSE9NRS8g L3Zhci90bXAvIC90bXAvIC13cml0YWJsZSAtcHJpbnQpCiAJW1sgJExJU1QgXV0gfHwKIAkJZGll IDEgIlVuYWJsZSB0byBmaW5kIGEgc2F0aXNmYWN0b3J5IGxvY2F0aW9uIGZvciB0ZW1wb3Jhcnkg ZmlsZXMiCiAK