193404 2007-09-22 11:18 0000 media-libs/libsdl uses c++ (non c90 comments) in public headers 2007-10-21 00:34:44 0000 1 1 1 Unclassified Gentoo Linux Library unspecified All Linux RESOLVED FIXED http://bugzilla.libsdl.org/show_bug.cgi?id=474 P2 minor --- 1 robert.wohlrab@gmx.de games@gentoo.org robert.wohlrab@gmx.de 2007-09-22 11:18:48 0000 When you try to compile ansi c stuff with libsdl-1.2.12 you will produce errors or warnings due usage of c++ comments in public headers Reproducible: Always Steps to Reproduce: 1. emerge libsdl-1.2.12 2. compile c code using libsdl with -ansi (for more problems use -Wall -W -pedantic and co.) Actual Results: Errors and Warnings about non-C90 comments in begin_code.h Expected Results: a clean compile This is fixed upstream robert.wohlrab@gmx.de 2007-09-22 11:20:26 0000 Created an attachment (id=131587) Removed some C++ style comments from the public headers mr_bones_@gentoo.org 2007-10-21 00:34:44 0000 In portage. Thanks for the bug report. 131587 2007-09-22 11:20 0000 Removed some C++ style comments from the public headers libsdl-1.2.12-c90-comments.patch text/plain aHR0cDovL2J1Z3MuZ2VudG9vLm9yZy8xOTM0MDQKClJldmlzaW9uIDMzODYKTW90aWZpZWQgU3Vu IEF1ZyA1IDAzOjIxOjE4IDIwMDcgVVRDIGJ5IGljY3VsdXMKUmVtb3ZlZCBzb21lIEMrKyBzdHls ZSBjb21tZW50cyBmcm9tIHRoZSBwdWJsaWMgaGVhZGVycy4KCi0tLSBicmFuY2hlcy9TREwtMS4y L2luY2x1ZGUvYmVnaW5fY29kZS5oCTIwMDcvMDgvMDMgMDQ6MTM6MDMJMzM4NQorKysgYnJhbmNo ZXMvU0RMLTEuMi9pbmNsdWRlL2JlZ2luX2NvZGUuaAkyMDA3LzA4LzA1IDAzOjIxOjE4CTMzODYK QEAgLTkwLDggKzkwLDggQEAKICNlbGlmICFkZWZpbmVkKF9fV0lOU19fKQogI3VuZGVmIERFQ0xT UEVDCiAjZGVmaW5lIERFQ0xTUEVDIF9fZGVjbHNwZWMoZGxsZXhwb3J0KQotI2VuZGlmIC8vRUtB MgotI2VuZGlmIC8vX19TWU1CSUFOMzJfXworI2VuZGlmIC8qICFFS0EyICovCisjZW5kaWYgLyog X19TWU1CSUFOMzJfXyAqLwogCiAvKiBGb3JjZSBzdHJ1Y3R1cmUgcGFja2luZyBhdCA0IGJ5dGUg YWxpZ25tZW50LgogICAgVGhpcyBpcyBuZWNlc3NhcnkgaWYgdGhlIGhlYWRlciBpcyBpbmNsdWRl ZCBpbiBjb2RlIHdoaWNoIGhhcyBzdHJ1Y3R1cmUK