192556 2007-09-14 21:26 0000 linux-info's get_version should not fail on missing .config 2008-01-22 21:07:46 0000 1 1 1 Unclassified Gentoo Linux Eclasses and Profiles unspecified All Linux RESOLVED FIXED P2 critical --- 148390 1 wolf31o2@gentoo.org kernel-misc@gentoo.org netzdamon@gmail.com pva@gentoo.org stoile@anderedomain.de wolf31o2@gentoo.org 2007-09-14 21:26:59 0000 This is pretty simple. The get_version script shouldn't fail on a missing .config or it breaks any package which tries to do kernel checks prior to the kernel being built. The usual suspects are installer/release-building, so we'd like this to be fixed before we start 2007.1 early next month. I'm willing to help test this in any way. wolf31o2@gentoo.org 2008-01-10 19:33:54 0000 This is still an issue which will block release-building. Has there been any progress here? This really is critical for Release Engineering. slong@rathaus.eclipse.co.uk 2008-01-15 07:50:39 0000 This should fix it (obviously needs testing.) The main issue is that there's a config check wrapped in there for other functions in the eclass. I added a -c option to get_version so these functions can ask it to check the config file's existence. Checking the tree, I could only find the following ebuilds which call get_version and check_config (but didn't look for other stuff like check_zlibinflate -- the same principle should apply.) They all call get_version first, then check_config (which implies they need kernel configured.) In these cases what'll happen is the first call will check for the directory, and the second call to get_version (via check_config) will look for the config file. Please note: if linux-info_pkg_setup() is called with CONFIG_CHECK non-empty it will still bail if there is not a configured kernel (ll. 560-563) HTH; a release would do us all a lot of good. slong@rathaus.eclipse.co.uk 2008-01-15 07:52:20 0000 Created an attachment (id=140964) linux-info.eclass.patch slong@rathaus.eclipse.co.uk 2008-01-15 07:54:20 0000 Doh sorry for spam (except the *spying-on-igli bods ofc) ebuilds i forgot to list: /usr/portage/net-dialup/ppp/ppp-2.4.4-r11.ebuild /usr/portage/net-dialup/ppp/ppp-2.4.4-r13.ebuild /usr/portage/net-dialup/ppp/ppp-2.4.4-r9.ebuild /usr/portage/net-firewall/tuxfrw/tuxfrw-2.61.ebuild /usr/portage/net-misc/br2684ctl/br2684ctl-20040226.ebuild /usr/portage/net-misc/quagga/quagga-0.99.7-r1.ebuild /usr/portage/net-misc/quagga/quagga-0.99.9.ebuild wolf31o2@gentoo.org 2008-01-15 17:22:15 0000 (In reply to comment #2) > HTH; a release would do us all a lot of good. Was this really a necessary statement to even make? I'll check out the patch today. It sounds like it does exactly what we'll need. Thanks dsd@gentoo.org 2008-01-15 18:52:56 0000 Logically I think config checking should be it's own function. That would probably simplify your changes to get_version (which I have not yet reviewed). slong@rathaus.eclipse.co.uk 2008-01-17 10:33:19 0000 (In reply to comment #6) > Logically I think config checking should be it's own function. That would > probably simplify your changes to get_version (which I have not yet reviewed). > Agreed; I started to do a base get_version which could be called by a config checking one but it started to get tricky trying to maintain the internal api and eliminate code duplication. So I just went for a quick patch using a flag, for this issue, rather than sort the whole eclass out. It's really crufty for one, so I'd end up cleaning it all first; it was late on this side of the Atlantic, and I wasn't sure if it would be received in the spirit it was meant. One minor issue is that for git sources, the extra bit at end won't be picked up til a -c call is done. Hope it helps, good luck. Feel free to email if you need any tweaks to bash stuff, Daniel. Removing cc to avoid unnecessary spam. dsd@gentoo.org 2008-01-17 10:43:47 0000 It doesn't need to be that complicated: one simple (one-line?) function gives a return code whether the .config exists. Then, the get_version function operates with a .config file if there is one there, and without if there is not one. Anything requiring a .config calls the first function, and dies if the return code indicates nothing is there. dsd@gentoo.org 2008-01-22 21:07:46 0000 Alright, implemented that. Also fixed the case where CONFIG_CHECK wasn't requiring anything to actually be set/unset but a .config was being required and checked all the same. Sorry for the delay. 140964 2008-01-15 07:52 0000 linux-info.eclass.patch linux-info.eclass.patch text/plain LS0tIC91c3IvcG9ydGFnZS9lY2xhc3MvbGludXgtaW5mby5lY2xhc3MJMjAwNy0xMC0wMyAxNDow NTo1Mi4wMDAwMDAwMDAgKzAxMDAKKysrIC91c3IvbG9jYWwvcG9ydGFnZS9lY2xhc3MvbGludXgt aW5mby5lY2xhc3MJMjAwOC0wMS0xNSAwNzo1Mzo1OS4wMDAwMDAwMDAgKzAwMDAKQEAgLTE2OCw4 ICsxNjgsOCBAQAogIyBnb3QgdGhlIGppc3QgeWV0PwogCiBrZXJuZWxfaXMoKSB7Ci0JIyBpZiB3 ZSBoYXZlbid0IGRldGVybWluZWQgdGhlIHZlcnNpb24geWV0LCB3ZSBuZWVkIHRvby4KLQlnZXRf dmVyc2lvbjsKKwkjIGlmIHdlIGhhdmVuJ3QgZGV0ZXJtaW5lZCB0aGUgdmVyc2lvbiB5ZXQsIHdl IG5lZWQgdG8uCisJZ2V0X3ZlcnNpb24KIAlsb2NhbCBvcGVyYXRvciB0ZXN0IHZhbHVlIHg9MCB5 PTAgej0wCiAKIAljYXNlICR7MX0gaW4KQEAgLTIxNSw5MSArMjE1LDk2IEBACiAJZWNobyAke3h9 CiB9CiAKK2RlY2xhcmUgLWkgbGludXhJbmZvR290Q2ZnCisKKyMgQWRkZWQgLWMgb3B0aW9uIHRv IGNoZWNrIGNvbmZpZyBhcyB3ZWxsIChCdWcgMTkyNTU2KQorIyBUaGlzIG1lYW5zIGl0IHdvbid0 IGNoZWNrIGZvciBhIGNvbmZpZyBmaWxlIHdpdGhvdXQgLWMKIGdldF92ZXJzaW9uKCkgewotCWxv Y2FsIGtidWlsZF9vdXRwdXQKKwlsb2NhbCBrYnVpbGRfb3V0cHV0IGdldENmZz0wCisJW1sgJDEg PSAtYyBdXSAmJiBnZXRDZmc9MQogCiAJIyBubyBuZWVkIHRvIGV4ZWN1dGUgdGhpcyB0d2ljZSBh c3N1bWluZyBLVl9GVUxMIGlzIHBvcHVsYXRlZC4KLQkjIHdlIGNhbiBmb3JjZSBieSB1bnNldHRp bmcgS1ZfRlVMTAotCVsgLW4gIiR7S1ZfRlVMTH0iIF0gJiYgcmV0dXJuIDAKLQotCSMgaWYgd2Ug ZG9udCBrbm93IEtWX0ZVTEwsIHRoZW4gd2UgbmVlZCB0b28uCi0JIyBtYWtlIHN1cmUgS1ZfRElS IGlzbnQgc2V0IHNpbmNlIHdlIG5lZWQgdG8gd29yayBpdCBvdXQgdmlhIEtFUk5FTF9ESVIKLQl1 bnNldCBLVl9ESVIKLQotCSMgS1ZfRElSIHdpbGwgY29udGFpbiB0aGUgZnVsbCBwYXRoIHRvIHRo ZSBzb3VyY2VzIGRpcmVjdG9yeSB3ZSBzaG91bGQgdXNlCi0JcWVpbmZvICJEZXRlcm1pbmluZyB0 aGUgbG9jYXRpb24gb2YgdGhlIGtlcm5lbCBzb3VyY2UgY29kZSIKLQlbIC1oICIke0tFUk5FTF9E SVJ9IiBdICYmIEtWX0RJUj0iJChyZWFkbGluayAtZiAke0tFUk5FTF9ESVJ9KSIKLQlbIC1kICIk e0tFUk5FTF9ESVJ9IiBdICYmIEtWX0RJUj0iJHtLRVJORUxfRElSfSIKLQotCWlmIFsgLXogIiR7 S1ZfRElSfSIgXQotCXRoZW4KLQkJcWVlcnJvciAiVW5hYmxlIHRvIGZpbmQga2VybmVsIHNvdXJj ZXMgYXQgJHtLRVJORUxfRElSfSIKLQkJcWVpbmZvICJUaGlzIHBhY2thZ2UgcmVxdWlyZXMgTGlu dXggc291cmNlcy4iCi0JCWlmIFsgIiR7S0VSTkVMX0RJUn0iID09ICIvdXNyL3NyYy9saW51eCIg XSA7IHRoZW4KLQkJCXFlaW5mbyAiUGxlYXNlIG1ha2Ugc3VyZSB0aGF0ICR7S0VSTkVMX0RJUn0g cG9pbnRzIGF0IHlvdXIgcnVubmluZyBrZXJuZWwsICIKLQkJCXFlaW5mbyAiKG9yIHRoZSBrZXJu ZWwgeW91IHdpc2ggdG8gYnVpbGQgYWdhaW5zdCkuIgotCQkJcWVpbmZvICJBbHRlcm5hdGl2ZWx5 LCBzZXQgdGhlIEtFUk5FTF9ESVIgZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gdGhlIGtlcm5lbCBz b3VyY2VzIGxvY2F0aW9uIgotCQllbHNlCi0JCQlxZWluZm8gIlBsZWFzZSBlbnN1cmUgdGhhdCB0 aGUgS0VSTkVMX0RJUiBlbnZpcm9ubWVudCB2YXJpYWJsZSBwb2ludHMgYXQgZnVsbCBMaW51eCBz b3VyY2VzIG9mIHRoZSBrZXJuZWwgeW91IHdpc2ggdG8gY29tcGlsZSBhZ2FpbnN0LiIKKwkjIHdl IGNhbiBmb3JjZSBieSB1bnNldHRpbmcgS1ZfRlVMTCwgb3Igc2V0dGluZyBpdCBlbXB0eQorCVtb ICRLVl9GVUxMIF1dICYmICgoIWdldENmZ3x8bGludXhJbmZvR290Q2ZnKSkgJiYgcmV0dXJuIDAK KwlbWyAkS1ZfRlVMTCBdXSB8fCB7CisJCSMgaWYgd2UgZG9udCBrbm93IEtWX0ZVTEwsIHRoZW4g d2UgbmVlZCB0b28uCisJCSMgbWFrZSBzdXJlIEtWX0RJUiBpc250IHNldCBzaW5jZSB3ZSBuZWVk IHRvIHdvcmsgaXQgb3V0IHZpYSBLRVJORUxfRElSCisJCXVuc2V0IEtWX0RJUgorCQorCQkjIEtW X0RJUiB3aWxsIGNvbnRhaW4gdGhlIGZ1bGwgcGF0aCB0byB0aGUgc291cmNlcyBkaXJlY3Rvcnkg d2Ugc2hvdWxkIHVzZQorCQlxZWluZm8gIkRldGVybWluaW5nIHRoZSBsb2NhdGlvbiBvZiB0aGUg a2VybmVsIHNvdXJjZSBjb2RlIgorCQlbIC1oICIke0tFUk5FTF9ESVJ9IiBdICYmIEtWX0RJUj0i JChyZWFkbGluayAtZiAke0tFUk5FTF9ESVJ9KSIKKwkJWyAtZCAiJHtLRVJORUxfRElSfSIgXSAm JiBLVl9ESVI9IiR7S0VSTkVMX0RJUn0iCisJCisJCWlmIFsgLXogIiR7S1ZfRElSfSIgXQorCQl0 aGVuCisJCQlxZWVycm9yICJVbmFibGUgdG8gZmluZCBrZXJuZWwgc291cmNlcyBhdCAke0tFUk5F TF9ESVJ9IgorCQkJcWVpbmZvICJUaGlzIHBhY2thZ2UgcmVxdWlyZXMgTGludXggc291cmNlcy4i CisJCQlpZiBbICIke0tFUk5FTF9ESVJ9IiA9PSAiL3Vzci9zcmMvbGludXgiIF0gOyB0aGVuCisJ CQkJcWVpbmZvICJQbGVhc2UgbWFrZSBzdXJlIHRoYXQgJHtLRVJORUxfRElSfSBwb2ludHMgYXQg eW91ciBydW5uaW5nIGtlcm5lbCwgIgorCQkJCXFlaW5mbyAiKG9yIHRoZSBrZXJuZWwgeW91IHdp c2ggdG8gYnVpbGQgYWdhaW5zdCkuIgorCQkJCXFlaW5mbyAiQWx0ZXJuYXRpdmVseSwgc2V0IHRo ZSBLRVJORUxfRElSIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIHRoZSBrZXJuZWwgc291cmNlcyBs b2NhdGlvbiIKKwkJCWVsc2UKKwkJCQlxZWluZm8gIlBsZWFzZSBlbnN1cmUgdGhhdCB0aGUgS0VS TkVMX0RJUiBlbnZpcm9ubWVudCB2YXJpYWJsZSBwb2ludHMgYXQgZnVsbCBMaW51eCBzb3VyY2Vz IG9mIHRoZSBrZXJuZWwgeW91IHdpc2ggdG8gY29tcGlsZSBhZ2FpbnN0LiIKKwkJCWZpCisJCQly ZXR1cm4gMQogCQlmaQotCQlyZXR1cm4gMQotCWZpCi0KLQlxZWluZm8gIkZvdW5kIGtlcm5lbCBz b3VyY2UgZGlyZWN0b3J5OiIKLQlxZWluZm8gIiAgICAke0tWX0RJUn0iCi0KLQlpZiBbICEgLXMg IiR7S1ZfRElSfS9NYWtlZmlsZSIgXQotCXRoZW4KLQkJcWVlcnJvciAiQ291bGQgbm90IGZpbmQg YSBNYWtlZmlsZSBpbiB0aGUga2VybmVsIHNvdXJjZSBkaXJlY3RvcnkuIgotCQlxZWVycm9yICJQ bGVhc2UgZW5zdXJlIHRoYXQgJHtLRVJORUxfRElSfSBwb2ludHMgdG8gYSBjb21wbGV0ZSBzZXQg b2YgTGludXggc291cmNlcyIKLQkJcmV0dXJuIDEKLQlmaQotCi0JIyBPSyBzbyBub3cgd2Uga25v dyBvdXIgc291cmNlcyBkaXJlY3RvcnksIGJ1dCB0aGV5IG1pZ2h0IGJlIHVzaW5nCi0JIyBLQlVJ TERfT1VUUFVULCBhbmQgd2UgbmVlZCB0aGlzIGZvciAuY29uZmlnIGFuZCBsb2NhbHZlcnNpb25z LSoKLQkjIHNvIHdlIGJldHRlciBmaW5kIGl0IGVoPwotCSMgZG8gd2UgcGFzcyBLQlVJTERfT1VU UFVUIG9uIHRoZSBDTEk/Ci0JT1VUUFVUX0RJUj0iJHtPVVRQVVRfRElSOi0ke0tCVUlMRF9PVVRQ VVR9fSIKLQotCSMgQW5kIGlmIHdlIGRpZG4ndCBwYXNzIGl0LCB3ZSBjYW4gdGFrZSBhIG5vc2V5 IGluIHRoZSBNYWtlZmlsZQotCWtidWlsZF9vdXRwdXQ9IiQoZ2V0ZmlsZXZhciBLQlVJTERfT1VU UFVUICR7S1ZfRElSfS9NYWtlZmlsZSkiCi0JT1VUUFVUX0RJUj0iJHtPVVRQVVRfRElSOi0ke2ti dWlsZF9vdXRwdXR9fSIKLQotCSMgQW5kIGNvbnRyYXJ5IHRvIGV4aXN0aW5nIGZ1bmN0aW9ucyBJ IGZlZWwgd2Ugc2hvdWxkbid0IHRydXN0IHRoZQotCSMgZGlyZWN0b3J5IG5hbWUgdG8gZmluZCB2 ZXJzaW9uIGluZm9ybWF0aW9uIGFzIHRoaXMgc2VlbXMgaW5zYW5lLgotCSMgc28gd2UgcGFyc2Ug JHtLVl9ESVJ9L01ha2VmaWxlCi0JS1ZfTUFKT1I9IiQoZ2V0ZmlsZXZhciBWRVJTSU9OICR7S1Zf RElSfS9NYWtlZmlsZSkiCi0JS1ZfTUlOT1I9IiQoZ2V0ZmlsZXZhciBQQVRDSExFVkVMICR7S1Zf RElSfS9NYWtlZmlsZSkiCi0JS1ZfUEFUQ0g9IiQoZ2V0ZmlsZXZhciBTVUJMRVZFTCAke0tWX0RJ Un0vTWFrZWZpbGUpIgotCUtWX0VYVFJBPSIkKGdldGZpbGV2YXIgRVhUUkFWRVJTSU9OICR7S1Zf RElSfS9NYWtlZmlsZSkiCi0KLQlpZiBbIC16ICIke0tWX01BSk9SfSIgLW8gLXogIiR7S1ZfTUlO T1J9IiAtbyAteiAiJHtLVl9QQVRDSH0iIF0KLQl0aGVuCi0JCXFlZXJyb3IgIkNvdWxkIG5vdCBk ZXRlY3Qga2VybmVsIHZlcnNpb24uIgotCQlxZWVycm9yICJQbGVhc2UgZW5zdXJlIHRoYXQgJHtL RVJORUxfRElSfSBwb2ludHMgdG8gYSBjb21wbGV0ZSBzZXQgb2YgTGludXggc291cmNlcy4iCi0J CXJldHVybiAxCi0JZmkKLQotCSMgYW5kIGluIG5ld2VyIHZlcnNpb25zIHdlIGNhbiBhbHNvIHB1 bGwgTE9DQUxWRVJTSU9OIGlmIGl0IGlzIHNldC4KLQkjIGJ1dCBiZWZvcmUgd2UgZG8gdGhpcywg d2UgbmVlZCB0byBmaW5kIGlmIHdlIHVzZSBhIGRpZmZlcmVudCBvYmplY3QgZGlyZWN0b3J5Lgot CSMgVGhpcyAqV0lMTCogYnJlYWsgaWYgdGhlIHVzZXIgaXMgdXNpbmcgbG9jYWx2ZXJzaW9ucywg YnV0IHdlIGFzc3VtZSBpdCB3YXMKLQkjIGNhdWdodCBiZWZvcmUgdGhpcyBpZiB0aGV5IGFyZS4K LQlbICIke0tWX01BSk9SfS4ke0tWX01JTk9SfS4ke0tWX1BBVENIfSR7S1ZfRVhUUkF9IiA9PSAi JCh1bmFtZSAtcikiIF0gJiYgXAotCQlPVVRQVVRfRElSPSIke09VVFBVVF9ESVI6LS9saWIvbW9k dWxlcy8ke0tWX01BSk9SfS4ke0tWX01JTk9SfS4ke0tWX1BBVENIfSR7S1ZfRVhUUkF9L2J1aWxk fSIKLQotCVsgLWggIiR7T1VUUFVUX0RJUn0iIF0gJiYgS1ZfT1VUX0RJUj0iJChyZWFkbGluayAt ZiAke09VVFBVVF9ESVJ9KSIKLQlbIC1kICIke09VVFBVVF9ESVJ9IiBdICYmIEtWX09VVF9ESVI9 IiR7T1VUUFVUX0RJUn0iCi0JaWYgWyAtbiAiJHtLVl9PVVRfRElSfSIgXTsKLQl0aGVuCi0JCXFl aW5mbyAiRm91bmQga2VybmVsIG9iamVjdCBkaXJlY3Rvcnk6IgotCQlxZWluZm8gIiAgICAke0tW X09VVF9ESVJ9IgotCi0JCUtWX0xPQ0FMPSIkKGdldF9sb2NhbHZlcnNpb24gJHtLVl9PVVRfRElS fSkiCi0JZmkKLQkjIGFuZCBpZiB3ZSBTVElMTCBoYXZlIG5vdCBnb3QgaXQsIHRoZW4gd2UgYmV0 dGVyIGp1c3Qgc2V0IGl0IHRvIEtWX0RJUgotCUtWX09VVF9ESVI9IiR7S1ZfT1VUX0RJUjotJHtL Vl9ESVJ9fSIKLQotCWlmIFsgISAtcyAiJHtLVl9PVVRfRElSfS8uY29uZmlnIiBdCisJCisJCXFl aW5mbyAiRm91bmQga2VybmVsIHNvdXJjZSBkaXJlY3Rvcnk6IgorCQlxZWluZm8gIiAgICAke0tW X0RJUn0iCisJCisJCWlmIFsgISAtcyAiJHtLVl9ESVJ9L01ha2VmaWxlIiBdCisJCXRoZW4KKwkJ CXFlZXJyb3IgIkNvdWxkIG5vdCBmaW5kIGEgTWFrZWZpbGUgaW4gdGhlIGtlcm5lbCBzb3VyY2Ug ZGlyZWN0b3J5LiIKKwkJCXFlZXJyb3IgIlBsZWFzZSBlbnN1cmUgdGhhdCAke0tFUk5FTF9ESVJ9 IHBvaW50cyB0byBhIGNvbXBsZXRlIHNldCBvZiBMaW51eCBzb3VyY2VzIgorCQkJcmV0dXJuIDEK KwkJZmkKKwkKKwkJIyBPSyBzbyBub3cgd2Uga25vdyBvdXIgc291cmNlcyBkaXJlY3RvcnksIGJ1 dCB0aGV5IG1pZ2h0IGJlIHVzaW5nCisJCSMgS0JVSUxEX09VVFBVVCwgYW5kIHdlIG5lZWQgdGhp cyBmb3IgLmNvbmZpZyBhbmQgbG9jYWx2ZXJzaW9ucy0qCisJCSMgc28gd2UgYmV0dGVyIGZpbmQg aXQgZWg/CisJCSMgZG8gd2UgcGFzcyBLQlVJTERfT1VUUFVUIG9uIHRoZSBDTEk/CisJCU9VVFBV VF9ESVI9IiR7T1VUUFVUX0RJUjotJHtLQlVJTERfT1VUUFVUfX0iCisJCisJCSMgQW5kIGlmIHdl IGRpZG4ndCBwYXNzIGl0LCB3ZSBjYW4gdGFrZSBhIG5vc2V5IGluIHRoZSBNYWtlZmlsZQorCQlr YnVpbGRfb3V0cHV0PSIkKGdldGZpbGV2YXIgS0JVSUxEX09VVFBVVCAke0tWX0RJUn0vTWFrZWZp bGUpIgorCQlPVVRQVVRfRElSPSIke09VVFBVVF9ESVI6LSR7a2J1aWxkX291dHB1dH19IgorCQor CQkjIEFuZCBjb250cmFyeSB0byBleGlzdGluZyBmdW5jdGlvbnMgSSBmZWVsIHdlIHNob3VsZG4n dCB0cnVzdCB0aGUKKwkJIyBkaXJlY3RvcnkgbmFtZSB0byBmaW5kIHZlcnNpb24gaW5mb3JtYXRp b24gYXMgdGhpcyBzZWVtcyBpbnNhbmUuCisJCSMgc28gd2UgcGFyc2UgJHtLVl9ESVJ9L01ha2Vm aWxlCisJCUtWX01BSk9SPSIkKGdldGZpbGV2YXIgVkVSU0lPTiAke0tWX0RJUn0vTWFrZWZpbGUp IgorCQlLVl9NSU5PUj0iJChnZXRmaWxldmFyIFBBVENITEVWRUwgJHtLVl9ESVJ9L01ha2VmaWxl KSIKKwkJS1ZfUEFUQ0g9IiQoZ2V0ZmlsZXZhciBTVUJMRVZFTCAke0tWX0RJUn0vTWFrZWZpbGUp IgorCQlLVl9FWFRSQT0iJChnZXRmaWxldmFyIEVYVFJBVkVSU0lPTiAke0tWX0RJUn0vTWFrZWZp bGUpIgorCQorCQlpZiBbIC16ICIke0tWX01BSk9SfSIgLW8gLXogIiR7S1ZfTUlOT1J9IiAtbyAt eiAiJHtLVl9QQVRDSH0iIF0KKwkJdGhlbgorCQkJcWVlcnJvciAiQ291bGQgbm90IGRldGVjdCBr ZXJuZWwgdmVyc2lvbi4iCisJCQlxZWVycm9yICJQbGVhc2UgZW5zdXJlIHRoYXQgJHtLRVJORUxf RElSfSBwb2ludHMgdG8gYSBjb21wbGV0ZSBzZXQgb2YgTGludXggc291cmNlcy4iCisJCQlyZXR1 cm4gMQorCQlmaQorCQorCQkjIGFuZCBpbiBuZXdlciB2ZXJzaW9ucyB3ZSBjYW4gYWxzbyBwdWxs IExPQ0FMVkVSU0lPTiBpZiBpdCBpcyBzZXQuCisJCSMgYnV0IGJlZm9yZSB3ZSBkbyB0aGlzLCB3 ZSBuZWVkIHRvIGZpbmQgaWYgd2UgdXNlIGEgZGlmZmVyZW50IG9iamVjdCBkaXJlY3RvcnkuCisJ CSMgVGhpcyAqV0lMTCogYnJlYWsgaWYgdGhlIHVzZXIgaXMgdXNpbmcgbG9jYWx2ZXJzaW9ucywg YnV0IHdlIGFzc3VtZSBpdCB3YXMKKwkJIyBjYXVnaHQgYmVmb3JlIHRoaXMgaWYgdGhleSBhcmUu CisJCVsgIiR7S1ZfTUFKT1J9LiR7S1ZfTUlOT1J9LiR7S1ZfUEFUQ0h9JHtLVl9FWFRSQX0iID09 ICIkKHVuYW1lIC1yKSIgXSAmJiBcCisJCQlPVVRQVVRfRElSPSIke09VVFBVVF9ESVI6LS9saWIv bW9kdWxlcy8ke0tWX01BSk9SfS4ke0tWX01JTk9SfS4ke0tWX1BBVENIfSR7S1ZfRVhUUkF9L2J1 aWxkfSIKKwkKKwkJWyAtaCAiJHtPVVRQVVRfRElSfSIgXSAmJiBLVl9PVVRfRElSPSIkKHJlYWRs aW5rIC1mICR7T1VUUFVUX0RJUn0pIgorCQlbIC1kICIke09VVFBVVF9ESVJ9IiBdICYmIEtWX09V VF9ESVI9IiR7T1VUUFVUX0RJUn0iCisJCWlmIFsgLW4gIiR7S1ZfT1VUX0RJUn0iIF07CisJCXRo ZW4KKwkJCXFlaW5mbyAiRm91bmQga2VybmVsIG9iamVjdCBkaXJlY3Rvcnk6IgorCQkJcWVpbmZv ICIgICAgJHtLVl9PVVRfRElSfSIKKwkKKwkJCUtWX0xPQ0FMPSIkKGdldF9sb2NhbHZlcnNpb24g JHtLVl9PVVRfRElSfSkiCisJCWZpCisJCSMgYW5kIGlmIHdlIFNUSUxMIGhhdmUgbm90IGdvdCBp dCwgdGhlbiB3ZSBiZXR0ZXIganVzdCBzZXQgaXQgdG8gS1ZfRElSCisJCUtWX09VVF9ESVI9IiR7 S1ZfT1VUX0RJUjotJHtLVl9ESVJ9fSIKKwl9CisJaWYgKChnZXRDZmcpKSAmJiBbICEgLXMgIiR7 S1ZfT1VUX0RJUn0vLmNvbmZpZyIgXQogCXRoZW4KIAkJcWVlcnJvciAiQ291bGQgbm90IGZpbmQg YSB1c2FibGUgLmNvbmZpZyBpbiB0aGUga2VybmVsIHNvdXJjZSBkaXJlY3RvcnkuIgogCQlxZWVy cm9yICJQbGVhc2UgZW5zdXJlIHRoYXQgJHtLRVJORUxfRElSfSBwb2ludHMgdG8gYSBjb25maWd1 cmVkIHNldCBvZiBMaW51eCBzb3VyY2VzLiIKQEAgLTMwOSwyMCArMzE0LDIwIEBACiAJZmkKIAog CUtWX0xPQ0FMPSIke0tWX0xPQ0FMfSQoZ2V0X2xvY2FsdmVyc2lvbiAke0tWX0RJUn0pIgotCUtW X0xPQ0FMPSIke0tWX0xPQ0FMfSQobGludXhfY2hrY29uZmlnX3N0cmluZyBMT0NBTFZFUlNJT04p IgorCSgoZ2V0Q2ZnKSkgJiYgS1ZfTE9DQUw9IiR7S1ZfTE9DQUx9JChsaW51eF9jaGtjb25maWdf c3RyaW5nIExPQ0FMVkVSU0lPTikiCiAJS1ZfTE9DQUw9IiR7S1ZfTE9DQUwvL1wiL30iCiAKIAkj IEZvciB0aGluZ3MgbGlrZSBnaXQgdGhhdCBjYW4gYXBwZW5kIGV4dHJhIHN0dWZmOgotCVsgLWUg JHtLVl9ESVJ9L3NjcmlwdHMvc2V0bG9jYWx2ZXJzaW9uIF0gJiYKKwkoKGdldENmZykpICYmIFtb IC1lICR7S1ZfRElSfS9zY3JpcHRzL3NldGxvY2FsdmVyc2lvbiBdXSAmJgogCQlsaW51eF9jaGtj b25maWdfYnVpbHRpbiBMT0NBTFZFUlNJT05fQVVUTyAmJgotCQlLVl9MT0NBTD0iJHtLVl9MT0NB TH0kKHNoICR7S1ZfRElSfS9zY3JpcHRzL3NldGxvY2FsdmVyc2lvbiAke0tWX0RJUn0pIgorCQkJ S1ZfTE9DQUw9IiR7S1ZfTE9DQUx9JChzaCAke0tWX0RJUn0vc2NyaXB0cy9zZXRsb2NhbHZlcnNp b24gJHtLVl9ESVJ9KSIKIAogCSMgQW5kIHdlIHNob3VsZCBzZXQgS1ZfRlVMTCB0byB0aGUgZnVs bCBleHBhbmRlZCB2ZXJzaW9uCiAJS1ZfRlVMTD0iJHtLVl9NQUpPUn0uJHtLVl9NSU5PUn0uJHtL Vl9QQVRDSH0ke0tWX0VYVFJBfSR7S1ZfTE9DQUx9IgogCiAJcWVpbmZvICJGb3VuZCBzb3VyY2Vz IGZvciBrZXJuZWwgdmVyc2lvbjoiCiAJcWVpbmZvICIgICAgJHtLVl9GVUxMfSIKLQorCSgoZ2V0 Q2ZnKSkgJiYgbGludXhJbmZvR290Q2ZnPTEKIAlyZXR1cm4gMAogfQogCkBAIC0zNTYsNyArMzYx LDcgQEAKIAogY2hlY2tfa2VybmVsX2J1aWx0KCkgewogCSMgaWYgd2UgaGF2ZW4ndCBkZXRlcm1p bmVkIHRoZSB2ZXJzaW9uIHlldCwgd2UgbmVlZCB0b28uCi0JZ2V0X3ZlcnNpb247CisJZ2V0X3Zl cnNpb24KIAogCWlmIFsgISAtZiAiJHtLVl9PVVRfRElSfS9pbmNsdWRlL2xpbnV4L3ZlcnNpb24u aCIgXQogCXRoZW4KQEAgLTM3NCw4ICszNzksNyBAQAogfQogCiBjaGVja19tb2R1bGVzX3N1cHBv cnRlZCgpIHsKLQkjIGlmIHdlIGhhdmVuJ3QgZGV0ZXJtaW5lZCB0aGUgdmVyc2lvbiB5ZXQsIHdl IG5lZWQgdG9vLgotCWdldF92ZXJzaW9uOworCWdldF92ZXJzaW9uIC1jIHx8IGRpZSAnTm8ga2Vy bmVsIGNvbmZpZycKIAogCWlmICEgbGludXhfY2hrY29uZmlnX2J1aWx0aW4gIk1PRFVMRVMiCiAJ dGhlbgpAQCAtMzkwLDggKzM5NCw3IEBACiAJbG9jYWwJY29uZmlnIG5lZ2F0ZSBkaWUgZXJyb3Ig cmV3b3JrbW9kdWxlbmFtZXMKIAlsb2NhbAlzb2Z0X2Vycm9yc19jb3VudD0wIGhhcmRfZXJyb3Jz X2NvdW50PTAKIAotCSMgaWYgd2UgaGF2ZW4ndCBkZXRlcm1pbmVkIHRoZSB2ZXJzaW9uIHlldCwg d2UgbmVlZCB0b28uCi0JZ2V0X3ZlcnNpb247CisJZ2V0X3ZlcnNpb24gLWMgfHwgZGllICdObyBr ZXJuZWwgY29uZmlnJwogCiAJZWluZm8gIkNoZWNraW5nIGZvciBzdWl0YWJsZSBrZXJuZWwgY29u ZmlndXJhdGlvbiBvcHRpb25zLi4uIgogCWZvciBjb25maWcgaW4gJHtDT05GSUdfQ0hFQ0t9CkBA IC00ODIsOCArNDg1LDcgQEAKIH0KIAogY2hlY2tfemxpYmluZmxhdGUoKSB7Ci0JIyBpZiB3ZSBo YXZlbid0IGRldGVybWluZWQgdGhlIHZlcnNpb24geWV0LCB3ZSBuZWVkIHRvby4KLQlnZXRfdmVy c2lvbjsKKwlnZXRfdmVyc2lvbiAtYyB8fCBkaWUgJ05vIGtlcm5lbCBjb25maWcnCiAKIAkjIGFs dGhvdWdoIEkgcmVzdHJ1Y3R1cmVkIHRoaXMgY29kZSAtIEkgcmVhbGx5IHJlYWxseSByZWFsbHkg ZG9udCBzdXBwb3J0IGl0IQogCkBAIC01NTUsNyArNTU3LDEwIEBACiAjIEFsc28gdXNlZCB3aGVu IGluaGVyaXRpbmcgbGludXgtbW9kIHRvIGZvcmNlIGEgZ2V0X3ZlcnNpb24gY2FsbAogCiBsaW51 eC1pbmZvX3BrZ19zZXR1cCgpIHsKLQlnZXRfdmVyc2lvbiB8fCBkaWUgIlVuYWJsZSB0byBjYWxj dWxhdGUgTGludXggS2VybmVsIHZlcnNpb24iCisJaWYgW1sgJENPTkZJR19DSEVDSyBdXTsgdGhl bgorCQlnZXRfdmVyc2lvbiAtYyB8fCBkaWUgJ05vIGtlcm5lbCBjb25maWcnCisJZWxzZSBnZXRf dmVyc2lvbgorCWZpCiAKIAlpZiBrZXJuZWxfaXMgMiA0OyB0aGVuCiAJCWlmIFsgIiQoIGdjYy1t YWpvci12ZXJzaW9uICkiIC1lcSAiNCIgXSA7IHRoZW4KQEAgLTU3Myw1ICs1NzgsNSBAQAogCQlm aQogCWZpCiAKLQlbIC1uICIke0NPTkZJR19DSEVDS30iIF0gJiYgY2hlY2tfZXh0cmFfY29uZmln OworCVtbICRDT05GSUdfQ0hFQ0sgXV0gJiYgY2hlY2tfZXh0cmFfY29uZmlnCiB9Cg==