190006 2007-08-24 07:59 0000 app-office/koffice-1.6.3: invalid desktop entries 2009-05-27 09:16:02 0000 1 1 1 Unclassified Gentoo Linux KDE 2007.0 All All RESOLVED FIXED P2 trivial --- 189364 1 Martin.vGagern@gmx.net kde@gentoo.org chain@rpgfiction.net esigra@gmail.com Martin.vGagern@gmx.net 2007-08-24 07:59:17 0000 After remerging kexi, I got an elog mail: /usr/share/applications/kde/kexi.desktop: value "application/x-kexiproject-sqlite;application/x-sqlite2;application/x-kexiproject-shortcut;application/x-kexiproject-sqlite2;application/x-kexiproject-sqlite3;application/x-sqlite3;application/x-kexi-connectiondata;application/x-msaccess" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character Checking all my desktop files, I found the following KOffice ebuilds had installed files containing errors: app-office/karbon-1.6.2 app-office/kchart-1.6.3 app-office/kexi-1.6.3 app-office/kformula-1.6.2 app-office/kivio-1.6.2 app-office/koffice-data-1.6.3 app-office/koffice-libs-1.6.3 app-office/kplato-1.6.2 app-office/kpresenter-1.6.3 app-office/krita-1.6.3 app-office/kspread-1.6.2 app-office/kugar-1.6.2 app-office/kword-1.6.3-r1 Martin.vGagern@gmx.net 2007-08-24 08:41:32 0000 As Jakub changed the Summary to give an explicit package name, I should say that I've got koffice-meta here, as you can probably tell from the above package list. I would assume, however, that the single package would contain the same errors. tanderson@gentoo.org 2007-08-26 12:05:36 0000 Ok, I am going to work on this bug, but I would prefer the input from some gentoo devs on the best way to go about it. Would it be best to sed the file? Or would a patch that is sendable to upstream be more appropriate? Either way I can do it, but the question of what type of fix to use is stopping me from fixing it. Thanks. tanderson@gentoo.org 2007-08-26 12:49:54 0000 Created an attachment (id=129236) Ebuild diff for app-portage/kexi-1.6.3 to fix the desktop file. I'll put patches for the others as I finish them tanderson@gentoo.org 2007-08-26 13:34:34 0000 Created an attachment (id=129238) Karbon patch I tested this one, Philantrop. :) tanderson@gentoo.org 2007-08-26 22:45:51 0000 Created an attachment (id=129268) Patch for Kformula tanderson@gentoo.org 2007-08-27 00:09:58 0000 Created an attachment (id=129269) Patch for Kword tanderson@gentoo.org 2007-08-27 12:52:38 0000 Created an attachment (id=129319) Patch for Krita Thanks to kojiro for help with the regular expression. tanderson@gentoo.org 2007-08-27 13:17:18 0000 Created an attachment (id=129321) Patch for Kchart tanderson@gentoo.org 2007-08-27 21:27:14 0000 Created an attachment (id=129377) Patch for Kivio jakub@gentoo.org 2007-10-26 09:33:04 0000 *** Bug 197113 has been marked as a duplicate of this bug. *** carlo@gentoo.org 2009-02-09 01:44:14 0000 With the 1.6.3_p20090204 ebuilds the desktop files are all fixed - at least to the degree it's possible, given that KDE's desktop files are not entirely standard compliant. A general remark - a patch should always be preferred to sed expressions for at least two reasons: As a Gentoo dev we signed¹, that our fixes reach upstream and not doing so is bad practice. A sed expression is also to be avoided, because it may linger around in ebuilds/eclasses, even when it isn't needed anymore. Expensive QA work is the result. sed expressions are only to be used for inevitable dynamic changes, stuff not going upstream, like branding etc.. When you fix desktop files, please rerun desktop-file-validate yourself and fix the (suppressed) warnings as well. [1] http://www.gentoo.org/main/en/contract.xml 129236 2007-08-26 12:49 0000 Ebuild diff for app-portage/kexi-1.6.3 to fix the desktop file. diff text/plain LS0tIGtleGktMS42LjMuZWJ1aWxkLm9yZwkyMDA3LTA4LTI2IDA4OjM4OjE5LjAwMDAwMDAwMCAt MDQwMAorKysga2V4aS0xLjYuMy5lYnVpbGQJMjAwNy0wOC0yNiAwODozNDo0Ni4wMDAwMDAwMDAg LTA0MDAKQEAgLTM5LDYgKzM5LDE0IEBACiAKIG5lZWQta2RlIDMuNQogCitzcmNfdW5wYWNrKCkg eworCWtkZS1tZXRhX3NyY191bnBhY2sKKworCWVpbmZvICJTZWQnaW5nIGtleGkuZGVza3RvcC4u LiIKKwljZCAke1N9CisJc2VkIC1pIC1lICJzLy1tc2FjY2Vzcy8tbXNhY2Nlc3NcOy9nIiBrZXhp L2tleGkuZGVza3RvcCB8fCBkaWUgIlNlZCBmYWlsZWQhIgorCit9CiBzcmNfY29tcGlsZSgpIHsK IAlsb2NhbCBteWNvbmY9IiQodXNlX2VuYWJsZSBteXNxbCkgJCh1c2VfZW5hYmxlIHBvc3RncmVz IHBnc3FsKSAtLWVuYWJsZS1rZXhpLXJlcG9ydHMiCiAK 129238 2007-08-26 13:34 0000 Karbon patch diff text/plain LS0tIGthcmJvbi0xLjYuMi5lYnVpbGQub3JnCTIwMDctMDgtMjYgMDk6MDM6MDAuMDAwMDAwMDAw IC0wNDAwCisrKyBrYXJib24tMS42LjIuZWJ1aWxkCTIwMDctMDgtMjYgMDk6MDY6MzguMDAwMDAw MDAwIC0wNDAwCkBAIC00OSw0ICs0OSw4IEBACiAJZWNobyAiU1VCRElSUyA9IGxpYm9vZmlsdGVy IGthcmJvbiIgPiAkUy9maWx0ZXJzL01ha2VmaWxlLmFtCiAKIAlrZGUtbWV0YV9zcmNfdW5wYWNr IG1ha2VmaWxlcworCisJY2QgJHtTfQorCXNlZCAtaSAtZSAicy9wb3N0c2NyaXB0JC9wb3N0c2Ny aXB0Oy9nIiAke1N9L2thcmJvbi9kYXRhL2thcmJvbi5kZXNrdG9wIHx8IFwKKwlkaWUgIlNlZCBG YWlsZWQhIgogfQo= 129268 2007-08-26 22:45 0000 Patch for Kformula diff text/plain LS0tIGtmb3JtdWxhLTEuNi4yLmVidWlsZC5vcmcJMjAwNy0wOC0yNiAxNjo1Nzo0My4wMDAwMDAw MDAgLTA0MDAKKysrIGtmb3JtdWxhLTEuNi4yLmVidWlsZAkyMDA3LTA4LTI2IDE3OjEyOjIyLjAw MDAwMDAwMCAtMDQwMApAQCAtMzQsMyArMzQsMTIgQEAKIEtNRVhUUkE9ImZpbHRlcnMva2Zvcm11 bGEiCiAKIG5lZWQta2RlIDMuNAorCitzcmNfdW5wYWNrKCkgeworCWtkZS1tZXRhX3NyY191bnBh Y2sKKworCWVpbmZvICJGaXhpbmcgRGVza3RvcCBFbnRyeS4uLiIKKwljZCAke1N9CisJc2VkIC1p IC1lICJzL3gta2Zvcm11bGEkL3gta2Zvcm11bGE7L2ciIGtmb3JtdWxhL2tmb3JtdWxhLmRlc2t0 b3AgfHwgZGllIFwKKwkiU2VkIEZhaWxlZCEiCit9Cg== 129269 2007-08-27 00:09 0000 Patch for Kword diff text/plain LS0tIGt3b3JkLTEuNi4zLXIxLmVidWlsZC5vcmcJMjAwNy0wOC0yNiAyMDowODowNC4wMDAwMDAw MDAgLTA0MDAKKysrIGt3b3JkLTEuNi4zLXIxLmVidWlsZAkyMDA3LTA4LTI2IDE5OjIxOjQwLjAw MDAwMDAwMCAtMDQwMApAQCAtNTYsNCArNTYsOCBAQAogCWRvbmUKIAogCWtkZS1tZXRhX3NyY191 bnBhY2sgbWFrZWZpbGVzCisKKwllaW5mbyAiRml4aW5nIERlc2t0b3AgRW50cnkuLi4iCisJc2Vk IC1pIC1lICJzL3gtbXN3cml0ZS94LW1zd3JpdGU7L2ciICR7U30va3dvcmQva3dvcmQuZGVza3Rv cCB8fCBkaWUgXAorCSJTZWQgRmFpbGVkISIKIH0K 129319 2007-08-27 12:52 0000 Patch for Krita diff text/plain LS0tIGtyaXRhLTEuNi4zLmVidWlsZC5vcmcJMjAwNy0wOC0yNyAwODo0OTo1MS4wMDAwMDAwMDAg LTA0MDAKKysrIGtyaXRhLTEuNi4zLmVidWlsZAkyMDA3LTA4LTI2IDIwOjU1OjMzLjAwMDAwMDAw MCAtMDQwMApAQCAtNjAsNiArNjAsMTAgQEAKIAkjIEZJWE1FIC0gZGlzYWJsZSBicm9rZW4gdGVz dHMgZm9yIG5vdwogCXNlZCAtaSAtZSAiczpURVNUU0RJUiA9Lio6VEVTVFNESVI9OiIgJHtTfS9r cml0YS9jb3JlL01ha2VmaWxlLmFtIFwKIAkJYGxzICR7U30va3JpdGEvY29sb3JzcGFjZXMvKi9N YWtlZmlsZS5hbWAKKworCWVpbmZvICJGaXhpbmcgRGVza3RvcCBFbnRyaWVzLi4uIgorCXNlZCAt aSAtZSAiL15SL3sgL1teWV0kL3sgcy8kL1kvZzsgfSB9IiAke1N9L2tyaXRhL2tyaXRhLmRlc2t0 b3AgfHwgZGllIFwKKwkiU2VkIEZhaWxlZCEiCiB9CiAKIHNyY19jb21waWxlKCkgewo= 129321 2007-08-27 13:17 0000 Patch for Kchart diff text/plain LS0tIGtjaGFydC0xLjYuMy5lYnVpbGQub3JnCTIwMDctMDgtMjcgMDk6MDk6MTYuMDAwMDAwMDAw IC0wNDAwCisrKyBrY2hhcnQtMS42LjMuZWJ1aWxkCTIwMDctMDgtMjcgMDg6NTk6NTMuMDAwMDAw MDAwIC0wNDAwCkBAIC00NSw0ICs0NSw4IEBACiAJZWNobyAiU1VCRElSUyA9IGxpYmRpYWxvZ2Zp bHRlciBrY2hhcnQiID4gJFMvZmlsdGVycy9NYWtlZmlsZS5hbQogCiAJa2RlLW1ldGFfc3JjX3Vu cGFjayBtYWtlZmlsZXMKKworCWVpbmZvICJGaXhpbmcgRGVza3RvcCBFbnRyeS4uLiIKKwlzZWQg LWkgLWUgIi9eTWltZVR5cGUveyAvW147XSQveyBzLyQvOy8gfSB9IiAke1N9L2tjaGFydC9rY2hh cnQuZGVza3RvcCB8fCBcCisJZGllICJTZWQgRmFpbGVkISIKIH0K 129377 2007-08-27 21:27 0000 Patch for Kivio diff text/plain LS0tIGtpdmlvLTEuNi4yLmVidWlsZC5vcmcJMjAwNy0wOC0yNyAxNzoxMTozMy4wMDAwMDAwMDAg LTA0MDAKKysrIGtpdmlvLTEuNi4yLmVidWlsZAkyMDA3LTA4LTI3IDE3OjE5OjA4LjAwMDAwMDAw MCAtMDQwMApAQCAtMzYsMyArMzYsMTEgQEAKIEtNRVhUUkE9ImZpbHRlcnMva2l2aW8iCiAKIG5l ZWQta2RlIDMuNAorCitzcmNfdW5wYWNrKCkgeworCWtkZS1tZXRhX3NyY191bnBhY2sKKworCWVp bmZvICJGaXhpbmcgRGVza3RvcCBFbnRyeS4uLiIKKwlzZWQgLWkgLWUgIi9eTWltZVR5cGUveyAv W147XSQveyBzLyQvOy8gfSB9IiBcCisJJHtTfS9raXZpby9raXZpb3BhcnQva2l2aW8uZGVza3Rv cCB8fCBkaWUgIlNlZCBGYWlsZWQhIgorfQo=