188760 2007-08-13 23:01 0000 kde-base/klaptopdaemon-3.5.7-r1: "Hibernate" menu item missing with 2.6.22 kernels (ebuild containing fix included) 2007-08-17 11:22:19 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED REMIND P2 minor --- 184683 1 temerkhanov@mail.ru kde@gentoo.org temerkhanov@mail.ru 2007-08-13 23:01:20 0000 There is a problem with klaptopdaemon and 2.6.22 (and probably higher) Linux kernels. There are no "Hibernate" and "Lock&Hibernate" menu items even if those are enabled at "ACPI Config" page and helper application is set up correctly. This is due to /sys/power/state file format have changed (\n appended) and has_acpi_sleep() function is unable to handle it properly. I've changed this function so that it can handle both old and new format as well (tested with gentoo-sources-2.6.22-r2 and 2.6.21-r4). I've also removed /proc/acpi/sleep checks due to deprecation of it in mainline kernels and scheduled ACPI procfs interface removal. Reproducible: Always Steps to Reproduce: 1. emerge >=gentoo-sources-2.6.22-r2 2. Start KDE, go to klaptopdaemon's menu 3. Select "Configure KLaptop...", go to "ACPI Config" page, check "Enable hibernate" 4. Go to klaptopdaemon's menu again Actual Results: Both "Hibernate" and "Lock&Hibernate" menu items are missing Expected Results: Both "Hibernate" and "Lock&Hibernate" menu items present temerkhanov@mail.ru 2007-08-13 23:02:27 0000 Created an attachment (id=127998) klaptopdaemon-3.5.7-has_acpi_sleep.patch temerkhanov@mail.ru 2007-08-13 23:03:00 0000 Created an attachment (id=127999) klaptopdaemon-3.5.7-r1.ebuild philantrop@gentoo.org 2007-08-17 08:58:21 0000 First of all, please file an upstream bug for this and post its URL here. This is really something that should go into KDE itself. That said, I need this, too, and so I have successfully tested your patch and added it for now to both kdeutils and klaptopdaemon. Especially since quite a few upstream bugs for other enhancements have been open at bugs.kde.org for ages and the sources in the focus areas haven't been changed for a long time. temerkhanov@mail.ru 2007-08-17 11:22:19 0000 Here's the URL for this bug in upstream: http://bugs.kde.org/show_bug.cgi?id=148928 127998 2007-08-13 23:02 0000 klaptopdaemon-3.5.7-has_acpi_sleep.patch klaptopdaemon-3.5.7-has_acpi_sleep.patch text/plain LS0tIC4va2xhcHRvcGRhZW1vbi9wb3J0YWJsZS5jcHAub2xkCTIwMDctMDUtMTQgMTE6NDA6NDUu MDAwMDAwMDAwICswNDAwCisrKyAuL2tsYXB0b3BkYWVtb24vcG9ydGFibGUuY3BwCTIwMDctMDgt MTQgMDE6NTI6MzAuNzc1NzkwODc5ICswNDAwCkBAIC02OTAsMTUgKzY5MCwxNiBAQCBoYXNfYWNw aV9zbGVlcChpbnQgc3RhdGUpIAogCQltYXNrID0gMDsKIAogCQlRRmlsZSBwKCIvc3lzL3Bvd2Vy L3N0YXRlIik7Ci0JCVFGaWxlIGYoIi9wcm9jL2FjcGkvc2xlZXAiKTsKIAogCQlpZiAocC5vcGVu KElPX1JlYWRPbmx5KSkgeworCQkJUVRleHRTdHJlYW0gc3RyZWFtKCZwKTsKIAkJCVFTdHJpbmcg bDsKLQkJCXAucmVhZExpbmUobCw1MDApOworCQkJbCA9IHN0cmVhbS5yZWFkTGluZSgpOworCiAJ CQlRU3RyaW5nTGlzdCBsbCA9IFFTdHJpbmdMaXN0OjpzcGxpdCgnICcsbCxmYWxzZSk7CiAJCQlm b3IgKFFWYWx1ZUxpc3RJdGVyYXRvcjxRU3RyaW5nPiBpID0gbGwuYmVnaW4oKTsgaSE9bGwuZW5k KCk7IGkrKykgewogCQkJCVFTdHJpbmcgcyA9ICppOwotCQkJCQorCiAJCQkJaWYgKHMuY29tcGFy ZSgic3RhbmRieSIpPT0wKQogCQkJCW1hc2sgfD0gKDE8PDEpOwogCQkJCWVsc2UgaWYgKHMuY29t cGFyZSgibWVtIik9PTApCkBAIC03MDgsMjAgKzcwOSw2IEBAIGhhc19hY3BpX3NsZWVwKGludCBz dGF0ZSkgCiAJCQl9CiAJCQlwLmNsb3NlKCk7CiAJCX0KLQkJZWxzZSBpZiAoZi5vcGVuKElPX1Jl YWRPbmx5KSkgewotCQkJUVN0cmluZyBsOwotCQkJZi5yZWFkTGluZShsLCA1MDApOwotCQkJUVN0 cmluZ0xpc3QgbGwgPSBRU3RyaW5nTGlzdDo6c3BsaXQoJyAnLGwsZmFsc2UpOwotCQkJZm9yIChR VmFsdWVMaXN0SXRlcmF0b3I8UVN0cmluZz4gaSA9IGxsLmJlZ2luKCk7IGkhPWxsLmVuZCgpOyBp KyspIHsKLQkJCQlRU3RyaW5nIHMgPSAqaTsKLQkJCQlpZiAoc1swXSA9PSAnUycpIHsKLQkJCQkJ aW50IGMgPSBzWzFdLmRpZ2l0VmFsdWUoKTsKLQkJCQkJaWYgKGMgPj0gMCAmJiBjIDw9IDkpCi0J CQkJCQltYXNrIHw9IDE8PGM7Ci0JCQkJfQotCQkJfQotCQkJZi5jbG9zZSgpOwotCQl9CiAJfQog CXJldHVybigobWFzayZhY3BpX3NsZWVwX2VuYWJsZWQmKDE8PHN0YXRlKSkgIT0gMCk7CiB9Cg== 127999 2007-08-13 23:03 0000 klaptopdaemon-3.5.7-r1.ebuild klaptopdaemon-3.5.7-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA3IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L2tkZS1iYXNlL2tsYXB0b3BkYWVtb24va2xhcHRv cGRhZW1vbi0zLjUuNy5lYnVpbGQsdiAxLjkgMjAwNy8wOC8xMSAxNToxNTowNyBhcm1pbjc2IEV4 cCAkCgpLTU5BTUU9a2RldXRpbHMKTUFYS0RFVkVSPSRQVgpLTV9ERVBSQU5HRT0iJFBWICRNQVhL REVWRVIiCmluaGVyaXQga2RlLW1ldGEgZXV0aWxzCgpTUkNfVVJJPSIke1NSQ19VUkl9CgltaXJy b3I6Ly9nZW50b28va2RldXRpbHMtMy41LXBhdGNoc2V0LTAyLnRhci5iejIiCgpERVNDUklQVElP Tj0iS0xhcHRvcGRhZW1vbiAtIEtERSBiYXR0ZXJ5IG1vbml0b3JpbmcgYW5kIG1hbmFnZW1lbnQg Zm9yIGxhcHRvcHMuIgpLRVlXT1JEUz0ifmFscGhhIH5hbWQ2NCB+aWE2NCB+cHBjIH5wcGM2NCB+ c3BhcmMgfng4NiB+eDg2LWZic2QiCklVU0U9ImtkZWhpZGRlbnZpc2liaWxpdHkgeHNjcmVlbnNh dmVyIgoKUkRFUEVORD0ieDExLWxpYnMvbGliWHRzdCIKCkRFUEVORD0iJHtSREVQRU5EfQoJeHNj cmVlbnNhdmVyPyAoIHgxMS1saWJzL2xpYlhTY3JuU2F2ZXIgKQoJeDExLWxpYnMvbGliWDExCgl4 MTEtcHJvdG8veHByb3RvCgl2aXJ0dWFsL29zLWhlYWRlcnMiCgpQQVRDSEVTPSIke0ZJTEVTRElS fS8ke1B9LWxpYlhzcy1saW5raW5nLnBhdGNoIAoJJHtGSUxFU0RJUn0vJHtQfS1oYXNfYWNwaV9z bGVlcC5wYXRjaCIKRVBBVENIX0VYQ0xVREU9ImtsYXB0b3BkYWVtb24tMy41LXN1c3BlbmQyK3hz ZXNzaW9uLWVycm9ycy5kaWZmIgoKc3JjX2NvbXBpbGUoKSB7CglteWNvbmY9IiR7bXljb25mfSAk KHVzZV93aXRoIHhzY3JlZW5zYXZlcikiCgoJa2RlX3NyY19jb21waWxlCn0K