<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>187882</bug_id>
          
          <creation_ts>2007-08-06 07:55 0000</creation_ts>
          <short_desc>media-libs/flac-1.2.0 doesn&apos;t compile with USE=&quot;-ogg&quot;</short_desc>
          <delta_ts>2007-08-06 11:12:46 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          <bug_file_loc>http://flac.cvs.sourceforge.net/flac/flac/src/flac/encode.c?r1=1.187&amp;r2=1.188&amp;view=patch</bug_file_loc>
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>marty.rosenberg@gmail.com</reporter>
          <assigned_to>sound@gentoo.org</assigned_to>
          

      

      
          <long_desc isprivate="0">
            <who>marty.rosenberg@gmail.com</who>
            <bug_when>2007-08-06 07:55:50 0000</bug_when>
            <thetext>Not really gentoo specific, unless this is a problem caused by a gentoo patch.
in flac-1.2.0/src/flac/encode.c, on line 2181, 

if(e-&gt;use_ogg &amp;&amp; e-&gt;total_samples_to_encode &gt; 0 &amp;&amp; e-&gt;total_samp
les_to_encode / e-&gt;sample_rate / 10 &gt; 230)

should be

if(
#if FLAC__HAS_OGG
e-&gt;use_ogg &amp;&amp;
#endif
 e-&gt;total_samples_to_encode &gt; 0 &amp;&amp; e-&gt;total_samp
les_to_encode / e-&gt;sample_rate / 10 &gt; 230)

or something else equivalent.  Personally, I think that the &apos;changing contents of if statement based on compile time flags&apos; is disgusting, but whatever.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>ssuominen@gentoo.org</who>
            <bug_when>2007-08-06 10:45:43 0000</bug_when>
            <thetext>(In reply to comment #0)
&gt; Not really gentoo specific, unless this is a problem caused by a gentoo patch.
&gt; in flac-1.2.0/src/flac/encode.c, on line 2181, 

It&apos;s not because of our patches but definately a problem, thanks.. looking at it.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>ssuominen@gentoo.org</who>
            <bug_when>2007-08-06 11:12:46 0000</bug_when>
            <thetext>Applied upstream patch fixing this. Thanks again for reporting :)</thetext>
          </long_desc>
      
    </bug>

</bugzilla>