186945 2007-07-28 23:04 0000 app-portage/gentoolkit - progress bar in new revdep-rebuild flickers 2007-09-13 15:51:22 0000 1 1 1 Unclassified Portage Development Tools unspecified All Linux RESOLVED FIXED InSVN P2 trivial --- 170220 1 rmmarm@sdf.lonestar.org tools-portage@gentoo.org dhp_gentoo@doublehp.org rmmarm@sdf.lonestar.org 2007-07-28 23:04:26 0000 I love the new revdep-rebuild. It's awesome. However, the [X%] progress bar thing flickers horribly. It's easy enough to fix -- just add code to only print when something has changed. I will attach a patch to this bug report. Reproducible: Always Steps to Reproduce: 1. Run revdep-rebuild without the -quiet flag. 2. Freeze in horror as the flickering progress bar gives you a headache. 3. Run screaming from the keyboard. Actual Results: Progress bar flickers. Expected Results: Progress bar updates only when the percentage is different from before. rmmarm@sdf.lonestar.org 2007-07-28 23:05:34 0000 Created an attachment (id=126280) Patch to remove flicker from the progress meter As promised, here's a patch to /usr/bin/revdep-rebuild. dhp_gentoo@doublehp.org 2007-08-04 10:20:37 0000 I put my complain in here, since it's similar bug, and to avoid creation of new one: I use revdep in cron. Cron mails me the result. It is usually very long since it mails me the compile log as side effect. But, see what happens: (this took 3/4 of the "visible hight of the mail" (not weight, but height): * Checking dynamic linking consistency [ 0% ] [ 0% ] [ 0% ] [...] [ 99% ] [ 99% ] [ 100% ] * broken /opt/sun-jdk-1.4.2.15/jre/lib/i386/libnio.so (no version information available) * Generated new //.revdep-rebuild.3_rebuild This has a very simple workaroung: do not use progress bar at all when the output is not a console (I have seen this feature some where, may be emerge: no progress bar or spinning bar when used like emerge -va foo |grep -v bar (outputs everything except "bar" => no spinning cursor). You will find there the code to implement it ^^ dhp_gentoo@doublehp.org 2007-08-04 10:21:44 0000 Robert, maybe it flickers because it is synchronised with your screen refresh ^^ LCD is a solution. rmmarm@sdf.lonestar.org 2007-08-04 13:13:31 0000 (In reply to comment #3) > Robert, maybe it flickers because it is synchronised with your screen refresh > ^^ LCD is a solution. > Thanks for the suggestion DeMaine, but as it turns out -- I only use LCD. The problem is simply that the progress bar gets draw multiple times when it does not need to. The patch I attached ought to solve the problem. Also, have you tried using the "-quiet" flag when running from your cron job? Does that get rid of the extra output in your logs? dhp_gentoo@doublehp.org 2007-08-04 14:50:52 0000 I tell you next week. fuzzyray@gentoo.org 2007-08-07 01:25:57 0000 Use --quiet to prevent the progress bar in scripts and cron jobs. michael@smith-li.com 2007-08-08 13:24:54 0000 Created an attachment (id=127278) revdep-rebuild-rewrite.patch Patch against the latest SVN version of *-rewrite. This patch also includes the fix to using ewarn before sourcing /etc/functions.sh. As for the progress() fix, It's the same idea as Robert's, just rewritten so it patches cleanly. Thanks, Robert! fuzzyray@gentoo.org 2007-08-08 14:54:19 0000 $ svn commit -m "Fix progress bar to only update when there is a change (Bug #186945)" Sending ChangeLog Sending src/revdep-rebuild/revdep-rebuild-rewrite Transmitting file data .. Committed revision 431. fuzzyray@gentoo.org 2007-09-13 15:51:22 0000 Released in gentoolkit-0.2.4_pre7 126280 2007-07-28 23:05 0000 Patch to remove flicker from the progress meter progress.patch text/plain LS0tIC91c3IvYmluL3JldmRlcC1yZWJ1aWxkCTIwMDctMDctMjggMTY6NTk6MDYuMDAwMDAwMDAw IC0wNDAwCisrKyAvdXNyL2Jpbi9yZXZkZXAtcmVidWlsZC5ybW1hcm0JMjAwNy0wNy0yOCAxODo1 Mjo1NC4wMDAwMDAwMDAgLTA0MDAKQEAgLTE2Myw4ICsxNjMsMTAgQEAKIAllbHNlCiAJCXByb2dy ZXNzKCkgewogCQkJKCggJDEgPT0gJDIgKSkgJiYgbG9jYWwgbGI9JCdcbicKLQkJCWVjaG8gLW5l ICdcciAgICAgICAgICAgICAgICAgICAgICAgICBccicKLQkJCWVjaG8gLW4gIlsgJCgoICQxICog MTAwIC8gJDIgKSklIF0gJGxiIgorICAgICAgICAgbmV3PSQoKCAkMSAqIDEwMCAvICQyICkpCisJ CQkoKCAkbmV3ICE9ICRvbGQgKSkgJiYgZWNobyAtbmUgJ1xyICAgICAgICAgICAgICAgICAgICAg ICAgIFxyJworICAgICAgICAgKCggJG5ldyAhPSAkb2xkICkpICYmIGVjaG8gLW4gIlsgJG5ldyUg XSAkbGIiCisgICAgICAgICBvbGQ9JG5ldwogCQl9CiAJCXByb2dyZXNzICRACiAJZmkKQEAgLTMw NCw2ICszMDYsNyBAQAogXV0KIAogZ2V0X2FyZ3MgIiRAIgorb2xkPTAKICMgVXNlIHRoZSBjb2xv ciBwcmVmZXJlbmNlIGZyb20gcG9ydGFnZQogZXhwb3J0IE5PQ09MT1I9JChwb3J0YWdlcSBlbnZ2 YXIgTk9DT0xPUikKIFtbICROT0NPTE9SID0geWVzIHx8ICROT0NPTE9SID0gdHJ1ZSBdXSAmJiBl eHBvcnQgUkNfTk9DT0xPUj15ZXMgIyBIQUNLISAoZ3JyKQo= 127278 2007-08-08 13:24 0000 revdep-rebuild-rewrite.patch revdep-rebuild-rewrite.patch text/plain LS0tIHJldmRlcC1yZWJ1aWxkLXJld3JpdGUub3JpZwkyMDA3LTA4LTA4IDA4OjMzOjE4LjAwMDAw MDAwMCAtMDQwMAorKysgcmV2ZGVwLXJlYnVpbGQtcmV3cml0ZQkyMDA3LTA4LTA4IDA4OjQ4OjU4 LjAwMDAwMDAwMCAtMDQwMApAQCAtNzAsNiArNzAsNyBAQAogZGVjbGFyZSBTRUFSQ0hfRElSU19N QVNLICMgTGlzdCBvZiBkaXJzIG5vdCB0byBzZWFyY2gKIAogIyBPdGhlciBnbG9iYWxzOgorZGVj bGFyZSBPTERQUk9HICAgICAgICAgICAgICAgICMgUHJldmlvdXMgcGFzcyB0aHJvdWdoIHRoZSBw cm9ncmVzcyBtZXRlcgogZGVjbGFyZSBFWEFDVF9QS0cgICAgICAgICAgICAgICMgVmVyc2lvbmF0 ZWQgYXRvbSB0byBlbWVyZ2UKIGRlY2xhcmUgSEVBRF9URVhUICAgICAgICAgICAgICAjIEZlZWRi YWNrIHN0cmluZyBhYm91dCB0aGUgc2VhcmNoCiBkZWNsYXJlIExJU1QgICAgICAgICAgICAgICAg ICAgIyBQcmVmaXggZm9yIHRlbXBvcmFyeSBmaWxlbmFtZXMKQEAgLTE2Miw5ICsxNjMsMTEgQEAK IAkJcHJvZ3Jlc3MoKSB7IDo7IH0KIAllbHNlCiAJCXByb2dyZXNzKCkgeworCQkJbG9jYWwgY3Vy UHJvZz0kKCggJDEgKiAxMDAgLyAkMiApKQorCQkJKCggY3VyUHJvZyA9PSBPTERQUk9HICkpICYm IHJldHVybiAjIG5vIGNoYW5nZSwgb3V0cHV0IG5vdGhpbmcKKwkJCU9MRFBST0c9IiRjdXJQcm9n IiAjIG11c3QgYmUgYSBnbG9iYWwgdmFyaWFibGUKIAkJCSgoICQxID09ICQyICkpICYmIGxvY2Fs IGxiPSQnXG4nCi0JCQllY2hvIC1uZSAnXHIgICAgICAgICAgICAgICAgICAgICAgICAgXHInCi0J CQllY2hvIC1uICJbICQoKCAkMSAqIDEwMCAvICQyICkpJSBdICRsYiIKKwkJCWVjaG8gLW5lICdc ciAgICAgICAgICAgICAgICAgICAgICAgICBcciciWyAkY3VyUHJvZyUgXSAkbGIiCiAJCX0KIAkJ cHJvZ3Jlc3MgJEAKIAlmaQpAQCAtMjk1LDYgKzI5OCwxMiBAQAogCQkJCXNlZCAnczovdmFyL2Ri L3BrZy9cKC4qXCkvQ09OVEVOVFM6XDE6JwogCQl9CiAJZmkKKworCSMgVXNlIHRoZSBjb2xvciBw cmVmZXJlbmNlIGZyb20gcG9ydGFnZQorCWV4cG9ydCBOT0NPTE9SPSQocG9ydGFnZXEgZW52dmFy IE5PQ09MT1IpCisJW1sgJE5PQ09MT1IgPSB5ZXMgfHwgJE5PQ09MT1IgPSB0cnVlIF1dICYmIGV4 cG9ydCBSQ19OT0NPTE9SPXllcyAjIEhBQ0shIChncnIpCisJc291cmNlIC9ldGMvaW5pdC5kL2Z1 bmN0aW9ucy5zaAorCQogCSMgTm9ybWFsaXplIHNvbWUgRU1FUkdFX09QVElPTlMKIAlFTUVSR0Vf T1BUSU9OUz0oJHtFTUVSR0VfT1BUSU9OU1tAXS8lLXAvLS1wcmV0ZW5kfSkKIAlFTUVSR0VfT1BU SU9OUz0oJHtFTUVSR0VfT1BUSU9OU1tAXS8lLWYvLS1mZXRjaG9ubHl9KQpAQCAtMzA5LDEwICsz MTgsNiBAQAogXV0KIAogZ2V0X2FyZ3MgIiRAIgotIyBVc2UgdGhlIGNvbG9yIHByZWZlcmVuY2Ug ZnJvbSBwb3J0YWdlCi1leHBvcnQgTk9DT0xPUj0kKHBvcnRhZ2VxIGVudnZhciBOT0NPTE9SKQot W1sgJE5PQ09MT1IgPSB5ZXMgfHwgJE5PQ09MT1IgPSB0cnVlIF1dICYmIGV4cG9ydCBSQ19OT0NP TE9SPXllcyAjIEhBQ0shIChncnIpCi1zb3VyY2UgL2V0Yy9pbml0LmQvZnVuY3Rpb25zLnNoCiAK IGVpbmZvICJDb25maWd1cmluZyBzZWFyY2ggZW52aXJvbm1lbnQgZm9yICRBUFBfTkFNRSIKIAo=