186750 2007-07-27 06:37 0000 mozilla-firefox/xulrunner ebuilds sed substitution of wrong file 2007-10-22 14:35:50 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 minor --- 1 wuno@lsvw.de mozilla@gentoo.org jakub@gentoo.org polynomial-c@gentoo.org wuno@lsvw.de 2007-07-27 06:37:10 0000 type about:buildconfig in mozilla-firefox or epiphany built on xulrunner, you'll see -Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC -Wno-return-type -w -fshort-wchar -pthread -pipe -DARON_WAS_HERE <--- same in seamonkey Wno-non-virtual-dtor -Wno-long-long -march=athlon64 -pipe -fPIC -Wno-return-type -w -fshort-wchar -pthread -pipe -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\" <--- The reason is that we substitute the seamonkey builconfig.html residing in xpfe also in mozilla-firefox and xulrunner ebuilds. However, there is a second buildconfig.html in toolkit/content that is the correct one for toolkit applications like mozilla-firefox and xulrunner patch for the ebuild to follow Reproducible: Always wuno@lsvw.de 2007-07-27 06:38:23 0000 Created an attachment (id=126107) mozilla-firefox-2.0.0.5.ebuild patch wuno@lsvw.de 2007-07-27 06:39:00 0000 Created an attachment (id=126108) xulrunner-1.8.1.5 patch jakub@gentoo.org 2007-07-27 06:47:48 0000 Hmmm? What's exactly wrong with that? wuno@lsvw.de 2007-07-27 15:40:58 0000 (In reply to comment #3) > Hmmm? What's exactly wrong with that? > For some problems with econf the define -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" cannot be used during configuring, therefor the placeholder -DARON_WAS_HERE is used, that becomes substituted by sed during compile time. In case of mozilla-firefox and xulrunner we have to do the substition in buildconfig.html in the toolkit/content directory and not in the xpfe/global directory. The latter is for seamonkey. When we do the substitution in the correct file, we see also in mozilla-firefox or xulrunner embedded browsers in about:buildconfig -DGENTOO_NSPLUGINS_DIR=\"/usr/lib64/nsplugins\" -DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib64/nsbrowser/plugins\" and not -DARON_WAS_HERE Of course, this is only cosmetics, therefore of only minor severity but its easy to fix. wuno@lsvw.de 2007-09-20 06:50:48 0000 changing Summary to be more precise armin76@gentoo.org 2007-10-21 20:53:10 0000 Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't forget about thunderbird Thanks wuno@lsvw.de 2007-10-21 21:13:30 0000 (In reply to comment #6) > Fixed on firefox, seamonkey, and xulrunner, i'll leave this bug open so i don't > forget about thunderbird > > Thanks > Thanks for fixing this, however I didn't post a patch for Seamonkey as in this particular case ${S}/xpfe/global/buildconfig.html was correct. For thunderbird we won't need a fix as we don't support plugins. polynomial-c@gentoo.org 2007-10-22 07:26:43 0000 Yes, this change should be reverted in seamonkey ebuilds until seamonkey-2.0 is out which will use toolkit as well... armin76@gentoo.org 2007-10-22 09:38:45 0000 Okay, all done then. Thanks wuno@lsvw.de 2007-10-22 14:22:36 0000 (In reply to comment #9) > Okay, all done then. > > Thanks > Sorry to bother again, the correct substitution for firefox and xulrunner is /toolkit/content/ not /toolkit/global/ as it's now in the new ebuilds. armin76@gentoo.org 2007-10-22 14:35:50 0000 Fixed again, thanks, sorry for making mistakes, my head fails a bit :) 126107 2007-07-27 06:38 0000 mozilla-firefox-2.0.0.5.ebuild patch ffebuild.patch text/plain LS0tIG1vemlsbGEtZmlyZWZveC0yLjAuMC41LmVidWlsZAkyMDA3LTA3LTI2IDE4OjM2OjExLjAw MDAwMDAwMCArMDIwMAorKysgbW96aWxsYS1maXJlZm94LTIuMC4wLjUuZWJ1aWxkCTIwMDctMDct MjcgMDg6MjY6MzMuMDAwMDAwMDAwICswMjAwCkBAIC0xODUsNyArMTg1LDcgQEAKIAlzZWQgLWkg LWUgXAogCQknc3wtREFST05fV0FTX0hFUkV8LURHRU5UT09fTlNQTFVHSU5TX0RJUj1cXFwiL3Vz ci8nIiQoZ2V0X2xpYmRpcikiJy9uc3BsdWdpbnNcXFwiIC1ER0VOVE9PX05TQlJPV1NFUl9QTFVH SU5TX0RJUj1cXFwiL3Vzci8nIiQoZ2V0X2xpYmRpcikiJy9uc2Jyb3dzZXIvcGx1Z2luc1xcXCJ8 JyBcCiAJCSR7U30vY29uZmlnL2F1dG9jb25mLm1rIFwKLQkJJHtTfS94cGZlL2dsb2JhbC9idWls ZGNvbmZpZy5odG1sCisJCSR7U30vdG9vbGtpdC9jb250ZW50L2J1aWxkY29uZmlnLmh0bWwKIAog CSMgVGhpcyByZW1vdmVzIGV4dHJhbmVvdXMgQ0ZMQUdTIGZyb20gdGhlIE1ha2VmaWxlcyB0byBy ZWR1Y2UgUkFNCiAJIyByZXF1aXJlbWVudHMgd2hpbGUgY29tcGlsaW5nCg== 126108 2007-07-27 06:39 0000 xulrunner-1.8.1.5 patch xulrebuild.patch text/plain LS0tIHh1bHJ1bm5lci0xLjguMS41LmVidWlsZAkyMDA3LTA3LTI0IDE4OjA1OjU5LjAwMDAwMDAw MCArMDIwMAorKysgeHVscnVubmVyLTEuOC4xLjUuZWJ1aWxkCTIwMDctMDctMjcgMDg6Mjc6MTIu MDAwMDAwMDAwICswMjAwCkBAIC0xMDcsNyArMTA3LDcgQEAKIAlzZWQgLWkgLWUgXAogCQknc3wt REFST05fV0FTX0hFUkV8LURHRU5UT09fTlNQTFVHSU5TX0RJUj1cXFwiL3Vzci8nIiQoZ2V0X2xp YmRpcikiJy9uc3BsdWdpbnNcXFwiIC1ER0VOVE9PX05TQlJPV1NFUl9QTFVHSU5TX0RJUj1cXFwi L3Vzci8nIiQoZ2V0X2xpYmRpcikiJy9uc2Jyb3dzZXIvcGx1Z2luc1xcXCJ8JyBcCiAJCSR7U30v Y29uZmlnL2F1dG9jb25mLm1rIFwKLQkJJHtTfS94cGZlL2dsb2JhbC9idWlsZGNvbmZpZy5odG1s CisJCSR7U30vdG9vbGtpdC9jb250ZW50L2J1aWxkY29uZmlnLmh0bWwKIAogCSMgVGhpcyByZW1v dmVzIGV4dHJhbmVvdXMgQ0ZMQUdTIGZyb20gdGhlIE1ha2VmaWxlcyB0byByZWR1Y2UgUkFNCiAJ IyByZXF1aXJlbWVudHMgd2hpbGUgY29tcGlsaW5nCg==