184925 2007-07-11 06:40 0000 app-misc/fdupes-1.40: implicit declaration of memcpy 2008-05-13 08:36:41 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All All RESOLVED FIXED P3 normal --- 1 daniel.santos@pobox.com shell-tools@gentoo.org daniel.santos@pobox.com 2007-07-11 06:40:24 0000 The programmer put a #include in the wrong place and the problem only occurs when you aren't compiling md5.c for testing. I am actually uncertain of the real outcome of this issue, although it's likely to cause nasties in some form or another. daniel.santos@pobox.com 2007-07-11 06:41:13 0000 Created an attachment (id=124520) fdupes-1.40-r1.ebuild new ebuild to fix the problem daniel.santos@pobox.com 2007-07-11 06:41:57 0000 Created an attachment (id=124521) fdupes-1.40-md5.c.patch daniel.santos@pobox.com 2007-07-11 06:47:00 0000 Oh yea, I've only tested this on Gentoo/amd64, but the problem is pretty straight forward. daniel.santos@pobox.com 2007-07-11 21:19:44 0000 Created an attachment (id=124593) fdupes-1.40-r1.ebuild Adds md5sum-external use flag to cause fdupes to use an eternal md5sum executable rather than it's bundled md5 routines. I know there's some stuff that should go in the manifest.xml and probably the ChangeLog, sorry I haven't learned all of that yet. dev-zero@gentoo.org 2007-12-15 11:50:26 0000 Well, the outcome is simple: It causes segfaults on 64bit architectures. @Daniel: Did you report the bug to upstream? daniel.santos@pobox.com 2007-12-16 06:24:51 0000 (In reply to comment #5) > Well, the outcome is simple: It causes segfaults on 64bit architectures. > > @Daniel: Did you report the bug to upstream? Well, I did now :) I figured it would do something nasty like that. So how do I make sure that fixes like this actually make it into the main portage tree in the future? cslycord@gmail.com 2008-01-27 21:00:19 0000 (In reply to comment #4) > Created an attachment (id=124593) [edit] > fdupes-1.40-r1.ebuild > > Adds md5sum-external use flag to cause fdupes to use an eternal md5sum > executable rather than it's bundled md5 routines. I know there's some stuff > that should go in the manifest.xml and probably the ChangeLog, sorry I haven't > learned all of that yet. > Sounds like this should be a separate bug. daniel.santos@pobox.com 2008-01-28 12:03:19 0000 (In reply to comment #7) > (In reply to comment #4) > > Created an attachment (id=124593) [edit] > > fdupes-1.40-r1.ebuild > > > > Adds md5sum-external use flag to cause fdupes to use an eternal md5sum > > executable rather than it's bundled md5 routines. I know there's some stuff > > that should go in the manifest.xml and probably the ChangeLog, sorry I haven't > > learned all of that yet. > > > > Sounds like this should be a separate bug. > Separate bug for the new use flag or not, the patch to fix this segfaulting bug has has been here since last July, half a year ago, and it still isn't in the portage tree. The new use flag is an enhancement that adds support for one of the features in the configure script. Use the older ebuild if you want, but it would be nice if the user community could get access to patches that work a bit sooner after they are documented and submitted. daniel.santos@pobox.com 2008-01-28 12:05:00 0000 oh, I forgot to mention that using an external md5sum program would also work-around the issue, although you can't use that feature with the ebuild in its current state because that feature isn't supported. pva@gentoo.org 2008-05-06 09:13:22 0000 Tiziano what did cause segfaults on amd64? patch or usage of external program? Daniel, please, show us the errors you experience and steps to reproduce the problem. At first glance string.h seems to be in correct place as all str*() are used only inside #ifdef TEST ... #endif block. pva@gentoo.org 2008-05-12 22:02:21 0000 Daniel, drop my last comment. I was obviously wrong there. I did not manage to reproduce any segfalts on amd64 with this patch, so I've applied it in fdupes-1.40-r1. In fdupes-1.40-r2 I've added md5sum-external USE flag... Thank you for your work. FIXED. daniel.santos@pobox.com 2008-05-13 08:36:41 0000 (In reply to comment #11) > Daniel, drop my last comment. I was obviously wrong there. I did not manage to > reproduce any segfalts on amd64 with this patch, so I've applied it in > fdupes-1.40-r1. In fdupes-1.40-r2 I've added md5sum-external USE flag... Thank > you for your work. FIXED. > hurray! :) 124520 2007-07-11 06:41 0000 fdupes-1.40-r1.ebuild fdupes-1.40-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA1IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCkRFU0NSSVBUSU9OPSJpZGVudGlmeS9kZWxldGUgZHVwbGljYXRlIGZpbGVzIHJlc2lk aW5nIHdpdGhpbiBzcGVjaWZpZWQgZGlyZWN0b3JpZXMiCkhPTUVQQUdFPSJodHRwOi8vbmV0ZGlh bC5jYXJpYmUubmV0L35hZHJpYW4yL2ZkdXBlcy5odG1sIgpTUkNfVVJJPSJodHRwOi8vbmV0ZGlh bC5jYXJpYmUubmV0L35hZHJpYW4yL3Byb2dyYW1zLyR7UH0udGFyLmd6IgoKTElDRU5TRT0iTUlU IgpTTE9UPSIwIgpLRVlXT1JEUz0iYW1kNjQgYXJtIGhwcGEgaWE2NCB+bWlwcyBwcGMgcHBjNjQg czM5MCBzcGFyYyB4ODYiCklVU0U9IiIKCkRFUEVORD0iIgoKc3JjX3VucGFjaygpIHsKCXVucGFj ayAke0F9CgoJIyBmaXggbWlzcGxhY2VkICNpbmNsdWRlCglwYXRjaCAtcDEgPCAke0ZJTEVTRElS fS9mZHVwZXMtMS40MC1tZDUuYy5wYXRjaCBcCgkJfHwgZGllICJwYXRjaCBmYWlsZWQiCn0KCnNy Y19jb21waWxlKCkgewoJZW1ha2UgfHwgZGllCn0KCnNyY19pbnN0YWxsKCkgewoJZG9iaW4gZmR1 cGVzIHx8IGRpZQoJZG9tYW4gZmR1cGVzLjEKCWRvZG9jIENIQU5HRVMgQ09OVFJJQlVUT1JTIElO U1RBTEwgUkVBRE1FIFRPRE8KfQo= 124521 2007-07-11 06:41 0000 fdupes-1.40-md5.c.patch fdupes-1.40-md5.c.patch text/plain ZGlmZiAtcmMgb3JpZy9mZHVwZXMtMS40MC9tZDUvbWQ1LmMgbmV3L2ZkdXBlcy0xLjQwL21kNS9t ZDUuYwoqKiogb3JpZy9mZHVwZXMtMS40MC9tZDUvbWQ1LmMJVGh1IE5vdiAgNCAxOTowNDozNiAx OTk5Ci0tLSBuZXcvZmR1cGVzLTEuNDAvbWQ1L21kNS5jCVdlZCBKdWwgMTEgMDE6MTY6MTggMjAw NwoqKioqKioqKioqKioqKioKKioqIDM5LDQ0ICoqKioKLS0tIDM5LDQ1IC0tLS0KICAgKi8KICAK ICAjaW5jbHVkZSAibWQ1LmgiCisgI2luY2x1ZGUgPHN0cmluZy5oPgogIAogICNpZmRlZiBURVNU CiAgLyoKKioqKioqKioqKioqKioqCioqKiA0Niw1MiAqKioqCiAgICogVGhlIHRlc3QgcHJvZ3Jh bSBzaG91bGQgcHJpbnQgb3V0IHRoZSBzYW1lIHZhbHVlcyBhcyBnaXZlbiBpbiBzZWN0aW9uCiAg ICogQS41IG9mIFJGQyAxMzIxLCByZXByb2R1Y2VkIGJlbG93LgogICAqLwotICNpbmNsdWRlIDxz dHJpbmcuaD4KICBtYWluKCkKICB7CiAgICAgIHN0YXRpYyBjb25zdCBjaGFyICpjb25zdCB0ZXN0 WzddID0gewotLS0gNDcsNTIgLS0tLQo= 124593 2007-07-11 21:19 0000 fdupes-1.40-r1.ebuild fdupes-1.40-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA1IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCkRFU0NSSVBUSU9OPSJpZGVudGlmeS9kZWxldGUgZHVwbGljYXRlIGZpbGVzIHJlc2lk aW5nIHdpdGhpbiBzcGVjaWZpZWQgZGlyZWN0b3JpZXMiCkhPTUVQQUdFPSJodHRwOi8vbmV0ZGlh bC5jYXJpYmUubmV0L35hZHJpYW4yL2ZkdXBlcy5odG1sIgpTUkNfVVJJPSJodHRwOi8vbmV0ZGlh bC5jYXJpYmUubmV0L35hZHJpYW4yL3Byb2dyYW1zLyR7UH0udGFyLmd6IgoKTElDRU5TRT0iTUlU IgpTTE9UPSIwIgpLRVlXT1JEUz0iYW1kNjQgYXJtIGhwcGEgaWE2NCB+bWlwcyBwcGMgcHBjNjQg czM5MCBzcGFyYyB4ODYiCklVU0U9Im1kNXN1bS1leHRlcm5hbCIKCkRFUEVORD0iIgoKc3JjX3Vu cGFjaygpIHsKCXVucGFjayAke0F9CgoJIyBmaXggbWlzcGxhY2VkICNpbmNsdWRlCglwYXRjaCAt cDEgPCAke0ZJTEVTRElSfS9mZHVwZXMtMS40MC1tZDUuYy5wYXRjaCBcCgkJfHwgZGllICJwYXRj aCBmYWlsZWQiCgoJaWYgdXNlIG1kNXN1bS1leHRlcm5hbDsgdGhlbgoJCWNkICIke1N9IgoJCXNl ZCAtaSBcCgkJCS1lICdzL14jRVhURVJOQUxfTUQ1ID0gL0VYVEVSTkFMX01ENSA9IC9nJyBcCgkJ CU1ha2VmaWxlIFwKCQkJfHwgZGllICJzZWQgZmFpbGVkIgoJZmkKfQoKc3JjX2NvbXBpbGUoKSB7 CgllbWFrZSB8fCBkaWUKfQoKc3JjX2luc3RhbGwoKSB7Cglkb2JpbiBmZHVwZXMgfHwgZGllCglk b21hbiBmZHVwZXMuMQoJZG9kb2MgQ0hBTkdFUyBDT05UUklCVVRPUlMgSU5TVEFMTCBSRUFETUUg VE9ETwp9Cg==