<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>184105</bug_id>
          
          <creation_ts>2007-07-03 16:08 0000</creation_ts>
          <short_desc>net-www/gnash-0.8.0 and gnash-9999 use flawed logic when setting media handler and sound options.</short_desc>
          <delta_ts>2007-07-10 07:19:18 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Ebuilds</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>harley@thepetersclan.com</reporter>
          <assigned_to>genstef@gentoo.org</assigned_to>
          <cc>levertond@googlemail.com</cc>

      

      
          <long_desc isprivate="0">
            <who>harley@thepetersclan.com</who>
            <bug_when>2007-07-03 16:08:52 0000</bug_when>
            <thetext>With the current ebuilds no matter what you set for use variables ffmpeg or gstreamer. Gnash will be compiled with ffmpeg for the media handler and sdl for sound.
The ebuild is trying to set --enable-sound=gst when using the gstreamer use setting.

#--enable-sound=gst,sdl
	if use gstreamer; then
		myconf=&quot;${myconf} --enable-sound=gst&quot;
	else
		myconf=&quot;${myconf} --enable-sound=sdl&quot;
	fi

This is useless as when gnash checks that the media handler is still set to ffmpeg (the default) it ignore&apos;s this setting and use&apos;s sdl instead.

The only possible options are:

ffmpeg as media handler and sdl for sound.
mad as media handler and sdl for sound.
gst as media handler and gst for sound.

Everything else is invalid.

I suggest your replace the following code:

#--enable-sound=gst,sdl
	if use gstreamer; then
		myconf=&quot;${myconf} --enable-sound=gst&quot;
	else
		myconf=&quot;${myconf} --enable-sound=sdl&quot;
	fi

	if use ffmpeg; then
		myconf=&quot;${myconf} --with-mp3-decoder=ffmpeg&quot;
	fi

With something similar to:

#--enable-media=gst||ffmpeg||mad
	if use gstreamer; then
		myconf=&quot;${myconf} --enable-media=gst&quot;
	fi

	if use ffmpeg; then
		myconf=&quot;${myconf} --enable-media=ffmpeg&quot;
	fi

	if use !gstreamer &amp;&amp; use !ffmpeg; then
		myconf=&quot;${myconf} --enable-media=mad&quot;
	fi	

This will set the media handler using the use words ffmpeg and gstreamer (will default to mad) which in turn will automatically set the correct sound option (gst,sdl).

You should also add the option --disable-debugger to the ebuild. It improves performance a little.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>harley@thepetersclan.com</who>
            <bug_when>2007-07-03 22:40:24 0000</bug_when>
            <thetext>Created an attachment (id=123839)
Example ebuild

With the example ebuild ffmpeg has priority over gstreamer and mad.
Gstreamer has priority over mad.

</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>genstef@gentoo.org</who>
            <bug_when>2007-07-10 07:19:18 0000</bug_when>
            <thetext>Thank you. I added your patch</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>123839</attachid>
            <date>2007-07-03 22:40 0000</date>
            <desc>Example ebuild</desc>
            <filename>gnash-0.8.0.ebuild</filename>
            <type>text/plain</type>
            <data encoding="base64">IyBDb3B5cmlnaHQgMTk5OS0yMDA3IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k
ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk
ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L25ldC13d3cvZ25hc2gvZ25hc2gtMC44LjAuZWJ1
aWxkLHYgMS4yIDIwMDcvMDYvMTIgMTE6MTU6MDkgb3BmZXIgRXhwICQKCmluaGVyaXQgbnNwbHVn
aW5zIGtkZS1mdW5jdGlvbnMgcXQzIG11bHRpbGliCnNldC1rZGVkaXIKCkRFU0NSSVBUSU9OPSJH
bmFzaCBpcyBhIEdOVSBGbGFzaCBtb3ZpZSBwbGF5ZXIgdGhhdCBzdXBwb3J0cyBtYW55IFNXRiB2
NyBmZWF0dXJlcyIKSE9NRVBBR0U9Imh0dHA6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9nbmFzaCIK
U1JDX1VSST0ibWlycm9yOi8vZ251LyR7UE59LyR7UFZ9LyR7UH0udGFyLmJ6MiIKCkxJQ0VOU0U9
IkdQTC0yIgpTTE9UPSIwIgpLRVlXT1JEUz0ifmFtZDY0IH5wcGMgfnNwYXJjIH54ODYgfng4Ni1m
YnNkIgpJVVNFPSJhZ2cgZ3N0cmVhbWVyIGZmbXBlZyBrZGUgbWFkIG5zcGx1Z2luIHhtbCB2aWRl
b19jYXJkc19pODEwIgojZG1hbGxvYywgYnJva2VuIHNlZSBidWcgMTQyOTM5CiNkbWFsbG9jPyAo
IGRldi1saWJzL2RtYWxsb2MgKQojCQkkKHVzZV9lbmFibGUgZG1hbGxvYykgXAoKUkRFUEVORD0i
Cgl4bWw/ICggZGV2LWxpYnMvbGlieG1sMiApCglzeXMtbGlicy96bGliCgltZWRpYS1saWJzL2pw
ZWcKCW1lZGlhLWxpYnMvbGlib2dnCgltZWRpYS1saWJzL2xpYnBuZwoJbmV0LW1pc2MvY3VybAoJ
bWFkPyAoIG1lZGlhLWxpYnMvbGlibWFkICkKCWZmbXBlZz8gKCBtZWRpYS12aWRlby9mZm1wZWcg
KQoJZ3N0cmVhbWVyPyAoIG1lZGlhLWxpYnMvZ3N0cmVhbWVyCgkJfHwgKAoJCQltZWRpYS1wbHVn
aW5zL2dzdC1wbHVnaW5zLWZmbXBlZwoJCQltZWRpYS1wbHVnaW5zL2dzdC1wbHVnaW5zLW1hZAoJ
CQltZWRpYS1wbHVnaW5zL2dzdC1wbHVnaW5zLWxhbWUKCQkpCgkpCgkhZ3N0cmVhbWVyPyAoIG1l
ZGlhLWxpYnMvbGlic2RsICkKCWRldi1saWJzL2Jvb3N0Cgl8fCAoCgkJKCB4MTEtbGlicy9saWJY
MTEKCQl4MTEtbGlicy9saWJYaQoJCXgxMS1saWJzL2xpYlhtdQoJCXgxMS1saWJzL2xpYlh0CgkJ
eDExLXByb3RvL3hwcm90byApCgkJdmlydHVhbC94MTEKCSkKCWRldi1saWJzL2F0awoJZGV2LWxp
YnMvZ2xpYgoJPngxMS1saWJzL2d0aystMgoJeDExLWxpYnMvcGFuZ28KCSFhZ2c/ICggdmlydHVh
bC9vcGVuZ2wgeDExLWxpYnMvZ3RrZ2xleHQgKQoJa2RlPyAoIGtkZS1iYXNlL2tkZWxpYnMgKQoJ
YWdnPyAoIHgxMS1saWJzL2FnZyApIgoJI2NhaXJvPyAoIHgxMS1saWJzL2NhaXJvICkKCnBrZ19z
ZXR1cCgpIHsKCWlmIHVzZSBhZ2cgJiYgdXNlIGtkZTsgdGhlbgoJCWVlcnJvciAiQnVpbGRpbmcg
a2xhc2ggd2l0aCB0aGUgYWdnIGJhc2VkIHJlbmRlcmVyIGlzIG5vdCBzdXBwb3J0ZWQiCgkJZWVy
cm9yICJQbGVhc2UgVVNFIC1rZGUgb3IgLWFnZyIKCQlkaWUgImtkZSBhbmQgYWdnIG5vdCBzdXBw
b3J0ZWQgYXQgdGhlIHNhbWUgdGltZSIKCWZpCgoJaWYgaGFzX3ZlcnNpb24gJzxkZXYtbGlicy9i
b29zdC0xLjM0JyAmJiAhIGJ1aWx0X3dpdGhfdXNlIGRldi1saWJzL2Jvb3N0IHRocmVhZHM7IHRo
ZW4KCQllZXJyb3IgImRldi1saWJzdC9ib29zdCBoYXMgdG8gYmUgYnVpbHQgd2l0aCB0aGUgJ3Ro
cmVhZHMnIFVTRSBmbGFnIgoJCWRpZSAiZGV2LWxpYnMvYm9vc3Qgbm90IGJ1aWx0IHdpdGggdGhy
ZWFkcyIKCWZpCgoJaWYgdXNlIG1hZCAmJiAoIHVzZSAhZmZtcGVnICYmIHVzZSAhZ3N0cmVhbWVy
ICkgJiYgKCB1c2UgbnNwbHVnaW4gfHwgdXNlIHhtbCApOyB0aGVuCgkJZWVycm9yICJCdWlsZGlu
ZyBHbmFzaCB1c2luZyB0aGUgbWFkIG1lZGlhIGhhbmRsZXIgaXMgaW5jb21wYXRpYmxlIHdpdGgg
dGhlIG5zcGx1Z2luIG9yIHhtbCBVU0UgZmxhZ3MiCgkJZGllICJuc3BsdWdpbiBhbmQgeG1sIG5v
dCBzdXBwb3J0ZWQgd2l0aCBtYWQgbWVkaWEgaGFuZGxlciIKCWZpCgkKCWlmIHVzZSAhbWFkICYm
IHVzZSAhZmZtcGVnICYmIHVzZSAhZ3N0cmVhbWVyOyB0aGVuCgkJZWVycm9yICJZb3UgYXJlIHRy
eWluZyB0byBidWlsZCBHbmFzaCB3aXRob3V0IGNob29zaW5nIGEgbWVkaWEgaGFuZGxlciIKCQll
ZXJyb3IgIlBsZWFzZSBlbmFibGUgb25lIG9mIHRoZSBmb2xsb3dpbmcgZmZtcGVnLGdzdHJlYW1l
ciBvciBtYWQobXAzIGF1ZGlvIG9ubHkpIgoJCWRpZSAiTm8gbWVkaWEgaGFuZGxlciBzZWxlY3Rl
ZCAhIgoJZmkKfQoKc3JjX2NvbXBpbGUoKSB7Cglsb2NhbCBteWNvbmYKCgl1c2UgbnNwbHVnaW4g
JiYgbXljb25mPSIke215Y29uZn0gLS13aXRoLXBsdWdpbmRpcj0vb3B0L25ldHNjYXBlL3BsdWdp
bnMiCgoJIy0tZW5hYmxlLXJlbmRlcmVyPWVuZ2luZSBTcGVjaWZ5IHJlbmRlcmluZyBlbmdpbmU6
CgkjCQkJCU9wZW5HTCAoZGVmYXVsdCkKCSMJCQkJQ2Fpcm8gIChleHBlcmltZW50YWwpCgkjY2Fp
cm86IGRvZXMgbm90IHdvcmsgZm9yIHBsdWdpbnMgeWV0LCBvZmZlcnMgZmxhc2ggZm9yIG5vbi1h
Y2NlbGVyYXRlZCBnZng/CgkjaWYgdXNlIGNhaXJvOyB0aGVuCgkjCW15Y29uZj0iJHtteWNvbmZ9
IC0tZW5hYmxlLXJlbmRlcmVyPWNhaXJvIgoJI2ZpCglpZiB1c2UgYWdnOyB0aGVuCgkJbXljb25m
PSIke215Y29uZn0gLS1lbmFibGUtcmVuZGVyZXI9YWdnIgoJZmkKCSMtLWVuYWJsZS1ndWk9Zmxh
dm9yIFNwZWNpZnkgZ3VpIGZsYXZvcjoKCSMJCQkJR1RLCgkjCQkJCVNETCAtPiBoYXMgbm8gY29u
dHJvbHMsIHdlIGRvIG5vdCBVU0UgaXQKCSMkKHVzZV9lbmFibGUgZ3RrIGdsZXh0KSB3aXRoIFVT
RT0tZ3RrLCBmYWlscyB0byBkZXRlY3QgZ3RrZ2xleHQsIGJ1ZyAxMzUwMTAKCSMtLWVuYWJsZS1t
ZWRpYT1nc3R8fGZmbXBlZ3x8bWFkCglpZiB1c2UgbWFkICYmIHVzZSAhZmZtcGVnICYmIHVzZSAh
Z3N0cmVhbWVyOyB0aGVuCgkJbXljb25mPSIke215Y29uZn0gLS1lbmFibGUtbWVkaWE9bWFkIgoJ
ZmkKCglpZiB1c2UgZ3N0cmVhbWVyICYmIHVzZSAhZmZtcGVnOyB0aGVuCgkJbXljb25mPSIke215
Y29uZn0gLS1lbmFibGUtbWVkaWE9Z3N0IgoJZmkKCglpZiB1c2UgZmZtcGVnOyB0aGVuCgkJbXlj
b25mPSIke215Y29uZn0gLS1lbmFibGUtbWVkaWE9ZmZtcGVnIgoJZmkKCglpZiB1c2Uga2RlOyB0
aGVuCgkJbXljb25mPSIke215Y29uZn0gLS1lbmFibGUta2xhc2ggLS13aXRoLXF0LWluY2w9JHtR
VERJUn0vaW5jbHVkZQoJCQktLXdpdGgtcXQtbGliPSR7UVRESVJ9LyQoZ2V0X2xpYmRpcikiCgll
bHNlCgkJbXljb25mPSIke215Y29uZn0gLS1kaXNhYmxlLWtsYXNoIgoJZmkKCgllY29uZiBcCgkJ
JCh1c2VfZW5hYmxlIG5zcGx1Z2luIHBsdWdpbikgXAoJCSQodXNlX2VuYWJsZSB4bWwpIFwKCQkk
KHVzZV9lbmFibGUgdmlkZW9fY2FyZHNfaTgxMCBpODEwLWxvZC1iaWFzKSBcCgkJLS13aXRob3V0
LWdjYy1hcmNoIC0tZGlzYWJsZS1kZWJ1Z2dlciBcCgkJJHtteWNvbmZ9IHx8IGRpZSAiZWNvbmYg
ZmFpbGVkIgoJZW1ha2UgLWoxIHx8IGRpZSAiZW1ha2UgZmFpbGVkIgp9CgpzcmNfaW5zdGFsbCgp
IHsKCWVtYWtlIERFU1RESVI9IiR7RH0iIGluc3RhbGwgfHwgZGllICJlbWFrZSBpbnN0YWxsIGZh
aWxlZCIKCXVzZSBuc3BsdWdpbiAmJiBpbnN0X3BsdWdpbiAvb3B0L25ldHNjYXBlL3BsdWdpbnMv
bGliZ25hc2hwbHVnaW4uc28gXAoJCXx8IHJtIC1yZiAiJHtEfS9vcHQiCglkb2RvYyBBVVRIT1JT
IENoYW5nZUxvZyBORVdTIFJFQURNRQp9Cgpwa2dfcG9zdGluc3QoKSB7Cglld2FybiAiQUxQSEEi
Cglld2FybiAiZ25hc2ggaXMgc3RpbGwgaW4gaGVhdnkgZGV2ZWxvcG1lbnQiCglld2FybiAicGxl
YXNlIHJlcG9ydCBnbmFzaCBidWdzIHVwc3RyZWFtIHRvIHRoZSBnbmFzaCBkZXZzIgp9Cg==
</data>        

          </attachment>
    </bug>

</bugzilla>