182314 2007-06-17 11:25 0000 app-pda/libopensync-0.22 fail compilation on Gentoo/FreeBSD 2007-06-17 12:32:14 0000 1 1 1 Unclassified Gentoo/Alt FreeBSD unspecified AMD64 FreeBSD RESOLVED FIXED P2 normal --- 178853 1 toffanin.mauro@gmail.com bsd@gentoo.org toffanin.mauro@gmail.com 2007-06-17 11:25:18 0000 on Gentoo/FreeBSD libopensync fail compilation: cc1: warnings being treated as errors vformat.c: In function '_read_attribute_value_add': vformat.c:242: warning: passing argument 2 of 'libiconv' from incompatible pointer type vformat.c:270: warning: passing argument 2 of 'libiconv' from incompatible pointer type gmake[3]: *** [vformat.lo] Error 1 gmake[3]: *** Waiting for unfinished jobs.... gmake[2]: *** [all-recursive] Error 1 gmake[1]: *** [all-recursive] Error 1 gmake: *** [all] Error 2 the problem is around an #ifdef specific for Solaris making g/fbsd fallback to a generic #ifdef statement not suitable for *BSD userland. Attached there is a patch that change the #ifdef declaration in something usable for Solaris/FreeBSD/NetBSD. Reproducible: Always toffanin.mauro@gmail.com 2007-06-17 11:26:00 0000 Created an attachment (id=122313) libopensync-0.22-fbsd.patch toffanin.mauro@gmail.com 2007-06-17 12:06:25 0000 patch reported upstream peper@gentoo.org 2007-06-17 12:32:14 0000 Thanks, commited. 122313 2007-06-17 11:26 0000 libopensync-0.22-fbsd.patch libopensync-0.22-fbsd.patch text/plain LS0tIGxpYm9wZW5zeW5jLTAuMjIvZm9ybWF0cy92Zm9ybWF0cy14bWwvdmZvcm1hdC5jCTIwMDct MDYtMTcgMTA6NTQ6NTQgKzAwMDAKKysrIGxpYm9wZW5zeW5jLTAuMjIvZm9ybWF0cy92Zm9ybWF0 cy14bWwvdmZvcm1hdC5jCTIwMDctMDYtMTcgMTA6NTU6MzAgKzAwMDAKQEAgLTIzNiw3ICsyMzYs NyBAQAogCWlmIChjaGFyc2V0KSB7CiAKIAkJY2QgPSBpY29udl9vcGVuKCJVVEYtOCIsIGNoYXJz ZXQtPnN0cik7Ci0jaWZkZWYgU09MQVJJUworI2lmIGRlZmluZWQoU09MQVJJUykgfHwgZGVmaW5l ZChfX0ZyZWVCU0RfXykgfHwgZGVmaW5lZChfX05ldEJTRF9fKQogICAgICAgICAgICAgICAgIGlm IChpY29udihjZCwgKGNvbnN0IGNoYXIqKikmaW5idWYsICZpbmJ5dGVzbGVmdCwgJnAsICZvdXRi eXRlc2xlZnQpICE9IChzaXplX3QpKC0xKSkgewogI2Vsc2UKICAgICAgICAgICAgICAgICBpZiAo aWNvbnYoY2QsICZpbmJ1ZiwgJmluYnl0ZXNsZWZ0LCAmcCwgJm91dGJ5dGVzbGVmdCkgIT0gKHNp emVfdCkoLTEpKSB7CkBAIC0yNjQsNyArMjY0LDcgQEAKIAogCQkJLyogYmVjYXVzZSBpbmJ1ZiBp cyBub3QgVVRGLTgsIHdlIHRoaW5rIGl0IGlzIElTTy04ODU5LTEgKi8KICAgICAgICAgICAgICAg ICAgICAgICAgIGNkID0gaWNvbnZfb3BlbigiVVRGLTgiLCAiSVNPLTg4NTktMSIpOwotI2lmZGVm IFNPTEFSSVMKKyNpZiBkZWZpbmVkKFNPTEFSSVMpIHx8IGRlZmluZWQoX19GcmVlQlNEX18pIHx8 IGRlZmluZWQoX19OZXRCU0RfXykKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChpY29udihj ZCwgKGNvbnN0IGNoYXIqKikmaW5idWYsICZpbmJ5dGVzbGVmdCwgJnAsICZvdXRieXRlc2xlZnQp ICE9IChzaXplX3QpKC0xKSkgewogI2Vsc2UKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChp Y29udihjZCwgJmluYnVmLCAmaW5ieXRlc2xlZnQsICZwLCAmb3V0Ynl0ZXNsZWZ0KSAhPSAoc2l6 ZV90KSgtMSkpIHsK