182031 2007-06-14 14:47 0000 sys-apps/util-linux - /etc/init.d/crypto-loop stop fails on cryptoloop based swaps 2007-10-05 23:26:57 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified x86 Linux RESOLVED FIXED P2 minor --- 1 petr.pisar@atlas.cz base-system@gentoo.org petr.pisar@atlas.cz 2007-06-14 14:47:17 0000 Stopping crypto-loop assumes that all loop devices are mounted. At first it tries to umount them and then to destroy the loop disk via losetup -d. If the losetup -d failed, the complete script terminates with error. But if the loop device is used for swapping and then it's not possible to umount and to destroy it. Reproducible: Always Steps to Reproduce: 1. Append following line into /etc/fstab: /dev/hdaN none swap sw,loop=/dev/loop1,encryption=twofish 2. swapon -a 3. /etc/init.d/crypto-loop stop Actual Results: The script failed Expected Results: The script should cope with other loop devices. The crypto-loop script is schisofrenic. Start phase works only on devices defined in /etc/conf.d/crypto-loop but the stop phase processes all loop devices. I understand the motivation (deleting old encrypted devices that have been removed from config file), but contemporal access is suboptimal. petr.pisar@atlas.cz 2007-06-14 14:48:48 0000 Created an attachment (id=122032) /etc/init.d/crypto-loop Attemp to swapoff loop device which failed on umount vapier@gentoo.org 2007-10-05 23:26:57 0000 added to 2.13-r2 / 2.12r-r8, thanks ! 122032 2007-06-14 14:48 0000 /etc/init.d/crypto-loop crypto-loop.diff text/plain LS0tIC9ldGMvaW5pdC5kL2NyeXB0by1sb29wLm9yaWcJMjAwNy0wNi0xNCAxNjoyMToyMy4wMDAw MDAwMDAgKzAyMDAKKysrIC9ldGMvaW5pdC5kL2NyeXB0by1sb29wCTIwMDctMDYtMTQgMTY6MTk6 MjcuMDAwMDAwMDAwICswMjAwCkBAIC01MSw3ICs1MSw4IEBACiAJZm9yIGxvb3AgaW4gJChscyAv ZGV2L2xvb3BbMC05XSkgOyBkbwogCQlsb3NldHVwICIke2xvb3B9IiAmPiAvZGV2L251bGwKIAkJ aWYgW1sgJD8gPT0gMCBdXSA7IHRoZW4KLQkJCXVtb3VudCAke2xvb3B9ICY+L2Rldi9udWxsCisJ CQl1bW91bnQgJHtsb29wfSAmPi9kZXYvbnVsbCB8fCBcCisJCQkJc3dhcG9mZiAiJHtsb29wfSIg Jj4vZGV2L251bGwKIAkJCWlmICEgL3NiaW4vbG9zZXR1cCAtZCAke2xvb3B9ICY+IC9kZXYvbnVs bCA7IHRoZW4KIAkJCQlld2FybiAiRmFpbHVyZSBkZWNvbmZpZ3VyaW5nICR7bG9vcH0uIgogCQkJ CXN0YXR1cz0xCg==