181822 2007-06-12 20:20 0000 media-sound/alsaplayer-0.99.80-rc1 fails to build with flac >=1.1.3 on amd64 2007-07-16 12:11:46 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 152007 1 aballier@gentoo.org redhatter@gentoo.org amd64@gentoo.org Fred@Familie-Roehner.de sound@gentoo.org aballier@gentoo.org 2007-06-12 20:20:56 0000 last round of checks before unmasking flac 1.1.4 : /bin/sh ../../libtool --tag=CXX --mode=compile x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../alsaplayer -D_REENTRANT -march=athlon64 -O2 -pipe -march=athlon64 -O2 -pipe -c -o FlacStream.lo FlacStream.cpp x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../alsaplayer -D_REENTRANT -march=athlon64 -O2 -pipe -march=athlon64 -O2 -pipe -c FlacStream.cpp -fPIC -DPIC -o .libs/FlacStream.o FlacStream.cpp: In member function 'virtual bool Flac::FlacStream::open()': FlacStream.cpp:154: error: invalid conversion from 'FLAC__StreamDecoderReadStatus (*)(const FLAC__StreamDecoder*, FLAC__byte*, unsigned int*, void*)' to 'FLAC__StreamDecoderReadStatus (*)(const FLAC__StreamDecoder*, FLAC__byte*, size_t*, void*)' FlacStream.cpp:154: error: initializing argument 2 of 'FLAC__StreamDecoderInitStatus FLAC__stream_decoder_init_stream(FLAC__StreamDecoder*, FLAC__StreamDecoderReadStatus (*)(const FLAC__StreamDecoder*, FLAC__byte*, size_t*, void*), FLAC__StreamDecoderSeekStatus (*)(const FLAC__StreamDecoder*, FLAC__uint64, void*), FLAC__StreamDecoderTellStatus (*)(const FLAC__StreamDecoder*, FLAC__uint64*, void*), FLAC__StreamDecoderLengthStatus (*)(const FLAC__StreamDecoder*, FLAC__uint64*, void*), FLAC__bool (*)(const FLAC__StreamDecoder*, void*), FLAC__StreamDecoderWriteStatus (*)(const FLAC__StreamDecoder*, const FLAC__Frame*, const FLAC__int32* const*, void*), void (*)(const FLAC__StreamDecoder*, const FLAC__StreamMetadata*, void*), void (*)(const FLAC__StreamDecoder*, FLAC__StreamDecoderErrorStatus, void*), void*)' make[3]: *** [FlacStream.lo] Error 1 make[3]: Leaving directory `/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1/input/flac' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1/input' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/media-sound/alsaplayer-0.99.80_rc1/work/alsaplayer-0.99.80-rc1' make: *** [all] Error 2 please just leave that one open until it's resolved so that people do not believe we're just lazy to unmask flac 1.1.4 ;) sizeof(unsigned) == 4, sizeof(size_t) == 8 here dominique.michel@vtxnet.ch 2007-06-16 10:00:37 0000 Created an attachment (id=122212) Fix for flac 64 bit build This patch will fix this issue, but it will break with flac < 1.4. So, test the flac version in the ebuild if you want to apply it. I committed a modified version into the svn that will hopefully work in any cases. Will be with next release. dominique.michel@vtxnet.ch 2007-06-16 10:01:51 0000 (In reply to comment #1) > This patch will fix this issue, but it will break with flac < 1.4. Sorry, it was flac < 1.1.4 of course dirtyepic@gentoo.org 2007-06-17 02:45:10 0000 aballier: would you like me to lock this version to <flac-1.1.3 in the meantime? aballier@gentoo.org 2007-06-17 20:39:31 0000 (In reply to comment #3) > aballier: would you like me to lock this version to <flac-1.1.3 in the > meantime? It'd be probably saner, yes, just ~dep to flac 1.1.2. But please leave that bug open until the new release (or the patch) hits the tree so that I'll easily know when to unmask flac 1.1.4 by looking at blockers of bug #152007 (now that they're all setup properly) redhatter@gentoo.org 2007-06-18 11:10:04 0000 Hi, Sorry for the slow response. I'll have to have a closer look at this patch this coming weekend, since at the moment, I'm right in the middle of study for my last exam this semester. Does anyone know if this problem is specific to AMD64, or has it been verified on other architectures too? Seeing as I don't have any AMD64 kit, it's incredibly difficult for me to test my changes. (My boxes are x86 and mips.) I'll see if I can reproduce it on mips (this is my main platform at the moment) and see what happens... but would appreciate feedback from others who may have experienced this on architectures other than AMD64. ssuominen@gentoo.org 2007-07-13 15:26:16 0000 Been a month and this is only thing stopping flac-1.1.4 unmasking so either apply it, drop USE flac from alsaplayer or let amd64 package.use.mask it. So ping.. ssuominen@gentoo.org 2007-07-13 18:34:12 0000 (In reply to comment #3) > aballier: would you like me to lock this version to <flac-1.1.3 in the > meantime? > works fine on ~x86 and flac-1.1.4 so don't. ssuominen@gentoo.org 2007-07-14 18:39:51 0000 Patch committed, flac dep raised to >=flac-1.1.3. Thanks Dominique for patch, aballier for testing.. (was after discussing with dirtyepic) ssuominen@gentoo.org 2007-07-14 18:40:17 0000 > aballier for testing.. s/testing/reporting/ Fred@Familie-Roehner.de 2007-07-16 07:45:52 0000 dep raising to >=flac-1.1.3 breaks deps on (stable) akode and xine-lib (at least!) !! ssuominen@gentoo.org 2007-07-16 12:11:46 0000 (In reply to comment #10) > dep raising to >=flac-1.1.3 breaks deps on (stable) akode and xine-lib (at > least!) !! > I don't see any stable KEYWORDS here. alsaplayer-0.99.80_rc1.ebuild:KEYWORDS="~amd64 ~mips ~ppc ~sparc ~x86" flac-1.1.3.ebuild:KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd" flac-1.1.4.ebuild:KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd" So, basically you're saying you locally unmasked flac-1.1.3 or 1.1.4 and it breaks? So don't, it's not ready for stable yet. No breakage here. 122212 2007-06-16 10:00 0000 Fix for flac 64 bit build flac.patch text/plain LS0tIGlucHV0L2ZsYWMvRmxhY1N0cmVhbS5oLWRpc3QJMjAwNy0wNC0yNSAxNDo0NDo1Mi4wMDAw MDAwMDAgKzAyMDAKKysrIGlucHV0L2ZsYWMvRmxhY1N0cmVhbS5oCTIwMDctMDQtMjUgMTQ6NDU6 MTEuMDAwMDAwMDAwICswMjAwCkBAIC0xOTEsNyArMTkxLDcgQEAgY2xhc3MgRmxhY1N0cmVhbQog CiAgICAgRkxBQ19fU3RyZWFtRGVjb2RlclJlYWRTdGF0dXMgCiAgICAgICAgICAgICAgICAgIHJl YWxSZWFkQ2FsbEJhY2sgKEZMQUNfX2J5dGUgYnVmZmVyW10sCi0JCQkJICAgdW5zaWduZWQgKiBi eXRlcyk7CisJCQkJICAgc2l6ZV90ICogYnl0ZXMpOwogCiAKICBwcm90ZWN0ZWQ6CkBAIC0yMzMs NyArMjMzLDcgQEAgY2xhc3MgRmxhY1N0cmVhbQogICAgIHN0YXRpYyBGTEFDX19TdHJlYW1EZWNv ZGVyUmVhZFN0YXR1cwogCXJlYWRDYWxsQmFjayAoY29uc3QgRkxBQ19fU3RyZWFtRGVjb2RlciAq IGRlY29kZXIsCiAJCSAgICAgIEZMQUNfX2J5dGUgYnVmZmVyW10sCi0JCSAgICAgIHVuc2lnbmVk ICogYnl0ZXMsCisJCSAgICAgIHNpemVfdCAqIGJ5dGVzLAogCQkgICAgICB2b2lkICogY2xpZW50 X2RhdGEpOwogCiAgICAgc3RhdGljIHZvaWQgZXJyQ2FsbEJhY2sgKGNvbnN0IEZMQUNfX1N0cmVh bURlY29kZXIgKiBkZWNvZGVyLAotLS0gaW5wdXQvZmxhYy9GbGFjU3RyZWFtLmNwcC1kaXN0CTIw MDctMDQtMjUgMTQ6NDQ6MTAuMDAwMDAwMDAwICswMjAwCisrKyBpbnB1dC9mbGFjL0ZsYWNTdHJl YW0uY3BwCTIwMDctMDQtMjUgMTQ6NDQ6NDkuMDAwMDAwMDAwICswMjAwCkBAIC0zMjEsNyArMzIx LDcgQEAKIAogCiBGTEFDX19TdHJlYW1EZWNvZGVyUmVhZFN0YXR1cwotRmxhY1N0cmVhbTo6cmVh bFJlYWRDYWxsQmFjayAoRkxBQ19fYnl0ZSBidWZmZXJbXSwgdW5zaWduZWQgKiBieXRlcykKK0Zs YWNTdHJlYW06OnJlYWxSZWFkQ2FsbEJhY2sgKEZMQUNfX2J5dGUgYnVmZmVyW10sIHNpemVfdCAq IGJ5dGVzKQogewogICAgICpieXRlcyA9IHJlYWRlcl9yZWFkIChidWZmZXIsICpieXRlcywgX2Rh dGFzb3VyY2UpOwogICAgIHJldHVybiAqYnl0ZXMgPiAwID8gRkxBQ19fU1RSRUFNX0RFQ09ERVJf UkVBRF9TVEFUVVNfQ09OVElOVUUgOgpAQCAtMzM2LDcgKzMzNiw3IEBACiBGTEFDX19TdHJlYW1E ZWNvZGVyUmVhZFN0YXR1cwogRmxhY1N0cmVhbTo6cmVhZENhbGxCYWNrIChjb25zdCBGTEFDX19T dHJlYW1EZWNvZGVyICosCiAJCQkgIEZMQUNfX2J5dGUgYnVmZmVyW10sCi0JCQkgIHVuc2lnbmVk ICogYnl0ZXMsCisJCQkgIHNpemVfdCAqIGJ5dGVzLAogCQkJICB2b2lkICogY2xpZW50X2RhdGEp CiB7CiAgICAgaWYgKCFjbGllbnRfZGF0YSkKLS0tIGlucHV0L2ZsYWMvRmxhY1NlZWthYmxlU3Ry ZWFtLmNwcC1kaXN0CTIwMDctMDQtMjUgMTQ6NDU6MjkuMDAwMDAwMDAwICswMjAwCisrKyBpbnB1 dC9mbGFjL0ZsYWNTZWVrYWJsZVN0cmVhbS5jcHAJMjAwNy0wNC0yNSAxNDo0NTo0My4wMDAwMDAw MDAgKzAyMDAKQEAgLTI1NSw3ICsyNTUsNyBAQAogRmxhY1NlZWthYmxlU3RyZWFtOjpyZWFkQ2Fs bEJhY2sgKGNvbnN0IEZMQUNfX1N0cmVhbURlY29kZXIgKiAvKmRlY29kZXIqLywKICNlbmRpZgog CQkJCSAgRkxBQ19fYnl0ZSBidWZmZXJbXSwKLQkJCQkgIHVuc2lnbmVkICogYnl0ZXMsCisJCQkJ ICBzaXplX3QgKiBieXRlcywKIAkJCQkgIHZvaWQgKiBjbGllbnRfZGF0YSkKIHsKICAgICBpZiAo IWNsaWVudF9kYXRhKQotLS0gaW5wdXQvZmxhYy9GbGFjU2Vla2FibGVTdHJlYW0uaC1kaXN0CTIw MDctMDQtMjUgMTQ6NDU6MzIuMDAwMDAwMDAwICswMjAwCisrKyBpbnB1dC9mbGFjL0ZsYWNTZWVr YWJsZVN0cmVhbS5oCTIwMDctMDQtMjUgMTQ6NDU6NTMuMDAwMDAwMDAwICswMjAwCkBAIC0xMTQs NyArMTE0LDcgQEAgY2xhc3MgRmxhY1NlZWthYmxlU3RyZWFtIDogcHVibGljIEZsYWNTdAogCXJl YWRDYWxsQmFjayAoY29uc3QgRkxBQ19fU3RyZWFtRGVjb2RlciAqIGRlY29kZXIsCiAjZW5kaWYK IAkJICAgICAgRkxBQ19fYnl0ZSBidWZmZXJbXSwKLQkJICAgICAgdW5zaWduZWQgKiBieXRlcywK KwkJICAgICAgc2l6ZV90ICogYnl0ZXMsCiAJCSAgICAgIHZvaWQgKiBjbGllbnRfZGF0YSk7CiAK ICNpZmRlZiBMRUdBQ1lfRkxBQwo=