181783 2007-06-12 16:30 0000 app-arch/zip-2.32: "crypt" USE flag has no effect (+Ignored {C,LD}FLAGS) 2007-06-13 00:30:15 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 normal --- 1 arfrever@gentoo.org base-system@gentoo.org arfrever@gentoo.org 2007-06-12 16:30:03 0000 CFLAGS are always ignored. ### List of files built with LDFLAGS ignored ### /usr/bin/zip /usr/bin/zipcloak /usr/bin/zipsplit /usr/bin/zipnote ### End of list ### jakub@gentoo.org 2007-06-12 17:48:20 0000 OK, that was about enough. 1/ Use common sense when filing bugs (like, what about mailing gentoo-dev mailing list first and asking about the best course of action here? 2/ If you have a patch, submit it *upstream* unless this is a *Gentoo-specific* issue. arfrever@gentoo.org 2007-06-12 18:14:58 0000 This bug report also concerns CFLAGS. Unfortunately you didn't see it. http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building/index.html and http://devmanual.gentoo.org/general-concepts/user-environment/index.html say that CFLAGS should be respected. I think that this bug report should be reopened. arfrever@gentoo.org 2007-06-12 19:48:32 0000 I discovered that target "generic" has broken behaviour (and generally this Makefile is strange). It uses variables from file "flags", so this file must be recreated. If "eval $(MAKE) zips `cat flags`" is changed to "eval $(MAKE) zips", then we have new problems: 1. CFLAGS doesn't contain probably necessary -D* flags. 2. "LFLAGS1 =" line should be changed to "LFLAGS1 = $(LDFLAGS)" using sed. 3. "LFLAGS2 = -s" line causes "QA Notice: Pre-stripped files found". 4. OBJA isn't set and executable "zip" lacks code from 2 object files, because there is in unix/Makefile: OBJA = ... zip$(EXE): $(OBJZ) $(OBJI) $(OBJA) $(BIND) -o zip$(EXE) $(LFLAGS1) $(OBJZ) $(OBJI) $(OBJA) $(LFLAGS2) I think that recreating file "flags" is good decision. arfrever@gentoo.org 2007-06-12 19:49:53 0000 Created an attachment (id=121847) Patch vapier@gentoo.org 2007-06-13 00:30:15 0000 that patch is certainly not right ... you cant hardcode those flags in the ebuild ive cleaned up the build process in cvs 121847 2007-06-12 19:49 0000 Patch zip.patch text/plain LS0tIGFwcC1hcmNoL3ppcC96aXAtMi4zMi5lYnVpbGQKKysrIGFwcC1hcmNoL3ppcC96aXAtMi4z Mi5lYnVpbGQKQEAgLTIxLDE3ICsyMSwyMCBAQAogCWVwYXRjaCAiJHtGSUxFU0RJUn0iL3ppcC0y LjMtdW5peF9jb25maWd1cmUtcGljLnBhdGNoCiAJZXBhdGNoICIke0ZJTEVTRElSfSIvJHtQTn0t Mi4zMS1leGVjLXN0YWNrLnBhdGNoCiAJZXBhdGNoICIke0ZJTEVTRElSfSIvJHtQTn0tMi4zMS1t YWtlLnBhdGNoCi0JY2QgdW5peAogCXVzZSBjcnlwdCB8fCBhcHBlbmQtZmxhZ3MgLUROT19DUllQ VAotCXNlZCAtaSAtZSAiczotTzI6JHtDRkxBR1N9OiIgTWFrZWZpbGUKKworCWNhdCA8PEVPRj5m bGFncworQ0M9IiQodGMtZ2V0Q0MpIgorQ1BQPSIkKHRjLWdldENDKSAtRSIKK0NGTEFHUz0iJHtD RkxBR1N9IC1JLiAtRFVOSVggLURBU01WIC1EQVNNX0NSQyAtREhBVkVfRElSRU5UX0ggLURIQVZF X1RFUk1JT1NfSCAtREhBVkVfRlNFRUtPIgorTEZMQUdTMT0iJHtMREZMQUdTfSIKK0xGTEFHUzI9 IiIKK09CSkE9Im1hdGNoLm8gY3JjX2kzODYubyIKK0VPRgogfQogCiBzcmNfY29tcGlsZSgpIHsK LQllbWFrZSBcCi0JCS1mIHVuaXgvTWFrZWZpbGUgXAotCQlDQz0iJCh0Yy1nZXRDQykiIFwKLQkJ Q1BQPSIkKHRjLWdldENDKSAtRSIgXAotCQlnZW5lcmljIHx8IGRpZQorCWVtYWtlIC1mIHVuaXgv TWFrZWZpbGUgZ2VuZXJpYyB8fCBkaWUKIH0KIAogc3JjX2luc3RhbGwoKSB7Cg==