181288 2007-06-08 10:23 0000 media-sound/lastfmplayer-1.1.3-r2 - endian problem causes wrong playback on big endian based systems 2007-07-04 00:59:03 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 ich@az2000.de ppc@gentoo.org genstef@gentoo.org ich@az2000.de 2007-06-08 10:23:35 0000 Hi I already have made a patch for this issue :) Will attach it... Except for this problem (which I fixed now), lastfmplayer works stable here, so please add ~ppc (and perhaps other other big endian systems; but I only tested PPC). ich@az2000.de 2007-06-08 10:24:19 0000 Created an attachment (id=121486) lastfm_mp3transcode.diff josejx@gentoo.org 2007-06-28 14:23:39 0000 Thanks for the patch! I've updated it for the new version too. Please make sure to submit this for inclusion upstream! Thanks! ich@az2000.de 2007-07-03 14:09:36 0000 I just tested the new version 1.3.0.58 and it seems that the patch is not needed there. That means, with applied patch, you again have the bytes switched one time too often and you again got the wrong playblack. It seems that they have switched the bytes elsewhere in 1.3.0.58 (I haven't took a more deeper look at the code to determit where in detail). I have tested 1.3.0.58 without the patch and it works good. So the simple solution: Use the patch for 1.1.3 but remove it for 1.3.0.58. josejx@gentoo.org 2007-07-04 00:59:03 0000 Whoops. :p I only tested it on 1.1.3-r2, I've removed the newer one, thanks. 121486 2007-06-08 10:24 0000 lastfm_mp3transcode.diff lastfm_mp3transcode.diff text/plain LS0tIHNyYy9tcDN0cmFuc2NvZGUvbXAzdHJhbnNjb2RlLmNwcC5vbGQJMjAwNy0wNi0wOCAxMToy MDo0OS4wMDAwMDAwMDAgKzAyMDAKKysrIHNyYy9tcDN0cmFuc2NvZGUvbXAzdHJhbnNjb2RlLmNw cAkyMDA3LTA2LTA4IDExOjU4OjA1LjAwMDAwMDAwMCArMDIwMApAQCAtMTksNiArMTksNyBAQAog ICogICA1MSBGcmFua2xpbiBTdGVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgIDAyMTExLTEz MDcsIFVTQS4gICAgICAgICAgKgogICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KIAorI2luY2x1ZGUgPHFj b25maWcuaD4gLy8gZm9yIFFfQllURV9PUkRFUgogI2luY2x1ZGUgPFF0R3VpPgogCiAjaW5jbHVk ZSAibXAzdHJhbnNjb2RlLmgiCkBAIC02NCw4ICs2NSwxMyBAQAogICAgICAgICB7CiAgICAgICAg ICAgICBmb3IgKCBpbnQgaSA9IDA7IGkgPCAoIHNpemUgLyAyICk7IGkrKyApCiAgICAgICAgICAg ICB7CisjaWYgUV9CWVRFX09SREVSID09IFFfTElUVExFX0VORElBTgogICAgICAgICAgICAgICAg IG91dHB1dEJ1ZmZlci5hcHBlbmQoIHRlbXBCdWZmZXJbaSAqIDJdICk7CiAgICAgICAgICAgICAg ICAgb3V0cHV0QnVmZmVyLmFwcGVuZCggdGVtcEJ1ZmZlcltpICogMiArIDFdICk7CisjZWxzZSAv LyBRX0JJR19FTkRJQU4KKyAgICAgICAgICAgICAgICBvdXRwdXRCdWZmZXIuYXBwZW5kKCB0ZW1w QnVmZmVyW2kgKiAyICsgMV0gKTsKKyAgICAgICAgICAgICAgICBvdXRwdXRCdWZmZXIuYXBwZW5k KCB0ZW1wQnVmZmVyW2kgKiAyXSApOworI2VuZGlmIC8vIFFfQllURV9PUkRFUgogICAgICAgICAg ICAgfQogCiAgICAgICAgICAgICByZXN1bHQgPSBkZWNvZGVNUDMoICZtcGVnLCBOVUxMLCAwLCB0 ZW1wQnVmZmVyLCBzaXplb2YoIHRlbXBCdWZmZXIgKSwgJnNpemUgKTsK