180340 2007-05-30 12:52 0000 sys-fs/lvm2 - lvm2-start.sh is too restrictive 2007-05-31 14:34:13 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 Jimmy.Jazz@gmx.net cardoe@gentoo.org base-system@gentoo.org rocket@gentoo.org Jimmy.Jazz@gmx.net 2007-05-30 12:52:58 0000 Hello, if one of your disks is faulty and not necessarily the one needed during the boot process, vgscan won't return 0 and you won't be able to boot at all. That could appended when you use a disk managed with evms or if for some reason, your logical volumes become corrupted. By chance, vgchange will do the job well and you will at least be able to switch to the single user if needed. The idea is to live the $? = 0 test from the if condition in /lib64/rcscripts/addons/lvm-start.sh: + /sbin/vgscan --mknodes --ignorelockingfailure >/dev/null + if [ -x /sbin/vgchange ] && \ + [ -f /etc/lvmtab -o -d /etc/lvm ] + then + /sbin/vgchange --ignorelockingfailure -a y >/dev/null fi Jj Reproducible: Always jakub@gentoo.org 2007-05-31 10:05:03 0000 Sorry, the patch doesn't parse. :) It's a verbatim copy of current behaviour, so what exactly is the idea here? Attach a unified diff since it's not really apparent what are you fixing. Also post emerge --info. Jimmy.Jazz@gmx.net 2007-05-31 13:00:29 0000 (In reply to comment #1) > Sorry, the patch doesn't parse. :) It's a verbatim copy of current behaviour, > so what exactly is the idea here? Attach a unified diff since it's not really > apparent what are you fixing. Also post emerge --info. > Sorry, i was a bite on a hurry when i wrote that post. It is not so easy to maintain so much packages on my computers, during my spare time (even if i don't have time to use them all) and still have time to write something almost "intelligible" in a foreign language when something goes wrong :). Anyway, the idea was to increase the ability gentoo boots the system even if something goes wrong. I use on my computers evms, mdp and lvm disks. Some of the older evms disks are no more recognized by evms_activate. Also, udev-start.sh calls evms_activate and in my case will fail before the root filesystem is mounted. The system just stops and gives me a dull ash prompt (That is why i commented out evms_activate and vgscan from udev-start.sh, but that is out of the topic). Moreover, the evms drive doesn't contain the root filesystem. When lvm-start.sh is called, some of the evms disks are however recognized by vgscan and vgchange but vgscan returns a status different from 0 and that will make lvm-start.sh end with a failure. That's why it would be great not to check the vgscan status and take only account of the vgchange one. Jj Jimmy.Jazz@gmx.net 2007-05-31 13:01:29 0000 Created an attachment (id=120764) less restrictive checking jakub@gentoo.org 2007-05-31 13:21:21 0000 (In reply to comment #3) > Created an attachment (id=120764) [edit] > less restrictive checking Much more clear now... cardoe@gentoo.org 2007-05-31 14:34:13 0000 Thanks for the patch. Looks good. Committed. 120764 2007-05-31 13:01 0000 less restrictive checking lvm-start.sh.diff text/plain LS0tIC91c3IvcG9ydGFnZS9zeXMtZnMvbHZtMi9maWxlcy9sdm0yLXN0YXJ0LnNoCTIwMDctMDUt MjEgMTY6MzY6MjEuMDAwMDAwMDAwICswMjAwCisrKyBsdm0tc3RhcnQuc2gJMjAwNy0wNS0zMCAx NDoyNDo1My4wMDAwMDAwMDAgKzAyMDAKQEAgLTI1LDcgKzI1LDcgQEAKIAkJZWJlZ2luICJTZXR0 aW5nIHVwIHRoZSBMb2dpY2FsIFZvbHVtZSBNYW5hZ2VyIgogCQkjc3RpbGwgZWNobyBzdGRlcnIg Zm9yIGRlYnVnZ2luZwogCQkvc2Jpbi92Z3NjYW4gLS1ta25vZGVzIC0taWdub3JlbG9ja2luZ2Zh aWx1cmUgPi9kZXYvbnVsbAotCQlpZiBbICQ/ID0gMCAtYSAteCAvc2Jpbi92Z2NoYW5nZSBdICYm IFwKKwkJaWYgWyAteCAvc2Jpbi92Z2NoYW5nZSBdICYmIFwKIAkJICAgWyAtZiAvZXRjL2x2bXRh YiAtbyAtZCAvZXRjL2x2bSBdCiAJCXRoZW4KIAkJCS9zYmluL3ZnY2hhbmdlIC0taWdub3JlbG9j a2luZ2ZhaWx1cmUgLWEgeSA+L2Rldi9udWxsCg==